when folding duplicate conditions, delete the

now-probably-dead instruction tree feeding it.

llvm-svn: 83778
This commit is contained in:
Chris Lattner 2009-10-11 18:39:58 +00:00
parent 729185ce68
commit 8ae883b5f0
3 changed files with 35 additions and 30 deletions

View File

@ -450,9 +450,11 @@ bool JumpThreading::ProcessBranchOnDuplicateCond(BasicBlock *PredBB,
<< "' folding condition to '" << BranchDir << "': " << "' folding condition to '" << BranchDir << "': "
<< *BB->getTerminator() << '\n'); << *BB->getTerminator() << '\n');
++NumFolds; ++NumFolds;
Value *OldCond = DestBI->getCondition();
DestBI->setCondition(ConstantInt::get(Type::getInt1Ty(BB->getContext()), DestBI->setCondition(ConstantInt::get(Type::getInt1Ty(BB->getContext()),
BranchDir)); BranchDir));
ConstantFoldTerminator(BB); ConstantFoldTerminator(BB);
RecursivelyDeleteTriviallyDeadInstructions(OldCond);
return true; return true;
} }

View File

@ -139,3 +139,36 @@ F2:
ret i32 %B ret i32 %B
} }
;; Lexically duplicated conditionals should be threaded.
define i32 @test6(i32 %A) {
; CHECK: @test6
%tmp455 = icmp eq i32 %A, 42
br i1 %tmp455, label %BB1, label %BB2
BB2:
; CHECK: call i32 @f1()
; CHECK-NEXT: call void @f3()
; CHECK-NEXT: ret i32 4
call i32 @f1()
br label %BB1
BB1:
%tmp459 = icmp eq i32 %A, 42
br i1 %tmp459, label %BB3, label %BB4
BB3:
call i32 @f2()
ret i32 3
BB4:
call void @f3()
ret i32 4
}

View File

@ -1,30 +0,0 @@
; RUN: opt < %s -jump-threading -die -S | grep icmp | count 1
declare void @f1()
declare void @f2()
declare void @f3()
define i32 @test(i32 %A) {
%tmp455 = icmp eq i32 %A, 42
br i1 %tmp455, label %BB1, label %BB2
BB2:
call void @f1()
br label %BB1
BB1:
%tmp459 = icmp eq i32 %A, 42
br i1 %tmp459, label %BB3, label %BB4
BB3:
call void @f2()
ret i32 3
BB4:
call void @f3()
ret i32 4
}