RPCS3/llvm-mirror
1
0
Fork 0
mirror of https://github.com/RPCS3/llvm-mirror.git synced 2025-01-22 11:55:12 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix format string in bindings/go/llvm/ir_test.go (PR40561)

Browse Source 
The test started failing for me recently. I don't see any changes around
this code, so maybe it's my local go version that changed or something.

The error seems real to me: we're trying to print an Attribute with %d.
The test talks about "attribute masks" I'm not sure what that refers to,
but I suppose we could print the raw pointer value, since that's
what the test seems to be comparing.

Differential revision: https://reviews.llvm.org/D57672

llvm-svn: 353155
This commit is contained in:
Hans Wennborg 2019-02-05 11:01:54 +00:00
parent 9819ff8761
commit 8b23ed2ade
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
bindings/go/llvm/ir_test.go
View File

@ -30,7 +30,7 @@ func testAttribute(t *testing.T, name string) {
fn.AddFunctionAttr(attr)
newattr := fn.GetEnumFunctionAttribute(kind)
if attr != newattr {
t.Errorf("got attribute mask %d, want %d", newattr, attr)
t.Errorf("got attribute %p, want %p", newattr.C, attr.C)
}
text := mod.String()
@ -41,7 +41,7 @@ func testAttribute(t *testing.T, name string) {
fn.RemoveEnumFunctionAttribute(kind)
newattr = fn.GetEnumFunctionAttribute(kind)
if !newattr.IsNil() {
t.Errorf("got attribute mask %d, want 0", newattr)
t.Errorf("got attribute %p, want 0", newattr.C)
}
}