RPCS3/llvm-mirror
1
0
Fork 0
mirror of https://github.com/RPCS3/llvm-mirror.git synced 2025-01-08 20:30:50 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

[X86] Don't fail disassembly if REX.R/REX.B is used on an MMX register. Similar fix to not fail to disassembler CR9-CR15 references.

Browse Source 
llvm-svn: 224861
This commit is contained in:
Craig Topper 2014-12-26 18:19:44 +00:00
parent ffda29da2a
commit 955459673e
3 changed files with 18 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
lib/Target/X86/Disassembler/X86DisassemblerDecoder.cpp
View File

@ -1447,9 +1447,7 @@ static int readModRM(struct InternalInstruction* insn) {
case TYPE_MM64: \
case TYPE_MM32: \
case TYPE_MM: \
if (index > 7) \
*valid = 0; \
return prefix##_MM0 + index; \
return prefix##_MM0 + (index & 0x7); \
case TYPE_SEGMENTREG: \
if (index > 5) \
*valid = 0; \
@ -1459,8 +1457,6 @@ static int readModRM(struct InternalInstruction* insn) {
*valid = 0; \
return prefix##_DR0 + index; \
case TYPE_CONTROLREG: \
if (index > 8) \
*valid = 0; \
return prefix##_CR0 + index; \
} \
}

9
lib/Target/X86/Disassembler/X86DisassemblerDecoder.h
View File

@ -352,7 +352,14 @@ namespace X86Disassembler {
ENTRY(CR5) \
ENTRY(CR6) \
ENTRY(CR7) \
ENTRY(CR8)
ENTRY(CR8) \
ENTRY(CR9) \
ENTRY(CR10) \
ENTRY(CR11) \
ENTRY(CR12) \
ENTRY(CR13) \
ENTRY(CR14) \
ENTRY(CR15)
#define ALL_EA_BASES \
EA_BASES_16BIT \

9
test/MC/Disassembler/X86/prefixes.txt
View File

@ -54,6 +54,15 @@
# CHECK-NEXT: stosq
0xf3 0xf3 0x48 0xab
# Test that we can disassembler control registers above CR8
# CHECK: movq %cr15, %rax
0x44 0x0f 0x20 0xf8
# Test that MMX ignore REX.R and REX.B.
# CHECK: movq %mm0, %mm1
0x46 0x0f 0x7f 0xc1
# Test that a prefix on it's own works. It's debatable as to if this is
# something that is considered valid, but however as LLVM's own disassembler
# has decided to disassemble prefixes as being separate opcodes, it therefore