RPCS3/llvm-mirror
1
0
Fork 0
mirror of https://github.com/RPCS3/llvm-mirror.git synced 2025-01-07 11:51:13 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

[LoopUnrolling] Peel loops with invariant backedge Phi input

Browse Source 
Summary:
If a loop contains a Phi node which has an invariant input from back
edge, it is profitable to peel such loops (rather than unroll them) to
use the advantage that this Phi is always invariant starting from 2nd
iteration. After the 1st iteration is peeled, other optimizations can
potentially simplify calculations with this invariant.

Patch by Max Kazantsev!

Reviewers: sanjoy, apilipenko, igor-laevsky, anna, mkuper, reames

Reviewed By: mkuper

Subscribers: mkuper, mzolotukhin, llvm-commits

Differential Revision: https://reviews.llvm.org/D30161

llvm-svn: 296898
This commit is contained in:
Sanjoy Das 2017-03-03 18:19:15 +00:00
parent f07ac23c21
commit 9ecf4261b1
2 changed files with 50 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
lib/Transforms/Utils/LoopUnrollPeel.cpp
View File

@ -71,6 +71,31 @@ void llvm::computePeelCount(Loop *L, unsigned LoopSize,
if (!L->empty())
return;
// Try to find a Phi node that has the same loop invariant as an input from
// its only back edge. If there is such Phi, peeling 1 iteration from the
// loop is profitable, because starting from 2nd iteration we will have an
// invariant instead of this Phi.
if (auto *BackEdge = L->getLoopLatch()) {
BasicBlock *Header = L->getHeader();
// Iterate over Phis to find one with invariant input on back edge.
bool FoundCandidate = false;
PHINode *Phi;
for (auto BI = Header->begin(); Phi = dyn_cast<PHINode>(&*BI); ++BI) {
Value *Input = Phi->getIncomingValueForBlock(BackEdge);
if (L->isLoopInvariant(Input)) {
FoundCandidate = true;
break;
}
}
if (FoundCandidate) {
DEBUG(dbgs() << "Peel one iteration to get rid of " << *Phi
<< " because starting from 2nd iteration it is always"
<< " an invariant\n");
UP.PeelCount = 1;
return;
}
}
// Bail if we know the statically calculated trip count.
// In this case we rather prefer partial unrolling.
if (TripCount)

25
test/Transforms/LoopUnroll/peel-loop-not-forced.ll Normal file
View File

@ -0,0 +1,25 @@
; RUN: opt < %s -S -loop-unroll | FileCheck %s
define i32 @invariant_backedge_1(i32 %a, i32 %b) {
; CHECK-LABEL: @invariant_backedge_1
; CHECK-NOT: %plus = phi
; CHECK: loop.peel:
; CHECK: loop:
; CHECK: %i = phi
; CHECK: %sum = phi
entry:
br label %loop
loop:
%i = phi i32 [ 0, %entry ], [ %inc, %loop ]
%sum = phi i32 [ 0, %entry ], [ %incsum, %loop ]
%plus = phi i32 [ %a, %entry ], [ %b, %loop ]
%incsum = add i32 %sum, %plus
%inc = add i32 %i, 1
%cmp = icmp slt i32 %i, 1000
br i1 %cmp, label %loop, label %exit
exit:
ret i32 %sum
}