RPCS3/llvm-mirror
1
0
Fork 0
mirror of https://github.com/RPCS3/llvm-mirror.git synced 2024-11-26 04:40:38 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

phab doc: Replace or remove references to svn

Browse Source
This commit is contained in:
Sylvestre Ledru 2020-01-09 22:28:45 +01:00
parent c2ccd2282d
commit ad24680356
1 changed files with 6 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
docs/Phabricator.rst
View File

@ -26,7 +26,7 @@ Make *sure* that the email address registered with Phabricator is subscribed
to the relevant -commits mailing list. If you are not subscribed to the commit
list, all mail sent by Phabricator on your behalf will be held for moderation.
Note that if you use your Subversion user name as Phabricator user name,
Note that if you use your git user name as Phabricator user name,
Phabricator will automatically connect your submits to your Phabricator user in
the `Code Repository Browser`_.
@ -48,9 +48,9 @@ Requesting a review via the web interface
The tool to create and review patches in Phabricator is called
*Differential*.
Note that you can upload patches created through various diff tools,
including git and svn. To make reviews easier, please always include
**as much context as possible** with your diff! Don't worry, Phabricator
Note that you can upload patches created through git.
To make reviews easier, please always include **as much context as
possible** with your diff! Don't worry, Phabricator
will automatically send a diff with a smaller context in the review
email, but having the full file in the web interface will help the
reviewer understand your code.
@ -60,7 +60,6 @@ to upload your patch):
* ``git show HEAD -U999999 > mypatch.patch``
* ``git format-patch -U999999 @{u}``
* ``svn diff --diff-cmd=diff -x -U999999``
Before uploading your patch, please make sure it is formatted properly, as
described in :ref:`How to Submit a Patch <format patches>`.
@ -107,7 +106,7 @@ Finding potential reviewers
Here are a couple of ways to pick the initial reviewer(s):
* Use ``svn blame`` and the commit log to find names of people who have
* Use ``git blame`` and the commit log to find names of people who have
recently modified the same area of code that you are modifying.
* Look in CODE_OWNERS.TXT to see who might be responsible for that area.
* If you've discussed the change on a dev list, the people who participated
@ -176,7 +175,7 @@ guide <commit_from_git>`.
Note that if you commit the change without using Arcanist and forget to add the
``Differential Revision`` line to your commit message then it is recommended
that you close the review manually. In the web UI, under "Leap Into Action" put
the SVN revision number in the Comment, set the Action to "Close Revision" and
the git revision number in the Comment, set the Action to "Close Revision" and
click Submit. Note the review must have been Accepted first.