Fix the inline cost calculation to take into account instructions

which cannot be folded even if they have constant operands. Significantly
helps if_spppsubr.c attached to PR4573.

llvm-svn: 76285
This commit is contained in:
Eli Friedman 2009-07-18 05:26:06 +00:00
parent c0d63a2fec
commit b5b88b60b3

View File

@ -42,6 +42,13 @@ unsigned InlineCostAnalyzer::FunctionInfo::
// Figure out if this instruction will be removed due to simple constant
// propagation.
Instruction &Inst = cast<Instruction>(**UI);
// We can't constant propagate instructions which have effects or
// read memory.
if (Inst.mayReadFromMemory() || Inst.mayHaveSideEffects() ||
isa<AllocationInst>(Inst))
continue;
bool AllOperandsConstant = true;
for (unsigned i = 0, e = Inst.getNumOperands(); i != e; ++i)
if (!isa<Constant>(Inst.getOperand(i)) && Inst.getOperand(i) != V) {