mirror of
https://github.com/RPCS3/llvm-mirror.git
synced 2025-03-07 11:59:09 +00:00
Check whether functions have any lines associated before emitting coverage info for them. This isn't just a size/time saving, gcov may crash on these.
llvm-svn: 206671
This commit is contained in:
parent
9932fa2364
commit
bd9ff641e7
@ -449,6 +449,21 @@ bool GCOVProfiler::runOnModule(Module &M) {
|
||||
return false;
|
||||
}
|
||||
|
||||
static bool functionHasLines(Function *F) {
|
||||
// Check whether this function actually has any source lines. Not only
|
||||
// do these waste space, they also can crash gcov.
|
||||
for (Function::iterator BB = F->begin(), E = F->end(); BB != E; ++BB) {
|
||||
for (BasicBlock::iterator I = BB->begin(), IE = BB->end();
|
||||
I != IE; ++I) {
|
||||
const DebugLoc &Loc = I->getDebugLoc();
|
||||
if (Loc.isUnknown()) continue;
|
||||
if (Loc.getLine() != 0)
|
||||
return true;
|
||||
}
|
||||
}
|
||||
return false;
|
||||
}
|
||||
|
||||
void GCOVProfiler::emitProfileNotes() {
|
||||
NamedMDNode *CU_Nodes = M->getNamedMetadata("llvm.dbg.cu");
|
||||
if (!CU_Nodes) return;
|
||||
@ -474,6 +489,7 @@ void GCOVProfiler::emitProfileNotes() {
|
||||
|
||||
Function *F = SP.getFunction();
|
||||
if (!F) continue;
|
||||
if (!functionHasLines(F)) continue;
|
||||
|
||||
// gcov expects every function to start with an entry block that has a
|
||||
// single successor, so split the entry block to make sure of that.
|
||||
@ -549,6 +565,7 @@ bool GCOVProfiler::emitProfileArcs() {
|
||||
continue;
|
||||
Function *F = SP.getFunction();
|
||||
if (!F) continue;
|
||||
if (!functionHasLines(F)) continue;
|
||||
if (!Result) Result = true;
|
||||
unsigned Edges = 0;
|
||||
for (Function::iterator BB = F->begin(), E = F->end(); BB != E; ++BB) {
|
||||
|
Loading…
x
Reference in New Issue
Block a user