RPCS3/llvm-mirror
1
0
Fork 0
mirror of https://github.com/RPCS3/llvm-mirror.git synced 2025-02-03 02:43:51 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

LiveRangeCalc: Fix reporting of invalid vreg usage in liveness calculation

Browse Source 
Machine programs need a definition of each vreg before reaching a use
(the definition may come from an IMPLICIT_DEF instruction). This class
of errors is not detected by the MachineVerifier because of efficiency
concerns. LiveRangeCalc used to report these problems, make it do that
again (followup to r279625).

Also use report_fatal_error() instead of llvm_unreachable() as the error
reporting is only present in asserts build anyway.

llvm-svn: 281914
This commit is contained in:
Matthias Braun 2016-09-19 16:49:45 +00:00
parent 4d399f0ac6
commit c02cdc0d60
2 changed files with 34 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
lib/CodeGen/LiveRangeCalc.cpp
View File

@ -361,14 +361,14 @@ bool LiveRangeCalc::findReachingDefs(LiveRange &LR, MachineBasicBlock &UseMBB,
MachineBasicBlock *MBB = MF->getBlockNumbered(WorkList[i]);
#ifndef NDEBUG
if (Undefs.size() > 0 && MBB->pred_empty()) {
if (MBB->pred_empty()) {
MBB->getParent()->verify();
errs() << "Use of " << PrintReg(PhysReg)
<< " does not have a corresponding definition on every path:\n";
const MachineInstr *MI = Indexes->getInstructionFromIndex(Use);
if (MI != nullptr)
errs() << Use << " " << *MI;
llvm_unreachable("Use not jointly dominated by defs.");
report_fatal_error("Use not jointly dominated by defs.");
}
if (TargetRegisterInfo::isPhysicalRegister(PhysReg) &&
@ -378,7 +378,7 @@ bool LiveRangeCalc::findReachingDefs(LiveRange &LR, MachineBasicBlock &UseMBB,
errs() << "The register " << PrintReg(PhysReg, TRI)
<< " needs to be live in to BB#" << MBB->getNumber()
<< ", but is missing from the live-in list.\n";
llvm_unreachable("Invalid global physical register");
report_fatal_error("Invalid global physical register");
}
#endif
FoundUndef |= MBB->pred_empty();

31
test/CodeGen/X86/invalid-liveness.mir Normal file
View File

@ -0,0 +1,31 @@
# RUN: not llc -march=x86 -run-pass liveintervals -o - %s 2>&1 | FileCheck %s
# REQUIRES: asserts
--- |
define void @func() { ret void }
...
---
# Liveness calculation should detect that we do not have a definition for vreg0
# on all paths; In this example a def for vreg0 is missing when jumping from
# bb.0 to bb.3.
#
# CHECK: Use of %vreg0 does not have a corresponding definition on every path
# CHECK: ERROR: Use not jointly dominated by defs.
name: func
registers:
- { id: 0, class: gr32 }
body: |
bb.0:
successors: %bb.2, %bb.3
JG_1 %bb.2, implicit %eflags
JMP_1 %bb.3
bb.2:
successors: %bb.3
%0 = IMPLICIT_DEF
JMP_1 %bb.3
bb.3:
%eax = COPY %0
RETQ %eax
...