RPCS3/llvm-mirror
1
0
Fork 0
mirror of https://github.com/RPCS3/llvm-mirror.git synced 2025-02-23 05:52:40 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Call destroy from ~BasicCallGraph.

Browse Source 
This fix a memory leak found by valgrind.

Calling it from the base class destructor would not destroy the BasicCallGraph
bits.

FIXME: BasicCallGraph is the only thing that inherits from CallGraph. Can
we merge the two?

llvm-svn: 193412
This commit is contained in:
Rafael Espindola 2013-10-25 15:01:34 +00:00
parent 0617dece78
commit cd9791ce72
2 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
include/llvm/Analysis/CallGraph.h
View File

@ -152,7 +152,7 @@ protected:
CallGraph() {} CallGraph() {}
public: public:
virtual ~CallGraph() { destroy(); } virtual ~CallGraph() { }
/// initialize - Call this method before calling other methods, /// initialize - Call this method before calling other methods,
/// re/initializes the state of the CallGraph. /// re/initializes the state of the CallGraph.

4
lib/Analysis/IPA/CallGraph.cpp
View File

@ -46,12 +46,16 @@ public:
ExternalCallingNode(0), CallsExternalNode(0) { ExternalCallingNode(0), CallsExternalNode(0) {
initializeBasicCallGraphPass(*PassRegistry::getPassRegistry()); initializeBasicCallGraphPass(*PassRegistry::getPassRegistry());
} }
~BasicCallGraph() {
destroy();
}
// runOnModule - Compute the call graph for the specified module. // runOnModule - Compute the call graph for the specified module.
virtual bool runOnModule(Module &M) { virtual bool runOnModule(Module &M) {
CallGraph::initialize(M); CallGraph::initialize(M);
ExternalCallingNode = getOrInsertFunction(0); ExternalCallingNode = getOrInsertFunction(0);
assert(!CallsExternalNode);
CallsExternalNode = new CallGraphNode(0); CallsExternalNode = new CallGraphNode(0);
Root = 0; Root = 0;