Make sure SimplifyStoreAtEndOfBlock doesn't mess with loops; the

structure checks are incorrect if the blocks aren't distinct.
Fixes PR2435.

llvm-svn: 52257
This commit is contained in:
Eli Friedman 2008-06-13 21:17:49 +00:00
parent 40c8db881a
commit d38a639deb
2 changed files with 28 additions and 2 deletions

View File

@ -10379,8 +10379,12 @@ bool InstCombiner::SimplifyStoreAtEndOfBlock(StoreInst &SI) {
}
if (++PI != pred_end(DestBB))
return false;
// Bail out if all the relevant blocks aren't distinct (this can happen,
// for example, if SI is in an infinite loop)
if (StoreBB == DestBB || OtherBB == DestBB)
return false;
// Verify that the other block ends in a branch and is not otherwise empty.
BasicBlock::iterator BBI = OtherBB->getTerminator();
BranchInst *OtherBr = dyn_cast<BranchInst>(BBI);

View File

@ -0,0 +1,22 @@
; RUN: llvm-as < %s | opt -instcombine | llvm-dis | grep {store i32} | count 2
target datalayout = "e-p:32:32:32-i1:8:8-i8:8:8-i16:16:16-i32:32:32-i64:32:64-f32:32:32-f64:32:64-v64:64:64-v128:128:128-a0:0:64-f80:128:128"
target triple = "i386-apple-darwin8"
@g_139 = global i32 0 ; <i32*> [#uses=2]
define void @func_56(i32 %p_60) nounwind {
entry:
store i32 1, i32* @g_139, align 4
%tmp1 = icmp ne i32 %p_60, 0 ; <i1> [#uses=1]
%tmp12 = zext i1 %tmp1 to i8 ; <i8> [#uses=1]
%toBool = icmp ne i8 %tmp12, 0 ; <i1> [#uses=1]
br i1 %toBool, label %bb, label %return
bb: ; preds = %bb, %entry
store i32 1, i32* @g_139, align 4
br label %bb
return: ; preds = %entry
ret void
}