RPCS3/llvm-mirror
1
0
Fork 0
mirror of https://github.com/RPCS3/llvm-mirror.git synced 2024-12-26 13:36:28 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Visibility hidden GVs do not require extra load of symbol address from the GOT or non-lazy-ptr.

Browse Source 
llvm-svn: 60519
This commit is contained in:
Evan Cheng 2008-12-04 01:56:50 +00:00
parent f8e215d4b1
commit d4b7459179
6 changed files with 22 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/Target/ARM/ARMISelLowering.cpp
View File

@ -830,7 +830,7 @@ SDValue ARMTargetLowering::LowerGlobalAddressELF(SDValue Op,
/// GVIsIndirectSymbol - true if the GV will be accessed via an indirect symbol
/// even in non-static mode.
static bool GVIsIndirectSymbol(GlobalValue *GV, Reloc::Model RelocM) {
return RelocM != Reloc::Static &&
return RelocM != Reloc::Static && !GV->hasHiddenVisibility() &&
(GV->hasWeakLinkage() || GV->hasLinkOnceLinkage() ||
(GV->isDeclaration() && !GV->hasNotBeenReadFromBitcode()));
}

5
lib/Target/PowerPC/AsmPrinter/PPCAsmPrinter.cpp
View File

@ -387,8 +387,9 @@ void PPCAsmPrinter::printOp(const MachineOperand &MO) {
// External or weakly linked global variables need non-lazily-resolved stubs
if (TM.getRelocationModel() != Reloc::Static) {
if (((GV->isDeclaration() || GV->hasWeakLinkage() ||
GV->hasLinkOnceLinkage() || GV->hasCommonLinkage()))) {
if (!GV->hasHiddenVisibility() &&
(GV->isDeclaration() || GV->hasWeakLinkage() ||
GV->hasLinkOnceLinkage() || GV->hasCommonLinkage())) {
GVStubs.insert(Name);
printSuffixedName(Name, "$non_lazy_ptr");
if (GV->hasExternalWeakLinkage())

4
lib/Target/PowerPC/PPCSubtarget.cpp
View File

@ -141,7 +141,9 @@ bool PPCSubtarget::hasLazyResolverStub(const GlobalValue *GV) const {
// We never hae stubs if HasLazyResolverStubs=false or if in static mode.
if (!HasLazyResolverStubs || TM.getRelocationModel() == Reloc::Static)
return false;
// Extra load is not needed for symbols with hidden visibility.
if (GV->hasHiddenVisibility())
return false;
return GV->hasWeakLinkage() || GV->hasLinkOnceLinkage() ||
GV->hasCommonLinkage() ||
(GV->isDeclaration() && !GV->hasNotBeenReadFromBitcode());

2
lib/Target/X86/AsmPrinter/X86ATTAsmPrinter.cpp
View File

@ -391,6 +391,8 @@ void X86ATTAsmPrinter::printOperand(const MachineInstr *MI, unsigned OpNo,
FnStubs.insert(Name);
printSuffixedName(Name, "$stub");
}
} else if (GV->hasHiddenVisibility()) {
O << Name;
} else {
GVStubs.insert(Name);
printSuffixedName(Name, "$non_lazy_ptr");

3
lib/Target/X86/X86Subtarget.cpp
View File

@ -40,6 +40,9 @@ bool X86Subtarget::GVRequiresExtraLoad(const GlobalValue* GV,
if (TM.getRelocationModel() != Reloc::Static &&
TM.getCodeModel() != CodeModel::Large) {
if (isTargetDarwin()) {
if (GV->hasHiddenVisibility())
// Extra load is not needed for symbols with hidden visibility.
return false;
return (!isDirectCall &&
(GV->hasWeakLinkage() || GV->hasLinkOnceLinkage() ||
GV->hasCommonLinkage() ||

10
test/CodeGen/X86/hidden-vis-2.ll Normal file
View File

@ -0,0 +1,10 @@
; RUN: llvm-as < %s | llc -mtriple=i386-apple-darwin9 | grep mov | count 1
; RUN: llvm-as < %s | llc -mtriple=x86_64-apple-darwin9 | not grep GOT
@x = weak hidden global i32 0 ; <i32*> [#uses=1]
define i32 @t() nounwind readonly {
entry:
%0 = load i32* @x, align 4 ; <i32> [#uses=1]
ret i32 %0
}