RPCS3/llvm-mirror
1
0
Fork 0
mirror of https://github.com/RPCS3/llvm-mirror.git synced 2024-11-27 21:30:51 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

[llvm][NFC] refactor setBlockFrequency for clarity.

Browse Source 
The refactoring encapsulates frequency calculation in MachineBlockFrequencyInfo,
and renames the API to clarify its motivation. It should clarify
frequencies may not be reset 'freely' by users of the analysis, as the
API serves as a partial update to avoid a full analysis recomputation.

Differential Revision: https://reviews.llvm.org/D84427
This commit is contained in:
Mircea Trofin 2020-07-28 13:04:11 -07:00
parent 2eb832d47c
commit d7c7affaca
3 changed files with 16 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
include/llvm/CodeGen/MachineBlockFrequencyInfo.h
View File

@ -74,7 +74,11 @@ public:
bool isIrrLoopHeader(const MachineBasicBlock *MBB) const;
void setBlockFreq(const MachineBasicBlock *MBB, uint64_t Freq);
/// incrementally calculate block frequencies when we split edges, to avoid
/// full CFG traversal.
void onEdgeSplit(const MachineBasicBlock &NewPredecessor,
const MachineBasicBlock &NewSuccessor,
const MachineBranchProbabilityInfo &MBPI);
const MachineFunction *getFunction() const;
const MachineBranchProbabilityInfo *getMBPI() const;

11
lib/CodeGen/MachineBlockFrequencyInfo.cpp
View File

@ -247,10 +247,15 @@ bool MachineBlockFrequencyInfo::isIrrLoopHeader(
return MBFI->isIrrLoopHeader(MBB);
}
void MachineBlockFrequencyInfo::setBlockFreq(const MachineBasicBlock *MBB,
uint64_t Freq) {
void MachineBlockFrequencyInfo::onEdgeSplit(
const MachineBasicBlock &NewPredecessor,
const MachineBasicBlock &NewSuccessor,
const MachineBranchProbabilityInfo &MBPI) {
assert(MBFI && "Expected analysis to be available");
MBFI->setBlockFreq(MBB, Freq);
auto NewSuccFreq = MBFI->getBlockFreq(&NewPredecessor) *
MBPI.getEdgeProbability(&NewPredecessor, &NewSuccessor);
MBFI->setBlockFreq(&NewSuccessor, NewSuccFreq.getFrequency());
}
const MachineFunction *MachineBlockFrequencyInfo::getFunction() const {

8
lib/CodeGen/MachineSink.cpp
View File

@ -347,11 +347,9 @@ bool MachineSinking::runOnMachineFunction(MachineFunction &MF) {
<< printMBBReference(*Pair.first) << " -- "
<< printMBBReference(*NewSucc) << " -- "
<< printMBBReference(*Pair.second) << '\n');
if (MBFI) {
auto NewSuccFreq = MBFI->getBlockFreq(Pair.first) *
MBPI->getEdgeProbability(Pair.first, NewSucc);
MBFI->setBlockFreq(NewSucc, NewSuccFreq.getFrequency());
}
if (MBFI)
MBFI->onEdgeSplit(*Pair.first, *NewSucc, *MBPI);
MadeChange = true;
++NumSplit;
} else