RPCS3/llvm-mirror
1
0
Fork 0
mirror of https://github.com/RPCS3/llvm-mirror.git synced 2024-12-28 14:36:34 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Disable the load-shrinking optimization from looking at

Browse Source 
anything larger than 64-bits, avoiding a crash.  This should
really be fixed to use APInts, though type legalization happens
to help us out and we get good code on the attached testcase at
least.

This fixes rdar://6836460

llvm-svn: 70360
This commit is contained in:
Chris Lattner 2009-04-29 03:45:07 +00:00
parent 4f8ccd5bc8
commit e1eefefdc3
2 changed files with 22 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
lib/CodeGen/SelectionDAG/TargetLowering.cpp
View File

@ -1538,19 +1538,22 @@ TargetLowering::SimplifySetCC(MVT VT, SDValue N0, SDValue N1,
N0.getOperand(0).getNode()->hasOneUse() &&
isa<ConstantSDNode>(N0.getOperand(1))) {
LoadSDNode *Lod = cast<LoadSDNode>(N0.getOperand(0));
uint64_t Mask = cast<ConstantSDNode>(N0.getOperand(1))->getZExtValue();
uint64_t bestMask = 0;
unsigned bestWidth = 0, bestOffset = 0;
if (!Lod->isVolatile() && Lod->isUnindexed()) {
if (!Lod->isVolatile() && Lod->isUnindexed() &&
// FIXME: This uses getZExtValue() below so it only works on i64 and
// below.
N0.getValueType().getSizeInBits() <= 64) {
unsigned origWidth = N0.getValueType().getSizeInBits();
// We can narrow (e.g.) 16-bit extending loads on 32-bit target to
// 8 bits, but have to be careful...
if (Lod->getExtensionType() != ISD::NON_EXTLOAD)
origWidth = Lod->getMemoryVT().getSizeInBits();
uint64_t Mask =cast<ConstantSDNode>(N0.getOperand(1))->getZExtValue();
for (unsigned width = origWidth / 2; width>=8; width /= 2) {
uint64_t newMask = (1ULL << width) - 1;
for (unsigned offset=0; offset<origWidth/width; offset++) {
if ((newMask & Mask)==Mask) {
if ((newMask & Mask) == Mask) {
if (!TD->isLittleEndian())
bestOffset = (origWidth/width - offset - 1) * (width/8);
else

16
test/CodeGen/Generic/2009-04-28-i128-cmp-crash.ll Normal file
View File

@ -0,0 +1,16 @@
; RUN: llvm-as < %s | llc
; rdar://6836460
define i32 @test(i128* %P) nounwind {
entry:
%tmp48 = load i128* %P
%and49 = and i128 %tmp48, 18446744073709551616 ; <i128> [#uses=1]
%tobool = icmp ne i128 %and49, 0 ; <i1> [#uses=1]
br i1 %tobool, label %if.then50, label %if.end61
if.then50: ; preds = %if.then20
ret i32 1241
if.end61: ; preds = %if.then50, %if.then20, %entry
ret i32 123
}