RPCS3/llvm-mirror
1
0
Fork 0
mirror of https://github.com/RPCS3/llvm-mirror.git synced 2024-12-12 22:17:47 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

[APInt] Move operator~ out of line to make it better able to reused memory allocation from temporary objects

Browse Source 
Summary:
This makes operator~ take the APInt by value so if it came from a temporary APInt the move constructor will get invoked and it will be able to reuse the memory allocation from the temporary.

This is similar to what was already done for 2s complement negation.

Reviewers: hans, davide, RKSimon

Reviewed By: davide

Subscribers: llvm-commits

Differential Revision: https://reviews.llvm.org/D30614

llvm-svn: 296997
This commit is contained in:
Craig Topper 2017-03-06 06:30:47 +00:00
parent 4e17c0a9f9
commit e2e31b6a01
2 changed files with 32 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
include/llvm/ADT/APInt.h
View File

@ -612,17 +612,6 @@ public:
/// \returns *this decremented by one.
APInt &operator--();
/// \brief Unary bitwise complement operator.
///
/// Performs a bitwise complement operation on this APInt.
///
/// \returns an APInt that is the bitwise complement of *this
APInt operator~() const {
APInt Result(*this);
Result.flipAllBits();
return Result;
}
/// \brief Logical negation operator.
///
/// Performs logical negation operation on this APInt.
@ -1733,6 +1722,14 @@ inline bool operator==(uint64_t V1, const APInt &V2) { return V2 == V1; }
inline bool operator!=(uint64_t V1, const APInt &V2) { return V2 != V1; }
/// \brief Unary bitwise complement operator.
///
/// \returns an APInt that is the bitwise complement of \p v.
inline APInt operator~(APInt v) {
v.flipAllBits();
return v;
}
inline APInt operator&(APInt a, uint64_t RHS) {
a &= RHS;
return a;

24
unittests/ADT/APIntTest.cpp
View File

@ -761,6 +761,30 @@ TEST(APIntTest, rvalue_arithmetic) {
}
}
TEST(APIntTest, rvalue_invert) {
// Lamdba to return an APInt by value, but also provide the raw value of the
// allocated data.
auto getRValue = [](const char *HexString, uint64_t const *&RawData) {
APInt V(129, HexString, 16);
RawData = V.getRawData();
return V;
};
APInt One(129, 1);
APInt NegativeTwo(129, -2ULL, true);
const uint64_t *RawData = nullptr;
{
// ~1 = -2
APInt NegL = ~One;
EXPECT_EQ(NegL, NegativeTwo);
APInt NegR = ~getRValue("1", RawData);
EXPECT_EQ(NegR, NegativeTwo);
EXPECT_EQ(NegR.getRawData(), RawData);
}
}
// Tests different div/rem varaints using scheme (a * b + c) / a
void testDiv(APInt a, APInt b, APInt c) {