RPCS3/llvm-mirror
1
0
Fork 0
mirror of https://github.com/RPCS3/llvm-mirror.git synced 2025-03-01 08:47:42 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

[ConstantRange] Cleanup addWithNoWrap() by just piggybacking on sadd_sat()/uadd_sat()

Browse Source 
As discussed in https://reviews.llvm.org/D69918
that happens to work as intended, and returns empty set if
there is always an overflow because we get lucky with intersection.
Since there's now an explicit test for that, let's prefer cleaner code.
This commit is contained in:
Roman Lebedev 2019-11-07 01:19:54 +03:00
parent 6c155b3a15
commit e4ece27aeb
1 changed files with 8 additions and 32 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

40
lib/IR/ConstantRange.cpp
View File

@ -864,41 +864,17 @@ ConstantRange ConstantRange::addWithNoWrap(const ConstantRange &Other,
using OBO = OverflowingBinaryOperator;
ConstantRange Result = add(Other);
auto addWithNoUnsignedWrap = [this](const ConstantRange &Other) {
APInt LMin = getUnsignedMin(), LMax = getUnsignedMax();
APInt RMin = Other.getUnsignedMin(), RMax = Other.getUnsignedMax();
bool Overflow;
APInt NewMin = LMin.uadd_ov(RMin, Overflow);
if (Overflow)
return getEmpty();
APInt NewMax = LMax.uadd_sat(RMax);
return getNonEmpty(std::move(NewMin), std::move(NewMax) + 1);
};
auto addWithNoSignedWrap = [this](const ConstantRange &Other) {
APInt LMin = getSignedMin(), LMax = getSignedMax();
APInt RMin = Other.getSignedMin(), RMax = Other.getSignedMax();
if (LMin.isNonNegative()) {
bool Overflow;
APInt Temp = LMin.sadd_ov(RMin, Overflow);
if (Overflow)
return getEmpty();
}
if (LMax.isNegative()) {
bool Overflow;
APInt Temp = LMax.sadd_ov(RMax, Overflow);
if (Overflow)
return getEmpty();
}
APInt NewMin = LMin.sadd_sat(RMin);
APInt NewMax = LMax.sadd_sat(RMax);
return getNonEmpty(std::move(NewMin), std::move(NewMax) + 1);
};
// If an overflow happens for every value pair in these two constant ranges,
// we must return Empty set. In this case, we get that for free, because we
// get lucky that intersection of add() with uadd_sat()/sadd_sat() results
// in an empty set.
if (NoWrapKind & OBO::NoSignedWrap)
Result = Result.intersectWith(addWithNoSignedWrap(Other), RangeType);
Result = Result.intersectWith(sadd_sat(Other), RangeType);
if (NoWrapKind & OBO::NoUnsignedWrap)
Result = Result.intersectWith(addWithNoUnsignedWrap(Other), RangeType);
Result = Result.intersectWith(uadd_sat(Other), RangeType);
return Result;
}