mirror of
https://github.com/RPCS3/llvm-mirror.git
synced 2024-12-18 17:17:49 +00:00
[llvm-cov] Allow commas in filenames passed to -object
flag
Currently, -object takes a comma separated list of objects as an argument, which prevents it working with path names that contain a comma. Drop comma-separated support, which requires to set pass the -object flag multiple times to set multiple objects. Patch by Andrew Gallagher! Differential Revision: https://reviews.llvm.org/D87003
This commit is contained in:
parent
6640720520
commit
ea70c5e0ce
@ -0,0 +1,3 @@
|
||||
RUN: llvm-cov show %t -instr-profile %t -dump-collected-objects -object a,b | FileCheck %s
|
||||
|
||||
CHECK: a,b
|
@ -544,8 +544,11 @@ int CodeCoverageTool::run(Command Cmd, int argc, const char **argv) {
|
||||
cl::Positional, cl::desc("Covered executable or object file."));
|
||||
|
||||
cl::list<std::string> CovFilenames(
|
||||
"object", cl::desc("Coverage executable or object file"), cl::ZeroOrMore,
|
||||
cl::CommaSeparated);
|
||||
"object", cl::desc("Coverage executable or object file"), cl::ZeroOrMore);
|
||||
|
||||
cl::opt<bool> DebugDumpCollectedObjects(
|
||||
"dump-collected-objects", cl::Optional, cl::Hidden,
|
||||
cl::desc("Show the collected coverage object files"));
|
||||
|
||||
cl::list<std::string> InputSourceFiles(
|
||||
cl::Positional, cl::desc("<Source files>"), cl::ZeroOrMore);
|
||||
@ -668,6 +671,12 @@ int CodeCoverageTool::run(Command Cmd, int argc, const char **argv) {
|
||||
::exit(1);
|
||||
}
|
||||
|
||||
if (DebugDumpCollectedObjects) {
|
||||
for (StringRef OF : ObjectFilenames)
|
||||
outs() << OF << '\n';
|
||||
::exit(0);
|
||||
}
|
||||
|
||||
ViewOpts.Format = Format;
|
||||
switch (ViewOpts.Format) {
|
||||
case CoverageViewOptions::OutputFormat::Text:
|
||||
|
Loading…
Reference in New Issue
Block a user