MVT::getMVT uses iPTR for pointer types, while we need the actual

intptr_t type in this case. FastISel can now select simple
getelementptr instructions.

llvm-svn: 55125
This commit is contained in:
Dan Gohman 2008-08-21 17:25:26 +00:00
parent 4b801d38a1
commit f4269f7bea
2 changed files with 13 additions and 10 deletions

View File

@ -74,7 +74,7 @@ bool FastISel::SelectGetElementPtr(Instruction *I,
return false;
const Type *Ty = I->getOperand(0)->getType();
MVT VT = MVT::getMVT(Ty, /*HandleUnknown=*/false);
MVT::SimpleValueType VT = TLI.getPointerTy().getSimpleVT();
for (GetElementPtrInst::op_iterator OI = I->op_begin()+1, E = I->op_end();
OI != E; ++OI) {
Value *Idx = *OI;
@ -85,7 +85,7 @@ bool FastISel::SelectGetElementPtr(Instruction *I,
uint64_t Offs = TD.getStructLayout(StTy)->getElementOffset(Field);
// FIXME: This can be optimized by combining the add with a
// subsequent one.
N = FastEmit_ri_(VT.getSimpleVT(), ISD::ADD, N, Offs, VT.getSimpleVT());
N = FastEmit_ri_(VT, ISD::ADD, N, Offs, VT);
if (N == 0)
// Unhandled operand. Halt "fast" selection and bail.
return false;
@ -99,7 +99,7 @@ bool FastISel::SelectGetElementPtr(Instruction *I,
if (CI->getZExtValue() == 0) continue;
uint64_t Offs =
TD.getABITypeSize(Ty)*cast<ConstantInt>(CI)->getSExtValue();
N = FastEmit_ri_(VT.getSimpleVT(), ISD::ADD, N, Offs, VT.getSimpleVT());
N = FastEmit_ri_(VT, ISD::ADD, N, Offs, VT);
if (N == 0)
// Unhandled operand. Halt "fast" selection and bail.
return false;
@ -117,21 +117,21 @@ bool FastISel::SelectGetElementPtr(Instruction *I,
// it.
MVT IdxVT = MVT::getMVT(Idx->getType(), /*HandleUnknown=*/false);
if (IdxVT.bitsLT(VT))
IdxN = FastEmit_r(VT.getSimpleVT(), ISD::SIGN_EXTEND, IdxN);
IdxN = FastEmit_r(VT, ISD::SIGN_EXTEND, IdxN);
else if (IdxVT.bitsGT(VT))
IdxN = FastEmit_r(VT.getSimpleVT(), ISD::TRUNCATE, IdxN);
IdxN = FastEmit_r(VT, ISD::TRUNCATE, IdxN);
if (IdxN == 0)
// Unhandled operand. Halt "fast" selection and bail.
return false;
// FIXME: If multiple is power of two, turn it into a shift. The
// optimization should be in FastEmit_ri?
IdxN = FastEmit_ri_(VT.getSimpleVT(), ISD::MUL, IdxN,
ElementSize, VT.getSimpleVT());
IdxN = FastEmit_ri_(VT, ISD::MUL, IdxN,
ElementSize, VT);
if (IdxN == 0)
// Unhandled operand. Halt "fast" selection and bail.
return false;
N = FastEmit_rr(VT.getSimpleVT(), ISD::ADD, N, IdxN);
N = FastEmit_rr(VT, ISD::ADD, N, IdxN);
if (N == 0)
// Unhandled operand. Halt "fast" selection and bail.
return false;

View File

@ -3,10 +3,11 @@
; This tests very minimal fast-isel functionality.
define i32 @foo(i32* %p, i32* %q) {
define i32* @foo(i32* %p, i32* %q, i32** %z) {
entry:
%r = load i32* %p
%s = load i32* %q
%y = load i32** %z
br label %fast
fast:
@ -17,10 +18,12 @@ fast:
%t4 = or i32 %t3, %s
%t5 = xor i32 %t4, %s
%t6 = add i32 %t5, 2
%t7 = getelementptr i32* %y, i32 1
%t8 = getelementptr i32* %t7, i32 %t6
br label %exit
exit:
ret i32 %t6
ret i32* %t8
}
define double @bar(double* %p, double* %q) {