RPCS3/llvm-mirror
1
0
Fork 0
mirror of https://github.com/RPCS3/llvm-mirror.git synced 2025-02-11 07:18:44 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Don't do (x - (y - z)) --> (x + (z - y)) on floating-point types, because

Browse Source 
it may round differently. This fixes PR4374.

llvm-svn: 73243
This commit is contained in:
Dan Gohman 2009-06-12 19:23:25 +00:00
parent 43f66023c3
commit f9b0419cd8
2 changed files with 8 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
lib/Transforms/Scalar/InstructionCombining.cpp
View File

@ -2608,21 +2608,6 @@ Instruction *InstCombiner::visitFSub(BinaryOperator &I) {
else if (Op1I->getOperand(1) == Op0) // X-(Y+X) == -Y
return BinaryOperator::CreateFNeg(Op1I->getOperand(0), I.getName());
}
if (Op1I->hasOneUse()) {
// Replace (x - (y - z)) with (x + (z - y)) if the (y - z) subexpression
// is not used by anyone else...
//
if (Op1I->getOpcode() == Instruction::FSub) {
// Swap the two operands of the subexpr...
Value *IIOp0 = Op1I->getOperand(0), *IIOp1 = Op1I->getOperand(1);
Op1I->setOperand(0, IIOp1);
Op1I->setOperand(1, IIOp0);
// Create the new top level fadd instruction...
return BinaryOperator::CreateFAdd(Op0, Op1);
}
}
}
return 0;

8
test/Transforms/InstCombine/fsub-fsub.ll Normal file
View File

@ -0,0 +1,8 @@
; RUN: llvm-as < %s | opt -instcombine | llvm-dis | grep fsub | count 2
; PR4374
define float @func(float %a, float %b) nounwind {
%tmp3 = fsub float %a, %b
%tmp4 = fsub float -0.000000e+00, %tmp3
ret float %tmp4
}