RPCS3/llvm-mirror
1
0
Fork 0
mirror of https://github.com/RPCS3/llvm-mirror.git synced 2025-01-10 13:51:37 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

[MC] - Don't crash on unclosed frame.

Browse Source 
llvm-mc can crash when
there is cfi_startproc without cfi_end_proc:

.text
.globl foo
foo:
 .cfi_startproc

Testcase shows the issue, patch fixes it.

Differential revision: https://reviews.llvm.org/D43456

llvm-svn: 325564
This commit is contained in:
George Rimar 2018-02-20 09:04:13 +00:00
parent a78ed93af4
commit fdb04128c9
2 changed files with 14 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
lib/MC/MCStreamer.cpp
View File

@ -816,10 +816,11 @@ void MCStreamer::EmitWindowsUnwindTables() {
}
void MCStreamer::Finish() {
if (!DwarfFrameInfos.empty() && !DwarfFrameInfos.back().End)
getContext().reportError(SMLoc(), "Unfinished frame!");
if (!WinFrameInfos.empty() && !WinFrameInfos.back()->End)
if ((!DwarfFrameInfos.empty() && !DwarfFrameInfos.back().End) ||
(!WinFrameInfos.empty() && !WinFrameInfos.back()->End)) {
getContext().reportError(SMLoc(), "Unfinished frame!");
return;
}
MCTargetStreamer *TS = getTargetStreamer();
if (TS)

10
test/MC/X86/cfi-scope-unclosed.s Normal file
View File

@ -0,0 +1,10 @@
# RUN: not llvm-mc %s -filetype=obj -triple=x86_64-unknown-linux \
# RUN: -o /dev/null 2>&1 | FileCheck %s
## Check we don't crash on unclosed frame scope.
# CHECK: error: Unfinished frame!
.text
.globl foo
foo:
.cfi_startproc