RPCS3/llvm-mirror
1
0
Fork 0
mirror of https://github.com/RPCS3/llvm-mirror.git synced 2025-02-17 18:58:39 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

[opt-viewer] Make filter_=None by default in get_remarks and gather_results

Browse Source 
Right now, if you try to use optdiff.py on any opt records, it will fail because
its calls to gather_results weren't updated to support filtering.

Since filters are supposed to be optional, this makes them None by default in
get_remarks and in gather_results. This allows other tools that don't support
filtering to still use the functions as is.

Differential Revision: https://reviews.llvm.org/D59894

llvm-svn: 357106
This commit is contained in:
Jessica Paquette 2019-03-27 18:14:32 +00:00
parent 9cc632cfab
commit ff88899fb1
1 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
tools/opt-viewer/optrecord.py
View File

@ -265,7 +265,7 @@ class Missed(Remark):
return "red"
def get_remarks(input_file, filter_):
def get_remarks(input_file, filter_=None):
max_hotness = 0
all_remarks = dict()
file_remarks = defaultdict(functools.partial(defaultdict, list))
@ -273,14 +273,16 @@ def get_remarks(input_file, filter_):
with open(input_file) as f:
docs = yaml.load_all(f, Loader=Loader)
filter_e = re.compile(filter_)
filter_e = None
if filter_:
filter_e = re.compile(filter_)
for remark in docs:
remark.canonicalize()
# Avoid remarks withoug debug location or if they are duplicated
if not hasattr(remark, 'DebugLoc') or remark.key in all_remarks:
continue
if filter_ and not filter_e.search(remark.Pass):
if filter_e and not filter_e.search(remark.Pass):
continue
all_remarks[remark.key] = remark
@ -297,7 +299,7 @@ def get_remarks(input_file, filter_):
return max_hotness, all_remarks, file_remarks
def gather_results(filenames, num_jobs, should_print_progress, filter_):
def gather_results(filenames, num_jobs, should_print_progress, filter_=None):
if should_print_progress:
print('Reading YAML files...')
if not Remark.demangler_proc: