3 Commits

Author	SHA1	Message	Date
Mitch Phillips	2a55bb0f7c	Revert "Fix Base64Test - for StringRef size" ... This reverts commit b52355f8a196b5040dc2e42870bf8c459306cfaa. The change this patch depends on (5a1958f2673f8c771e406a7e309e160b432c9a79) broke the UBSan buildbots. See https://reviews.llvm.org/D75057 for more information.	2020-03-02 09:33:21 -08:00
serge-sans-paille	cbaf8eb24e	Fix Base64Test - for StringRef size ... Original failures: http://lab.llvm.org:8011/builders/clang-with-lto-ubuntu/builds/15975/steps/test-stage1-compiler/logs/stdio	2020-03-02 11:13:30 +01:00
serge-sans-paille	9d5f964841	Syndicate, test and fix base64 implementation ... Move Base64 implementation from clangd/SemanticHighlighting to llvm/Support/Base64, fix its implementation and provide a decent test suite. Previous implementation code was using + operator instead of | to combine some results, which is a problem when shifting signed values. (0xFF << 16) is implicitly converted to a (signed) int, and thus results in 0xffff0000, which is negative. Combining negative numbers with a + in that context is not what we want to do. This fixes https://github.com/llvm/llvm-project/issues/149. Differential Revision: https://reviews.llvm.org/D75057	2020-03-02 10:02:25 +01:00