RPCS3/llvm-mirror
1
0
Fork 0
mirror of https://github.com/RPCS3/llvm-mirror.git synced 2025-04-06 09:41:38 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity
58,148 Commits 6 Branches 6 Tags
Commit Graph

61 Commits

Author SHA1 Message Date
Chris Lattner
7ad458c173 eliminate dynamic_cast from this file. 
llvm-svn: 94157
 2010-01-22 05:46:59 +00:00
Chris Lattner
f683d7d909 eliminate a bunch more unneeded dynamic_cast's. 
llvm-svn: 94156
 2010-01-22 05:37:10 +00:00
Chris Lattner
1bd9c3ec88 eliminate a bunch of dynamic_cast's. 
llvm-svn: 94155
 2010-01-22 05:24:46 +00:00
David Greene
5980bb69ba Change dbgs() back to errs() for assert messages as Chris requested. 
llvm-svn: 92080
 2009-12-23 23:09:39 +00:00
David Greene
a2539e0ff7 Convert debug messages to use dbgs(). Generally this means 
s/errs/dbgs/g except for certain special cases.

llvm-svn: 92035
 2009-12-23 20:10:59 +00:00
Dan Gohman
09f5f7f190 Extend the StartPassTimer and StopPassTimer functions so that the 
code that stops the timer doesn't have to search to find the timer
object before it stops the timer. This avoids a lock acquisition
and a few other things done with the timer running.

llvm-svn: 82949
 2009-09-28 00:07:05 +00:00
Chris Lattner
50438771c0 make -debug-pass=Executions show information about what call graph nodes 
are in the SCC for each execution of a CGSCC pass.

llvm-svn: 81838
 2009-09-15 05:03:04 +00:00
Dale Johannesen
fa355ddba3 Fix uppercaseo. 
llvm-svn: 81463
 2009-09-10 22:01:32 +00:00
Chris Lattner
140720ab83 revert my patch, duncan points out what is wrong with my logic. Add 
a comment so that I don't change this in the future :)

llvm-svn: 80760
 2009-09-02 04:39:04 +00:00
Chris Lattner
e1637fa3f6 one more try at making this simpler, hopefully it won't break everything :) 
llvm-svn: 80759
 2009-09-02 04:34:06 +00:00
Duncan Sands
b970a46d06 Complicate Chris's simplification, avoiding complaints 
about singular iterators when building with expensive
checks turned on.

llvm-svn: 80757
 2009-09-02 03:48:41 +00:00
Chris Lattner
7db43e1b57 debug intrinsics do not go in the callgraph, this fixes a couple 
clang regtest failures.

llvm-svn: 80724
 2009-09-01 21:37:50 +00:00
Chris Lattner
dd05e763cc Fix a regression I introduced in r80708, found by llvm-test. 
llvm-svn: 80718
 2009-09-01 20:33:43 +00:00
Chris Lattner
ccbb87c998 remove CallGraphNode::replaceCallSite, it is redundant with other APIs. 
llvm-svn: 80708
 2009-09-01 18:52:39 +00:00
Chris Lattner
23bedf2b9b doxygenate RefreshCallGraph, add a new 'verification mode', and run it after 
CGSCC passes make change to ensure they are updating the callgraph correctly
(when assertions are enabled).

llvm-svn: 80698
 2009-09-01 18:32:03 +00:00
Chris Lattner
341df26dd9 simpler solution to iterator invalidation "problem" found 
by expensive checking.

llvm-svn: 80695
 2009-09-01 18:13:40 +00:00
Duncan Sands
7f018fd2d3 Do not manipulate invalid iterators. This fixes the 
llvm-gcc build when expensive checking is turned on.

llvm-svn: 80671
 2009-09-01 15:13:02 +00:00
Chris Lattner
53698d7fd7 Change CallGraphNode to maintain it's Function as an AssertingVH 
for sanity.  This didn't turn up any bugs.

Change CallGraphNode to maintain its "callsite" information in the 
call edges list as a WeakVH instead of as an instruction*.  This fixes
a broad class of dangling pointer bugs, and makes CallGraph have a number
of useful invariants again.  This fixes the class of problem indicated
by PR4029 and PR3601.

llvm-svn: 80663
 2009-09-01 06:31:31 +00:00
Chris Lattner
91cb0c1aa7 cleanups pointed out by duncan 
llvm-svn: 80595
 2009-08-31 17:08:30 +00:00
Chris Lattner
acdb45e484 Step #1 to giving Callgraph some sane invariants. The problems with callgraph 
stem from the fact that we have two types of passes that need to update it:

1. callgraphscc and module passes that are explicitly aware of it
2. Functionpasses (and loop passes etc) that are interlaced with CGSCC passes
   by the CGSCC Passmgr.

In the case of #1, we can reasonably expect the passes to update the call
graph just like any analysis.  However, functionpasses are not and generally
should not be CG aware.  This has caused us no end of problems, so this takes
a new approach.  Logically, the CGSCC Pass manager can rescan every function 
after it runs a function pass over it to see if the functionpass made any 
updates to the IR that affect the callgraph.  This allows it to catch new calls
introduced by the functionpass.

In practice, doing this would be slow.  This implementation keeps track of
whether or not the current scc is dirtied by a function pass, and, if so, 
delays updating the callgraph until it is actually needed again.  This was
we avoid extraneous rescans, but we still have good invariants when the
callgraph is needed.

Step #2 of the "give Callgraph some sane invariants" is to change CallGraphNode
to use a CallBackVH for the callsite entry of the CallGraphNode.  This way
we can immediately remove entries from the callgraph when a FunctionPass is
active instead of having dangling pointers.  The current pass tries to tolerate
these dangling pointers, but it is just an evil hack.

This is related to PR3601/4835/4029.  This also reverts r80541, a hack working
around the sad lack of invariants.

llvm-svn: 80566
 2009-08-31 07:23:46 +00:00
Chris Lattner
36e941a542 cleanups, factor some code out to a helper function 
llvm-svn: 80542
 2009-08-31 06:01:21 +00:00
Chris Lattner
085c521fe2 Fix some nasty callgraph dangling pointer problems in 
argpromotion and structretpromote.  Basically, when replacing
a function, they used the 'changeFunction' api which changes
the entry in the function map (and steals/reuses the callgraph
node).

This has some interesting effects: first, the problem is that it doesn't
update the "callee" edges in any callees of the function in the call graph.
Second, this covers for a major problem in all the CGSCC pass stuff, which 
is that it is completely broken when functions are deleted if they *don't*
reuse a CGN.  (there is a cute little fixme about this though :).

This patch changes the protocol that CGSCC passes must obey: now the CGSCC 
pass manager copies the SCC and preincrements its iterator to avoid passes
invalidating it.  This allows CGSCC passes to mutate the current SCC.  However
multiple passes may be run on that SCC, so if passes do this, they are now
required to *update* the SCC to be current when they return.

Other less interesting parts of this patch are that it makes passes update
the CG more directly, eliminates changeFunction, and requires clients of
replaceCallSite to specify the new callee CGN if they are changing it.

llvm-svn: 80527
 2009-08-31 00:19:58 +00:00
Chris Lattner
1c0452caeb Change Pass::print to take a raw ostream instead of std::ostream, 
update all code that this affects.

llvm-svn: 79830
 2009-08-23 06:03:38 +00:00
Daniel Dunbar
4a36d5dcfd Remove Value::getName{Start,End}, the last of the old Name APIs. 
llvm-svn: 77152
 2009-07-26 09:48:23 +00:00
Nick Lewycky
260e80bd90 Reapply r64300: 
Make sure the SCC pass manager initializes any contained
function pass managers.  Without this, simplify-libcalls
would add nocapture attributes when run on its own, but
not when run as part of -std-compile-opts or similar.

llvm-svn: 64443
 2009-02-13 07:15:53 +00:00
Bill Wendling
dfb5880317 Revert r64300 and r64301. These were causing the following errors respectively: 
During llvm-gcc bootstrap:

Undefined symbols:
  "llvm::FPPassManager::doFinalization(llvm::Module&)", referenced from:
      (anonymous namespace)::CGPassManager::doFinalization(llvm::CallGraph&, llvm::Module&)
        in libLLVMipa.a(CallGraphSCCPass.o)
  "llvm::FPPassManager::doInitialization(llvm::Module&)", referenced from:
      (anonymous namespace)::CGPassManager::doInitialization(llvm::CallGraph&, llvm::Module&)
        in libLLVMipa.a(CallGraphSCCPass.o)
ld: symbol(s) not found
collect2: ld returned 1 exit status
make[3]: *** [/Volumes/Sandbox/Buildbot/llvm/full-llvm/build/llvmCore.roots/llvmCore~obj/obj-llvm/Release/bin/opt] Error 1

During an LLVM release build:

/Volumes/Sandbox/Buildbot/llvm/full-llvm/build/llvm.sh.build/Release/bin/tblgen -I  /Volumes/Sandbox/Buildbot/llvm/full-llvm/build/llvmCore/lib/Target/X86 -I  /Volumes/Sandbox/Buildbot/llvm/full-llvm/build/llvmCore/include -I  /Volumes/Sandbox/Buildbot/llvm/full-llvm/build/llvmCore/include -I  /Volumes/Sandbox/Buildbot/llvm/full-llvm/build/llvmCore/lib/Target -gen-register-desc -o  /Volumes/Sandbox/Buildbot/llvm/full-llvm/build/llvm.sh.build/lib/Target/X86/Release/X86GenRegisterInfo.inc.tmp /Volumes/Sandbox/Buildbot/llvm/full-llvm/build/llvmCore/lib/Target/X86/X86.td
llvm[3]: Building X86.td instruction names with tblgen
/Volumes/Sandbox/Buildbot/llvm/full-llvm/build/llvm.sh.build/Release/bin/tblgen -I  /Volumes/Sandbox/Buildbot/llvm/full-llvm/build/llvmCore/lib/Target/X86 -I  /Volumes/Sandbox/Buildbot/llvm/full-llvm/build/llvmCore/include -I  /Volumes/Sandbox/Buildbot/llvm/full-llvm/build/llvmCore/include -I  /Volumes/Sandbox/Buildbot/llvm/full-llvm/build/llvmCore/lib/Target -gen-instr-enums -o  /Volumes/Sandbox/Buildbot/llvm/full-llvm/build/llvm.sh.build/lib/Target/X86/Release/X86GenInstrNames.inc.tmp /Volumes/Sandbox/Buildbot/llvm/full-llvm/build/llvmCore/lib/Target/X86/X86.td
llvm[3]: Building X86.td instruction information with tblgen
/Volumes/Sandbox/Buildbot/llvm/full-llvm/build/llvm.sh.build/Release/bin/tblgen -I  /Volumes/Sandbox/Buildbot/llvm/full-llvm/build/llvmCore/lib/Target/X86 -I  /Volumes/Sandbox/Buildbot/llvm/full-llvm/build/llvmCore/include -I  /Volumes/Sandbox/Buildbot/llvm/full-llvm/build/llvmCore/include -I  /Volumes/Sandbox/Buildbot/llvm/full-llvm/build/llvmCore/lib/Target -gen-instr-desc -o  /Volumes/Sandbox/Buildbot/llvm/full-llvm/build/llvm.sh.build/lib/Target/X86/Release/X86GenInstrInfo.inc.tmp /Volumes/Sandbox/Buildbot/llvm/full-llvm/build/llvmCore/lib/Target/X86/X86.td
llvm[3]: Building X86.td assembly writer with tblgen
/Volumes/Sandbox/Buildbot/llvm/full-llvm/build/llvm.sh.build/Release/bin/tblgen -I  /Volumes/Sandbox/Buildbot/llvm/full-llvm/build/llvmCore/lib/Target/X86 -I  /Volumes/Sandbox/Buildbot/llvm/full-llvm/build/llvmCore/include -I  /Volumes/Sandbox/Buildbot/llvm/full-llvm/build/llvmCore/include -I  /Volumes/Sandbox/Buildbot/llvm/full-llvm/build/llvmCore/lib/Target -gen-asm-writer -o  /Volumes/Sandbox/Buildbot/llvm/full-llvm/build/llvm.sh.build/lib/Target/X86/Release/X86GenAsmWriter.inc.tmp /Volumes/Sandbox/Buildbot/llvm/full-llvm/build/llvmCore/lib/Target/X86/X86.td
llvm[3]: Compiling InstructionCombining.cpp for Release build 
if /Volumes/Sandbox/Buildbot/llvm/full-llvm/build/llvmgcc42.roots/llvmgcc42~dst/Developer/usr/bin/llvm-g++-4.2 -I/Volumes/Sandbox/Buildbot/llvm/full-llvm/build/llvm.sh.build/include -I/Volumes/Sandbox/Buildbot/llvm/full-llvm/build/llvm.sh.build/lib/Transforms/Scalar -I/Volumes/Sandbox/Buildbot/llvm/full-llvm/build/llvmCore/include -I/Volumes/Sandbox/Buildbot/llvm/full-llvm/build/llvmCore/lib/Transforms/Scalar  -D_DEBUG  -D_GNU_SOURCE -D__STDC_LIMIT_MACROS -D__STDC_CONSTANT_MACROS -O3  -fno-exceptions  -Woverloaded-virtual -pedantic -Wall -W -Wwrite-strings -Wno-long-long -Wunused -Wno-unused-parameter  -fstrict-aliasing -Wstrict-aliasing -c -MMD -MP -MF "/Volumes/Sandbox/Buildbot/llvm/full-llvm/build/llvm.sh.build/lib/Transforms/Scalar/Release/InstructionCombining.d.tmp" -MT "/Volumes/Sandbox/Buildbot/llvm/full-llvm/build/llvm.sh.build/lib/Transforms/Scalar/Release/InstructionCombining.lo" -MT "/Volumes/Sandbox/Buildbot/llvm/full-llvm/build/llvm.sh.build/lib/Transforms/Scalar/Release/InstructionCombining.o" -MT "/Volumes/Sandbox/Buildbot/llvm/full-llvm/build/llvm.sh.build/lib/Transforms/Scalar/Release/InstructionCombining.d" /Volumes/Sandbox/Buildbot/llvm/full-llvm/build/llvmCore/lib/Transforms/Scalar/InstructionCombining.cpp -o /Volumes/Sandbox/Buildbot/llvm/full-llvm/build/llvm.sh.build/lib/Transforms/Scalar/Release/InstructionCombining.o ; \
           then /bin/mv -f "/Volumes/Sandbox/Buildbot/llvm/full-llvm/build/llvm.sh.build/lib/Transforms/Scalar/Release/InstructionCombining.d.tmp" "/Volumes/Sandbox/Buildbot/llvm/full-llvm/build/llvm.sh.build/lib/Trans

llvm-svn: 64311
 2009-02-11 18:19:24 +00:00
Duncan Sands
e71d1394f6 Make sure the SCC pass manager initializes any contained 
function pass managers.  Without this, simplify-libcalls
would add nocapture attributes when run on its own, but
not when run as part of -std-compile-opts or similar.

llvm-svn: 64300
 2009-02-11 09:58:43 +00:00
Dan Gohman
e1f9be27bc Tidy up several unbeseeming casts from pointer to intptr_t. 
llvm-svn: 55779
 2008-09-04 17:05:41 +00:00
Chris Lattner
a4e876cf8a Don't call getAnalysisUsage unless -debug-pass is enabled. This speeds 
up the passmgr by avoiding useless work.

llvm-svn: 54528
 2008-08-08 15:14:09 +00:00
Dan Gohman
bab18cae46 Clean up the use of static and anonymous namespaces. This turned up 
several things that were neither in an anonymous namespace nor static
but not intended to be global.

llvm-svn: 51017
 2008-05-13 00:00:25 +00:00
Devang Patel
4b2359feec Add assert. 
llvm-svn: 50596
 2008-05-02 22:13:33 +00:00
Chris Lattner
ad9a6ccb83 Remove attribution from file headers, per discussion on llvmdev. 
llvm-svn: 45418
 2007-12-29 20:36:04 +00:00
Devang Patel
fa7277dd34 Do not overuse std::string. Pass around char * directly. 
llvm-svn: 41001
 2007-08-10 18:29:32 +00:00
Dan Gohman
7dd04fb91c More explicit keywords. 
llvm-svn: 40673
 2007-08-01 15:32:29 +00:00
Devang Patel
45675e56ad Verify loop info. 
llvm-svn: 40062
 2007-07-19 18:02:32 +00:00
Duncan Sands
8c6657894f Replace mysterious code causing a g++-4.2 warning 
with hopefully correct code that pleases g++-4.2.

llvm-svn: 40051
 2007-07-19 09:42:01 +00:00
Devang Patel
0b2cb3ec61 CallGraphSCCPass manager may require other passes. 
Use schedulePass() to accomodate these requirement instead of directly
assigning a manager to new CallGraph PassManager.

llvm-svn: 37695
 2007-06-21 22:29:02 +00:00
Devang Patel
cd45427a87 Drop 'const' 
llvm-svn: 36662
 2007-05-03 01:11:54 +00:00
Devang Patel
8ee9065162 Use 'static const char' instead of 'static const int'. 
Due to darwin gcc bug, one version of darwin linker coalesces
static const int, which defauts PassID based pass identification.

llvm-svn: 36652
 2007-05-02 21:39:20 +00:00
Devang Patel
38a66bc82e Do not use typeinfo to identify pass in pass manager. 
llvm-svn: 36632
 2007-05-01 21:15:47 +00:00
Anton Korobeynikov
f3e62a428a Removed tabs everywhere except autogenerated & external files. Add make 
target for tabs checking.

llvm-svn: 36146
 2007-04-16 18:10:23 +00:00
Devang Patel
6668a341ae Avoid constructing std::strings unless pass debugging is ON. 
llvm-svn: 34933
 2007-03-05 20:01:30 +00:00
Devang Patel
89791371ce Make getPassManagerType() const. 
llvm-svn: 34669
 2007-02-27 15:00:39 +00:00
Devang Patel
e5e4a44cca Dump function names when debug-pass=Executions is used. 
llvm-svn: 33772
 2007-02-01 22:38:33 +00:00
Devang Patel
015a474023 Pretty print pass manager 
llvm-svn: 33766
 2007-02-01 22:09:37 +00:00
Devang Patel
3eb643f21e Use StartPassTimer() and StopPassManager() 
llvm-svn: 33640
 2007-01-29 23:29:54 +00:00
Devang Patel
dd0a7887fa Measure timings. 
llvm-svn: 33627
 2007-01-29 20:08:03 +00:00
Devang Patel
f1ef346a53 Remove dead code. 
CallGraphSCCPass does not need to implement runOnModule().
It supports runOnSCC().

llvm-svn: 33516
 2007-01-26 01:08:18 +00:00
Devang Patel
f8db9e212e Fix typo. 
llvm-svn: 33467
 2007-01-23 21:55:17 +00:00
Devang Patel
cfd7cfeccd Add CallGraphSCCPass::assignPassManager(). 
This enables CalLGraphPassManager.

llvm-svn: 33466
 2007-01-23 21:52:35 +00:00