5 Commits

Author	SHA1	Message	Date
Vitaly Buka	e2e04cf2d8	Revert "Attempt to pacify ASan and UBSan reports in CrashRecovery tests" ... It's not needed after r303729. This reverts commit r303311. llvm-svn: 303783	2017-05-24 17:58:09 +00:00
Reid Kleckner	e6004ebcc3	Attempt to pacify ASan and UBSan reports in CrashRecovery tests ... llvm-svn: 303311	2017-05-17 22:23:20 +00:00
Reid Kleckner	ecbf774b0a	Re-land r303274: "[CrashRecovery] Use SEH __try instead of VEH when available" ... We have to check gCrashRecoveryEnabled before using __try. In other words, SEH works too well and we ended up recovering from crashes in implicit module builds that we weren't supposed to. Only libclang is supposed to enable CrashRecoveryContext to allow implicit module builds to crash. llvm-svn: 303279	2017-05-17 18:16:17 +00:00
Reid Kleckner	82f1302263	Revert "[CrashRecovery] Use SEH __try instead of VEH when available" ... This reverts commit r303274, it appears to break some clang tests. llvm-svn: 303275	2017-05-17 17:15:00 +00:00
Reid Kleckner	febdda5ca0	[CrashRecovery] Use SEH __try instead of VEH when available ... Summary: It avoids problems when other libraries raise exceptions. In particular, OutputDebugString raises an exception that the debugger is supposed to catch and suppress. VEH kicks in first right now, and that is entirely incorrect. Unfortunately, GCC does not support SEH, so I've kept the old buggy VEH codepath around. We could fix it with SetUnhandledExceptionFilter, but that is not per-thread, so a well-behaved library shouldn't set it. Reviewers: zturner Subscribers: llvm-commits, mgorny Differential Revision: https://reviews.llvm.org/D33261 llvm-svn: 303274	2017-05-17 17:02:16 +00:00