mirror of
https://github.com/RPCS3/llvm-mirror.git
synced 2025-05-21 22:45:55 +00:00

Summary: This reverts commit r372204. This change causes build bot failures under msan: http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/35236/steps/check-llvm%20msan/logs/stdio: ``` FAIL: LLVM :: DebugInfo/AArch64/asan-stack-vars.mir (19531 of 33579) ******************** TEST 'LLVM :: DebugInfo/AArch64/asan-stack-vars.mir' FAILED ******************** Script: -- : 'RUN: at line 1'; /b/sanitizer-x86_64-linux-fast/build/llvm_build_msan/bin/llc -O0 -start-before=livedebugvalues -filetype=obj -o - /b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/test/DebugInfo/AArch64/asan-stack-vars.mir | /b/sanitizer-x86_64-linux-fast/build/llvm_build_msan/bin/llvm-dwarfdump -v - | /b/sanitizer-x86_64-linux-fast/build/llvm_build_msan/bin/FileCheck /b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/test/DebugInfo/AArch64/asan-stack-vars.mir -- Exit Code: 2 Command Output (stderr): -- ==62894==WARNING: MemorySanitizer: use-of-uninitialized-value #0 0xdfcafb in llvm::AArch64FrameLowering::resolveFrameOffsetReference(llvm::MachineFunction const&, int, bool, unsigned int&, bool, bool) const /b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/lib/Target/AArch64/AArch64FrameLowering.cpp:1658:3 #1 0xdfae8a in resolveFrameIndexReference /b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/lib/Target/AArch64/AArch64FrameLowering.cpp:1580:10 #2 0xdfae8a in llvm::AArch64FrameLowering::getFrameIndexReference(llvm::MachineFunction const&, int, unsigned int&) const /b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/lib/Target/AArch64/AArch64FrameLowering.cpp:1536 #3 0x46642c1 in (anonymous namespace)::LiveDebugValues::extractSpillBaseRegAndOffset(llvm::MachineInstr const&) /b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/lib/CodeGen/LiveDebugValues.cpp:582:21 #4 0x4647cb3 in transferSpillOrRestoreInst /b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/lib/CodeGen/LiveDebugValues.cpp:883:11 #5 0x4647cb3 in process /b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/lib/CodeGen/LiveDebugValues.cpp:1079 #6 0x4647cb3 in (anonymous namespace)::LiveDebugValues::ExtendRanges(llvm::MachineFunction&) /b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/lib/CodeGen/LiveDebugValues.cpp:1361 #7 0x463ac0e in (anonymous namespace)::LiveDebugValues::runOnMachineFunction(llvm::MachineFunction&) /b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/lib/CodeGen/LiveDebugValues.cpp:1415:18 #8 0x4854ef0 in llvm::MachineFunctionPass::runOnFunction(llvm::Function&) /b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/lib/CodeGen/MachineFunctionPass.cpp:73:13 #9 0x53b0b01 in llvm::FPPassManager::runOnFunction(llvm::Function&) /b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/lib/IR/LegacyPassManager.cpp:1648:27 #10 0x53b15f6 in llvm::FPPassManager::runOnModule(llvm::Module&) /b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/lib/IR/LegacyPassManager.cpp:1685:16 #11 0x53b298d in runOnModule /b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/lib/IR/LegacyPassManager.cpp:1750:27 #12 0x53b298d in llvm::legacy::PassManagerImpl::run(llvm::Module&) /b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/lib/IR/LegacyPassManager.cpp:1863 #13 0x905f21 in compileModule(char**, llvm::LLVMContext&) /b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/tools/llc/llc.cpp:601:8 #14 0x8fdc4e in main /b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/tools/llc/llc.cpp:355:22 #15 0x7f67673632e0 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x202e0) #16 0x882369 in _start (/b/sanitizer-x86_64-linux-fast/build/llvm_build_msan/bin/llc+0x882369) MemorySanitizer: use-of-uninitialized-value /b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/lib/Target/AArch64/AArch64FrameLowering.cpp:1658:3 in llvm::AArch64FrameLowering::resolveFrameOffsetReference(llvm::MachineFunction const&, int, bool, unsigned int&, bool, bool) const Exiting error: -: The file was not recognized as a valid object file FileCheck error: '-' is empty. FileCheck command line: /b/sanitizer-x86_64-linux-fast/build/llvm_build_msan/bin/FileCheck /b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/test/DebugInfo/AArch64/asan-stack-vars.mir ``` Reviewers: bkramer Reviewed By: bkramer Subscribers: sdardis, aprantl, kristof.beyls, jrtc27, atanasyan, llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D67710 llvm-svn: 372228
130 lines
5.1 KiB
C++
130 lines
5.1 KiB
C++
//===- TargetFrameLoweringImpl.cpp - Implement target frame interface ------==//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
//
|
|
// Implements the layout of a stack frame on the target machine.
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "llvm/ADT/BitVector.h"
|
|
#include "llvm/CodeGen/MachineFrameInfo.h"
|
|
#include "llvm/CodeGen/MachineFunction.h"
|
|
#include "llvm/CodeGen/MachineRegisterInfo.h"
|
|
#include "llvm/CodeGen/TargetFrameLowering.h"
|
|
#include "llvm/CodeGen/TargetRegisterInfo.h"
|
|
#include "llvm/CodeGen/TargetSubtargetInfo.h"
|
|
#include "llvm/IR/Attributes.h"
|
|
#include "llvm/IR/CallingConv.h"
|
|
#include "llvm/IR/Function.h"
|
|
#include "llvm/MC/MCRegisterInfo.h"
|
|
#include "llvm/Support/Compiler.h"
|
|
#include "llvm/Target/TargetMachine.h"
|
|
#include "llvm/Target/TargetOptions.h"
|
|
|
|
using namespace llvm;
|
|
|
|
TargetFrameLowering::~TargetFrameLowering() = default;
|
|
|
|
bool TargetFrameLowering::enableCalleeSaveSkip(const MachineFunction &MF) const {
|
|
assert(MF.getFunction().hasFnAttribute(Attribute::NoReturn) &&
|
|
MF.getFunction().hasFnAttribute(Attribute::NoUnwind) &&
|
|
!MF.getFunction().hasFnAttribute(Attribute::UWTable));
|
|
return false;
|
|
}
|
|
|
|
/// Returns the displacement from the frame register to the stack
|
|
/// frame of the specified index, along with the frame register used
|
|
/// (in output arg FrameReg). This is the default implementation which
|
|
/// is overridden for some targets.
|
|
int TargetFrameLowering::getFrameIndexReference(const MachineFunction &MF,
|
|
int FI, unsigned &FrameReg) const {
|
|
const MachineFrameInfo &MFI = MF.getFrameInfo();
|
|
const TargetRegisterInfo *RI = MF.getSubtarget().getRegisterInfo();
|
|
|
|
// By default, assume all frame indices are referenced via whatever
|
|
// getFrameRegister() says. The target can override this if it's doing
|
|
// something different.
|
|
FrameReg = RI->getFrameRegister(MF);
|
|
|
|
return MFI.getObjectOffset(FI) + MFI.getStackSize() -
|
|
getOffsetOfLocalArea() + MFI.getOffsetAdjustment();
|
|
}
|
|
|
|
bool TargetFrameLowering::needsFrameIndexResolution(
|
|
const MachineFunction &MF) const {
|
|
return MF.getFrameInfo().hasStackObjects();
|
|
}
|
|
|
|
void TargetFrameLowering::determineCalleeSaves(MachineFunction &MF,
|
|
BitVector &SavedRegs,
|
|
RegScavenger *RS) const {
|
|
const TargetRegisterInfo &TRI = *MF.getSubtarget().getRegisterInfo();
|
|
|
|
// Resize before the early returns. Some backends expect that
|
|
// SavedRegs.size() == TRI.getNumRegs() after this call even if there are no
|
|
// saved registers.
|
|
SavedRegs.resize(TRI.getNumRegs());
|
|
|
|
// When interprocedural register allocation is enabled caller saved registers
|
|
// are preferred over callee saved registers.
|
|
if (MF.getTarget().Options.EnableIPRA &&
|
|
isSafeForNoCSROpt(MF.getFunction()) &&
|
|
isProfitableForNoCSROpt(MF.getFunction()))
|
|
return;
|
|
|
|
// Get the callee saved register list...
|
|
const MCPhysReg *CSRegs = MF.getRegInfo().getCalleeSavedRegs();
|
|
|
|
// Early exit if there are no callee saved registers.
|
|
if (!CSRegs || CSRegs[0] == 0)
|
|
return;
|
|
|
|
// In Naked functions we aren't going to save any registers.
|
|
if (MF.getFunction().hasFnAttribute(Attribute::Naked))
|
|
return;
|
|
|
|
// Noreturn+nounwind functions never restore CSR, so no saves are needed.
|
|
// Purely noreturn functions may still return through throws, so those must
|
|
// save CSR for caller exception handlers.
|
|
//
|
|
// If the function uses longjmp to break out of its current path of
|
|
// execution we do not need the CSR spills either: setjmp stores all CSRs
|
|
// it was called with into the jmp_buf, which longjmp then restores.
|
|
if (MF.getFunction().hasFnAttribute(Attribute::NoReturn) &&
|
|
MF.getFunction().hasFnAttribute(Attribute::NoUnwind) &&
|
|
!MF.getFunction().hasFnAttribute(Attribute::UWTable) &&
|
|
enableCalleeSaveSkip(MF))
|
|
return;
|
|
|
|
// Functions which call __builtin_unwind_init get all their registers saved.
|
|
bool CallsUnwindInit = MF.callsUnwindInit();
|
|
const MachineRegisterInfo &MRI = MF.getRegInfo();
|
|
for (unsigned i = 0; CSRegs[i]; ++i) {
|
|
unsigned Reg = CSRegs[i];
|
|
if (CallsUnwindInit || MRI.isPhysRegModified(Reg))
|
|
SavedRegs.set(Reg);
|
|
}
|
|
}
|
|
|
|
unsigned TargetFrameLowering::getStackAlignmentSkew(
|
|
const MachineFunction &MF) const {
|
|
// When HHVM function is called, the stack is skewed as the return address
|
|
// is removed from the stack before we enter the function.
|
|
if (LLVM_UNLIKELY(MF.getFunction().getCallingConv() == CallingConv::HHVM))
|
|
return MF.getTarget().getAllocaPointerSize();
|
|
|
|
return 0;
|
|
}
|
|
|
|
int TargetFrameLowering::getInitialCFAOffset(const MachineFunction &MF) const {
|
|
llvm_unreachable("getInitialCFAOffset() not implemented!");
|
|
}
|
|
|
|
unsigned TargetFrameLowering::getInitialCFARegister(const MachineFunction &MF)
|
|
const {
|
|
llvm_unreachable("getInitialCFARegister() not implemented!");
|
|
} |