Sanjay Patel 3363715e8e [SDAG] remove use restriction in isNegatibleForFree() when called from getNegatedExpression() ...

This is an alternate fix for the bug discussed in D70595.
This also includes minimal tests for other in-tree targets
to show the problem more generally.

We check the number of uses as a predicate for whether some
value is free to negate, but that use count can change as we
rewrite the expression in getNegatedExpression(). So something
that was marked free to negate during the cost evaluation
phase becomes not free to negate during the rewrite phase (or
the inverse - something that was not free becomes free).
This can lead to a crash/assert because we expect that
everything in an expression that is negatible to be handled
in the corresponding code within getNegatedExpression().

This patch skips the use check during the rewrite phase.
So we determine that some expression isNegatibleForFree
(identically to without this patch), but during the rewrite,
don't rely on use counts to decide how to create the optimal
expression.

Differential Revision: https://reviews.llvm.org/D70975

2019-12-11 13:30:39 -05:00

..

llvm

[SDAG] remove use restriction in isNegatibleForFree() when called from getNegatedExpression()

2019-12-11 13:30:39 -05:00

llvm-c

Recommit "[DWARF5]Addition of alignment atrribute in typedef DIE."

2019-12-03 09:51:43 +05:30