mirror of
https://github.com/RPCS3/llvm-mirror.git
synced 2025-01-06 03:08:43 +00:00
6c170b33ed
The work order was changed in r228186 from SCC order to RPO with an arbitrary sorting function. The sorting function attempted to move inner loop nodes earlier. This was was apparently relying on an assumption that every block in a given loop / the same loop depth would be seen before visiting another loop. In the broken testcase, a block outside of the loop was encountered before moving onto another block in the same loop. The testcase would then structurize such that one blocks unconditional successor could never be reached. Revert to plain RPO for the analysis phase. This fixes detecting edges as backedges that aren't really. The processing phase does use another visited set, and I'm unclear on whether the order there is as important. An arbitrary order doesn't work, and triggers some infinite loops. The reversed RPO list seems to work and is closer to the order that was used before, minus the arbitary custom sorting. A few of the changed tests now produce smaller code, and a few are slightly worse looking. llvm-svn: 321751 |
||
|---|---|---|
| .. | ||
| AMDGPU | ||
| branch-on-argument.ll | ||
| invert-constantexpr.ll | ||
| loop-multiple-exits.ll | ||
| nested-loop-order.ll | ||
| no-branch-to-entry.ll | ||
| one-loop-multiple-backedges.ll | ||
| post-order-traversal-bug.ll | ||
| rebuild-ssa-infinite-loop.ll | ||
| switch.ll | ||