Yuanfang Chen 725cd0da61 [Support] make report_fatal_error abort instead of exit ... Summary: This patch could be treated as a rebase of D33960. It also fixes PR35547. A fix for `llvm/test/Other/close-stderr.ll` is proposed in D68164. Seems the consensus is that the test is passing by chance and I'm not sure how important it is for us. So it is removed like in D33960 for now. The rest of the test fixes are just adding `--crash` flag to `not` tool. ** The reason it fixes PR35547 is `exit` does cleanup including calling class destructor whereas `abort` does not do any cleanup. In multithreading environment such as ThinLTO or JIT, threads may share states which mostly are ManagedStatic<>. If faulting thread tearing down a class when another thread is using it, there are chances of memory corruption. This is bad 1. It will stop error reporting like pretty stack printer; 2. The memory corruption is distracting and nondeterministic in terms of error message, and corruption type (depending one the timing, it could be double free, heap free after use, etc.). Reviewers: rnk, chandlerc, zturner, sepavloff, MaskRay, espindola Reviewed By: rnk, MaskRay Subscribers: wuzish, jholewinski, qcolombet, dschuff, jyknight, emaste, sdardis, nemanjai, jvesely, nhaehnle, sbc100, arichardson, jgravelle-google, aheejin, kbarton, fedor.sergeev, asb, rbar, johnrusso, simoncook, apazos, sabuasal, niosHD, jrtc27, zzheng, edward-jones, atanasyan, rogfer01, MartinMosbeck, brucehoult, the_o, PkmX, jocewei, jsji, lenary, s.egerton, pzheng, cfe-commits, MaskRay, filcab, davide, MatzeB, mehdi_amini, hiraditya, steven_wu, dexonsmith, rupprecht, seiya, llvm-commits Tags: #llvm, #clang Differential Revision: https://reviews.llvm.org/D67847		2020-01-15 17:05:13 -08:00
..
Analysis
Assembler	[Support] make report_fatal_error abort instead of exit	2020-01-15 17:05:13 -08:00
Bindings
Bitcode	[Support] make report_fatal_error abort instead of exit	2020-01-15 17:05:13 -08:00
BugPoint
CodeGen	[Support] make report_fatal_error abort instead of exit	2020-01-15 17:05:13 -08:00
DebugInfo	[Support] make report_fatal_error abort instead of exit	2020-01-15 17:05:13 -08:00
Demangle
Examples
ExecutionEngine
Feature
FileCheck
Instrumentation
Integer
JitListener
Linker
LTO	[Support] make report_fatal_error abort instead of exit	2020-01-15 17:05:13 -08:00
MachineVerifier	[Support] make report_fatal_error abort instead of exit	2020-01-15 17:05:13 -08:00
MC	[Support] make report_fatal_error abort instead of exit	2020-01-15 17:05:13 -08:00
Object	[Support] make report_fatal_error abort instead of exit	2020-01-15 17:05:13 -08:00
ObjectYAML
Other	[Support] make report_fatal_error abort instead of exit	2020-01-15 17:05:13 -08:00
Reduce
SafepointIRVerifier
Support
SymbolRewriter
TableGen	[Support] make report_fatal_error abort instead of exit	2020-01-15 17:05:13 -08:00
ThinLTO/X86	[ThinLTO] Always import constants	2020-01-15 19:29:01 +03:00
tools	[Support] make report_fatal_error abort instead of exit	2020-01-15 17:05:13 -08:00
Transforms	[Support] make report_fatal_error abort instead of exit	2020-01-15 17:05:13 -08:00
Unit
Verifier
YAMLParser
.clang-format
CMakeLists.txt
lit.cfg.py
lit.site.cfg.py.in
TestRunner.sh