mirror of
https://github.com/RPCS3/llvm-mirror.git
synced 2024-12-02 08:26:29 +00:00
866992fbb3
Suppose an inline instance has hot total sample count but 0 entry count, and
it is an indirect call target. If the indirect call has no other call target
and inline instance associated with it and it is promoted, currently the
conditional branch generated by indirect call promotion will have invalid
branch profile which is !{!"branch_weights", i32 0, i32 0} -- because the
entry count of the promoted target is 0 and the total entry count of all
targets is also 0. This caused a SEGV in Control Height Reduction and may
cause problem in other passes.
Function entry count of an inline instance is computed by a heuristic --
using either the sample of the starting line or starting inner inline
instance. The patch changes the heuristic a little bit so that when total
sample count is larger than 0, the computed entry count will be at least 1.
Then the new branch profile will be !{!"branch_weights", i32 1, i32 0}.
Differential Revision: https://reviews.llvm.org/D72790
73 lines
2.8 KiB
LLVM
73 lines
2.8 KiB
LLVM
; Make sure Import GUID list for ThinLTO properly maintained while update function's entry count for inlining
|
|
|
|
; RUN: opt < %s -passes='thinlto-pre-link<O2>' -pgo-kind=pgo-sample-use-pipeline -sample-profile-file=%S/Inputs/inline-callee-update.prof -S | FileCheck %s
|
|
|
|
@y = global i32* ()* null, align 8
|
|
@z = global i32* ()* null, align 8
|
|
|
|
; CHECK: define i32* @sample_loader_inlinee() {{.*}} !prof ![[ENTRY:[0-9]+]]
|
|
define i32* @sample_loader_inlinee() !dbg !3 {
|
|
bb:
|
|
%tmp = call i32* @direct_leaf_func(i32* null), !dbg !4
|
|
%cmp = icmp ne i32* %tmp, null
|
|
br i1 %cmp, label %then, label %else
|
|
|
|
then: ; preds = %bb
|
|
%tmp1 = load i32* ()*, i32* ()** @z, align 8, !dbg !5
|
|
%tmp2 = call i32* %tmp1(), !dbg !5
|
|
ret i32* %tmp2
|
|
|
|
else: ; preds = %bb
|
|
ret i32* null
|
|
}
|
|
|
|
; CHECK: define i32* @cgscc_inlinee() {{.*}} !prof ![[ENTRY:[0-9]+]]
|
|
define i32* @cgscc_inlinee() !dbg !6 {
|
|
bb:
|
|
%tmp = call i32* @direct_leaf_func(i32* null), !dbg !7
|
|
%cmp = icmp ne i32* %tmp, null
|
|
br i1 %cmp, label %then, label %else
|
|
|
|
then: ; preds = %bb
|
|
%tmp1 = load i32* ()*, i32* ()** @y, align 8, !dbg !8
|
|
%tmp2 = call i32* %tmp1(), !dbg !8
|
|
ret i32* %tmp2
|
|
|
|
else: ; preds = %bb
|
|
ret i32* null
|
|
}
|
|
|
|
define i32* @test_sample_loader_inline(void ()* %arg) !dbg !9 {
|
|
bb:
|
|
%tmp = call i32* @sample_loader_inlinee(), !dbg !10
|
|
ret i32* %tmp
|
|
}
|
|
|
|
define i32* @test_cgscc_inline(void ()* %arg) !dbg !11 {
|
|
bb:
|
|
%tmp = call i32* @cgscc_inlinee(), !dbg !12
|
|
ret i32* %tmp
|
|
}
|
|
|
|
declare i32* @direct_leaf_func(i32*)
|
|
|
|
!llvm.dbg.cu = !{!0}
|
|
!llvm.module.flags = !{!2}
|
|
|
|
!0 = distinct !DICompileUnit(language: DW_LANG_C_plus_plus, file: !1, isOptimized: false, runtimeVersion: 0, emissionKind: NoDebug)
|
|
!1 = !DIFile(filename: "test.cc", directory: "/")
|
|
!2 = !{i32 2, !"Debug Info Version", i32 3}
|
|
!3 = distinct !DISubprogram(name: "sample_loader_inlinee", scope: !1, file: !1, line: 11, spFlags: DISPFlagDefinition, unit: !0)
|
|
!4 = !DILocation(line: 12, scope: !3)
|
|
!5 = !DILocation(line: 13, scope: !3)
|
|
!6 = distinct !DISubprogram(name: "cgscc_inlinee", scope: !1, file: !1, line: 31, spFlags: DISPFlagDefinition, unit: !0)
|
|
!7 = !DILocation(line: 32, scope: !6)
|
|
!8 = !DILocation(line: 33, scope: !6)
|
|
!9 = distinct !DISubprogram(name: "test_sample_loader_inline", scope: !1, file: !1, line: 3, spFlags: DISPFlagDefinition, unit: !0)
|
|
!10 = !DILocation(line: 4, scope: !9)
|
|
!11 = distinct !DISubprogram(name: "test_cgscc_inline", scope: !1, file: !1, line: 20, spFlags: DISPFlagDefinition, unit: !0)
|
|
!12 = !DILocation(line: 21, scope: !11)
|
|
|
|
; Make sure the ImportGUID stays with entry count metadata for ThinLTO-PreLink
|
|
; CHECK: ![[ENTRY]] = !{!"function_entry_count", i64 1, i64 -9171813444624716006}
|