mirror of
https://github.com/RPCS3/llvm-mirror.git
synced 2024-12-15 07:39:31 +00:00
b664c03f18
In the commit message to r185476 I wrote: >The PowerPC-specific modifiers VK_PPC_TLSGD and VK_PPC_TLSLD >correspond exactly to the generic modifiers VK_TLSGD and VK_TLSLD. >This causes some confusion with the asm parser, since VK_PPC_TLSGD >is output as @tlsgd, which is then read back in as VK_TLSGD. > >To avoid this confusion, this patch removes the PowerPC-specific >modifiers and uses the generic modifiers throughout. (The only >drawback is that the generic modifiers are printed in upper case >while the usual convention on PowerPC is to use lower-case modifiers. >But this is just a cosmetic issue.) This was unfortunately incorrect, there is is fact another, serious drawback to using the default VK_TLSLD/VK_TLSGD variant kinds: using these causes ELFObjectWriter::RelocNeedsGOT to return true, which in turn causes the ELFObjectWriter to emit an undefined reference to _GLOBAL_OFFSET_TABLE_. This is a problem on powerpc64, because it uses the TOC instead of the GOT, and the linker does not provide _GLOBAL_OFFSET_TABLE_, so the symbol remains undefined. This means shared libraries using TLS built with the integrated assembler are currently broken. While the whole RelocNeedsGOT / _GLOBAL_OFFSET_TABLE_ situation probably ought to be properly fixed at some point, for now I'm simply reverting the r185476 commit. Now this in turn exposes the breakage of handling @tlsgd/@tlsld in the asm parser that this check-in was originally intended to fix. To avoid this regression, I'm also adding a different fix for this problem: while common code now parses @tlsgd as VK_TLSGD, a special hack in the asm parser translates this code to the platform-specific VK_PPC_TLSGD that the back-end now expects. While this is not really pretty, it's self-contained and shouldn't hurt anything else for now. One the underlying problem is fixed, this hack can be reverted again. llvm-svn: 185945 |
||
|---|---|---|
| .. | ||
| MCDisassembler | ||
| MCParser | ||
| CMakeLists.txt | ||
| ELFObjectWriter.cpp | ||
| LLVMBuild.txt | ||
| MachObjectWriter.cpp | ||
| Makefile | ||
| MCAsmBackend.cpp | ||
| MCAsmInfo.cpp | ||
| MCAsmInfoCOFF.cpp | ||
| MCAsmInfoDarwin.cpp | ||
| MCAsmStreamer.cpp | ||
| MCAssembler.cpp | ||
| MCAtom.cpp | ||
| MCCodeEmitter.cpp | ||
| MCCodeGenInfo.cpp | ||
| MCContext.cpp | ||
| MCDisassembler.cpp | ||
| MCDwarf.cpp | ||
| MCELF.cpp | ||
| MCELFObjectTargetWriter.cpp | ||
| MCELFStreamer.cpp | ||
| MCExpr.cpp | ||
| MCExternalSymbolizer.cpp | ||
| MCFunction.cpp | ||
| MCInst.cpp | ||
| MCInstPrinter.cpp | ||
| MCInstrAnalysis.cpp | ||
| MCLabel.cpp | ||
| MCMachObjectTargetWriter.cpp | ||
| MCMachOStreamer.cpp | ||
| MCModule.cpp | ||
| MCNullStreamer.cpp | ||
| MCObjectDisassembler.cpp | ||
| MCObjectFileInfo.cpp | ||
| MCObjectStreamer.cpp | ||
| MCObjectSymbolizer.cpp | ||
| MCObjectWriter.cpp | ||
| MCPureStreamer.cpp | ||
| MCRegisterInfo.cpp | ||
| MCRelocationInfo.cpp | ||
| MCSection.cpp | ||
| MCSectionCOFF.cpp | ||
| MCSectionELF.cpp | ||
| MCSectionMachO.cpp | ||
| MCStreamer.cpp | ||
| MCSubtargetInfo.cpp | ||
| MCSymbol.cpp | ||
| MCSymbolizer.cpp | ||
| MCValue.cpp | ||
| MCWin64EH.cpp | ||
| SubtargetFeature.cpp | ||
| WinCOFFObjectWriter.cpp | ||
| WinCOFFStreamer.cpp | ||