mirror of
https://github.com/RPCS3/llvm-mirror.git
synced 2025-04-05 17:21:39 +00:00
9200890ea3
Split out a new, low-level intrusive list type with clear semantics.
Unlike iplist (and ilist), all operations on simple_ilist are intrusive,
and simple_ilist never takes ownership of its nodes. This enables an
intuitive API that has the right defaults for intrusive lists.
- insert() takes references (not pointers!) to nodes (in iplist/ilist,
passing a reference will cause the node to be copied).
- erase() takes only iterators (like std::list), and does not destroy
the nodes.
- remove() takes only references and has the same behaviour as erase().
- clear() does not destroy the nodes.
- The destructor does not destroy the nodes.
- New API {erase,remove,clear}AndDispose() take an extra Disposer
functor for callsites that want to call some disposal routine (e.g.,
std::default_delete).
This list is not currently configurable, and has no callbacks.
The initial motivation was to fix iplist<>::sort to work correctly (even
with callbacks in ilist_traits<>). iplist<> uses simple_ilist<>::sort
directly. The new test in unittests/IR/ModuleTest.cpp crashes without
this commit.
Fixing sort() via a low-level layer provided a good opportunity to:
- Unit test the low-level functionality thoroughly.
- Modernize the API, largely inspired by other intrusive list
implementations.
Here's a sketch of a longer-term plan:
- Create BumpPtrList<>, a non-intrusive list implemented using
simple_ilist<>, and use it for the Token list in
lib/Support/YAMLParser.cpp. This will factor out the only real use of
createNode().
- Evolve the iplist<> and ilist<> APIs in the direction of
simple_ilist<>, making allocation/deallocation explicit at call sites
(similar to simple_ilist<>::eraseAndDispose()).
- Factor out remaining calls to createNode() and deleteNode() and remove
the customization from ilist_traits<>.
- Transition uses of iplist<>/ilist<> that don't need callbacks over to
simple_ilist<>.
llvm-svn: 280107
49 lines
1.6 KiB
C++
49 lines
1.6 KiB
C++
//===- unittests/IR/ModuleTest.cpp - Module unit tests --------------------===//
|
|
//
|
|
// The LLVM Compiler Infrastructure
|
|
//
|
|
// This file is distributed under the University of Illinois Open Source
|
|
// License. See LICENSE.TXT for details.
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "llvm/IR/GlobalVariable.h"
|
|
#include "llvm/IR/Module.h"
|
|
#include "gtest/gtest.h"
|
|
|
|
using namespace llvm;
|
|
|
|
namespace {
|
|
|
|
bool sortByName(const GlobalVariable &L, const GlobalVariable &R) {
|
|
return L.getName() < R.getName();
|
|
}
|
|
|
|
bool sortByNameReverse(const GlobalVariable &L, const GlobalVariable &R) {
|
|
return sortByName(R, L);
|
|
}
|
|
|
|
TEST(ModuleTest, sortGlobalsByName) {
|
|
LLVMContext Context;
|
|
for (auto compare : {sortByName, sortByNameReverse}) {
|
|
Module M("M", Context);
|
|
Type *T = Type::getInt8Ty(Context);
|
|
GlobalValue::LinkageTypes L = GlobalValue::ExternalLinkage;
|
|
(void)new GlobalVariable(M, T, false, L, nullptr, "A");
|
|
(void)new GlobalVariable(M, T, false, L, nullptr, "F");
|
|
(void)new GlobalVariable(M, T, false, L, nullptr, "G");
|
|
(void)new GlobalVariable(M, T, false, L, nullptr, "E");
|
|
(void)new GlobalVariable(M, T, false, L, nullptr, "B");
|
|
(void)new GlobalVariable(M, T, false, L, nullptr, "H");
|
|
(void)new GlobalVariable(M, T, false, L, nullptr, "C");
|
|
(void)new GlobalVariable(M, T, false, L, nullptr, "D");
|
|
|
|
// Sort the globals by name.
|
|
EXPECT_FALSE(std::is_sorted(M.global_begin(), M.global_end(), compare));
|
|
M.getGlobalList().sort(compare);
|
|
EXPECT_TRUE(std::is_sorted(M.global_begin(), M.global_end(), compare));
|
|
}
|
|
}
|
|
|
|
} // end namespace
|