mirror of
https://github.com/RPCS3/llvm-mirror.git
synced 2025-04-14 21:51:19 +00:00
ab809dc2fa
There's a lot of misuse of Twine scattered around LLVM. This ranges in severity from benign (returning a Twine from a function by value that is just a string literal) to pretty sketchy (storing a Twine by value in a class). While there are some uses for copying Twines, most of the very compelling ones are confined to the Twine class implementation itself, and other uses are either dubious or easily worked around. This patch makes Twine's copy constructor private, and fixes up all callsites. Differential Revision: https://reviews.llvm.org/D38767 llvm-svn: 315530
97 lines
3.3 KiB
C++
97 lines
3.3 KiB
C++
//===- Error.cpp - system_error extensions for Object -----------*- C++ -*-===//
|
|
//
|
|
// The LLVM Compiler Infrastructure
|
|
//
|
|
// This file is distributed under the University of Illinois Open Source
|
|
// License. See LICENSE.TXT for details.
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
//
|
|
// This defines a new error_category for the Object library.
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "llvm/Object/Error.h"
|
|
#include "llvm/Support/ErrorHandling.h"
|
|
#include "llvm/Support/ManagedStatic.h"
|
|
|
|
using namespace llvm;
|
|
using namespace object;
|
|
|
|
namespace {
|
|
// FIXME: This class is only here to support the transition to llvm::Error. It
|
|
// will be removed once this transition is complete. Clients should prefer to
|
|
// deal with the Error value directly, rather than converting to error_code.
|
|
class _object_error_category : public std::error_category {
|
|
public:
|
|
const char* name() const noexcept override;
|
|
std::string message(int ev) const override;
|
|
};
|
|
}
|
|
|
|
const char *_object_error_category::name() const noexcept {
|
|
return "llvm.object";
|
|
}
|
|
|
|
std::string _object_error_category::message(int EV) const {
|
|
object_error E = static_cast<object_error>(EV);
|
|
switch (E) {
|
|
case object_error::arch_not_found:
|
|
return "No object file for requested architecture";
|
|
case object_error::invalid_file_type:
|
|
return "The file was not recognized as a valid object file";
|
|
case object_error::parse_failed:
|
|
return "Invalid data was encountered while parsing the file";
|
|
case object_error::unexpected_eof:
|
|
return "The end of the file was unexpectedly encountered";
|
|
case object_error::string_table_non_null_end:
|
|
return "String table must end with a null terminator";
|
|
case object_error::invalid_section_index:
|
|
return "Invalid section index";
|
|
case object_error::bitcode_section_not_found:
|
|
return "Bitcode section not found in object file";
|
|
case object_error::invalid_symbol_index:
|
|
return "Invalid symbol index";
|
|
}
|
|
llvm_unreachable("An enumerator of object_error does not have a message "
|
|
"defined.");
|
|
}
|
|
|
|
char BinaryError::ID = 0;
|
|
char GenericBinaryError::ID = 0;
|
|
|
|
GenericBinaryError::GenericBinaryError(const Twine &Msg) : Msg(Msg.str()) {}
|
|
|
|
GenericBinaryError::GenericBinaryError(const Twine &Msg,
|
|
object_error ECOverride)
|
|
: Msg(Msg.str()) {
|
|
setErrorCode(make_error_code(ECOverride));
|
|
}
|
|
|
|
void GenericBinaryError::log(raw_ostream &OS) const {
|
|
OS << Msg;
|
|
}
|
|
|
|
static ManagedStatic<_object_error_category> error_category;
|
|
|
|
const std::error_category &object::object_category() {
|
|
return *error_category;
|
|
}
|
|
|
|
llvm::Error llvm::object::isNotObjectErrorInvalidFileType(llvm::Error Err) {
|
|
if (auto Err2 =
|
|
handleErrors(std::move(Err), [](std::unique_ptr<ECError> M) -> Error {
|
|
// Try to handle 'M'. If successful, return a success value from
|
|
// the handler.
|
|
if (M->convertToErrorCode() == object_error::invalid_file_type)
|
|
return Error::success();
|
|
|
|
// We failed to handle 'M' - return it from the handler.
|
|
// This value will be passed back from catchErrors and
|
|
// wind up in Err2, where it will be returned from this function.
|
|
return Error(std::move(M));
|
|
}))
|
|
return Err2;
|
|
return Err;
|
|
}
|