Kevin Enderby cde48ff083 Clean up the logic of the Archive::Child::Child() with an assert to know Err is not a nullptr ...

when we are pointed at real data.

David Blaikie pointed out some odd logic in the case the Err value was a nullptr and
Lang Hames suggested it could be cleaned it up with an assert to know that Err is
not a nullptr when we are pointed at real data.  As only in the case of constructing
the sentinel value by pointing it at null data is Err is permitted to be a nullptr,
since no error could occur in that case.

With this change the testing for “if (Err)” is removed from the constructor’s logic
and *Err is used directly without any check after the assert().

llvm-svn: 277776

2016-08-04 21:54:19 +00:00

..

Archive.cpp

Clean up the logic of the Archive::Child::Child() with an assert to know Err is not a nullptr

2016-08-04 21:54:19 +00:00

ArchiveWriter.cpp

Reapply "More fixes to get good error messages for bad archives."

2016-08-03 19:02:50 +00:00

Binary.cpp

Change Archive::create() from ErrorOr<...> to Expected<...> and update

2016-06-29 20:35:44 +00:00

CMakeLists.txt

[CMake] Restrict libxar linkage to just llvm-objdump

2016-05-26 16:32:40 +00:00

COFFObjectFile.cpp

[COFF] Expose iterators for ImportAddressTableRVA

2016-07-31 19:40:02 +00:00

ELF.cpp

BPF: Use official ELF e_machine value

2016-07-15 22:27:55 +00:00

ELFObjectFile.cpp

[llvm-objdump] Support detection of feature bits from the object and implement this for Mips.

2016-06-16 09:17:03 +00:00

Error.cpp

Add FIXMEs to all derived classes of std::error_category.

2016-05-24 20:13:46 +00:00

IRObjectFile.cpp

function_refify. NFC.

2016-07-01 11:05:15 +00:00

LLVMBuild.txt

…

MachOObjectFile.cpp

[Support] Make ErrorAsOutParameter take an Error* rather than an Error&.

2016-07-22 16:11:25 +00:00

MachOUniversal.cpp

[Support] Make ErrorAsOutParameter take an Error* rather than an Error&.

2016-07-22 16:11:25 +00:00

ModuleSummaryIndexObjectFile.cpp

Apply another batch of fixes from clang-tidy's performance-unnecessary-value-param.

2016-06-17 20:41:14 +00:00

Object.cpp

Thread Expected<...> up from libObject’s getSymbolAddress() for symbols to allow

2016-06-24 18:24:42 +00:00

ObjectFile.cpp

Thread Expected<...> up from libObject’s getType() for symbols to allow llvm-objdump to produce a good error message.

2016-05-02 20:28:12 +00:00

RecordStreamer.cpp

RecordStreamer: handle inline asm "lazy_reference" and mark symbols as "used"

2016-08-03 03:51:42 +00:00

RecordStreamer.h

[IRObjectFile] Propagate .weak attribute correctly for ASM symbols.

2016-06-22 20:48:15 +00:00

SymbolicFile.cpp

Thread Expected<...> up from createMachOObjectFile() to allow llvm-objdump to produce a real error message

2016-04-06 22:14:09 +00:00

SymbolSize.cpp

[SymbolSize] Skip sorting by index, just assign by index.

2015-06-29 16:05:00 +00:00