mirror of
https://github.com/RPCS3/llvm-mirror.git
synced 2024-12-14 23:29:51 +00:00
eb66b33867
I did this a long time ago with a janky python script, but now clang-format has built-in support for this. I fed clang-format every line with a #include and let it re-sort things according to the precise LLVM rules for include ordering baked into clang-format these days. I've reverted a number of files where the results of sorting includes isn't healthy. Either places where we have legacy code relying on particular include ordering (where possible, I'll fix these separately) or where we have particular formatting around #include lines that I didn't want to disturb in this patch. This patch is *entirely* mechanical. If you get merge conflicts or anything, just ignore the changes in this patch and run clang-format over your #include lines in the files. Sorry for any noise here, but it is important to keep these things stable. I was seeing an increasing number of patches with irrelevant re-ordering of #include lines because clang-format was used. This patch at least isolates that churn, makes it easy to skip when resolving conflicts, and gets us to a clean baseline (again). llvm-svn: 304787
156 lines
5.2 KiB
C++
156 lines
5.2 KiB
C++
//===-- PPCTOCRegDeps.cpp - Add Extra TOC Register Dependencies -----------===//
|
|
//
|
|
// The LLVM Compiler Infrastructure
|
|
//
|
|
// This file is distributed under the University of Illinois Open Source
|
|
// License. See LICENSE.TXT for details.
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
//
|
|
// When resolving an address using the ELF ABI TOC pointer, two relocations are
|
|
// generally required: one for the high part and one for the low part. Only
|
|
// the high part generally explicitly depends on r2 (the TOC pointer). And, so,
|
|
// we might produce code like this:
|
|
//
|
|
// .Ltmp526:
|
|
// addis 3, 2, .LC12@toc@ha
|
|
// .Ltmp1628:
|
|
// std 2, 40(1)
|
|
// ld 5, 0(27)
|
|
// ld 2, 8(27)
|
|
// ld 11, 16(27)
|
|
// ld 3, .LC12@toc@l(3)
|
|
// rldicl 4, 4, 0, 32
|
|
// mtctr 5
|
|
// bctrl
|
|
// ld 2, 40(1)
|
|
//
|
|
// And there is nothing wrong with this code, as such, but there is a linker bug
|
|
// in binutils (https://sourceware.org/bugzilla/show_bug.cgi?id=18414) that will
|
|
// misoptimize this code sequence to this:
|
|
// nop
|
|
// std r2,40(r1)
|
|
// ld r5,0(r27)
|
|
// ld r2,8(r27)
|
|
// ld r11,16(r27)
|
|
// ld r3,-32472(r2)
|
|
// clrldi r4,r4,32
|
|
// mtctr r5
|
|
// bctrl
|
|
// ld r2,40(r1)
|
|
// because the linker does not know (and does not check) that the value in r2
|
|
// changed in between the instruction using the .LC12@toc@ha (TOC-relative)
|
|
// relocation and the instruction using the .LC12@toc@l(3) relocation.
|
|
// Because it finds these instructions using the relocations (and not by
|
|
// scanning the instructions), it has been asserted that there is no good way
|
|
// to detect the change of r2 in between. As a result, this bug may never be
|
|
// fixed (i.e. it may become part of the definition of the ABI). GCC was
|
|
// updated to add extra dependencies on r2 to instructions using the @toc@l
|
|
// relocations to avoid this problem, and we'll do the same here.
|
|
//
|
|
// This is done as a separate pass because:
|
|
// 1. These extra r2 dependencies are not really properties of the
|
|
// instructions, but rather due to a linker bug, and maybe one day we'll be
|
|
// able to get rid of them when targeting linkers without this bug (and,
|
|
// thus, keeping the logic centralized here will make that
|
|
// straightforward).
|
|
// 2. There are ISel-level peephole optimizations that propagate the @toc@l
|
|
// relocations to some user instructions, and so the exta dependencies do
|
|
// not apply only to a fixed set of instructions (without undesirable
|
|
// definition replication).
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "MCTargetDesc/PPCPredicates.h"
|
|
#include "PPC.h"
|
|
#include "PPCInstrBuilder.h"
|
|
#include "PPCInstrInfo.h"
|
|
#include "PPCMachineFunctionInfo.h"
|
|
#include "PPCTargetMachine.h"
|
|
#include "llvm/ADT/STLExtras.h"
|
|
#include "llvm/ADT/Statistic.h"
|
|
#include "llvm/CodeGen/MachineFrameInfo.h"
|
|
#include "llvm/CodeGen/MachineFunctionPass.h"
|
|
#include "llvm/CodeGen/MachineInstr.h"
|
|
#include "llvm/CodeGen/MachineRegisterInfo.h"
|
|
#include "llvm/MC/MCAsmInfo.h"
|
|
#include "llvm/Support/Debug.h"
|
|
#include "llvm/Support/ErrorHandling.h"
|
|
#include "llvm/Support/TargetRegistry.h"
|
|
#include "llvm/Support/raw_ostream.h"
|
|
|
|
using namespace llvm;
|
|
|
|
#define DEBUG_TYPE "ppc-toc-reg-deps"
|
|
|
|
namespace llvm {
|
|
void initializePPCTOCRegDepsPass(PassRegistry&);
|
|
}
|
|
|
|
namespace {
|
|
// PPCTOCRegDeps pass - For simple functions without epilogue code, move
|
|
// returns up, and create conditional returns, to avoid unnecessary
|
|
// branch-to-blr sequences.
|
|
struct PPCTOCRegDeps : public MachineFunctionPass {
|
|
static char ID;
|
|
PPCTOCRegDeps() : MachineFunctionPass(ID) {
|
|
initializePPCTOCRegDepsPass(*PassRegistry::getPassRegistry());
|
|
}
|
|
|
|
protected:
|
|
bool hasTOCLoReloc(const MachineInstr &MI) {
|
|
if (MI.getOpcode() == PPC::LDtocL ||
|
|
MI.getOpcode() == PPC::ADDItocL)
|
|
return true;
|
|
|
|
for (const MachineOperand &MO : MI.operands()) {
|
|
if ((MO.getTargetFlags() & PPCII::MO_ACCESS_MASK) == PPCII::MO_TOC_LO)
|
|
return true;
|
|
}
|
|
|
|
return false;
|
|
}
|
|
|
|
bool processBlock(MachineBasicBlock &MBB) {
|
|
bool Changed = false;
|
|
|
|
for (auto &MI : MBB) {
|
|
if (!hasTOCLoReloc(MI))
|
|
continue;
|
|
|
|
MI.addOperand(MachineOperand::CreateReg(PPC::X2,
|
|
false /*IsDef*/,
|
|
true /*IsImp*/));
|
|
Changed = true;
|
|
}
|
|
|
|
return Changed;
|
|
}
|
|
|
|
public:
|
|
bool runOnMachineFunction(MachineFunction &MF) override {
|
|
bool Changed = false;
|
|
|
|
for (MachineFunction::iterator I = MF.begin(); I != MF.end();) {
|
|
MachineBasicBlock &B = *I++;
|
|
if (processBlock(B))
|
|
Changed = true;
|
|
}
|
|
|
|
return Changed;
|
|
}
|
|
|
|
void getAnalysisUsage(AnalysisUsage &AU) const override {
|
|
MachineFunctionPass::getAnalysisUsage(AU);
|
|
}
|
|
};
|
|
}
|
|
|
|
INITIALIZE_PASS(PPCTOCRegDeps, DEBUG_TYPE,
|
|
"PowerPC TOC Register Dependencies", false, false)
|
|
|
|
char PPCTOCRegDeps::ID = 0;
|
|
FunctionPass*
|
|
llvm::createPPCTOCRegDepsPass() { return new PPCTOCRegDeps(); }
|
|
|