RPCS3/llvm
1
0
Fork 0
mirror of https://github.com/RPCS3/llvm.git synced 2026-07-19 23:23:38 -04:00
Code Issues Packages Projects Releases 10 Wiki Activity

[CGP] Fix UB when GEP is bound to trivial PHINode

Browse Source 
Differential revision: https://reviews.llvm.org/D59140


git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@355904 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Eugene Leviant
2019-03-12 10:10:29 +00:00
parent 4b43b47d8a
commit 13df7e16ef
2 changed files with 34 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/CodeGen/CodeGenPrepare.cpp
+1
View File
@@ -6849,6 +6849,7 @@ bool CodeGenPrepare::optimizeInst(Instruction *I, DominatorTree &DT,
// to introduce PHI nodes too late to be cleaned up. If we detect such a
// trivial PHI, go ahead and zap it here.
if (Value *V = SimplifyInstruction(P, {*DL, TLInfo})) {
LargeOffsetGEPMap.erase(P);
P->replaceAllUsesWith(V);
P->eraseFromParent();
++NumPHIsElim;
test/CodeGen/AArch64/cgp-trivial-phi-node.ll
+33
View File
@@ -0,0 +1,33 @@
; Checks that case when GEP is bound to trivial PHI node is correctly handled.
; RUN: opt %s -mtriple=aarch64-linux-gnu -codegenprepare -S -o - | FileCheck %s
; CHECK: define void @crash([65536 x i32]** %s, i32 %n) {
; CHECK-NEXT: entry:
; CHECK-NEXT: %struct = load [65536 x i32]*, [65536 x i32]** %s
; CHECK-NEXT: %gep0 = getelementptr [65536 x i32], [65536 x i32]* %struct, i64 0, i32 20000
; CHECK-NEXT: store i32 %n, i32* %gep0
; CHECK-NEXT: ret void
; CHECK-NEXT: }
define void @crash([65536 x i32]** %s, i32 %n) {
entry:
%struct = load [65536 x i32]*, [65536 x i32]** %s
%cmp = icmp slt i32 0, %n
br i1 %cmp, label %baz, label %bar
baz:
br label %bar
foo:
%gep0 = getelementptr [65536 x i32], [65536 x i32]* %phi2, i64 0, i32 20000
br label %st
st:
store i32 %n, i32* %gep0
br label %out
bar:
%phi2 = phi [65536 x i32]* [ %struct, %baz ], [ %struct, %entry ]
br label %foo
out:
ret void
}