[MIRParser] Update a diagnostic message to use the correct register sigil. NFC

Summary:
Patch r323922 changed the sigil for physical registers to '$',  instead of '%'.
An error message was missed during this change, and reports the wrong sigil.
This patch corrects that diagnostic and the tests that check that error string.


Reviewers: zer0, bjope

Reviewed By: bjope

Subscribers: bjope, thegameg, plotfi, llvm-commits

Differential Revision: https://reviews.llvm.org/D48086

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@335066 91177308-0d34-0410-b5e6-96231b3b80d8

lib/CodeGen/MIRParser/MIParser.cpp

@@ -929,7 +929,7 @@ bool MIParser::verifyImplicitOperands(ArrayRef<ParsedMachineOperand> Operands,
       continue;
     return error(Operands.empty() ? Token.location() : Operands.back().End,
                  Twine("missing implicit register operand '") +
-                     printImplicitRegisterFlag(I) + " %" +
+                     printImplicitRegisterFlag(I) + " $" +
                      getRegisterName(TRI, I.getReg()) + "'");
   }
   return false;

test/CodeGen/MIR/X86/expected-different-implicit-operand.mir

@@ -23,7 +23,7 @@ body: |
   bb.0.entry:
     $eax = MOV32rm $rdi, 1, _, 0, _
     CMP32ri8 $eax, 10, implicit-def $eflags
-  ; CHECK: [[@LINE+1]]:35: missing implicit register operand 'implicit %eflags'
+  ; CHECK: [[@LINE+1]]:35: missing implicit register operand 'implicit $eflags'
     JG_1 %bb.2.exit, implicit $eax
 
   bb.1.less:

test/CodeGen/MIR/X86/expected-different-implicit-register-flag.mir

@@ -23,7 +23,7 @@ body: |
   bb.0.entry:
     $eax = MOV32rm $rdi, 1, _, 0, _
     CMP32ri8 $eax, 10, implicit-def $eflags
-  ; CHECK: [[@LINE+1]]:42: missing implicit register operand 'implicit %eflags'
+  ; CHECK: [[@LINE+1]]:42: missing implicit register operand 'implicit $eflags'
     JG_1 %bb.2.exit, implicit-def $eflags
 
   bb.1.less:

test/CodeGen/MIR/X86/missing-implicit-operand.mir

@@ -27,7 +27,7 @@ body: |
 
     $eax = MOV32rm $rdi, 1, _, 0, _
     CMP32ri8 $eax, 10, implicit-def $eflags
-  ; CHECK: [[@LINE+1]]:20: missing implicit register operand 'implicit %eflags'
+  ; CHECK: [[@LINE+1]]:20: missing implicit register operand 'implicit $eflags'
     JG_1 %bb.2.exit
 
   bb.1.less: