7 Commits

Author SHA1 Message Date
Jordan Rupprecht
9275184cf2 [Remarks] Fix mismatched delete due to missing virtual destructor
This fixes an asan failure introduced in r356519.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@356583 91177308-0d34-0410-b5e6-96231b3b80d8
2019-03-20 17:44:24 +00:00
Douglas Yung
75be4b8c64 Retry to add workaround to build scoped enums with VS2015. NFCI.
We need this as we still have internal build bots on VS2015.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@356534 91177308-0d34-0410-b5e6-96231b3b80d8
2019-03-20 01:52:40 +00:00
Douglas Yung
a90778f4d6 Revert "Add workaround to build scoped enums with VS2015. NFCI."
This reverts commit 6080a6fb1949a2bdf053245d6062c7bf58dae7a6 (r356532).

Clang does not accept this syntax, so reverting this until I can find something that works across all compilers.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@356533 91177308-0d34-0410-b5e6-96231b3b80d8
2019-03-20 00:41:12 +00:00
Douglas Yung
43779dfd98 Add workaround to build scoped enums with VS2015. NFCI.
We need this as we still have internal build bots on VS2015.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@356532 91177308-0d34-0410-b5e6-96231b3b80d8
2019-03-20 00:26:56 +00:00
Francis Visoiu Mistrih
ae5245f08c Reland "[Remarks] Add a new Remark / RemarkParser abstraction"
This adds a Remark class that allows us to share code when working with
remarks.

The C API has been updated to reflect this. Instead of the parser
generating C structs, it's now using a C++ object that is used through
opaque pointers in C. This gives us much more flexibility on what
changes we can make to the internal state of the object and interacts
much better with scenarios where the library is used through dlopen.

* C API updates:
  * move from C structs to opaque pointers and functions
  * the remark type is now an enum instead of a string
* unit tests updates:
  * use mostly the C++ API
  * keep one test for the C API
  * rename to YAMLRemarksParsingTest
* a typo was fixed: AnalysisFPCompute -> AnalysisFPCommute.
* a new error message was added: "expected a remark tag."
* llvm-opt-report has been updated to use the C++ parser instead of the
C API

Differential Revision: https://reviews.llvm.org/D59049

Original llvm-svn: 356491

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@356519 91177308-0d34-0410-b5e6-96231b3b80d8
2019-03-19 21:11:07 +00:00
Francis Visoiu Mistrih
7feeb42225 Revert "[Remarks] Add a new Remark / RemarkParser abstraction"
This reverts commit 51dc6a8c84cd6a58562e320e1828a0158dbbf750.

Breaks
http://lab.llvm.org:8011/builders/clang-cmake-x86_64-sde-avx512-linux/builds/20034/steps/build%20stage%201/logs/stdio.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@356492 91177308-0d34-0410-b5e6-96231b3b80d8
2019-03-19 18:21:43 +00:00
Francis Visoiu Mistrih
2e8758fd51 [Remarks] Add a new Remark / RemarkParser abstraction
This adds a Remark class that allows us to share code when working with
remarks.

The C API has been updated to reflect this. Instead of the parser
generating C structs, it's now using a C++ object that is used through
opaque pointers in C. This gives us much more flexibility on what
changes we can make to the internal state of the object and interacts
much better with scenarios where the library is used through dlopen.

* C API updates:
  * move from C structs to opaque pointers and functions
  * the remark type is now an enum instead of a string
* unit tests updates:
  * use mostly the C++ API
  * keep one test for the C API
  * rename to YAMLRemarksParsingTest
* a typo was fixed: AnalysisFPCompute -> AnalysisFPCommute.
* a new error message was added: "expected a remark tag."
* llvm-opt-report has been updated to use the C++ parser instead of the
C API

Differential Revision: https://reviews.llvm.org/D59049

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@356491 91177308-0d34-0410-b5e6-96231b3b80d8
2019-03-19 18:09:51 +00:00