Sanjay Patel 756b38c9d2 [InstCombine] fix operand-complexity-based canonicalization (PR28296) ...

The code comments didn't match the code logic, and we didn't actually distinguish the fake unary (not/neg/fneg) 
operators from arguments. Adding another level to the weighting scheme provides more structure and can help 
simplify the pattern matching in InstCombine and other places.

I fixed regressions that would have shown up from this change in:
rL290067
rL290127

But that doesn't mean there are no pattern-matching logic holes left; some combines may just be missing regression tests.

Should fix:
https://llvm.org/bugs/show_bug.cgi?id=28296

Differential Revision: https://reviews.llvm.org/D27933


git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@294049 91177308-0d34-0410-b5e6-96231b3b80d8

2017-02-03 21:43:34 +00:00

..

ADCE

[ADCE] Add code to remove dead branches

2016-12-13 16:42:18 +00:00

AddDiscriminators

Introduce updateDiscriminator interface to DILocation to make it cleaner assigning discriminators.

2016-10-26 15:48:45 +00:00

AlignmentFromAssumptions

[PM] Port AlignmentFromAssumptions to the new PM.

2016-06-15 06:18:01 +00:00

ArgumentPromotion

Remove the ScalarReplAggregates pass

2016-06-15 00:19:09 +00:00

AtomicExpand

Support expanding partial-word cmpxchg to full-word cmpxchg in AtomicExpandPass.

2016-06-17 18:11:48 +00:00

BBVectorize

Introduce -unroll-partial-threshold to separate PartialThreshold from Threshold in loop unorller.

2017-01-17 23:39:33 +00:00

BDCE

[BDCE] Skip metadata while replacing uses.

2016-12-07 21:47:32 +00:00

BranchFolding

Move branch folding test to a better location.

2015-12-03 19:41:25 +00:00

CodeExtractor

CodeExtractor : Add ability to preserve profile data.

2016-08-02 02:15:45 +00:00

CodeGenPrepare

[Analysis] Centralize objectsize lowering logic.

2016-12-20 23:46:36 +00:00

ConstantHoisting

This implements a more optimal algorithm for selecting a base constant in

2016-07-14 07:44:20 +00:00

ConstantMerge

[PM] Port ConstantMerge to the new pass manager.

2016-05-05 00:51:09 +00:00

ConstProp

[InstCombiner] Simplify lib calls to round{,f}

2016-12-26 14:29:29 +00:00

Coroutines

[coroutines] Spill the result of the invoke instruction correctly

2017-01-25 02:25:54 +00:00

CorrelatedValuePropagation

Revert @llvm.assume with operator bundles (r289755-r289757)

2016-12-19 08:22:17 +00:00

CountingFunctionInserter

Add a counter-function insertion pass

2016-09-01 09:42:39 +00:00

CrossDSOCFI

[PM] Port CrossDSOCFI to the new pass manager.

2016-07-09 03:25:35 +00:00

DCE

llvm/test/Transforms/DCE/calls-errno.ll: Suppress checking @pow(+0,-1).

2016-11-04 18:50:45 +00:00

DeadArgElim

DeadArgElim: Don't mark swifterror arguments as unused

2016-09-21 15:29:08 +00:00

DeadStoreElimination

[DSE] Don't remove stores made live by a call which unwinds.

2016-08-12 01:09:53 +00:00

EarlyCSE

[EarlyCSE] Don't DSE across readnone functions that may throw

2017-01-17 20:15:47 +00:00

EliminateAvailableExternally

[PM] Port EliminateAvailableExternally pass to the new pass manager.

2016-05-05 02:37:32 +00:00

Float2Int

[PM] Port float2int to the new pass manager

2016-06-24 23:32:02 +00:00

ForcedFunctionAttrs

[attrs] Split off the forced attributes utility into its own pass that

2015-12-27 08:13:45 +00:00

FunctionAttrs

IR, X86: Understand !absolute_symbol metadata on global variables.

2016-12-08 19:01:00 +00:00

FunctionImport

FunctionImport: Remove the -disable-force-link-odr flag and change importFunctions to never force link.

2017-02-02 18:42:25 +00:00

GCOVProfiling

[IR] Remove the DIExpression field from DIGlobalVariable.

2016-12-20 02:09:43 +00:00

GlobalDCE

[PH] Replace uses of AssertingVH from members of analysis results with

2017-01-24 12:55:57 +00:00

GlobalMerge

Renumber testcase metadata nodes after r290153.

2016-12-22 00:45:21 +00:00

GlobalOpt

Fix some broken CHECK lines.

2017-01-22 20:28:56 +00:00

GlobalSplit

[GlobalSplit] Port to the new pass manager.

2016-11-21 00:28:23 +00:00

GuardWidening

[GuardWidening] Fix incorrect use of remove_if

2016-05-21 02:24:44 +00:00

GVN

Do not propagate DebugLoc across basic blocks

2017-01-31 20:57:13 +00:00

GVNHoist

Remove the load hoisting code of MLSM, it is completely subsumed by GVNHoist

2017-01-24 19:55:36 +00:00

IndVarSimplify

[IndVars] Change the order to compute WidenAddRec in widenIVUse.

2016-11-15 17:34:52 +00:00

InferAddressSpaces

InferAddressSpaces: Handle more cases with constant select operands

2017-02-02 03:37:22 +00:00

InferFunctionAttrs

[InferAttributes] Don't access parameters that don't exist.

2016-09-20 23:10:31 +00:00

Inline

[Inliner] Fold analysis remarks into missed remarks

2017-01-30 16:22:45 +00:00

InstCombine

[InstCombine] fix operand-complexity-based canonicalization (PR28296)

2017-02-03 21:43:34 +00:00

InstMerge

Remove the load hoisting code of MLSM, it is completely subsumed by GVNHoist

2017-01-24 19:55:36 +00:00

InstSimplify

[ValueTracking] remove a FIXME for something we don't want to do; NFC

2017-02-01 22:27:34 +00:00

InterleavedAccess

InterleaveAccessPass: Avoid constructing invalid shuffle masks

2017-01-31 18:37:53 +00:00

Internalize

[Internalize] Test that __stack_chk_{guard, fail} are not internalized.

2016-06-05 19:08:54 +00:00

IPConstantProp

[IPSCCP] Restore the old behaviour (pre r293799).

2017-02-02 00:46:54 +00:00

IRCE

[IRCE] Avoid loop optimizations on pre and post loops

2016-12-13 21:05:21 +00:00

JumpThreading

[JumpThread] Enhance finding partial redundant loads by continuing scanning single predecessor

2017-02-02 15:12:34 +00:00

LCSSA

Revert "Revert r275883 and r275891. They seem to cause PR28608."

2016-07-20 01:55:27 +00:00

LICM

[LICM] Hoist loads that are dominated by invariant.start intrinsic, and are invariant in the loop.

2017-02-02 13:22:03 +00:00

LoadCombine

[LoadCombine] Combine Loads formed from GEPS with negative indexes

2016-06-19 06:14:56 +00:00

LoadStoreVectorizer

[LoadStoreVectorizer] Enable vectorization of stores in the presence of an aliasing load

2016-11-23 17:43:15 +00:00

LoopDataPrefetch

[PM] Port LoopDataPrefetch AArch64 tests to new pass manager

2016-08-22 12:59:58 +00:00

LoopDeletion

[PM] Teach LoopDeletion to correctly update the LPM when loops are

2017-01-18 02:41:26 +00:00

LoopDistribute

Move test of lazy BFI with ORE to a generic directory

2017-01-13 00:16:23 +00:00

LoopIdiom

Fix some broken CHECK lines.

2017-01-22 20:28:56 +00:00

LoopInterchange

[LoopInterchange] Track all dependencies, not just anti dependencies.

2016-09-21 19:16:47 +00:00

LoopLoadElim

[PM] Port LoopLoadElimination to the new pass manager and wire it into

2017-01-27 01:32:26 +00:00

LoopPredication

[Guards] Introduce loop-predication pass

2017-01-25 16:00:44 +00:00

LoopReroll

[LoopReroll] Make root-finding more aggressive.

2016-11-21 22:35:34 +00:00

LoopRotate

Revert @llvm.assume with operator bundles (r289755-r289757)

2016-12-19 08:22:17 +00:00

LoopSimplify

Make a test actually test what it set out to test.

2017-01-12 03:49:07 +00:00

LoopSimplifyCFG

LPM: Drop require<loops> from these tests, it's redundant. NFC

2016-05-10 18:28:10 +00:00

LoopStrengthReduce

LSR: Don't drop address space when type doesn't match

2017-01-30 19:50:17 +00:00

LoopUnroll

AMDGPU: Don't unroll for private with dynamic allocas

2017-02-03 19:36:00 +00:00

LoopUnswitch

Constant fold switch inst when looking for trivial conditions to unswitch on.

2017-01-27 01:42:20 +00:00

LoopVectorize

[LV] Also port failure remarks to new OptimizationRemarkEmitter API

2017-02-02 05:41:51 +00:00

LoopVersioning

[LDist] Match behavior between invoking via optimization pipeline or opt -loop-distribute

2016-12-21 04:07:40 +00:00

LoopVersioningLICM

[Loop Vectorizer] Fixed memory confilict checks.

2016-08-28 08:53:53 +00:00

LowerAtomic

[PM] Port LowerAtomic to the new pass manager.

2016-05-13 22:52:35 +00:00

LowerExpectIntrinsic

[Profile] handle select instruction in 'expect' lowering

2016-09-02 22:03:40 +00:00

LowerGuardIntrinsic

[PM] Port LowerGuardIntrinsic to the new PM.

2016-07-28 22:08:41 +00:00

LowerInvoke

[PM] Port LowerInvoke to the new pass manager

2016-08-12 17:28:27 +00:00

LowerSwitch

Have a single way for creating unique value names.

2015-11-22 00:16:24 +00:00

LowerTypeTests

LowerTypeTests: Ignore external globals with type metadata.

2017-01-26 00:32:15 +00:00

Mem2Reg

[PM] Port Mem2Reg to the new pass manager.

2016-06-14 03:22:22 +00:00

MemCpyOpt

[MemCpyOpt] Don't sink LoadInst below possible clobber.

2016-12-27 17:58:12 +00:00

MergeFunc

MergeFunctions: Preserve debug info in thunks, under option -mergefunc-preserve-debug-info

2017-01-21 02:02:56 +00:00

MetaRenamer

Revert "Change memcpy/memset/memmove to have dest and source alignments."

2015-11-19 05:56:52 +00:00

NameAnonGlobals

[ThinLTO] Ensure anonymous globals renamed even at -O0

2016-09-17 20:40:16 +00:00

NaryReassociate

Revert @llvm.assume with operator bundles (r289755-r289757)

2016-12-19 08:22:17 +00:00

NewGVN

Do not propagate DebugLoc across basic blocks

2017-01-31 20:57:13 +00:00

ObjCARC

[ObjCARC] Traverse chain downwards to replace uses of argument passed to

2016-09-13 23:43:11 +00:00

PartiallyInlineLibCalls

Add positive test for sqrt "partial inlining". NFC.

2017-01-04 21:24:56 +00:00

PGOProfile

Fix some broken CHECK lines.

2017-01-22 20:28:56 +00:00

PhaseOrdering

Mark that SpeculativeExecution preserves Globals Alias Analysis.

2016-05-03 08:33:26 +00:00

PlaceSafepoints

[PlaceSafepoints] Don't call undef in test case; NFC

2016-06-25 01:40:54 +00:00

PreISelIntrinsicLowering

[PM] Port PreISelIntrinsicLowering to the new PM

2016-06-24 20:13:42 +00:00

PruneEH

[PruneEH] Be correct in the face IPO

2016-10-03 19:35:30 +00:00

Reassociate

Fixed the lost FastMathFlags in Reassociate optimization.

2016-11-22 20:23:04 +00:00

Reg2Mem

Move the personality function from LandingPadInst to Function

2015-06-17 20:52:32 +00:00

RewriteStatepointsForGC

[RS4GC] Strengthen coverage: add more tests

2016-10-07 20:34:00 +00:00

SafeStack

[safestack] Use non-thread-local unsafe stack pointer for Contiki OS

2016-10-14 17:56:00 +00:00

SampleProfile

Explicitly promote indirect calls before sample profile annotation.

2017-01-31 17:49:37 +00:00

Scalarizer

Scalarizer: Support scalarizing intrinsics

2016-07-25 20:02:54 +00:00

SCCP

[SCCP] Teach the pass how to handle div with overdefined operands.

2017-01-19 23:07:51 +00:00

SeparateConstOffsetFromGEP

[NVPTX] Enable the load-store vectorizer on nvptx.

2016-07-20 22:11:36 +00:00

SimplifyCFG

[InstCombine] Merge DebugLoc when speculatively hoisting store instruction

2017-01-28 07:05:43 +00:00

Sink

Add a testcase for r275581

2016-07-19 17:52:41 +00:00

SLPVectorizer

[SLP] Use SCEV to sort memory accesses.

2017-02-03 19:09:45 +00:00

SpeculativeExecution

SpeculativeExecution: Allow speculating more inst types

2016-10-28 20:00:33 +00:00

SROA

[DIExpression] Introduce a dedicated DW_OP_LLVM_fragment operation

2016-12-05 18:04:47 +00:00

StraightLineStrengthReduce

[SLSR] Call getPointerSizeInBits with the correct address space.

2016-07-11 18:13:28 +00:00

StripDeadPrototypes

[PM] Port StripDeadPrototypes to the new pass manager

2015-10-30 23:28:12 +00:00

StripSymbols

Renumber testcase metadata nodes after r290153.

2016-12-22 00:45:21 +00:00

StructurizeCFG

[StructurizeCfg] Update dominator info.

2017-01-10 02:50:47 +00:00

TailCallElim

Avoid tail recursion elimination across calls with operand bundles

2016-11-07 21:01:49 +00:00

ThinLTOBitcodeWriter

ThinLTOBitcodeWriter: Clear comdats on filtered globals.

2017-01-18 20:03:02 +00:00

Util

[MemorySSA] Add new tests for invariant.groups

2017-01-23 16:38:10 +00:00

WholeProgramDevirt

WholeProgramDevirt: Teach the pass to handle structs of arrays.

2016-12-09 01:10:11 +00:00