mirror of
https://github.com/RPCS3/llvm.git
synced 2024-12-23 12:40:17 +00:00
75d77cd179
Summary: Fixes a FIXME in MachineSinking. Instead of using the simple heuristics in isPostDominatedBy, use the real MachinePostDominatorTree and MachineLoopInfo. The old heuristics caused instructions to sink unnecessarily, and might create register pressure. This is the second try of the fix. The first one (D4814) caused a performance regression due to failing to sink instructions out of loops (PR21115). This patch fixes PR21115 by sinking an instruction from a deeper loop to a shallower one regardless of whether the target block post-dominates the source. Thanks Alexey Volkov for reporting PR21115! Test Plan: Added a NVPTX codegen test to verify that our change prevents the backend from over-sinking. It also shows the unnecessary register pressure caused by over-sinking. Added an X86 test to verify we can sink instructions out of loops regardless of the dominance relationship. This test is reduced from Alexey's test in PR21115. Updated an affected test in X86. Also ran SPEC CINT2006 and llvm-test-suite for compilation time and runtime performance. Results are attached separately in the review thread. Reviewers: Jiangning, resistor, hfinkel Reviewed By: hfinkel Subscribers: hfinkel, bruno, volkalexey, llvm-commits, meheff, eliben, jholewinski Differential Revision: http://reviews.llvm.org/D5633 git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@219773 91177308-0d34-0410-b5e6-96231b3b80d8 |
||
|---|---|---|
| .. | ||
| access-non-generic.ll | ||
| add-128bit.ll | ||
| addrspacecast-gvar.ll | ||
| addrspacecast.ll | ||
| aggr-param.ll | ||
| annotations.ll | ||
| arg-lowering.ll | ||
| arithmetic-fp-sm20.ll | ||
| arithmetic-int.ll | ||
| atomics.ll | ||
| bfe.ll | ||
| bug17709.ll | ||
| call-with-alloca-buffer.ll | ||
| callchain.ll | ||
| calling-conv.ll | ||
| compare-int.ll | ||
| constant-vectors.ll | ||
| convert-fp.ll | ||
| convert-int-sm20.ll | ||
| ctlz.ll | ||
| ctpop.ll | ||
| cttz.ll | ||
| div-ri.ll | ||
| envreg.ll | ||
| fast-math.ll | ||
| fma-disable.ll | ||
| fma.ll | ||
| fp16.ll | ||
| fp-contract.ll | ||
| fp-literals.ll | ||
| generic-to-nvvm.ll | ||
| global-ordering.ll | ||
| gvar-init.ll | ||
| half.ll | ||
| i1-global.ll | ||
| i1-int-to-fp.ll | ||
| i1-param.ll | ||
| i8-param.ll | ||
| imad.ll | ||
| implicit-def.ll | ||
| inline-asm.ll | ||
| intrin-nocapture.ll | ||
| intrinsic-old.ll | ||
| intrinsics.ll | ||
| isspacep.ll | ||
| ld-addrspace.ll | ||
| ld-generic.ll | ||
| ldparam-v4.ll | ||
| ldu-i8.ll | ||
| ldu-ldg.ll | ||
| ldu-reg-plus-offset.ll | ||
| lit.local.cfg | ||
| load-sext-i1.ll | ||
| local-stack-frame.ll | ||
| machine-sink.ll | ||
| managed.ll | ||
| misaligned-vector-ldst.ll | ||
| module-inline-asm.ll | ||
| mulwide.ll | ||
| noduplicate-syncthreads.ll | ||
| nvvm-reflect.ll | ||
| param-align.ll | ||
| pr13291-i1-store.ll | ||
| pr16278.ll | ||
| pr17529.ll | ||
| ptx-version-30.ll | ||
| ptx-version-31.ll | ||
| refl1.ll | ||
| rotate.ll | ||
| rsqrt.ll | ||
| sched1.ll | ||
| sched2.ll | ||
| sext-in-reg.ll | ||
| sext-params.ll | ||
| shift-parts.ll | ||
| simple-call.ll | ||
| sm-version-20.ll | ||
| sm-version-21.ll | ||
| sm-version-30.ll | ||
| sm-version-35.ll | ||
| st-addrspace.ll | ||
| st-generic.ll | ||
| surf-read-cuda.ll | ||
| surf-read.ll | ||
| surf-write-cuda.ll | ||
| surf-write.ll | ||
| symbol-naming.ll | ||
| tex-read-cuda.ll | ||
| tex-read.ll | ||
| texsurf-queries.ll | ||
| tuple-literal.ll | ||
| vec8.ll | ||
| vec-param-load.ll | ||
| vector-args.ll | ||
| vector-call.ll | ||
| vector-compare.ll | ||
| vector-loads.ll | ||
| vector-select.ll | ||
| vector-stores.ll | ||
| weak-global.ll | ||
| weak-linkage.ll | ||