[PR #1] [MERGED] Fix "unused" warning and potential inefficiency #1

New Issue

2026-02-15T15:54:08-05:00

yindo commented

2026-02-15 15:54:08 -05:00

📋 Pull Request Information

Original PR: https://github.com/RPCS3/rsx_program_decompiler/pull/1
Author: @danilaml
Created: 1/11/2016
Status: ✅ Merged
Merged: 1/13/2016
Merged by: @DHrpcs3

Base: master ← Head: patch-1

📝 Commits (1)

1f3309b Fix "unused" warning and potential inefficiency

📊 Changes

1 file changed (+3 additions, -3 deletions)

View changed files

📝 shader_code/clike_language.h (+3 -3)

📄 Description

clang 3.6.0 seems to recognize pattern and optimize int[] creation just fine:
https://goo.gl/9uPGla

While it generates x1.7 as much code with std::string : https://goo.gl/yWVMTa
(~180 against ~300 lines of asm).
For gcc 4.9.2 it's 73 against 200.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/RPCS3/rsx_program_decompiler/pull/1 **Author:** [@danilaml](https://github.com/danilaml) **Created:** 1/11/2016 **Status:** ✅ Merged **Merged:** 1/13/2016 **Merged by:** [@DHrpcs3](https://github.com/DHrpcs3) **Base:** `master` ← **Head:** `patch-1` --- ### 📝 Commits (1) - [`1f3309b`](https://github.com/RPCS3/rsx_program_decompiler/commit/1f3309b290a53c53ffa76419cf8926531d0f1b75) Fix "unused" warning and potential inefficiency ### 📊 Changes **1 file changed** (+3 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `shader_code/clike_language.h` (+3 -3) </details> ### 📄 Description clang 3.6.0 seems to recognize pattern and optimize int[] creation just fine: https://goo.gl/9uPGla While it generates x1.7 as much code with std::string : https://goo.gl/yWVMTa (~180 against ~300 lines of asm). For gcc 4.9.2 it's 73 against 200. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

yindo added the pull-request label 2026-02-15 15:54:08 -05:00

yindo closed this issue

2026-02-15 15:54:08 -05:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: RPCS3/rsx_program_decompiler#1