Adrian Prantl 02474a32eb Move the complex address expression out of DIVariable and into an extra ... argument of the llvm.dbg.declare/llvm.dbg.value intrinsics. Previously, DIVariable was a variable-length field that has an optional reference to a Metadata array consisting of a variable number of complex address expressions. In the case of OpPiece expressions this is wasting a lot of storage in IR, because when an aggregate type is, e.g., SROA'd into all of its n individual members, the IR will contain n copies of the DIVariable, all alike, only differing in the complex address reference at the end. By making the complex address into an extra argument of the dbg.value/dbg.declare intrinsics, all of the pieces can reference the same variable and the complex address expressions can be uniqued across the CU, too. Down the road, this will allow us to move other flags, such as "indirection" out of the DIVariable, too. The new intrinsics look like this: declare void @llvm.dbg.declare(metadata %storage, metadata %var, metadata %expr) declare void @llvm.dbg.value(metadata %storage, i64 %offset, metadata %var, metadata %expr) This patch adds a new LLVM-local tag to DIExpressions, so we can detect and pretty-print DIExpression metadata nodes. What this patch doesn't do: This patch does not touch the "Indirect" field in DIVariable; but moving that into the expression would be a natural next step. http://reviews.llvm.org/D4919 rdar://problem/17994491 Thanks to dblaikie and dexonsmith for reviewing this patch! Note: I accidentally committed a bogus older version of this patch previously. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@218787 91177308-0d34-0410-b5e6-96231b3b80d8		2014-10-01 18:55:02 +00:00
..
2004-10-10-CastStoreOnce.ll
2005-06-15-LocalizeConstExprCrash.ll
2005-09-27-Crash.ll	Land the long talked about "type system rewrite" patch. This	2011-07-09 17:41:24 +00:00
2006-07-07-InlineAsmCrash.ll
2006-11-01-ShrinkGlobalPhiCrash.ll
2007-04-05-Crash.ll	manually upgrade a bunch of tests to modern syntax, and remove some that	2011-06-17 03:14:27 +00:00
2007-05-13-Crash.ll
2007-06-04-PackedStruct.ll
2007-11-09-GEP-GEP-Crash.ll
2008-01-03-Crash.ll
2008-01-13-OutOfRangeSROA.ll	Convert all tests using TCL-style quoting to use shell-style quoting.	2012-07-02 12:47:22 +00:00
2008-01-29-VolatileGlobal.ll	Convert all tests using TCL-style quoting to use shell-style quoting.	2012-07-02 12:47:22 +00:00
2008-04-26-SROA-Global-Align.ll	Convert all tests using TCL-style quoting to use shell-style quoting.	2012-07-02 12:47:22 +00:00
2008-07-17-addrspace.ll	Quote potential shell expansions found in tests	2013-10-28 23:37:45 +00:00
2008-12-16-HeapSRACrash-2.ll	manually upgrade a bunch of tests to modern syntax, and remove some that	2011-06-17 03:14:27 +00:00
2008-12-16-HeapSRACrash.ll	manually upgrade a bunch of tests to modern syntax, and remove some that	2011-06-17 03:14:27 +00:00
2009-01-13-phi-user.ll	Convert all tests using TCL-style quoting to use shell-style quoting.	2012-07-02 12:47:22 +00:00
2009-02-15-BitcastAlias.ll	Allow alias to point to an arbitrary ConstantExpr.	2014-06-03 02:41:57 +00:00
2009-02-15-ResolveAlias.ll	Use "weak alias" instead of "alias weak"	2014-07-30 22:51:54 +00:00
2009-03-05-dbg.ll	Move the complex address expression out of DIVariable and into an extra	2014-10-01 18:55:02 +00:00
2009-03-06-Anonymous.ll	GlobalOpt: Don't swap private for internal linkage	2014-07-01 15:26:50 +00:00
2009-03-07-PromotePtrToBool.ll	Revert r193251 : Use address-taken to disambiguate global variable and indirect memops.	2013-10-27 03:08:44 +00:00
2009-06-01-RecursivePHI.ll
2009-11-16-BrokenPerformHeapAllocSRoA.ll	Teach globalopt to not nuke all stores to globals. Keep them around of they	2012-07-24 07:21:08 +00:00
2009-11-16-MallocSingleStoreToGlobalVar.ll	Revert r193251 : Use address-taken to disambiguate global variable and indirect memops.	2013-10-27 03:08:44 +00:00
2010-02-25-MallocPromote.ll	Tests: rewrite 'opt ... %s' to 'opt ... < %s' so that opt does not emit a ModuleID	2012-12-30 02:33:22 +00:00
2010-02-26-MallocSROA.ll	Tests: rewrite 'opt ... %s' to 'opt ... < %s' so that opt does not emit a ModuleID	2012-12-30 02:33:22 +00:00
2010-10-19-WeakOdr.ll
2011-04-09-EmptyGlobalCtors.ll	Add back a couple checks removed by r129128; the fact that an intitializer	2011-04-09 09:11:09 +00:00
2012-05-11-blockaddress.ll	Catch more CHECK that can be converted to CHECK-LABEL in Transforms for easier debugging. No functionality change.	2013-07-14 01:50:49 +00:00
alias-resolve.ll	Use "weak alias" instead of "alias weak"	2014-07-30 22:51:54 +00:00
alias-used-address-space.ll	Use "weak alias" instead of "alias weak"	2014-07-30 22:51:54 +00:00
alias-used-section.ll	Use "weak alias" instead of "alias weak"	2014-07-30 22:51:54 +00:00
alias-used.ll	Use "weak alias" instead of "alias weak"	2014-07-30 22:51:54 +00:00
array-elem-refs.ll	Fix a use-after-free error in GlobalOpt CleanupConstantGlobalUsers	2013-12-12 20:45:24 +00:00
atexit.ll	IR: Don't allow non-default visibility on local linkage	2014-05-07 22:57:20 +00:00
atomic.ll	Revert r193251 : Use address-taken to disambiguate global variable and indirect memops.	2013-10-27 03:08:44 +00:00
basictest.ll
blockaddress.ll	Update Transforms tests to use CHECK-LABEL for easier debugging. No functionality change.	2013-07-14 01:42:54 +00:00
cleanup-pointer-root-users.ll	Update Transforms tests to use CHECK-LABEL for easier debugging. No functionality change.	2013-07-14 01:42:54 +00:00
compiler-used.ll	Don't crash when llvm.compiler.used becomes empty.	2013-07-20 23:33:15 +00:00
constantexpr-dangle.ll	Convert all tests using TCL-style quoting to use shell-style quoting.	2012-07-02 12:47:22 +00:00
constantfold-initializers.ll	GlobalOpt: Optimize in the face of insertvalue/extractvalue	2014-08-08 05:50:43 +00:00
crash-2.ll	Use a worklist to avoid a sneaky iterator invalidation.	2013-04-02 08:16:45 +00:00
crash.ll	Tests: rewrite 'opt ... %s' to 'opt ... < %s' so that opt does not emit a ModuleID	2012-12-30 02:33:22 +00:00
ctor-list-opt-constexpr.ll	Update Transforms tests to use CHECK-LABEL for easier debugging. No functionality change.	2013-07-14 01:42:54 +00:00
ctor-list-opt-inbounds.ll
ctor-list-opt.ll	Add comdat key field to llvm.global_ctors and llvm.global_dtors	2014-05-16 20:39:27 +00:00
cxx-dtor.ll	GlobalOpt: Be more aggressive about elminating side-effect free static dtors.	2012-02-09 14:26:06 +00:00
deadfunction.ll	Refactor code from inlining and globalopt that checks whether a function definition is unused, and enhance it so it can tell that functions which are only used by a blockaddress are in fact dead. This probably doesn't happen much on most code, but the Linux kernel's _THIS_IP_ can trigger this issue with blockaddress. (GlobalDCE can also handle the given tescase, but we only run that at -O3.) Found while looking at PR11180.	2011-10-20 05:23:42 +00:00
deadglobal-2.ll
deadglobal.ll	Catch more CHECK that can be converted to CHECK-LABEL in Transforms for easier debugging. No functionality change.	2013-07-14 01:50:49 +00:00
externally-initialized-global-ctr.ll	Added missing newline to end of test case.	2013-02-05 19:39:44 +00:00
fastcc.ll	GlobalOpt: Apply fastcc to internal x86_thiscallcc functions	2014-02-26 19:57:30 +00:00
globalsra-partial.ll
globalsra-unknown-index.ll	Revert r193251 : Use address-taken to disambiguate global variable and indirect memops.	2013-10-27 03:08:44 +00:00
globalsra.ll
heap-sra-1.ll
heap-sra-2.ll
heap-sra-3.ll
heap-sra-4.ll
heap-sra-phi.ll	Convert all tests using TCL-style quoting to use shell-style quoting.	2012-07-02 12:47:22 +00:00
integer-bool.ll	Revert r204076 for now - it caused significant regressions in a number of	2014-03-23 04:22:31 +00:00
invariant-nodatalayout.ll	Check that TD isn't NULL before dereferencing it down this path.	2013-07-25 02:55:14 +00:00
invariant.ll	Check for the correct size in the invariant marker.	2012-02-20 23:32:26 +00:00
invoke.ll	Teach globalopt how to evaluate an invoke with a non-void return type.	2012-03-13 18:01:37 +00:00
iterate.ll
load-store-global.ll	Update Transforms tests to use CHECK-LABEL for easier debugging. No functionality change.	2013-07-14 01:42:54 +00:00
malloc-promote-1.ll
malloc-promote-2.ll
malloc-promote-3.ll	Respect the 'nobuiltin' attribute when determining if a call is to a memory builtin.	2013-05-16 04:12:04 +00:00
memcpy.ll	Convert all tests using TCL-style quoting to use shell-style quoting.	2012-07-02 12:47:22 +00:00
memset-null.ll	Tests: rewrite 'opt ... %s' to 'opt ... < %s' so that opt does not emit a ModuleID	2012-12-30 01:28:40 +00:00
memset.ll	Delete unread globals through addrspacecast	2014-01-02 20:01:43 +00:00
metadata.ll	Revert r191834 until we measure the effect of this benchmarks and maybe find a better way to fix it	2013-10-07 19:03:24 +00:00
phi-select.ll
preserve-comdats.ll	GlobalOpt: Preserve comdats of unoptimized initializers	2014-09-23 22:33:01 +00:00
storepointer-compare.ll	Convert all tests using TCL-style quoting to use shell-style quoting.	2012-07-02 12:47:22 +00:00
storepointer.ll
tls.ll	Update Transforms tests to use CHECK-LABEL for easier debugging. No functionality change.	2013-07-14 01:42:54 +00:00
trivialstore.ll
undef-init.ll
unnamed-addr.ll	Revert r193251 : Use address-taken to disambiguate global variable and indirect memops.	2013-10-27 03:08:44 +00:00
zeroinitializer-gep-load.ll	Update Transforms tests to use CHECK-LABEL for easier debugging. No functionality change.	2013-07-14 01:42:54 +00:00