SerenityOS/serenity
1
0 Fork 0
mirror of https://github.com/SerenityOS/serenity.git synced 2026-11-07 04:29:30 -10:00
Code Issues Packages Projects Releases Wiki Activity

LibWasm: Make BytecodeInterpreter overrides final

Browse Source 
This gives us free devirtualization of some hot calls inside the
bytecode interpreter. Most notably the did_trap() checks.

Modest performance improvement on the https://figma.com/ landing page.

(cherry picked from commit 2f3128333dcd5a781f35272800631d6cf03803ad)
This commit is contained in:
Andreas Kling authored and Nico Weber committed 2024-11-12 22:26:21 -05:00
1 parent 28af9da66f
commit b0d8d9ef4a
1 file changed
+4 -4
Download Patch File Download Diff File Expand all files Collapse all files
Userland/Libraries/LibWasm/AbstractMachine/BytecodeInterpreter.h
+4 -4
View File
@@ -18,18 +18,18 @@ struct BytecodeInterpreter : public Interpreter {
{
}
virtual void interpret(Configuration&) override;
virtual void interpret(Configuration&) final;
virtual ~BytecodeInterpreter() override = default;
virtual bool did_trap() const override { return !m_trap.has<Empty>(); }
virtual ByteString trap_reason() const override
virtual bool did_trap() const final { return !m_trap.has<Empty>(); }
virtual ByteString trap_reason() const final
{
return m_trap.visit(
[](Empty) -> ByteString { VERIFY_NOT_REACHED(); },
[](Trap const& trap) { return trap.reason; },
[](JS::Completion const& completion) { return completion.value()->to_string_without_side_effects().to_byte_string(); });
}
virtual void clear_trap() override { m_trap = Empty {}; }
virtual void clear_trap() final { m_trap = Empty {}; }
struct CallFrameHandle {
explicit CallFrameHandle(BytecodeInterpreter& interpreter, Configuration& configuration)