mirror of
https://github.com/Twigpine/zero.git
synced 2026-11-09 05:19:33 -10:00
Compare commits
14
Commits
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
c807f92b72 | ||
|
|
8eccc26698 | ||
|
|
6e0a665118 | ||
|
|
142c548c89 | ||
|
|
02f0c0929b | ||
|
|
3fde03a900 | ||
|
|
85273ea72d | ||
|
|
0914ced9e1 | ||
|
|
68669073c2 | ||
|
|
33410d8730 | ||
|
|
c0254e3266 | ||
|
|
c4c14d62d4 | ||
|
|
49bec0274f | ||
|
|
bcc65da2a0 |
No files matched your search
@@ -54,8 +54,10 @@ jobs:
|
||||
# is published under the pushed git tag. If they disagree, install.sh/install.ps1
|
||||
# and the npm postinstall all build a download URL that 404s. Fail fast so a
|
||||
# forgotten version bump can never publish mis-versioned, un-installable assets.
|
||||
# Matches on the ref (not event_name) because release-please dispatches this
|
||||
# workflow at the tag ref — its GITHUB_TOKEN-created tag cannot fire `push`.
|
||||
- name: Check tag matches package.json version
|
||||
if: ${{ github.event_name == 'push' && startsWith(github.ref, 'refs/tags/v') }}
|
||||
if: ${{ startsWith(github.ref, 'refs/tags/v') }}
|
||||
shell: bash
|
||||
run: |
|
||||
pkg_version="$(node -p "require('./package.json').version")"
|
||||
@@ -78,13 +80,15 @@ jobs:
|
||||
path: dist/release/*
|
||||
if-no-files-found: error
|
||||
|
||||
# On a `v*` tag push, publish the packaged archive + .sha256 as GitHub Release
|
||||
# assets so the documented `scripts/install.sh` / `install.ps1` path (which reads
|
||||
# /releases/latest) works. Uses the preinstalled `gh` (no new action dependency);
|
||||
# each matrix OS creates the release if absent (best-effort) then uploads its own
|
||||
# assets with --clobber. NOTE: maintainers must push the tag — this never tags.
|
||||
# On a `v*` tag ref (pushed manually, or dispatched at the tag by the
|
||||
# release-please workflow), publish the packaged archive + .sha256 as GitHub
|
||||
# Release assets so the documented `scripts/install.sh` / `install.ps1` path
|
||||
# (which reads /releases/latest) works. Uses the preinstalled `gh` (no new
|
||||
# action dependency); each matrix OS creates the release if absent
|
||||
# (best-effort — release-please normally creates it first) then uploads its
|
||||
# own assets with --clobber. Tags come from merging the release-please PR.
|
||||
- name: Publish to GitHub Release
|
||||
if: ${{ github.event_name == 'push' && startsWith(github.ref, 'refs/tags/v') }}
|
||||
if: ${{ startsWith(github.ref, 'refs/tags/v') }}
|
||||
shell: bash
|
||||
env:
|
||||
GH_TOKEN: ${{ github.token }}
|
||||
@@ -92,3 +96,83 @@ jobs:
|
||||
tag="${GITHUB_REF_NAME}"
|
||||
gh release create "$tag" --repo "$GITHUB_REPOSITORY" --title "$tag" --generate-notes 2>/dev/null || true
|
||||
gh release upload "$tag" dist/release/* --repo "$GITHUB_REPOSITORY" --clobber
|
||||
|
||||
# Publishes the npm wrapper (@gitlawb/zero) once every platform's release
|
||||
# assets are live — the package's postinstall downloads its binary from the
|
||||
# GitHub Release, so publishing before the assets exist would ship a package
|
||||
# that fails to install.
|
||||
#
|
||||
# Auth is npm OIDC trusted publishing: no NPM_TOKEN secret. The package's
|
||||
# npmjs.com settings must list this repo + workflow file as a trusted
|
||||
# publisher, and provenance is then generated automatically. Note npm only
|
||||
# allows configuring a trusted publisher on an EXISTING package, so the very
|
||||
# first @gitlawb/zero publish is a one-time manual `npm publish` bootstrap.
|
||||
publish-npm:
|
||||
name: Publish npm package
|
||||
needs: package
|
||||
if: ${{ startsWith(github.ref, 'refs/tags/v') }}
|
||||
runs-on: ubuntu-latest
|
||||
permissions:
|
||||
contents: read
|
||||
id-token: write # OIDC token exchange for npm trusted publishing + provenance
|
||||
steps:
|
||||
- name: Checkout
|
||||
uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4
|
||||
|
||||
# No registry-url here on purpose: setup-node's registry-url writes an
|
||||
# .npmrc line referencing $NODE_AUTH_TOKEN, and npm hard-fails on the
|
||||
# unset env var. Trusted publishing needs no token at all.
|
||||
- name: Setup Node
|
||||
uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4
|
||||
with:
|
||||
node-version: 24
|
||||
|
||||
# OIDC trusted publishing needs npm >= 11.5.1. Use the npm bundled with
|
||||
# the pinned Node toolchain (Node 24 ships >= 11.5.1) rather than pulling
|
||||
# npm@latest from the registry inside the publish path — an unpinned
|
||||
# install there would be avoidable supply-chain exposure. Fail fast if a
|
||||
# future runner/toolchain change ever regresses the bundled npm.
|
||||
- name: Check npm supports trusted publishing
|
||||
run: |
|
||||
npm --version | node -e '
|
||||
const version = require("fs").readFileSync(0, "utf8").trim();
|
||||
const [major, minor, patch] = version.split(".").map(Number);
|
||||
const ok =
|
||||
major > 11 ||
|
||||
(major === 11 && (minor > 5 || (minor === 5 && patch >= 1)));
|
||||
if (!ok) {
|
||||
console.error(
|
||||
`::error::bundled npm ${version} is too old for OIDC trusted ` +
|
||||
`publishing (needs >= 11.5.1) — bump node-version in this job.`,
|
||||
);
|
||||
process.exit(1);
|
||||
}
|
||||
console.log(`npm ${version} supports trusted publishing.`);
|
||||
'
|
||||
|
||||
# Probe the exact URLs postinstall will build (internal/release/release.go
|
||||
# asset-name scheme) as an anonymous client. This also blocks publishing
|
||||
# while the repo is still private — private release assets 404 without
|
||||
# auth, exactly as they would for an installing user.
|
||||
- name: Verify release assets are downloadable
|
||||
shell: bash
|
||||
run: |
|
||||
version="$(node -p "require('./package.json').version")"
|
||||
base="https://github.com/${GITHUB_REPOSITORY}/releases/download/v${version}"
|
||||
for asset in \
|
||||
"zero-v${version}-linux-x64.tar.gz" \
|
||||
"zero-v${version}-linux-arm64.tar.gz" \
|
||||
"zero-v${version}-macos-x64.tar.gz" \
|
||||
"zero-v${version}-macos-arm64.tar.gz" \
|
||||
"zero-v${version}-windows-x64.zip"; do
|
||||
for url in "${base}/${asset}" "${base}/${asset}.sha256"; do
|
||||
if ! curl -fsSLI -o /dev/null "$url"; then
|
||||
echo "::error::${url} is not publicly downloadable — npm postinstall would fail. Is the repo public and are all assets uploaded?" >&2
|
||||
exit 1
|
||||
fi
|
||||
done
|
||||
done
|
||||
echo "all release assets for v${version} are publicly downloadable."
|
||||
|
||||
- name: Publish to npm
|
||||
run: npm publish --access public
|
||||
@@ -0,0 +1,35 @@
|
||||
name: Release Please
|
||||
|
||||
on:
|
||||
push:
|
||||
branches:
|
||||
- main
|
||||
|
||||
permissions:
|
||||
contents: write # push the release-PR branch, create the tag + GitHub Release
|
||||
pull-requests: write # open/update the release PR
|
||||
issues: write # create/apply release-tracking labels on the release PR
|
||||
actions: write # dispatch release-artifacts.yml once a release is cut
|
||||
|
||||
jobs:
|
||||
release-please:
|
||||
name: Release PR / tag
|
||||
runs-on: ubuntu-latest
|
||||
steps:
|
||||
- name: Run release-please
|
||||
id: release
|
||||
uses: googleapis/release-please-action@a02a34c4d625f9be7cb89156071d8567266a2445 # v4.2.0
|
||||
|
||||
# Tags created with the default GITHUB_TOKEN never fire `on: push: tags`
|
||||
# workflows (GitHub suppresses workflows triggered by workflow-created
|
||||
# events), so release-artifacts.yml would not run for a release-please
|
||||
# tag. workflow_dispatch invoked through the API is exempt from that
|
||||
# suppression — dispatch the artifacts build at the new tag explicitly.
|
||||
- name: Build and publish release artifacts
|
||||
if: ${{ steps.release.outputs.release_created }}
|
||||
env:
|
||||
GH_TOKEN: ${{ github.token }}
|
||||
run: |
|
||||
gh workflow run release-artifacts.yml \
|
||||
--repo "$GITHUB_REPOSITORY" \
|
||||
--ref "${{ steps.release.outputs.tag_name }}"
|
||||
@@ -0,0 +1 @@
|
||||
{".":"0.1.0"}
|
||||
@@ -6,6 +6,19 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/),
|
||||
aims to follow [Semantic Versioning](https://semver.org/spec/v2.0.0.html) once the first release is
|
||||
tagged. Until then, source builds report the version `dev`.
|
||||
|
||||
## 0.1.0 (2026-07-02)
|
||||
|
||||
|
||||
### Features
|
||||
|
||||
* publish zero to npm via release-please ([#367](https://github.com/Gitlawb/zero/issues/367)) ([8eccc26](https://github.com/Gitlawb/zero/commit/8eccc2669887bc38d35bc16a315c888e4d9ec43a))
|
||||
* **tui:** FILES sidebar panel with click-to-select and file drill-in ([#365](https://github.com/Gitlawb/zero/issues/365)) ([142c548](https://github.com/Gitlawb/zero/commit/142c548c89a8652ce300e64ddf1228ee36df7606))
|
||||
|
||||
|
||||
### Bug Fixes
|
||||
|
||||
* **auth:** propagate credentials to every provider-build surface and pin children to the live provider ([#366](https://github.com/Gitlawb/zero/issues/366)) ([6e0a665](https://github.com/Gitlawb/zero/commit/6e0a665118fe0e09c4b07d482dd18f86045acd2b))
|
||||
|
||||
## [Unreleased]
|
||||
|
||||
### Added
|
||||
|
||||
+36
-21
@@ -210,27 +210,29 @@ func Run(ctx context.Context, prompt string, provider Provider, options Options)
|
||||
}
|
||||
}
|
||||
|
||||
// Wrapped callbacks flag ANY output forwarded this turn, so a stall retry
|
||||
// never re-streams on top of output the user already saw — even across the
|
||||
// reactive-compaction retry below, which overwrites `collected`.
|
||||
forwardedAnything := false
|
||||
mark := func() { forwardedAnything = true }
|
||||
// OnUsage is telemetry, not visible output, so it does NOT mark
|
||||
// forwardedAnything: a provider that emits an early usage event (e.g. prompt
|
||||
// tokens) then stalls with no content must still be safely retried. The gate
|
||||
// only guards against re-streaming output the user actually SAW.
|
||||
// forwardedVisibleText flags forwarded final PROSE (OnText) specifically —
|
||||
// the only output whose re-stream on a stall retry would visibly DUPLICATE
|
||||
// answer text the user already read. Transient working indicators
|
||||
// (reasoning previews, tool-call "writing…" previews) are deliberately NOT
|
||||
// counted: a turn that streamed only those then stalled — the common
|
||||
// gpt-5.x / ollama "froze mid-write_file" case — is safe to re-issue, since
|
||||
// the TUI resets the tool-call preview on the next tool-call-start and a
|
||||
// stalled turn is never appended to `messages` (it returns on the error
|
||||
// before the append), so the retry re-sends clean context with no
|
||||
// conversation-state duplication.
|
||||
forwardedVisibleText := false
|
||||
forwardingOpts := zeroruntime.CollectOptions{OnUsage: options.OnUsage}
|
||||
if options.OnText != nil {
|
||||
forwardingOpts.OnText = func(s string) { mark(); options.OnText(s) }
|
||||
forwardingOpts.OnText = func(s string) { forwardedVisibleText = true; options.OnText(s) }
|
||||
}
|
||||
if options.OnReasoning != nil {
|
||||
forwardingOpts.OnReasoning = func(s string) { mark(); options.OnReasoning(s) }
|
||||
forwardingOpts.OnReasoning = func(s string) { options.OnReasoning(s) }
|
||||
}
|
||||
if options.OnToolCallStart != nil {
|
||||
forwardingOpts.OnToolCallStart = func(id, name string) { mark(); options.OnToolCallStart(id, name) }
|
||||
forwardingOpts.OnToolCallStart = func(id, name string) { options.OnToolCallStart(id, name) }
|
||||
}
|
||||
if options.OnToolCallDelta != nil {
|
||||
forwardingOpts.OnToolCallDelta = func(id, fragment string) { mark(); options.OnToolCallDelta(id, fragment) }
|
||||
forwardingOpts.OnToolCallDelta = func(id, fragment string) { options.OnToolCallDelta(id, fragment) }
|
||||
}
|
||||
// recoverStreamError applies the same non-stall recovery the initial stream
|
||||
// gets to ANY collected error — including one from a reissued (stall-retry)
|
||||
@@ -284,15 +286,28 @@ func Run(ctx context.Context, prompt string, provider Provider, options Options)
|
||||
result.Messages = copyMessages(messages)
|
||||
return result, ctx.Err()
|
||||
}
|
||||
// A stream idle/stall timeout with NO output forwarded yet this turn can be
|
||||
// safely re-issued on a fresh connection — nothing was shown, so there's no
|
||||
// duplication (this recovers the macOS stale-pooled-connection hang when it
|
||||
// slips past the transport's response-header timeout). A turn that already
|
||||
// streamed partial text/tool-calls is NOT retried (it would duplicate) and
|
||||
// falls through to the error return below. Capped + exponential backoff.
|
||||
// A stream idle/stall timeout is safely re-issued when the turn committed NO
|
||||
// answer text — no forwarded visible prose (forwardedVisibleText) and no
|
||||
// collected final text (collected.Text). This covers two cases:
|
||||
// 1. Nothing streamed at all before the connection died (the original
|
||||
// macOS stale-pooled-connection hang past the response-header timeout).
|
||||
// 2. The model streamed transient reasoning and began a tool call (e.g. a
|
||||
// large write_file) then froze mid-arguments — the common gpt-5.x /
|
||||
// ollama heartbeat-pause stall. That partial tool call is NEVER executed
|
||||
// (a turn with collected.Error returns before dispatch below) and NEVER
|
||||
// appended to `messages`, so a retry re-issues clean context; the only
|
||||
// re-render is transient previews, not duplicated answer text. This is
|
||||
// why the gate no longer excludes collected.ToolCalls: an incomplete
|
||||
// tool call from a timed-out stream is discard-and-retry, not output.
|
||||
// A turn that forwarded real prose is NOT retried (it would duplicate visible
|
||||
// answer text) and falls through to the error return below. Capped +
|
||||
// exponential backoff, with a user-visible notice per attempt.
|
||||
for attempt := 1; attempt <= maxStreamStallRetries &&
|
||||
isStreamTimeoutError(collected.Error) && !forwardedAnything &&
|
||||
collected.Text == "" && len(collected.ToolCalls) == 0; attempt++ {
|
||||
isStreamTimeoutError(collected.Error) && !forwardedVisibleText &&
|
||||
collected.Text == ""; attempt++ {
|
||||
if notify := stallRetryNoticeFor(options); notify != nil {
|
||||
notify(attempt, maxStreamStallRetries)
|
||||
}
|
||||
if err := sleepWithContext(ctx, backoffFor(attempt)); err != nil {
|
||||
result.Messages = copyMessages(messages)
|
||||
return result, err
|
||||
|
||||
@@ -40,6 +40,21 @@ func reconnectNoticeFor(options Options) reconnectNotifier {
|
||||
}
|
||||
}
|
||||
|
||||
// stallRetryNoticeFor builds a notifier for the loop's content-stall retry (a
|
||||
// stream that connected and produced only transient output, then went silent).
|
||||
// Distinct wording from reconnectNoticeFor's "connection lost" because the
|
||||
// connection was fine — the model stalled. Surfaced through OnReasoning, the
|
||||
// non-content channel, so it never folds into the answer text. Nil when there
|
||||
// is no reasoning sink (the retry still happens silently).
|
||||
func stallRetryNoticeFor(options Options) reconnectNotifier {
|
||||
if options.OnReasoning == nil {
|
||||
return nil
|
||||
}
|
||||
return func(attempt, max int) {
|
||||
options.OnReasoning(fmt.Sprintf("\n[no output — model stalled; retrying %d/%d…]\n", attempt, max))
|
||||
}
|
||||
}
|
||||
|
||||
// streamWithReconnect issues request via provider.StreamCompletion and, on a
|
||||
// transient disconnect error, retries the connect up to maxStreamReconnects
|
||||
// times with exponential backoff. It returns the live stream on success, or the
|
||||
|
||||
@@ -10,19 +10,25 @@ import (
|
||||
)
|
||||
|
||||
// stallProvider connects successfully (HTTP 200) but the stream emits a stall/idle
|
||||
// timeout error for the first stallBefore calls, then succeeds with "done". When
|
||||
// partialText is set it emits that text BEFORE the stall, simulating a stall after
|
||||
// partial output (which must NOT be retried — re-issuing would duplicate it).
|
||||
// timeout error for the first stallBefore calls, then succeeds with "done". The
|
||||
// pre-stall emission simulates different partial-output shapes:
|
||||
// - partialText: forwarded PROSE (StreamEventText) — must NOT be retried
|
||||
// (re-issuing would duplicate visible answer text).
|
||||
// - reasoningText: transient reasoning preview — IS retried.
|
||||
// - partialToolCall: a tool call started (+ arg delta) but never ended, the
|
||||
// "froze mid-write_file" case — IS retried (the incomplete call is never
|
||||
// executed or committed).
|
||||
type stallProvider struct {
|
||||
calls int32
|
||||
stallBefore int32
|
||||
partialText string
|
||||
reasoningText string
|
||||
calls int32
|
||||
stallBefore int32
|
||||
partialText string
|
||||
reasoningText string
|
||||
partialToolCall string
|
||||
}
|
||||
|
||||
func (p *stallProvider) StreamCompletion(_ context.Context, _ zeroruntime.CompletionRequest) (<-chan zeroruntime.StreamEvent, error) {
|
||||
n := atomic.AddInt32(&p.calls, 1)
|
||||
ch := make(chan zeroruntime.StreamEvent, 3)
|
||||
ch := make(chan zeroruntime.StreamEvent, 5)
|
||||
if n <= p.stallBefore {
|
||||
if p.partialText != "" {
|
||||
ch <- zeroruntime.StreamEvent{Type: zeroruntime.StreamEventText, Content: p.partialText}
|
||||
@@ -30,9 +36,16 @@ func (p *stallProvider) StreamCompletion(_ context.Context, _ zeroruntime.Comple
|
||||
if p.reasoningText != "" {
|
||||
ch <- zeroruntime.StreamEvent{Type: zeroruntime.StreamEventReasoning, Content: p.reasoningText}
|
||||
}
|
||||
if p.partialToolCall != "" {
|
||||
// A tool call that starts and streams a partial argument fragment but
|
||||
// never gets StreamEventToolCallEnd, then the stream errors — exactly
|
||||
// the gpt-5.x "began the big write_file then froze" shape.
|
||||
ch <- zeroruntime.StreamEvent{Type: zeroruntime.StreamEventToolCallStart, ToolCallID: "tc_1", ToolName: p.partialToolCall}
|
||||
ch <- zeroruntime.StreamEvent{Type: zeroruntime.StreamEventToolCallDelta, ToolCallID: "tc_1", ArgumentsFragment: `{"path":"x.html","content":"<!doctype`}
|
||||
}
|
||||
ch <- zeroruntime.StreamEvent{
|
||||
Type: zeroruntime.StreamEventError,
|
||||
Error: "provider stream error: no output for 10m (the model produced nothing)",
|
||||
Error: "provider stream error: no output for 6m (the model produced nothing)",
|
||||
}
|
||||
close(ch)
|
||||
return ch, nil
|
||||
@@ -72,21 +85,54 @@ func TestRunDoesNotRetryStallAfterPartialOutput(t *testing.T) {
|
||||
}
|
||||
}
|
||||
|
||||
// A stall after only REASONING was forwarded (no text/tool-calls) must NOT be
|
||||
// retried: the user already saw the reasoning, so re-issuing with callbacks
|
||||
// re-enabled would duplicate it. collected.Text is empty here, so this exercises
|
||||
// the turn-level forwarded-output gate specifically, not the text check.
|
||||
func TestRunDoesNotRetryStallAfterForwardedReasoning(t *testing.T) {
|
||||
// A stall after only transient REASONING was forwarded (no prose text, no
|
||||
// completed tool call) IS retried: reasoning is a "thinking" preview, not
|
||||
// committed answer text, so re-streaming it on a clearly-signalled retry is
|
||||
// acceptable and recovers the common "reasoned then froze" stall. Only
|
||||
// forwarded final prose (OnText) blocks the retry (collected.Text is empty
|
||||
// here, so this exercises the transient-vs-prose gate specifically).
|
||||
func TestRunRetriesStallAfterOnlyReasoning(t *testing.T) {
|
||||
p := &stallProvider{stallBefore: 1, reasoningText: "thinking hard"}
|
||||
_, err := Run(context.Background(), "go", p, Options{
|
||||
result, err := Run(context.Background(), "go", p, Options{
|
||||
Registry: tools.NewRegistry(),
|
||||
OnReasoning: func(string) {},
|
||||
})
|
||||
if err == nil {
|
||||
t.Fatal("a stall after forwarded reasoning must NOT be retried; want an error")
|
||||
if err != nil {
|
||||
t.Fatalf("a stall after only reasoning should retry to success, got %v", err)
|
||||
}
|
||||
if got := atomic.LoadInt32(&p.calls); got != 1 {
|
||||
t.Fatalf("reasoning-then-stall must not retry, got %d calls", got)
|
||||
if result.FinalAnswer != "done" {
|
||||
t.Fatalf("final answer = %q, want %q", result.FinalAnswer, "done")
|
||||
}
|
||||
if got := atomic.LoadInt32(&p.calls); got != 2 {
|
||||
t.Fatalf("want 2 calls (1 stall + 1 retry), got %d", got)
|
||||
}
|
||||
}
|
||||
|
||||
// A stall mid-way through an INCOMPLETE tool call (started + partial args, never
|
||||
// ended) IS retried — the exact gpt-5.x / ollama "began the big write_file then
|
||||
// froze" case. The incomplete call is never executed (a turn returns on the
|
||||
// stall error before dispatch) and never committed to history, so re-issuing is
|
||||
// safe and recovers to success. This is the primary scenario this change fixes.
|
||||
func TestRunRetriesStallAfterIncompleteToolCall(t *testing.T) {
|
||||
starts := 0
|
||||
p := &stallProvider{stallBefore: 1, reasoningText: "planning", partialToolCall: "write_file"}
|
||||
result, err := Run(context.Background(), "go", p, Options{
|
||||
Registry: tools.NewRegistry(),
|
||||
OnReasoning: func(string) {},
|
||||
OnToolCallStart: func(string, string) { starts++ },
|
||||
OnToolCallDelta: func(string, string) {},
|
||||
})
|
||||
if err != nil {
|
||||
t.Fatalf("a stall mid-incomplete-tool-call should retry to success, got %v", err)
|
||||
}
|
||||
if result.FinalAnswer != "done" {
|
||||
t.Fatalf("final answer = %q, want %q", result.FinalAnswer, "done")
|
||||
}
|
||||
if got := atomic.LoadInt32(&p.calls); got != 2 {
|
||||
t.Fatalf("want 2 calls (1 stall + 1 retry), got %d", got)
|
||||
}
|
||||
if starts != 1 {
|
||||
t.Fatalf("the incomplete tool call should have been forwarded once before the stall, got %d starts", starts)
|
||||
}
|
||||
}
|
||||
|
||||
|
||||
@@ -455,11 +455,15 @@ func TestHarnessTimeoutCancelsBlockedAgent(t *testing.T) {
|
||||
|
||||
// The timeout is longer than materialization of the small fixture even on
|
||||
// slower Windows CI runners, so the agent is reached before it blocks until
|
||||
// the deadline fires.
|
||||
// the deadline fires. 10s wasn't generous enough in practice — it failed
|
||||
// on an otherwise-unrelated PR merge (materialization alone consumed the
|
||||
// full budget on a contended Windows runner, so the agent was never
|
||||
// reached); widened for headroom, since the assertions below still bound
|
||||
// worst-case test time via that same deadline, not this constant.
|
||||
report := harness.Run(context.Background(), suitePath, suite, BenchmarkInput{
|
||||
TaskID: "document-stream-json-verify-events",
|
||||
WorkRoot: t.TempDir(),
|
||||
Timeout: 10 * time.Second,
|
||||
Timeout: 30 * time.Second,
|
||||
})
|
||||
|
||||
if !agentReached {
|
||||
|
||||
+5
-2
@@ -43,8 +43,11 @@ func runACP(args []string, stdout io.Writer, stderr io.Writer, deps appDeps) int
|
||||
conn := acp.NewConn(deps.stdin, stdout)
|
||||
acp.NewAgent(conn, acp.Deps{
|
||||
ResolveConfig: deps.resolveConfig,
|
||||
NewProvider: deps.newProvider,
|
||||
RunAgent: agent.Run,
|
||||
// deps.newProvider is wrapped in fillAppDeps to apply the stored API key,
|
||||
// so ACP is authenticated for apiKeyStored profiles like every other
|
||||
// surface — no ACP-specific credential handling needed.
|
||||
NewProvider: deps.newProvider,
|
||||
RunAgent: agent.Run,
|
||||
// Build the SCOPED registry + sandbox engine per workspace, exactly like the
|
||||
// exec surface, so ACP shell/file tools are confined — never run unconfined.
|
||||
BuildWorkspace: func(workspaceRoot string, resolved config.ResolvedConfig) (*tools.Registry, *sandbox.Engine, error) {
|
||||
|
||||
+68
-16
@@ -43,12 +43,17 @@ import (
|
||||
var version = "dev"
|
||||
|
||||
type appDeps struct {
|
||||
getwd func() (string, error)
|
||||
stdin io.Reader
|
||||
userConfigPath func() (string, error)
|
||||
resolveConfig func(workspaceRoot string, overrides config.Overrides) (config.ResolvedConfig, error)
|
||||
resolveMCPConfig func(workspaceRoot string) (config.MCPConfig, error)
|
||||
newProvider func(config.ProviderProfile) (zeroruntime.Provider, error)
|
||||
getwd func() (string, error)
|
||||
stdin io.Reader
|
||||
userConfigPath func() (string, error)
|
||||
resolveConfig func(workspaceRoot string, overrides config.Overrides) (config.ResolvedConfig, error)
|
||||
resolveMCPConfig func(workspaceRoot string) (config.MCPConfig, error)
|
||||
newProvider func(config.ProviderProfile) (zeroruntime.Provider, error)
|
||||
// exportActiveProvider pins spawned children to the run's provider (production:
|
||||
// config.SetActiveProviderEnv, set in defaultAppDeps — deliberately NOT filled
|
||||
// by fillAppDeps, so tests never mutate the process environment unless they
|
||||
// inject it). nil ⇒ no export.
|
||||
exportActiveProvider func(providerName string)
|
||||
probeProviderHealth func(context.Context, providerhealth.Options) providerhealth.Result
|
||||
detectLocalRuntimes func(context.Context, provideronboarding.LocalDetectOptions) []provideronboarding.DetectedLocalRuntime
|
||||
newSessionStore func() *sessions.Store
|
||||
@@ -99,9 +104,10 @@ func Run(args []string, stdout io.Writer, stderr io.Writer) int {
|
||||
|
||||
func defaultAppDeps() appDeps {
|
||||
return appDeps{
|
||||
getwd: os.Getwd,
|
||||
stdin: os.Stdin,
|
||||
userConfigPath: config.DefaultUserConfigPath,
|
||||
getwd: os.Getwd,
|
||||
stdin: os.Stdin,
|
||||
userConfigPath: config.DefaultUserConfigPath,
|
||||
exportActiveProvider: config.SetActiveProviderEnv,
|
||||
resolveConfig: func(workspaceRoot string, overrides config.Overrides) (config.ResolvedConfig, error) {
|
||||
options, err := config.DefaultResolveOptions(workspaceRoot)
|
||||
if err != nil {
|
||||
@@ -118,9 +124,14 @@ func defaultAppDeps() appDeps {
|
||||
return config.ResolveMCP(options)
|
||||
},
|
||||
newProvider: func(profile config.ProviderProfile) (zeroruntime.Provider, error) {
|
||||
// Resolve the OAuth login ONCE: the bearer resolver and the login key it
|
||||
// bound must describe the same login (the key is passed on to the Codex
|
||||
// account-header resolver so it never re-selects independently).
|
||||
resolver, loginKey := oauthLoginForProfile(profile)
|
||||
return providers.New(profile, providers.Options{
|
||||
UserAgent: userAgent(),
|
||||
OAuthResolver: oauthResolverForProfile(profile),
|
||||
OAuthResolver: resolver,
|
||||
OAuthLoginKey: loginKey,
|
||||
})
|
||||
},
|
||||
probeProviderHealth: providerhealth.Probe,
|
||||
@@ -493,6 +504,17 @@ func fillAppDeps(deps appDeps) appDeps {
|
||||
if deps.now == nil {
|
||||
deps.now = defaults.now
|
||||
}
|
||||
// Wrap newProvider ONCE, after all defaults are filled, so every surface that
|
||||
// builds the runtime provider gets the credential-store key applied. The
|
||||
// resolver is pure and leaves apiKeyStored profiles keyless; an unwrapped
|
||||
// build sends unauthenticated requests. config.ApplyStoredAPIKey is a no-op
|
||||
// when the key is already set or the profile isn't stored-key, so this is
|
||||
// safe and idempotent for every profile kind and every injected newProvider.
|
||||
baseNewProvider := deps.newProvider
|
||||
userConfigPath := deps.userConfigPath
|
||||
deps.newProvider = func(profile config.ProviderProfile) (zeroruntime.Provider, error) {
|
||||
return baseNewProvider(applyStoredProviderKeyAt(profile, userConfigPath))
|
||||
}
|
||||
return deps
|
||||
}
|
||||
|
||||
@@ -720,20 +742,50 @@ func tuiSandboxSetupCommand(backend sandbox.Backend, deps appDeps) func(context.
|
||||
}
|
||||
}
|
||||
|
||||
// buildProvider constructs the run's provider at STARTUP — it is called only from
|
||||
// the two launch paths (interactive TUI and headless exec), never from mid-run
|
||||
// rebuilds (escalation, wizard, ACP go through deps.newProvider directly).
|
||||
func buildProvider(resolved config.ResolvedConfig, deps appDeps) (zeroruntime.Provider, error) {
|
||||
if !config.HasProviderProfile(resolved.Provider) {
|
||||
return nil, nil
|
||||
}
|
||||
// Load the API key from the encrypted credential store when it isn't already
|
||||
// resolved from inline config or an env var. This keeps the resolver pure (no
|
||||
// I/O) and is a no-op for env/inline-key providers and when nothing is stored.
|
||||
profile := resolved.Provider
|
||||
if path, perr := deps.userConfigPath(); perr == nil {
|
||||
// deps.newProvider is wrapped in fillAppDeps to apply the stored key, so this
|
||||
// (and every other newProvider caller) needs no per-site key handling.
|
||||
provider, err := deps.newProvider(resolved.Provider)
|
||||
if err != nil {
|
||||
return nil, err
|
||||
}
|
||||
// Pin spawned children (sub-agents / swarm members inherit the environment) to
|
||||
// THIS run's provider from launch, not only after an in-session switch. Without
|
||||
// the launch-time export a child re-resolves config.json at spawn time, so a
|
||||
// provider switch persisted by ANOTHER zero process mid-session would silently
|
||||
// move new children onto a different provider (and different credentials) than
|
||||
// the parent is running. Runtime switches (/model, /provider, wizard,
|
||||
// onboarding) re-export on commit, keeping the pin current. Injected via deps
|
||||
// (nil in tests) because it mutates the process environment.
|
||||
if deps.exportActiveProvider != nil {
|
||||
deps.exportActiveProvider(resolved.Provider.Name)
|
||||
}
|
||||
return provider, nil
|
||||
}
|
||||
|
||||
// applyStoredProviderKeyAt loads the API key from the encrypted credential store
|
||||
// when the resolver left it empty (the resolver is pure — no I/O — so an
|
||||
// apiKeyStored profile reaches this layer keyless). No-op for inline/env-key
|
||||
// providers and when nothing is stored. This is applied once, centrally, by the
|
||||
// deps.newProvider wrapper in fillAppDeps so EVERY surface that builds a runtime
|
||||
// provider (headless exec, the ACP builder, exec's mid-run escalation switcher,
|
||||
// and any future caller) is covered without a per-site invariant to forget.
|
||||
func applyStoredProviderKeyAt(profile config.ProviderProfile, userConfigPath func() (string, error)) config.ProviderProfile {
|
||||
if userConfigPath == nil {
|
||||
return profile
|
||||
}
|
||||
if path, perr := userConfigPath(); perr == nil {
|
||||
if store, err := config.ProviderKeyStoreAt(filepath.Dir(path)); err == nil {
|
||||
profile = config.ApplyStoredAPIKey(profile, store)
|
||||
}
|
||||
}
|
||||
return deps.newProvider(profile)
|
||||
return profile
|
||||
}
|
||||
|
||||
func newCoreRegistry(workspaceRoot string) *tools.Registry {
|
||||
|
||||
@@ -283,6 +283,9 @@ func newAuthManager(deps appDeps, out io.Writer) (*oauth.Manager, error) {
|
||||
// carries no token material. A real browser launch is intentionally not
|
||||
// performed (the sandbox/headless contexts make printing the safer default).
|
||||
OpenBrowser: func(string) error { return nil },
|
||||
// `zero auth login <preset>` (e.g. xai) should resolve the baked-in preset
|
||||
// without the operator exporting ZERO_OAUTH_ALLOW_PRESETS first.
|
||||
AllowPresets: true,
|
||||
})
|
||||
}
|
||||
|
||||
|
||||
@@ -0,0 +1,180 @@
|
||||
package cli
|
||||
|
||||
import (
|
||||
"bytes"
|
||||
"errors"
|
||||
"os"
|
||||
"path/filepath"
|
||||
"testing"
|
||||
|
||||
"github.com/Gitlawb/zero/internal/config"
|
||||
"github.com/Gitlawb/zero/internal/zeroruntime"
|
||||
)
|
||||
|
||||
// seedStoredProviderKey writes key into a credential store rooted beside the
|
||||
// returned config path, and returns deps fields wired at that path — the same
|
||||
// layout applyStoredProviderKey resolves through in production.
|
||||
func seedStoredProviderKey(t *testing.T, providerName, key string) (userConfigPath string) {
|
||||
t.Helper()
|
||||
t.Setenv("ZERO_CRED_STORAGE", "encrypted-file") // never touch the real OS keychain in tests
|
||||
dir := t.TempDir()
|
||||
store, err := config.ProviderKeyStoreAt(dir)
|
||||
if err != nil {
|
||||
t.Fatalf("ProviderKeyStoreAt: %v", err)
|
||||
}
|
||||
if err := store.Set(providerName, key); err != nil {
|
||||
t.Fatalf("seed stored key: %v", err)
|
||||
}
|
||||
return filepath.Join(dir, "config.json")
|
||||
}
|
||||
|
||||
// applyStoredProviderKeyAt must fill APIKey from the credential store for an
|
||||
// apiKeyStored profile — the single central helper the newProvider wrapper uses.
|
||||
func TestApplyStoredProviderKeyAtFillsFromCredstore(t *testing.T) {
|
||||
configPath := seedStoredProviderKey(t, "echo", "sk-stored-test")
|
||||
ucp := func() (string, error) { return configPath, nil }
|
||||
|
||||
stored := applyStoredProviderKeyAt(config.ProviderProfile{Name: "echo", APIKeyStored: true}, ucp)
|
||||
if stored.APIKey != "sk-stored-test" {
|
||||
t.Fatalf("APIKey = %q, want the stored key", stored.APIKey)
|
||||
}
|
||||
|
||||
// A profile that did NOT opt into stored-key auth must be left unchanged —
|
||||
// a stale store entry must not silently reactivate credentials.
|
||||
plain := applyStoredProviderKeyAt(config.ProviderProfile{Name: "echo"}, ucp)
|
||||
if plain.APIKey != "" {
|
||||
t.Fatalf("non-stored profile APIKey = %q, want empty", plain.APIKey)
|
||||
}
|
||||
}
|
||||
|
||||
// fillAppDeps wraps newProvider so EVERY surface that builds a runtime provider
|
||||
// (buildProvider, the ACP builder — which is just deps.newProvider — and exec's
|
||||
// escalation switcher) gets the stored key applied. Passing the raw resolved
|
||||
// profile previously sent unauthenticated requests for apiKeyStored profiles,
|
||||
// the default onboarding outcome. Testing the wrap covers all those surfaces.
|
||||
func TestFillAppDepsWrapsNewProviderWithStoredKey(t *testing.T) {
|
||||
configPath := seedStoredProviderKey(t, "echo", "sk-stored-wrap")
|
||||
|
||||
var captured config.ProviderProfile
|
||||
deps := fillAppDeps(appDeps{
|
||||
userConfigPath: func() (string, error) { return configPath, nil },
|
||||
newProvider: func(profile config.ProviderProfile) (zeroruntime.Provider, error) {
|
||||
captured = profile
|
||||
return nil, nil // only the captured profile matters here
|
||||
},
|
||||
})
|
||||
|
||||
if _, err := deps.newProvider(config.ProviderProfile{Name: "echo", APIKeyStored: true}); err != nil {
|
||||
t.Fatalf("wrapped newProvider: %v", err)
|
||||
}
|
||||
if captured.APIKey != "sk-stored-wrap" {
|
||||
t.Fatalf("wrapped newProvider built with APIKey = %q, want the stored key (unauthenticated regression)", captured.APIKey)
|
||||
}
|
||||
}
|
||||
|
||||
// buildProvider (the TUI/exec STARTUP construction site) must export
|
||||
// ZERO_PROVIDER so children spawned at any point in the run are pinned to the
|
||||
// parent's provider from launch — not only after an in-session switch. Without
|
||||
// this, a provider switch persisted by another zero process mid-session moves
|
||||
// new children onto a different provider (and credentials) than the parent.
|
||||
func TestBuildProviderExportsActiveProviderEnv(t *testing.T) {
|
||||
t.Setenv(config.ActiveProviderEnv, "stale-from-elsewhere")
|
||||
// The exporter is injected (defaultAppDeps wires config.SetActiveProviderEnv;
|
||||
// fillAppDeps deliberately leaves it nil so ordinary tests never mutate the
|
||||
// process env). Inject the real one here to assert the actual env effect.
|
||||
deps := appDeps{
|
||||
exportActiveProvider: config.SetActiveProviderEnv,
|
||||
newProvider: func(config.ProviderProfile) (zeroruntime.Provider, error) {
|
||||
return nil, nil
|
||||
},
|
||||
}
|
||||
|
||||
resolved := config.ResolvedConfig{Provider: config.ProviderProfile{Name: "pinned", ProviderKind: config.ProviderKindAnthropic, Model: "m"}}
|
||||
if _, err := buildProvider(resolved, deps); err != nil {
|
||||
t.Fatalf("buildProvider: %v", err)
|
||||
}
|
||||
if got := os.Getenv(config.ActiveProviderEnv); got != "pinned" {
|
||||
t.Fatalf("%s = %q after startup build, want %q (children would spawn on the stale provider)", config.ActiveProviderEnv, got, "pinned")
|
||||
}
|
||||
|
||||
// A FAILED build must not move the pin: the process never committed to the
|
||||
// new provider, so children must keep resolving whatever was in effect.
|
||||
t.Setenv(config.ActiveProviderEnv, "still-current")
|
||||
failing := appDeps{
|
||||
exportActiveProvider: config.SetActiveProviderEnv,
|
||||
newProvider: func(config.ProviderProfile) (zeroruntime.Provider, error) {
|
||||
return nil, errors.New("boom")
|
||||
},
|
||||
}
|
||||
if _, err := buildProvider(resolved, failing); err == nil {
|
||||
t.Fatal("expected build error")
|
||||
}
|
||||
if got := os.Getenv(config.ActiveProviderEnv); got != "still-current" {
|
||||
t.Fatalf("%s = %q after failed build, want it untouched", config.ActiveProviderEnv, got)
|
||||
}
|
||||
|
||||
// No provider profile at all → no provider, no pin change.
|
||||
if _, err := buildProvider(config.ResolvedConfig{}, deps); err != nil {
|
||||
t.Fatalf("buildProvider(empty): %v", err)
|
||||
}
|
||||
if got := os.Getenv(config.ActiveProviderEnv); got != "still-current" {
|
||||
t.Fatalf("%s = %q after profile-less build, want it untouched", config.ActiveProviderEnv, got)
|
||||
}
|
||||
}
|
||||
|
||||
// A mid-run --allow-escalation model switch previously rebuilt the provider
|
||||
// from the PURE resolved profile (the stored key lives only in buildProvider's
|
||||
// local copy), so the escalated provider was keyless and the next completion
|
||||
// call 401'd mid-run. Every profile handed to newProvider on this path must
|
||||
// carry the stored key.
|
||||
func TestRunExecEscalationSwitchKeepsStoredKey(t *testing.T) {
|
||||
dataHome := t.TempDir()
|
||||
t.Setenv("XDG_DATA_HOME", dataHome)
|
||||
cwd := t.TempDir()
|
||||
|
||||
if _, ok := mustUpgradeTarget(t, "claude-haiku-4.5"); !ok {
|
||||
t.Skip("registry has no upgrade target for claude-haiku-4.5")
|
||||
}
|
||||
|
||||
configPath := seedStoredProviderKey(t, "echo", "sk-stored-escalation")
|
||||
|
||||
var builtProfiles []config.ProviderProfile
|
||||
var stdout, stderr bytes.Buffer
|
||||
exitCode := runWithDeps([]string{
|
||||
"exec",
|
||||
"--allow-escalation",
|
||||
"--model", "claude-haiku-4.5",
|
||||
"--init-session-id", "escalation_stored_key_run",
|
||||
"escalate please",
|
||||
}, &stdout, &stderr, appDeps{
|
||||
getwd: func() (string, error) { return cwd, nil },
|
||||
userConfigPath: func() (string, error) { return configPath, nil },
|
||||
resolveConfig: func(_ string, overrides config.Overrides) (config.ResolvedConfig, error) {
|
||||
model := "claude-haiku-4.5"
|
||||
if overrides.Provider.Model != "" {
|
||||
model = overrides.Provider.Model
|
||||
}
|
||||
cfg := execResolvedConfig()
|
||||
cfg.Provider.ProviderKind = config.ProviderKindAnthropic
|
||||
cfg.Provider.Model = model
|
||||
cfg.Provider.APIKeyStored = true // key lives ONLY in the credstore
|
||||
cfg.MaxTurns = 3
|
||||
return cfg, nil
|
||||
},
|
||||
newProvider: func(profile config.ProviderProfile) (zeroruntime.Provider, error) {
|
||||
builtProfiles = append(builtProfiles, profile)
|
||||
return &usageEmittingEscalatingProvider{escalate: len(builtProfiles) == 1}, nil
|
||||
},
|
||||
})
|
||||
if exitCode != exitSuccess {
|
||||
t.Fatalf("exit = %d, want success; stderr=%s", exitCode, stderr.String())
|
||||
}
|
||||
if len(builtProfiles) < 2 {
|
||||
t.Fatalf("want at least 2 provider builds (initial + escalated), got %d", len(builtProfiles))
|
||||
}
|
||||
for i, profile := range builtProfiles {
|
||||
if profile.APIKey != "sk-stored-escalation" {
|
||||
t.Fatalf("provider build %d APIKey = %q, want the stored key (escalated build went out keyless)", i, profile.APIKey)
|
||||
}
|
||||
}
|
||||
}
|
||||
@@ -365,6 +365,9 @@ func runExec(args []string, stdout io.Writer, stderr io.Writer, deps appDeps) in
|
||||
var modelSwitcher func(context.Context, string) (agent.Provider, error)
|
||||
if options.allowEscalation {
|
||||
modelSwitcher = func(_ context.Context, modelID string) (agent.Provider, error) {
|
||||
// deps.newProvider is wrapped (fillAppDeps) to apply the stored key, so
|
||||
// the escalated provider is authenticated even though resolved.Provider
|
||||
// is the pure profile — no per-site key handling here.
|
||||
switchedProfile := resolved.Provider
|
||||
switchedProfile.Model = modelID
|
||||
switchedProvider, err := deps.newProvider(switchedProfile)
|
||||
|
||||
@@ -24,6 +24,7 @@ func TestProviderHasOAuthLogin(t *testing.T) {
|
||||
|
||||
func TestSetupRequiredRecognizesOAuthLogin(t *testing.T) {
|
||||
path := filepath.Join(t.TempDir(), "tok.json")
|
||||
t.Setenv("ZERO_OAUTH_STORAGE", "file") // an inherited "keyring" would ignore the temp path and hit the OS keychain
|
||||
t.Setenv("ZERO_OAUTH_TOKENS_PATH", path)
|
||||
store, err := oauth.NewStore(oauth.StoreOptions{FilePath: path})
|
||||
if err != nil {
|
||||
@@ -45,3 +46,88 @@ func TestSetupRequiredRecognizesOAuthLogin(t *testing.T) {
|
||||
t.Fatal("a keyless provider with no OAuth login must require onboarding")
|
||||
}
|
||||
}
|
||||
|
||||
// A profile renamed away from its catalog ID must still get a runtime OAuth
|
||||
// resolver when the login is stored under the catalog name — and a CASE-VARIANT
|
||||
// profile name must not drop the catalog-ID candidate (the store is
|
||||
// case-sensitive; a case-insensitive dedupe would swallow it).
|
||||
func TestOAuthResolverForProfileFallsBackToCatalogID(t *testing.T) {
|
||||
path := filepath.Join(t.TempDir(), "tok.json")
|
||||
t.Setenv("ZERO_OAUTH_STORAGE", "file") // an inherited "keyring" would ignore the temp path and hit the OS keychain
|
||||
t.Setenv("ZERO_OAUTH_TOKENS_PATH", path)
|
||||
store, err := oauth.NewStore(oauth.StoreOptions{FilePath: path})
|
||||
if err != nil {
|
||||
t.Fatalf("NewStore: %v", err)
|
||||
}
|
||||
if err := store.Save(oauth.ProviderKey("chatgpt"), oauth.Token{AccessToken: "tok", ExpiresAt: time.Now().Add(time.Hour)}); err != nil {
|
||||
t.Fatalf("seed token: %v", err)
|
||||
}
|
||||
|
||||
// A renamed profile resolves the catalog-ID login, and the returned key MUST be
|
||||
// that login's key — the same key the Codex account-header resolver reads from,
|
||||
// so bearer and account can never come from different logins.
|
||||
if resolver, key := oauthLoginForProfile(config.ProviderProfile{Name: "codex", CatalogID: "chatgpt"}); resolver == nil {
|
||||
t.Fatal("renamed profile with a catalog-ID login must get a resolver (unauthenticated-children regression)")
|
||||
} else if key != oauth.ProviderKey("chatgpt") {
|
||||
t.Fatalf("bound key = %q, want the chatgpt login key (bearer/account must share it)", key)
|
||||
}
|
||||
// Name differs from catalog ID only in CASE: the exact-case store key is
|
||||
// "provider:chatgpt", so "chatgpt" must survive as a distinct candidate.
|
||||
if resolver, key := oauthLoginForProfile(config.ProviderProfile{Name: "ChatGPT", CatalogID: "chatgpt"}); resolver == nil {
|
||||
t.Fatal("case-variant profile name must still resolve the catalog-ID login (case-insensitive dedupe regression)")
|
||||
} else if key != oauth.ProviderKey("chatgpt") {
|
||||
t.Fatalf("case-variant bound key = %q, want the chatgpt login key", key)
|
||||
}
|
||||
if resolver, _ := oauthLoginForProfile(config.ProviderProfile{Name: "chatgpt", CatalogID: "chatgpt"}); resolver == nil {
|
||||
t.Fatal("catalog-named profile must get a resolver")
|
||||
}
|
||||
if resolver, key := oauthLoginForProfile(config.ProviderProfile{Name: "openai", CatalogID: "openai"}); resolver != nil || key != "" {
|
||||
t.Fatalf("a profile with no stored login must get no resolver and an empty key, got key=%q", key)
|
||||
}
|
||||
}
|
||||
|
||||
// The catalog-ID fallback must NOT reach a sibling profile's OAuth login when
|
||||
// this profile has its own key — withBearer would erase the key and silently
|
||||
// bill the model call under the sibling's account (a real cross-profile
|
||||
// override the fallback introduced). A profile WITH its own resolved key gets no
|
||||
// resolver even when a catalog-shared login exists.
|
||||
func TestOAuthResolverForProfileDoesNotOverrideExplicitKey(t *testing.T) {
|
||||
path := filepath.Join(t.TempDir(), "tok.json")
|
||||
t.Setenv("ZERO_OAUTH_STORAGE", "file") // an inherited "keyring" would ignore the temp path and hit the OS keychain
|
||||
t.Setenv("ZERO_OAUTH_TOKENS_PATH", path)
|
||||
store, err := oauth.NewStore(oauth.StoreOptions{FilePath: path})
|
||||
if err != nil {
|
||||
t.Fatalf("NewStore: %v", err)
|
||||
}
|
||||
// A personal login stored under the catalog name.
|
||||
if err := store.Save(oauth.ProviderKey("anthropic"), oauth.Token{AccessToken: "personal-tok", ExpiresAt: time.Now().Add(time.Hour)}); err != nil {
|
||||
t.Fatalf("seed token: %v", err)
|
||||
}
|
||||
|
||||
// Work profile: same catalog, its OWN resolved API key, deliberately NOT the
|
||||
// personal OAuth account. It must keep using its key (no resolver attached).
|
||||
work := config.ProviderProfile{Name: "anthropic-work", CatalogID: "anthropic", APIKey: "sk-work-key"}
|
||||
if resolver, key := oauthLoginForProfile(work); resolver != nil || key != "" {
|
||||
t.Fatalf("a profile with its own API key must not get a catalog-shared OAuth resolver (cross-profile override), got key=%q", key)
|
||||
}
|
||||
// A raw auth-header credential must be protected the same way.
|
||||
header := config.ProviderProfile{Name: "anthropic-hdr", CatalogID: "anthropic", AuthHeaderValue: "Bearer byo"}
|
||||
if resolver, _ := oauthLoginForProfile(header); resolver != nil {
|
||||
t.Fatal("a profile with its own auth header must not get a catalog-shared OAuth resolver")
|
||||
}
|
||||
// A same-NAME login must not override an explicit key either (the name
|
||||
// candidate is gated on the profile being keyless, not just the catalog one).
|
||||
if err := store.Save(oauth.ProviderKey("anthropic-work"), oauth.Token{AccessToken: "name-tok", ExpiresAt: time.Now().Add(time.Hour)}); err != nil {
|
||||
t.Fatalf("seed name token: %v", err)
|
||||
}
|
||||
if resolver, _ := oauthLoginForProfile(work); resolver != nil {
|
||||
t.Fatal("a profile with its own API key must not get an OAuth resolver even from a same-name login")
|
||||
}
|
||||
// Sanity: a keyless sibling on the same catalog DOES resolve the shared login.
|
||||
keyless := config.ProviderProfile{Name: "anthropic-oauth", CatalogID: "anthropic"}
|
||||
if resolver, key := oauthLoginForProfile(keyless); resolver == nil {
|
||||
t.Fatal("a keyless profile should still resolve the catalog-shared login")
|
||||
} else if key != oauth.ProviderKey("anthropic") {
|
||||
t.Fatalf("keyless sibling bound key = %q, want the catalog login key", key)
|
||||
}
|
||||
}
|
||||
@@ -4,7 +4,6 @@ import (
|
||||
"context"
|
||||
"errors"
|
||||
"net/http"
|
||||
"strings"
|
||||
"time"
|
||||
|
||||
"github.com/Gitlawb/zero/internal/config"
|
||||
@@ -12,42 +11,48 @@ import (
|
||||
"github.com/Gitlawb/zero/internal/providers/providerio"
|
||||
)
|
||||
|
||||
// providerOAuthName resolves the OAuth login name for a provider profile. It is
|
||||
// the name a user logs in under (`zero auth login <name>`) whose token then
|
||||
// authenticates this provider's model calls. For now it is the profile name;
|
||||
// the provider presets map well-known kinds (openai/anthropic) to canonical
|
||||
// names on top of this.
|
||||
func providerOAuthName(profile config.ProviderProfile) string {
|
||||
return strings.TrimSpace(profile.Name)
|
||||
}
|
||||
|
||||
// oauthResolverForProfile returns a TokenResolver that authenticates a provider's
|
||||
// model calls with the user's OAuth login, or nil when no login exists for this
|
||||
// provider. Returning nil for the no-login case keeps API-key users free of any
|
||||
// per-request store lookups: the resolver is only attached once a login is
|
||||
// present at construction time.
|
||||
func oauthResolverForProfile(profile config.ProviderProfile) providerio.TokenResolver {
|
||||
name := providerOAuthName(profile)
|
||||
if name == "" {
|
||||
return nil
|
||||
// oauthLoginForProfile resolves the user's OAuth login for a provider ONCE and
|
||||
// returns both a TokenResolver that authenticates model calls with it and the
|
||||
// credential-store key it bound to. It returns (nil, "") when no login exists —
|
||||
// keeping API-key users free of any per-request store lookups, since the resolver
|
||||
// is only attached when a login is present at construction time.
|
||||
//
|
||||
// The returned key is the single source of truth for "which login is this
|
||||
// provider using": callers pass it to providers.Options.OAuthLoginKey so the
|
||||
// Codex chatgpt-account-id header reads its account from the exact login that
|
||||
// issued the bearer token, instead of doing a second, independent lookup that
|
||||
// could select a different login (a backend-rejected mismatch).
|
||||
//
|
||||
// Candidate login names (profile name, then a catalog-ID fallback, both gated on
|
||||
// the profile having no own configured credential) come from the shared
|
||||
// ProviderProfile.OAuthLoginCandidates so the runtime resolver, the Codex account
|
||||
// resolver, and the onboarding presence check never diverge.
|
||||
func oauthLoginForProfile(profile config.ProviderProfile) (providerio.TokenResolver, string) {
|
||||
candidates := profile.OAuthLoginCandidates()
|
||||
if len(candidates) == 0 {
|
||||
return nil, ""
|
||||
}
|
||||
store, err := oauth.NewStore(oauth.StoreOptions{})
|
||||
if err != nil {
|
||||
return nil
|
||||
return nil, ""
|
||||
}
|
||||
key := oauth.ProviderKey(name)
|
||||
if _, ok, loadErr := store.Load(key); loadErr != nil || !ok {
|
||||
// No login (or an unreadable/invalid key) → API-key auth, no resolver.
|
||||
return nil
|
||||
_, key, ok := oauth.FirstStored(store, candidates)
|
||||
if !ok {
|
||||
// No login under any candidate (or unreadable/invalid keys) → API-key
|
||||
// auth, no resolver.
|
||||
return nil, ""
|
||||
}
|
||||
manager, err := oauth.NewManager(oauth.ManagerOptions{
|
||||
Store: store,
|
||||
HTTPClient: &http.Client{Timeout: 30 * time.Second},
|
||||
// Refreshing a token the user logged into (possibly a preset provider like
|
||||
// xAI) re-resolves that provider's OAuth config, which needs the preset.
|
||||
AllowPresets: true,
|
||||
})
|
||||
if err != nil {
|
||||
return nil
|
||||
return nil, ""
|
||||
}
|
||||
return func(ctx context.Context, forceRefresh bool) (string, string, bool, error) {
|
||||
resolver := func(ctx context.Context, forceRefresh bool) (string, string, bool, error) {
|
||||
var token string
|
||||
var rerr error
|
||||
if forceRefresh {
|
||||
@@ -64,4 +69,5 @@ func oauthResolverForProfile(profile config.ProviderProfile) providerio.TokenRes
|
||||
}
|
||||
return "Authorization", "Bearer " + token, true, nil
|
||||
}
|
||||
return resolver, key
|
||||
}
|
||||
@@ -488,7 +488,7 @@ func validateProviderRuntimeReady(profile config.ProviderProfile) error {
|
||||
}
|
||||
|
||||
func providerProfileHasCredential(profile config.ProviderProfile) bool {
|
||||
return strings.TrimSpace(profile.APIKey) != "" || profile.APIKeyStored || strings.TrimSpace(profile.AuthHeaderValue) != ""
|
||||
return profile.HasConfiguredCredential()
|
||||
}
|
||||
|
||||
func providerKindForDescriptor(descriptor providercatalog.Descriptor) config.ProviderKind {
|
||||
|
||||
@@ -314,10 +314,14 @@ func setupRequired(resolved config.ResolvedConfig) bool {
|
||||
}
|
||||
|
||||
// providerHasOAuthLogin reports whether a stored OAuth login exists for the
|
||||
// provider, keyed by its profile name or catalog id.
|
||||
// provider. It uses the same ProviderProfile.OAuthLoginCandidates the runtime
|
||||
// resolver does, so the "authenticated in the UI" gate and the "authenticated at
|
||||
// runtime" resolver can never diverge. This is only consulted for a profile with
|
||||
// no usable API-key credential (setupRequired returns early otherwise), where
|
||||
// the candidate set is permissive (profile name + catalog ID).
|
||||
func providerHasOAuthLogin(profile config.ProviderProfile, oauthLogins map[string]bool) bool {
|
||||
for _, name := range []string{strings.TrimSpace(profile.Name), strings.TrimSpace(profile.CatalogID)} {
|
||||
if name != "" && oauthLogins[name] {
|
||||
for _, name := range profile.OAuthLoginCandidates() {
|
||||
if oauthLogins[name] {
|
||||
return true
|
||||
}
|
||||
}
|
||||
|
||||
@@ -155,6 +155,63 @@ func MigratePlaintextProviderKeys(path string, store APIKeySetter) (int, error)
|
||||
return migrated, nil
|
||||
}
|
||||
|
||||
// HasConfiguredCredential reports whether the profile is set up to authenticate
|
||||
// with its own API key (inline, stored, or a raw auth header). It is the single
|
||||
// definition of "this profile is key-authed", shared by OAuthLoginCandidates and
|
||||
// the cli/tui setup surfaces so they never disagree about whether a profile is
|
||||
// keyed. APIKeyEnv is deliberately NOT included: an env var may be unset at
|
||||
// runtime while the profile actually relies on an OAuth login, so an
|
||||
// env-configured-but-empty profile must still be allowed to resolve a token.
|
||||
func (profile ProviderProfile) HasConfiguredCredential() bool {
|
||||
return strings.TrimSpace(profile.APIKey) != "" ||
|
||||
profile.APIKeyStored ||
|
||||
strings.TrimSpace(profile.AuthHeaderValue) != ""
|
||||
}
|
||||
|
||||
// OAuthLoginCandidates returns the login names to try, in order, when resolving
|
||||
// this profile's OAuth token — used by the runtime bearer resolver, the Codex
|
||||
// account-header resolver, and the onboarding presence check so all three agree.
|
||||
//
|
||||
// It returns NO candidates for a profile that carries its own configured
|
||||
// credential: attaching an OAuth resolver to such a profile makes withBearer
|
||||
// erase the key the instant a token resolves, silently routing/billing the call
|
||||
// through the OAuth account instead of the intended key (the cross-profile
|
||||
// override the review caught — and, via the profile name, a same-name login
|
||||
// overriding an explicit key). A stored-key profile that reaches this keyless
|
||||
// (e.g. a transiently unreadable keyring) is likewise treated as key-auth, so it
|
||||
// fails with a clear missing-credential error rather than silently borrowing an
|
||||
// unrelated OAuth login. APIKeyEnv is intentionally not part of that gate (an
|
||||
// env var may be unset while the profile relies on OAuth).
|
||||
//
|
||||
// For a keyless profile the profile name comes first (a login under your own
|
||||
// profile name is unambiguously yours), then the catalog ID as a FALLBACK (so a
|
||||
// profile renamed away from its catalog ID — e.g. {name:"codex",
|
||||
// catalogID:"chatgpt"} — still finds a `zero auth login chatgpt` token).
|
||||
// Candidates are trimmed, blank-skipped, and de-duplicated CASE-SENSITIVELY — the
|
||||
// OAuth token store is a case-sensitive map, so "ChatGPT" and "chatgpt" are
|
||||
// distinct keys and both must survive.
|
||||
func (profile ProviderProfile) OAuthLoginCandidates() []string {
|
||||
if profile.HasConfiguredCredential() {
|
||||
return nil
|
||||
}
|
||||
var names []string
|
||||
add := func(s string) {
|
||||
s = strings.TrimSpace(s)
|
||||
if s == "" {
|
||||
return
|
||||
}
|
||||
for _, existing := range names {
|
||||
if existing == s { // case-sensitive: the store lookup is case-sensitive
|
||||
return
|
||||
}
|
||||
}
|
||||
names = append(names, s)
|
||||
}
|
||||
add(profile.Name)
|
||||
add(profile.CatalogID)
|
||||
return names
|
||||
}
|
||||
|
||||
// ApplyStoredAPIKey fills profile.APIKey from the credential store when it is not
|
||||
// already resolved — an inline config key or a resolved APIKeyEnv always wins, so
|
||||
// this only supplies a key for providers whose secret lives in the store. A nil
|
||||
|
||||
@@ -172,3 +172,69 @@ func TestProviderProfileAPIKeyStoredRoundTrips(t *testing.T) {
|
||||
t.Fatalf("no inline key expected, got %q", p.APIKey)
|
||||
}
|
||||
}
|
||||
|
||||
// OAuthLoginCandidates always offers the profile name, adds the catalog ID as a
|
||||
// fallback ONLY when the profile has no effective own credential, and dedupes
|
||||
// case-sensitively (the OAuth store is a case-sensitive map).
|
||||
func TestOAuthLoginCandidates(t *testing.T) {
|
||||
cases := []struct {
|
||||
name string
|
||||
profile ProviderProfile
|
||||
want []string
|
||||
}{
|
||||
{
|
||||
name: "renamed keyless profile falls back to catalog id",
|
||||
profile: ProviderProfile{Name: "codex", CatalogID: "chatgpt"},
|
||||
want: []string{"codex", "chatgpt"},
|
||||
},
|
||||
{
|
||||
name: "case-variant name keeps distinct catalog-id candidate",
|
||||
profile: ProviderProfile{Name: "ChatGPT", CatalogID: "chatgpt"},
|
||||
want: []string{"ChatGPT", "chatgpt"},
|
||||
},
|
||||
{
|
||||
name: "exact-duplicate name and catalog id collapse",
|
||||
profile: ProviderProfile{Name: "chatgpt", CatalogID: "chatgpt"},
|
||||
want: []string{"chatgpt"},
|
||||
},
|
||||
{
|
||||
// A configured key must block ALL candidates (name included): a login
|
||||
// under the profile's own name would otherwise erase the key too.
|
||||
name: "own inline key blocks every candidate",
|
||||
profile: ProviderProfile{Name: "anthropic-work", CatalogID: "anthropic", APIKey: "sk-work"},
|
||||
want: nil,
|
||||
},
|
||||
{
|
||||
name: "own auth header blocks every candidate",
|
||||
profile: ProviderProfile{Name: "acme", CatalogID: "anthropic", AuthHeaderValue: "Bearer x"},
|
||||
want: nil,
|
||||
},
|
||||
{
|
||||
// APIKeyStored means key-auth even if the key isn't loaded here (e.g. a
|
||||
// transiently unreadable keyring): don't silently borrow an OAuth login.
|
||||
name: "stored-key profile blocks every candidate",
|
||||
profile: ProviderProfile{Name: "openai-stored", CatalogID: "openai", APIKeyStored: true},
|
||||
want: nil,
|
||||
},
|
||||
{
|
||||
// APIKeyEnv is NOT a configured credential for gating: the env var may be
|
||||
// unset while the profile relies on an OAuth login, so candidates stand.
|
||||
name: "env-only profile still yields candidates",
|
||||
profile: ProviderProfile{Name: "xai", CatalogID: "xai", APIKeyEnv: "XAI_API_KEY"},
|
||||
want: []string{"xai"},
|
||||
},
|
||||
{
|
||||
name: "empty profile yields no candidates",
|
||||
profile: ProviderProfile{},
|
||||
want: nil,
|
||||
},
|
||||
}
|
||||
for _, c := range cases {
|
||||
t.Run(c.name, func(t *testing.T) {
|
||||
got := c.profile.OAuthLoginCandidates()
|
||||
if strings.Join(got, ",") != strings.Join(c.want, ",") {
|
||||
t.Fatalf("OAuthLoginCandidates() = %#v, want %#v", got, c.want)
|
||||
}
|
||||
})
|
||||
}
|
||||
}
|
||||
+39
-21
@@ -1,11 +1,11 @@
|
||||
package mcp
|
||||
|
||||
import (
|
||||
"bytes"
|
||||
"context"
|
||||
"encoding/json"
|
||||
"errors"
|
||||
"fmt"
|
||||
"io"
|
||||
"net/http"
|
||||
"net/http/httptest"
|
||||
"os"
|
||||
@@ -393,28 +393,43 @@ func TestConnectRejectsUnsupportedTransport(t *testing.T) {
|
||||
}
|
||||
|
||||
func TestClientRequestWaitsForMatchingResponseID(t *testing.T) {
|
||||
var incoming bytes.Buffer
|
||||
incomingWriter := newMessageWriter(&incoming)
|
||||
if err := incomingWriter.write(rpcMessage{Method: "notifications/progress"}); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
if err := incomingWriter.write(rpcMessage{
|
||||
ID: 99,
|
||||
Error: &rpcError{Code: -32000, Message: "wrong response"},
|
||||
}); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
if err := incomingWriter.write(rpcMessage{
|
||||
ID: 1,
|
||||
Result: mustRaw(map[string]any{"value": "matched"}),
|
||||
}); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
// Pipes, not a pre-filled bytes.Buffer: the fake server responds only AFTER
|
||||
// reading the outgoing request, matching production ordering. With responses
|
||||
// pre-loaded, the client's reader goroutine could consume the matching
|
||||
// response — and hit EOF — before request() registered its pending id,
|
||||
// flaking as "request() error = EOF" on fast runners.
|
||||
serverReader, clientWriter := io.Pipe() // client → server
|
||||
clientReader, serverWriter := io.Pipe() // server → client
|
||||
t.Cleanup(func() {
|
||||
_ = clientWriter.Close()
|
||||
_ = serverWriter.Close()
|
||||
})
|
||||
|
||||
serverErr := make(chan error, 1)
|
||||
go func() {
|
||||
requests := newMessageReader(serverReader)
|
||||
request, err := requests.read()
|
||||
if err != nil {
|
||||
serverErr <- err
|
||||
return
|
||||
}
|
||||
responses := newMessageWriter(serverWriter)
|
||||
for _, message := range []rpcMessage{
|
||||
{Method: "notifications/progress"},
|
||||
{ID: 99, Error: &rpcError{Code: -32000, Message: "wrong response"}},
|
||||
{ID: request.ID, Result: mustRaw(map[string]any{"value": "matched"})},
|
||||
} {
|
||||
if err := responses.write(message); err != nil {
|
||||
serverErr <- err
|
||||
return
|
||||
}
|
||||
}
|
||||
serverErr <- nil
|
||||
}()
|
||||
|
||||
var outgoing bytes.Buffer
|
||||
client := &Client{
|
||||
reader: newMessageReader(&incoming),
|
||||
writer: newMessageWriter(&outgoing),
|
||||
reader: newMessageReader(clientReader),
|
||||
writer: newMessageWriter(clientWriter),
|
||||
nextID: 1,
|
||||
}
|
||||
var result struct {
|
||||
@@ -426,6 +441,9 @@ func TestClientRequestWaitsForMatchingResponseID(t *testing.T) {
|
||||
if result.Value != "matched" {
|
||||
t.Fatalf("result.Value = %q, want matched response", result.Value)
|
||||
}
|
||||
if err := <-serverErr; err != nil {
|
||||
t.Fatalf("fake server error: %v", err)
|
||||
}
|
||||
}
|
||||
|
||||
type errorCloser struct {
|
||||
|
||||
@@ -44,10 +44,17 @@ type Manager struct {
|
||||
|
||||
// ManagerOptions configures a Manager.
|
||||
type ManagerOptions struct {
|
||||
Store *Store
|
||||
Registry *Registry
|
||||
HTTPClient *http.Client
|
||||
Env map[string]string
|
||||
Store *Store
|
||||
Registry *Registry
|
||||
HTTPClient *http.Client
|
||||
Env map[string]string
|
||||
// AllowPresets opts this manager into the baked-in OAuth presets without the
|
||||
// operator exporting ZERO_OAUTH_ALLOW_PRESETS — used by the interactive wizard
|
||||
// and CLI login (and the runtime token refresh) for a provider the user chose
|
||||
// to sign into, whose preset client identity is public (e.g. xAI). It layers the
|
||||
// flag onto Env (or the process environment when Env is nil), preserving any
|
||||
// ZERO_OAUTH_<NAME>_* overrides. Leave false for hermetic tests.
|
||||
AllowPresets bool
|
||||
Now func() time.Time
|
||||
RefreshBuffer time.Duration
|
||||
Out io.Writer
|
||||
@@ -83,9 +90,13 @@ func NewManager(opts ManagerOptions) (*Manager, error) {
|
||||
if open == nil {
|
||||
open = func(string) error { return nil }
|
||||
}
|
||||
env := opts.Env
|
||||
if opts.AllowPresets {
|
||||
env = envWithPresetsAllowed(env)
|
||||
}
|
||||
return &Manager{
|
||||
store: opts.Store, registry: registry, client: client,
|
||||
env: opts.Env, now: now, buffer: buffer, out: out, openBrowser: open,
|
||||
env: env, now: now, buffer: buffer, out: out, openBrowser: open,
|
||||
}, nil
|
||||
}
|
||||
|
||||
|
||||
@@ -52,6 +52,30 @@ func managerFor(t *testing.T, env map[string]string, openBrowser func(string) er
|
||||
return m
|
||||
}
|
||||
|
||||
// AllowPresets layers the opt-in onto the manager's env so a login/refresh for a
|
||||
// preset provider resolves; without it (and no Env) the env stays nil so callers
|
||||
// and tests remain hermetic.
|
||||
func TestNewManagerAllowPresetsForcesOptIn(t *testing.T) {
|
||||
store, err := NewStore(StoreOptions{FilePath: filepath.Join(t.TempDir(), "tok.json")})
|
||||
if err != nil {
|
||||
t.Fatalf("NewStore: %v", err)
|
||||
}
|
||||
m, err := NewManager(ManagerOptions{Store: store, AllowPresets: true})
|
||||
if err != nil {
|
||||
t.Fatalf("NewManager: %v", err)
|
||||
}
|
||||
if m.env["ZERO_OAUTH_ALLOW_PRESETS"] != "1" {
|
||||
t.Fatalf("AllowPresets should force the opt-in; got env[%q]=%q", "ZERO_OAUTH_ALLOW_PRESETS", m.env["ZERO_OAUTH_ALLOW_PRESETS"])
|
||||
}
|
||||
m2, err := NewManager(ManagerOptions{Store: store})
|
||||
if err != nil {
|
||||
t.Fatalf("NewManager: %v", err)
|
||||
}
|
||||
if m2.env != nil {
|
||||
t.Fatalf("env should stay nil without AllowPresets, got %v", m2.env)
|
||||
}
|
||||
}
|
||||
|
||||
func TestManagerLoginLoopback(t *testing.T) {
|
||||
fp := newFakeProvider(t, `{"access_token":"at","refresh_token":"rt","token_type":"Bearer","expires_in":3600}`)
|
||||
env := map[string]string{
|
||||
|
||||
@@ -1,6 +1,33 @@
|
||||
package oauth
|
||||
|
||||
import "strings"
|
||||
import (
|
||||
"os"
|
||||
"strings"
|
||||
)
|
||||
|
||||
// envWithPresetsAllowed returns an env map that opts into the baked-in presets
|
||||
// (as if ZERO_OAUTH_ALLOW_PRESETS=1 were exported) so an interactive wizard/CLI
|
||||
// login for a well-known public client (e.g. xAI) can use the preset without the
|
||||
// operator setting the flag themselves. It copies base — or snapshots the process
|
||||
// environment when base is nil — because envValue treats a non-nil map as hermetic
|
||||
// (a missing key does NOT fall back to os.Getenv), so a partial map would silently
|
||||
// drop the operator's ZERO_OAUTH_<NAME>_* overrides. The flag is then forced on.
|
||||
func envWithPresetsAllowed(base map[string]string) map[string]string {
|
||||
env := make(map[string]string, len(base)+1)
|
||||
if base == nil {
|
||||
for _, kv := range os.Environ() {
|
||||
if eq := strings.IndexByte(kv, '='); eq > 0 {
|
||||
env[kv[:eq]] = kv[eq+1:]
|
||||
}
|
||||
}
|
||||
} else {
|
||||
for k, v := range base {
|
||||
env[k] = v
|
||||
}
|
||||
}
|
||||
env["ZERO_OAUTH_ALLOW_PRESETS"] = "1"
|
||||
return env
|
||||
}
|
||||
|
||||
// providerPreset is a baked-in default OAuth configuration for a well-known
|
||||
// provider. Every field is overridable per provider via ZERO_OAUTH_<NAME>_*
|
||||
|
||||
@@ -46,6 +46,46 @@ func TestResolveConfigUsesXAIPreset(t *testing.T) {
|
||||
}
|
||||
}
|
||||
|
||||
// envWithPresetsAllowed lets a caller (the wizard / CLI login / runtime refresh)
|
||||
// opt into the preset without exporting ZERO_OAUTH_ALLOW_PRESETS: an otherwise-inert
|
||||
// xAI config now resolves from the baked-in preset.
|
||||
func TestEnvWithPresetsAllowedEnablesPreset(t *testing.T) {
|
||||
r := NewRegistry()
|
||||
// Baseline: a hermetic empty map keeps the preset inert.
|
||||
if _, _, err := r.ResolveConfig("xai", map[string]string{}); err == nil {
|
||||
t.Fatal("xai should not resolve without the opt-in")
|
||||
}
|
||||
// The helper forces the opt-in so the preset resolves.
|
||||
cfg, _, err := r.ResolveConfig("xai", envWithPresetsAllowed(map[string]string{}))
|
||||
if err != nil {
|
||||
t.Fatalf("envWithPresetsAllowed should enable the xai preset: %v", err)
|
||||
}
|
||||
if cfg.ClientID != "b1a00492-073a-47ea-816f-4c329264a828" {
|
||||
t.Fatalf("client_id = %q", cfg.ClientID)
|
||||
}
|
||||
}
|
||||
|
||||
// The helper copies the base map (never mutating it) and keeps ZERO_OAUTH_<NAME>_*
|
||||
// overrides — critical because envValue treats a non-nil map as hermetic, so a
|
||||
// partial map would silently drop them.
|
||||
func TestEnvWithPresetsAllowedPreservesOverrides(t *testing.T) {
|
||||
base := map[string]string{"ZERO_OAUTH_XAI_CLIENT_ID": "custom-id"}
|
||||
env := envWithPresetsAllowed(base)
|
||||
if env["ZERO_OAUTH_ALLOW_PRESETS"] != "1" {
|
||||
t.Fatalf("opt-in flag not set: %v", env)
|
||||
}
|
||||
if _, mutated := base["ZERO_OAUTH_ALLOW_PRESETS"]; mutated {
|
||||
t.Fatal("envWithPresetsAllowed mutated the caller's base map")
|
||||
}
|
||||
cfg, _, err := NewRegistry().ResolveConfig("xai", env)
|
||||
if err != nil {
|
||||
t.Fatalf("ResolveConfig with override env: %v", err)
|
||||
}
|
||||
if cfg.ClientID != "custom-id" {
|
||||
t.Fatalf("override dropped through the helper: client_id = %q", cfg.ClientID)
|
||||
}
|
||||
}
|
||||
|
||||
func TestResolveConfigEnvOverridesPreset(t *testing.T) {
|
||||
r := NewRegistry()
|
||||
env := map[string]string{
|
||||
|
||||
@@ -41,6 +41,26 @@ func ValidateKey(key string) error {
|
||||
// ProviderKey builds the store key for a provider login.
|
||||
func ProviderKey(name string) string { return KeyPrefixProvider + name }
|
||||
|
||||
// FirstStored returns the token and its ProviderKey for the FIRST candidate name
|
||||
// that has a token in the store, with ok=false when none do. Callers pass
|
||||
// ProviderProfile.OAuthLoginCandidates() so that everything derived from a login
|
||||
// — the bearer token AND any header claim like chatgpt-account-id — comes from
|
||||
// the SAME login; selecting independently per consumer could otherwise pair a
|
||||
// bearer from one login with an account header from another. A load error on a
|
||||
// candidate is treated as a miss (skip to the next), never a hard failure.
|
||||
func FirstStored(store *Store, candidates []string) (Token, string, bool) {
|
||||
if store == nil {
|
||||
return Token{}, "", false
|
||||
}
|
||||
for _, name := range candidates {
|
||||
key := ProviderKey(name)
|
||||
if token, ok, err := store.Load(key); err == nil && ok {
|
||||
return token, key, true
|
||||
}
|
||||
}
|
||||
return Token{}, "", false
|
||||
}
|
||||
|
||||
// Status is a redaction-safe summary of a stored token (no secret material).
|
||||
type Status struct {
|
||||
Key string `json:"key"`
|
||||
|
||||
@@ -85,6 +85,104 @@ func Discover(ctx context.Context, profile config.ProviderProfile, options Optio
|
||||
}
|
||||
}
|
||||
|
||||
// DiscoverOllamaContextWindow asks a local Ollama daemon for a model's context
|
||||
// length via its native /api/show endpoint. The generic /v1/models probe
|
||||
// (parseModelsResponse) only ever returns id/description — OpenAI-compatible
|
||||
// listings don't carry context-window metadata, and a custom/local model tag
|
||||
// (e.g. a user's own Ollama pull, including a ":cloud"-tagged model proxied
|
||||
// through the local daemon) has no curated-catalog entry to borrow one from
|
||||
// either, so modelContextWindow has nothing to show for it without this. Only
|
||||
// meaningful for the local Ollama provider (baseURL like
|
||||
// http://localhost:11434/v1) — Ollama Cloud's hosted API is a different
|
||||
// service and isn't assumed to expose the same endpoint.
|
||||
func DiscoverOllamaContextWindow(ctx context.Context, baseURL string, model string, options Options) (int, error) {
|
||||
model = strings.TrimSpace(model)
|
||||
if model == "" {
|
||||
return 0, fmt.Errorf("model name is required")
|
||||
}
|
||||
endpoint, err := ollamaShowEndpoint(baseURL)
|
||||
if err != nil {
|
||||
return 0, err
|
||||
}
|
||||
payload, err := json.Marshal(struct {
|
||||
Model string `json:"model"`
|
||||
}{Model: model})
|
||||
if err != nil {
|
||||
return 0, err
|
||||
}
|
||||
request, err := http.NewRequestWithContext(ctx, http.MethodPost, endpoint, strings.NewReader(string(payload)))
|
||||
if err != nil {
|
||||
return 0, err
|
||||
}
|
||||
request.Header.Set("Content-Type", "application/json")
|
||||
request.Header.Set("Accept", "application/json")
|
||||
|
||||
client := options.HTTPClient
|
||||
if client == nil {
|
||||
client = &http.Client{Timeout: 10 * time.Second}
|
||||
}
|
||||
response, err := client.Do(request)
|
||||
if err != nil {
|
||||
return 0, err
|
||||
}
|
||||
defer response.Body.Close()
|
||||
|
||||
body, err := io.ReadAll(io.LimitReader(response.Body, 1<<20))
|
||||
if err != nil {
|
||||
return 0, err
|
||||
}
|
||||
if response.StatusCode < 200 || response.StatusCode >= 300 {
|
||||
return 0, fmt.Errorf("ollama show endpoint returned %s: %s", response.Status, strings.TrimSpace(string(body)))
|
||||
}
|
||||
return parseOllamaShowContextWindow(body)
|
||||
}
|
||||
|
||||
// ollamaShowEndpoint derives the native Ollama API root from the
|
||||
// OpenAI-compatible base URL Zero stores for the provider (".../v1") and
|
||||
// appends /api/show.
|
||||
func ollamaShowEndpoint(baseURL string) (string, error) {
|
||||
baseURL = strings.TrimSpace(baseURL)
|
||||
if baseURL == "" {
|
||||
return "", fmt.Errorf("provider base URL is required for ollama model discovery")
|
||||
}
|
||||
parsed, err := url.Parse(baseURL)
|
||||
if err != nil || parsed.Scheme == "" || parsed.Host == "" {
|
||||
return "", fmt.Errorf("invalid provider base URL %q", baseURL)
|
||||
}
|
||||
path := strings.TrimRight(parsed.Path, "/")
|
||||
path = strings.TrimSuffix(path, "/v1")
|
||||
parsed.Path = strings.TrimRight(path, "/") + "/api/show"
|
||||
parsed.RawQuery = ""
|
||||
parsed.Fragment = ""
|
||||
return parsed.String(), nil
|
||||
}
|
||||
|
||||
// parseOllamaShowContextWindow extracts the context length from an
|
||||
// /api/show response. Ollama reports it under model_info with an
|
||||
// architecture-prefixed key (e.g. "llama.context_length",
|
||||
// "qwen2.context_length") — the prefix varies by model family, so this scans
|
||||
// for any key ending in ".context_length" rather than hardcoding one.
|
||||
func parseOllamaShowContextWindow(body []byte) (int, error) {
|
||||
// model_info mixes value types (strings like "general.architecture", numbers
|
||||
// like "*.context_length"), so decode values generically and only try to
|
||||
// read a number out of the one key we actually care about.
|
||||
var payload struct {
|
||||
ModelInfo map[string]any `json:"model_info"`
|
||||
}
|
||||
if err := json.Unmarshal(body, &payload); err != nil {
|
||||
return 0, fmt.Errorf("decode ollama show response: %w", err)
|
||||
}
|
||||
for key, value := range payload.ModelInfo {
|
||||
if !strings.HasSuffix(key, ".context_length") {
|
||||
continue
|
||||
}
|
||||
if window, ok := value.(float64); ok && window > 0 {
|
||||
return int(window), nil
|
||||
}
|
||||
}
|
||||
return 0, fmt.Errorf("ollama show response did not report a context length")
|
||||
}
|
||||
|
||||
func discoverOpenAIModels(ctx context.Context, profile config.ProviderProfile, options Options) ([]Model, error) {
|
||||
endpoint, err := modelsEndpoint(profile.BaseURL)
|
||||
if err != nil {
|
||||
|
||||
@@ -2,6 +2,7 @@ package providermodeldiscovery
|
||||
|
||||
import (
|
||||
"context"
|
||||
"io"
|
||||
"net/http"
|
||||
"net/http/httptest"
|
||||
"strings"
|
||||
@@ -267,3 +268,61 @@ func modelIDs(models []Model) []string {
|
||||
}
|
||||
return ids
|
||||
}
|
||||
|
||||
// TestDiscoverOllamaContextWindowFetchesFromNativeShowEndpoint: the generic
|
||||
// /v1/models probe never carries context-window metadata (parseModelsResponse
|
||||
// only extracts id/description), so a custom/local Ollama model tag with no
|
||||
// curated-catalog match has no other source for it. This exercises the
|
||||
// Ollama-native /api/show fallback that fills that gap.
|
||||
func TestDiscoverOllamaContextWindowFetchesFromNativeShowEndpoint(t *testing.T) {
|
||||
var gotPath, gotMethod, gotBody string
|
||||
server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
||||
gotPath = r.URL.Path
|
||||
gotMethod = r.Method
|
||||
body, _ := io.ReadAll(r.Body)
|
||||
gotBody = string(body)
|
||||
w.Header().Set("Content-Type", "application/json")
|
||||
_, _ = w.Write([]byte(`{
|
||||
"model_info": {
|
||||
"general.architecture": "qwen2",
|
||||
"qwen2.context_length": 131072
|
||||
}
|
||||
}`))
|
||||
}))
|
||||
defer server.Close()
|
||||
|
||||
window, err := DiscoverOllamaContextWindow(context.Background(), server.URL+"/v1", "kimi-k2.7-code:cloud", Options{HTTPClient: server.Client()})
|
||||
if err != nil {
|
||||
t.Fatalf("DiscoverOllamaContextWindow returned error: %v", err)
|
||||
}
|
||||
if window != 131072 {
|
||||
t.Fatalf("context window = %d, want 131072", window)
|
||||
}
|
||||
if gotPath != "/api/show" {
|
||||
t.Fatalf("requested path = %q, want /api/show (not under /v1)", gotPath)
|
||||
}
|
||||
if gotMethod != http.MethodPost {
|
||||
t.Fatalf("method = %q, want POST", gotMethod)
|
||||
}
|
||||
if !strings.Contains(gotBody, `"kimi-k2.7-code:cloud"`) {
|
||||
t.Fatalf("request body = %q, want it to name the model", gotBody)
|
||||
}
|
||||
}
|
||||
|
||||
func TestDiscoverOllamaContextWindowRequiresModelName(t *testing.T) {
|
||||
if _, err := DiscoverOllamaContextWindow(context.Background(), "http://localhost:11434/v1", "", Options{}); err == nil {
|
||||
t.Fatal("expected an error for an empty model name")
|
||||
}
|
||||
}
|
||||
|
||||
func TestDiscoverOllamaContextWindowErrorsWhenShowOmitsContextLength(t *testing.T) {
|
||||
server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
||||
w.Header().Set("Content-Type", "application/json")
|
||||
_, _ = w.Write([]byte(`{"model_info": {"general.architecture": "qwen2"}}`))
|
||||
}))
|
||||
defer server.Close()
|
||||
|
||||
if _, err := DiscoverOllamaContextWindow(context.Background(), server.URL+"/v1", "some-model", Options{HTTPClient: server.Client()}); err == nil {
|
||||
t.Fatal("expected an error when no *.context_length key is present")
|
||||
}
|
||||
}
|
||||
@@ -26,6 +26,13 @@ type Options struct {
|
||||
// OAuth bearer token (preferred over the API key). nil => API-key auth only.
|
||||
// Applied to the OpenAI and Anthropic providers.
|
||||
OAuthResolver providerio.TokenResolver
|
||||
// OAuthLoginKey is the credential-store key OAuthResolver bound to (empty when
|
||||
// there is no OAuth login). It is the SAME selection the bearer resolver made,
|
||||
// resolved ONCE by the caller so the Codex chatgpt-account-id header reads its
|
||||
// account from the exact login that issued the bearer token — never a second,
|
||||
// independent lookup that could pick a different login (a backend-rejected
|
||||
// mismatch).
|
||||
OAuthLoginKey string
|
||||
}
|
||||
|
||||
// New creates a runtime provider for a resolved provider profile.
|
||||
@@ -251,14 +258,22 @@ func isCodexCatalog(profile config.ProviderProfile, _ resolvedProfile) bool {
|
||||
|
||||
// newCodexProvider builds a Codex-flavored openai provider for the chatgpt
|
||||
// catalog. The Codex headers (`originator`, `chatgpt-account-id`) are
|
||||
// injected by the CodexProvider wrapper. The `chatgpt-account-id` is
|
||||
// resolved dynamically from the stored OAuth token's Account field on
|
||||
// every request so a refresh that rotates the token (and its account
|
||||
// claim) takes effect immediately — a static AccountID captured at
|
||||
// construction would go stale on the first refresh.
|
||||
// injected by the CodexProvider wrapper. The `chatgpt-account-id` is read from
|
||||
// the stored OAuth token's Account field on every request so a refresh that
|
||||
// rotates the token (and its account claim) takes effect immediately — a static
|
||||
// AccountID captured at construction would go stale on the first refresh.
|
||||
//
|
||||
// The *login* the header reads from is options.OAuthLoginKey — the SAME key the
|
||||
// bearer resolver bound, resolved ONCE by the caller. The bearer resolver
|
||||
// refreshes the token in place under that key; reading the account from the same
|
||||
// key keeps header and token on one login for the provider's life. Resolving the
|
||||
// key independently here (a second oauth.FirstStored) could, after a transient
|
||||
// per-candidate load error or a mid-session `zero auth login`, pick a different
|
||||
// login than the bearer — a mismatch the backend rejects.
|
||||
func newCodexProvider(profile config.ProviderProfile, resolved resolvedProfile, options Options) (zeroruntime.Provider, error) {
|
||||
accountKey := options.OAuthLoginKey
|
||||
resolver := openai.CodexAccountResolver(func(ctx context.Context) (string, bool, error) {
|
||||
account := codexAccountFromStore(profile.Name)
|
||||
account := codexAccountForKey(accountKey)
|
||||
if account == "" {
|
||||
return "", false, nil
|
||||
}
|
||||
@@ -288,17 +303,20 @@ func newCodexProvider(profile config.ProviderProfile, resolved resolvedProfile,
|
||||
})
|
||||
}
|
||||
|
||||
// codexAccountFromStore reads the chatgpt_account_id from the stored OAuth
|
||||
// token for the given provider name. It is called per-request (via the
|
||||
// resolver) so a refresh that rotates the token takes effect immediately
|
||||
// without restarting the agent. Returns "" when no token is stored (the
|
||||
// Codex provider then omits the header and the user sees a clear 401).
|
||||
func codexAccountFromStore(providerName string) string {
|
||||
// codexAccountForKey reads the chatgpt_account_id from the token currently
|
||||
// stored under key. Called per-request (via the resolver) so a refresh that
|
||||
// rotates the token — saved back in place under the same key — takes effect
|
||||
// immediately without restarting the agent. Returns "" when key is empty (no
|
||||
// OAuth login), or the token is absent or carries no account claim.
|
||||
func codexAccountForKey(key string) string {
|
||||
if key == "" {
|
||||
return ""
|
||||
}
|
||||
store, err := oauth.NewStore(oauth.StoreOptions{})
|
||||
if err != nil {
|
||||
return ""
|
||||
}
|
||||
token, ok, err := store.Load(oauth.ProviderKey(providerName))
|
||||
token, ok, err := store.Load(key)
|
||||
if err != nil || !ok {
|
||||
return ""
|
||||
}
|
||||
|
||||
@@ -269,6 +269,7 @@ func TestNewRoutesChatGPTCatalogToCodexProvider(t *testing.T) {
|
||||
// OAuth token and the "want empty chatgpt-account-id" assertion fails locally
|
||||
// (it still passes in CI, where no login is stored). Mirrors the isolation in
|
||||
// TestNewRoutesChatGPTCatalogWithStoredAccountID.
|
||||
t.Setenv("ZERO_OAUTH_STORAGE", "file")
|
||||
t.Setenv("ZERO_OAUTH_TOKENS_PATH", t.TempDir()+"/tokens.json")
|
||||
|
||||
transport := &captureTransport{
|
||||
@@ -322,11 +323,10 @@ func TestNewRoutesChatGPTCatalogToCodexProvider(t *testing.T) {
|
||||
|
||||
func TestNewRoutesChatGPTCatalogWithStoredAccountID(t *testing.T) {
|
||||
// The factory reads the stored OAuth token's Account field for the
|
||||
// chatgpt-account-id header. Seed a token in a temp store and point
|
||||
// ZERO_OAUTH_TOKENS_PATH at it so the factory picks it up.
|
||||
dir := t.TempDir()
|
||||
t.Setenv("ZERO_OAUTH_TOKENS_PATH", dir+"/tokens.json")
|
||||
store, err := newOAuthStoreForTest()
|
||||
// chatgpt-account-id header, from the login key the CALLER supplies in
|
||||
// Options.OAuthLoginKey (the same key the bearer resolver bound). Seed a
|
||||
// token in an isolated temp store, then pass that key.
|
||||
store, err := newOAuthStoreForTest(t)
|
||||
if err != nil {
|
||||
t.Fatalf("NewStore: %v", err)
|
||||
}
|
||||
@@ -344,8 +344,9 @@ func TestNewRoutesChatGPTCatalogWithStoredAccountID(t *testing.T) {
|
||||
CatalogID: "chatgpt",
|
||||
Model: "gpt-5",
|
||||
}, Options{
|
||||
HTTPClient: &http.Client{Transport: transport},
|
||||
UserAgent: "zero-factory-test",
|
||||
HTTPClient: &http.Client{Transport: transport},
|
||||
UserAgent: "zero-factory-test",
|
||||
OAuthLoginKey: oauth.ProviderKey("chatgpt"),
|
||||
})
|
||||
if err != nil {
|
||||
t.Fatalf("New() error = %v", err)
|
||||
@@ -407,10 +408,61 @@ func (transport *captureTransport) body() io.Reader {
|
||||
return strings.NewReader(transport.requestBody)
|
||||
}
|
||||
|
||||
// newOAuthStoreForTest builds a Store pointed at the current
|
||||
// ZERO_OAUTH_TOKENS_PATH (set by the caller). It exists so the chatgpt
|
||||
// factory tests can seed a token without copying the path-handling dance
|
||||
// from internal/cli.
|
||||
func newOAuthStoreForTest() (*oauth.Store, error) {
|
||||
// newOAuthStoreForTest pins the OAuth token store to a plain temp FILE and
|
||||
// returns a Store on it. Pinning ZERO_OAUTH_STORAGE matters as much as the
|
||||
// path: an inherited "keyring" value would send NewStore to the OS keychain
|
||||
// and ignore ZERO_OAUTH_TOKENS_PATH entirely, making the test read/write the
|
||||
// developer's real logins. Exists so the chatgpt factory tests can seed a
|
||||
// token without copying the path-handling dance from internal/cli.
|
||||
func newOAuthStoreForTest(t *testing.T) (*oauth.Store, error) {
|
||||
t.Helper()
|
||||
t.Setenv("ZERO_OAUTH_STORAGE", "file")
|
||||
t.Setenv("ZERO_OAUTH_TOKENS_PATH", t.TempDir()+"/tokens.json")
|
||||
return oauth.NewStore(oauth.StoreOptions{})
|
||||
}
|
||||
|
||||
// codexAccountForKey reads the chatgpt-account-id from the token stored under a
|
||||
// FIXED key — the key the caller (cli.oauthLoginForProfile) already bound for the
|
||||
// bearer token, passed through providers.Options.OAuthLoginKey. The account is
|
||||
// therefore always read from the same login that issued the bearer (no second,
|
||||
// independent selection). It re-reads per call, so an in-place token refresh (new
|
||||
// account claim under the SAME key) is picked up; an empty key (no OAuth login)
|
||||
// or a missing/account-less token yields "".
|
||||
func TestCodexAccountForKey(t *testing.T) {
|
||||
store, err := newOAuthStoreForTest(t)
|
||||
if err != nil {
|
||||
t.Fatalf("NewStore: %v", err)
|
||||
}
|
||||
if err := store.Save(oauth.ProviderKey("chatgpt"), oauth.Token{AccessToken: "tok-1", Account: "acc-catalog-7"}); err != nil {
|
||||
t.Fatalf("Save chatgpt: %v", err)
|
||||
}
|
||||
// A different login WITHOUT an account claim, to prove the read stays on the
|
||||
// requested key and never crosses to another login's account.
|
||||
if err := store.Save(oauth.ProviderKey("codex"), oauth.Token{AccessToken: "tok-codex"}); err != nil {
|
||||
t.Fatalf("Save codex: %v", err)
|
||||
}
|
||||
|
||||
if got := codexAccountForKey(oauth.ProviderKey("chatgpt")); got != "acc-catalog-7" {
|
||||
t.Fatalf("account = %q, want acc-catalog-7", got)
|
||||
}
|
||||
// The bound key's token has no account → "", NOT the other login's account.
|
||||
if got := codexAccountForKey(oauth.ProviderKey("codex")); got != "" {
|
||||
t.Fatalf("account = %q, want empty (must not cross to another login's account)", got)
|
||||
}
|
||||
// Empty key (no OAuth login) → header omitted.
|
||||
if got := codexAccountForKey(""); got != "" {
|
||||
t.Fatalf("account for empty key = %q, want empty", got)
|
||||
}
|
||||
// Unknown key → "".
|
||||
if got := codexAccountForKey(oauth.ProviderKey("nope")); got != "" {
|
||||
t.Fatalf("account for unknown key = %q, want empty", got)
|
||||
}
|
||||
|
||||
// An in-place refresh under the bound key IS reflected per request.
|
||||
if err := store.Save(oauth.ProviderKey("chatgpt"), oauth.Token{AccessToken: "tok-refreshed", Account: "acc-rotated"}); err != nil {
|
||||
t.Fatalf("refresh chatgpt: %v", err)
|
||||
}
|
||||
if got := codexAccountForKey(oauth.ProviderKey("chatgpt")); got != "acc-rotated" {
|
||||
t.Fatalf("account = %q, want acc-rotated (in-place refresh must be picked up)", got)
|
||||
}
|
||||
}
|
||||
@@ -6,10 +6,12 @@ import (
|
||||
"errors"
|
||||
"fmt"
|
||||
"io"
|
||||
"math"
|
||||
"net/http"
|
||||
"net/url"
|
||||
"os"
|
||||
"regexp"
|
||||
"runtime"
|
||||
"strconv"
|
||||
"strings"
|
||||
"time"
|
||||
@@ -25,9 +27,9 @@ var ErrStreamIdle = errors.New("idle timeout (upstream stopped sending data)")
|
||||
|
||||
// ErrStreamStalled reports that a streaming upstream kept the connection alive
|
||||
// (SSE keep-alives reset the idle watchdog, so it never fired) but produced no
|
||||
// actual output for streamContentStallFactor × the idle timeout. Without this an
|
||||
// upstream that heartbeats-but-stalls — observed on chatgpt/gpt-5.x and ollama
|
||||
// reasoning models — would hang the agent indefinitely.
|
||||
// actual output for ContentStallTimeout(idle). Without this an upstream that
|
||||
// heartbeats-but-stalls — observed on chatgpt/gpt-5.x and ollama reasoning
|
||||
// models — would hang the agent indefinitely.
|
||||
var ErrStreamStalled = errors.New("stream stalled (upstream kept the connection alive but produced no output)")
|
||||
|
||||
// StreamTimeoutMessage returns the human-readable detail for a stream-timeout
|
||||
@@ -38,7 +40,7 @@ var ErrStreamStalled = errors.New("stream stalled (upstream kept the connection
|
||||
// stuck or very slow.
|
||||
func StreamTimeoutMessage(err error, idleTimeout time.Duration) string {
|
||||
if errors.Is(err, ErrStreamStalled) {
|
||||
return fmt.Sprintf("no output for %s (the model kept the connection alive but produced nothing — it may be stuck; try a faster model or lower reasoning effort)", idleTimeout*streamContentStallFactor)
|
||||
return fmt.Sprintf("no output for %s (the model kept the connection alive but produced nothing — it may be stuck; try a faster model or lower reasoning effort)", ContentStallTimeout(idleTimeout))
|
||||
}
|
||||
return fmt.Sprintf("idle timeout after %s (upstream stopped sending data)", idleTimeout)
|
||||
}
|
||||
@@ -53,13 +55,32 @@ func StreamTimeoutMessage(err error, idleTimeout time.Duration) string {
|
||||
// Override globally with ZERO_STREAM_IDLE_TIMEOUT.
|
||||
const DefaultStreamIdleTimeout = 5 * time.Minute
|
||||
|
||||
// streamContentStallFactor bounds a heartbeat-but-no-output stream. Keep-alives
|
||||
// reset the idle watchdog (a heartbeating upstream is not "dead"), but if NO real
|
||||
// data line arrives for streamContentStallFactor × the idle timeout, the stream is
|
||||
// treated as stalled and aborted (ErrStreamStalled). It is > 1 so a slow-but-
|
||||
// producing request — one that emits data between heartbeats — is never killed; the
|
||||
// content watchdog only catches a stream that heartbeats while producing nothing.
|
||||
const streamContentStallFactor = 2
|
||||
// ContentStallTimeout bounds a heartbeat-but-no-output stream: keep-alives reset
|
||||
// the idle watchdog (a heartbeating upstream is not "dead"), but if NO real data
|
||||
// line arrives for this long the stream is aborted (ErrStreamStalled). Scaled
|
||||
// above idleTimeout (so a slow-but-producing request that emits data between
|
||||
// heartbeats is never killed — the watchdog only ever fires when NOTHING real
|
||||
// arrives), but only 1.2× rather than the old 2×: a genuine heartbeat-pause
|
||||
// stall on chatgpt/gpt-5.x rarely recovers, so a ~10-minute dead wait (at the 5m
|
||||
// idle default) was a terrible UX for a doomed turn. At the default idle this is
|
||||
// 6 minutes; it still scales with ZERO_STREAM_IDLE_TIMEOUT. A returned value <= 0
|
||||
// (idle watchdog disabled) leaves the content watchdog off too.
|
||||
func ContentStallTimeout(idleTimeout time.Duration) time.Duration {
|
||||
if idleTimeout <= 0 {
|
||||
return 0
|
||||
}
|
||||
// 1.2× computed as idle + idle/5 (not idle*6/5), plus a clamp: a
|
||||
// pathologically large ZERO_STREAM_IDLE_TIMEOUT could make idle*6 overflow
|
||||
// int64 and wrap to a NEGATIVE duration, which would arm the content timer
|
||||
// to fire immediately and abort every stream. Clamping to the max duration
|
||||
// on overflow just means "effectively no content watchdog" — the sane
|
||||
// result for an absurd idle timeout.
|
||||
extra := idleTimeout / 5
|
||||
if idleTimeout > math.MaxInt64-extra {
|
||||
return math.MaxInt64
|
||||
}
|
||||
return idleTimeout + extra
|
||||
}
|
||||
|
||||
// streamIdleTimeoutEnv is the global override for the stream idle timeout. It
|
||||
// accepts a Go duration ("5m", "300s", "90s") or a bare number of seconds
|
||||
@@ -122,6 +143,21 @@ func NormalizeBaseURL(baseURL string, defaultBaseURL string, label string) (stri
|
||||
// unaffected (the stream-idle + content watchdogs cover that).
|
||||
// - IdleConnTimeout is shortened so a connection that went idle across a pause
|
||||
// is closed (and re-dialed fresh) rather than reused after it has gone stale.
|
||||
// - DisableKeepAlives on darwin only: ResponseHeaderTimeout/IdleConnTimeout
|
||||
// above catch a reused connection that's fully dead (never responds) or
|
||||
// idle past the timeout, but not one that's alive-but-severely-degraded —
|
||||
// e.g. reused shortly after a prior request on the same host (well within
|
||||
// 30s, common across quick retries of the same turn), where it still
|
||||
// delivers real bytes, just at a crippled rate, resetting Zero's stream
|
||||
// idle/content-stall watchdogs (which only fire on true silence) without
|
||||
// ever recovering. That degraded-not-dead case is indistinguishable from
|
||||
// genuine backend slowness from inside the stream, so the only reliable
|
||||
// fix is removing pooling from the equation entirely on the one platform
|
||||
// where this class of bug has actually reproduced. A fresh TCP+TLS
|
||||
// handshake per request costs low tens of milliseconds — negligible next
|
||||
// to the minutes-long stalls this avoids — and this doesn't touch
|
||||
// Linux/Windows, where the underlying OS doesn't keep dead/degraded
|
||||
// pooled connections around as long.
|
||||
var sharedHTTPClient = func() *http.Client {
|
||||
transport := http.DefaultTransport.(*http.Transport).Clone()
|
||||
// 120s, not 60s: a slow cloud proxy (e.g. ollama `*:cloud`) can withhold its
|
||||
@@ -132,6 +168,7 @@ var sharedHTTPClient = func() *http.Client {
|
||||
// content-stall watchdogs.
|
||||
transport.ResponseHeaderTimeout = 120 * time.Second
|
||||
transport.IdleConnTimeout = 30 * time.Second
|
||||
transport.DisableKeepAlives = runtime.GOOS == "darwin"
|
||||
return &http.Client{Transport: transport}
|
||||
}()
|
||||
|
||||
@@ -285,7 +322,7 @@ func ScanSSEDataWithContext(
|
||||
// Content watchdog: only real data lines reset it (keep-alives do not), so a
|
||||
// stream that heartbeats without producing output is bounded instead of
|
||||
// hanging forever.
|
||||
contentTimeout := idleTimeout * streamContentStallFactor
|
||||
contentTimeout := ContentStallTimeout(idleTimeout)
|
||||
content := time.NewTimer(contentTimeout)
|
||||
defer content.Stop()
|
||||
contentC = content.C
|
||||
|
||||
@@ -4,7 +4,9 @@ import (
|
||||
"context"
|
||||
"errors"
|
||||
"io"
|
||||
"math"
|
||||
"net/http"
|
||||
"runtime"
|
||||
"strings"
|
||||
"testing"
|
||||
"time"
|
||||
@@ -203,11 +205,36 @@ func TestUpstreamUnreachable(t *testing.T) {
|
||||
}
|
||||
}
|
||||
|
||||
// ContentStallTimeout is 1.2× the idle timeout, disabled (0) when idle is
|
||||
// disabled, and must never overflow to a negative duration for an absurdly
|
||||
// large idle timeout (which would arm the content timer to fire immediately
|
||||
// and abort every stream).
|
||||
func TestContentStallTimeout(t *testing.T) {
|
||||
cases := []struct {
|
||||
idle time.Duration
|
||||
want time.Duration
|
||||
}{
|
||||
{5 * time.Minute, 6 * time.Minute},
|
||||
{30 * time.Second, 36 * time.Second},
|
||||
{100 * time.Millisecond, 120 * time.Millisecond},
|
||||
{0, 0},
|
||||
{-1, 0},
|
||||
}
|
||||
for _, c := range cases {
|
||||
if got := ContentStallTimeout(c.idle); got != c.want {
|
||||
t.Fatalf("ContentStallTimeout(%v) = %v, want %v", c.idle, got, c.want)
|
||||
}
|
||||
}
|
||||
// Overflow guard: idle*6 would wrap negative; the clamp keeps it positive.
|
||||
if got := ContentStallTimeout(math.MaxInt64); got <= 0 {
|
||||
t.Fatalf("ContentStallTimeout(MaxInt64) = %v, must stay positive (no overflow wrap)", got)
|
||||
}
|
||||
}
|
||||
|
||||
// A heartbeating-but-output-less upstream must not hang forever: SSE keep-alives
|
||||
// feed the idle watchdog (so it never fires), but the content watchdog
|
||||
// (idleTimeout × streamContentStallFactor) aborts with ErrStreamStalled when no
|
||||
// real data line arrives. This is the gpt-5.x / ollama "still generating forever"
|
||||
// hang.
|
||||
// (ContentStallTimeout(idle)) aborts with ErrStreamStalled when no real data
|
||||
// line arrives. This is the gpt-5.x / ollama "still generating forever" hang.
|
||||
func TestScanSSEDataWithContextAbortsOnContentStall(t *testing.T) {
|
||||
pr, pw := io.Pipe()
|
||||
defer func() { _ = pw.Close() }()
|
||||
@@ -235,7 +262,8 @@ func TestScanSSEDataWithContextAbortsOnContentStall(t *testing.T) {
|
||||
|
||||
done := make(chan error, 1)
|
||||
go func() {
|
||||
// idle 100ms → content stall at 200ms. Keep-alives reset idle but not content.
|
||||
// idle 100ms → content stall at 120ms (ContentStallTimeout = idle*1.2).
|
||||
// Keep-alives reset idle but not content.
|
||||
done <- ScanSSEDataWithContext(context.Background(), cancel, pr, 100*time.Millisecond, func(string) bool { return true })
|
||||
}()
|
||||
|
||||
@@ -258,7 +286,7 @@ func TestScanSSEDataWithContextContentResetsOnData(t *testing.T) {
|
||||
pr, pw := io.Pipe()
|
||||
|
||||
go func() {
|
||||
// One data line every 30ms for ~300ms (well past the 200ms content window,
|
||||
// One data line every 30ms for ~300ms (well past the 120ms content window,
|
||||
// with comfortable slack under the 100ms idle timeout), so the content
|
||||
// watchdog keeps resetting, then close cleanly.
|
||||
for i := 0; i < 10; i++ {
|
||||
@@ -290,16 +318,16 @@ func TestScanSSEDataWithContextContentResetsOnData(t *testing.T) {
|
||||
}
|
||||
|
||||
// StreamTimeoutMessage must give a stalled stream a distinct, accurate detail —
|
||||
// it reports the content window (idle × factor) and must NOT claim the upstream
|
||||
// "stopped sending data" (keep-alives were still arriving).
|
||||
// it reports the content window (ContentStallTimeout) and must NOT claim the
|
||||
// upstream "stopped sending data" (keep-alives were still arriving).
|
||||
func TestStreamTimeoutMessage(t *testing.T) {
|
||||
idle := 5 * time.Minute
|
||||
if msg := StreamTimeoutMessage(ErrStreamIdle, idle); !strings.Contains(msg, "idle timeout after 5m") {
|
||||
t.Fatalf("idle message = %q, want it to mention the 5m idle timeout", msg)
|
||||
}
|
||||
stalled := StreamTimeoutMessage(ErrStreamStalled, idle)
|
||||
if !strings.Contains(stalled, "no output for 10m") {
|
||||
t.Fatalf("stalled message = %q, want it to report the 10m content window", stalled)
|
||||
if !strings.Contains(stalled, "no output for 6m") {
|
||||
t.Fatalf("stalled message = %q, want it to report the 6m content window (idle 5m × 1.2)", stalled)
|
||||
}
|
||||
if strings.Contains(stalled, "stopped sending data") {
|
||||
t.Fatalf("stalled message must not claim the upstream stopped sending data: %q", stalled)
|
||||
@@ -324,6 +352,17 @@ func TestHTTPClientReturnsStallHardenedSharedClient(t *testing.T) {
|
||||
if tr.IdleConnTimeout != 30*time.Second {
|
||||
t.Fatalf("IdleConnTimeout = %v, want 30s", tr.IdleConnTimeout)
|
||||
}
|
||||
// DisableKeepAlives is the stronger mitigation scoped to darwin only: the
|
||||
// two timeouts above catch a reused connection that's fully dead or idle
|
||||
// too long, but not one that's alive-and-degraded (still delivers real
|
||||
// bytes, just at a crippled rate) — which resets Zero's stream watchdogs
|
||||
// without ever recovering. Removing pooling from the equation entirely is
|
||||
// only worth its reconnect cost on the platform this class of bug has
|
||||
// actually reproduced on.
|
||||
wantDisableKeepAlives := runtime.GOOS == "darwin"
|
||||
if tr.DisableKeepAlives != wantDisableKeepAlives {
|
||||
t.Fatalf("DisableKeepAlives = %v, want %v (GOOS=%s)", tr.DisableKeepAlives, wantDisableKeepAlives, runtime.GOOS)
|
||||
}
|
||||
if HTTPClient(nil) != got {
|
||||
t.Fatal("HTTPClient(nil) must return a shared instance so the conn pool is reused")
|
||||
}
|
||||
|
||||
@@ -124,10 +124,16 @@ func TestOutputToolBlocksUntilTaskCompletes(t *testing.T) {
|
||||
tool := NewOutputTool(manager)
|
||||
tool.PollInterval = time.Millisecond
|
||||
|
||||
// timeout is a ceiling, not a target: the test still returns as soon as the
|
||||
// 5ms write lands (PollInterval keeps it responsive), it just tolerates a
|
||||
// slow/contended CI runner without failing. A 100ms budget against a 5ms
|
||||
// write only left 20x margin, which Windows CI runners (coarser default
|
||||
// timer granularity, heavier scheduling contention than Linux/macOS) blew
|
||||
// through and failed the test on an otherwise-unrelated PR merge.
|
||||
result := tool.Run(context.Background(), map[string]any{
|
||||
"task_id": "child_task",
|
||||
"block": true,
|
||||
"timeout": 100,
|
||||
"timeout": 2000,
|
||||
})
|
||||
|
||||
if result.Status != tools.StatusOK || !strings.Contains(result.Output, "output:\nfinished") {
|
||||
|
||||
@@ -630,6 +630,16 @@ func (session *execSession) collect(ctx context.Context, wait time.Duration) (st
|
||||
if session.output.consumeTruncated() {
|
||||
truncated = true
|
||||
}
|
||||
// A background process that keeps writing output faster than this
|
||||
// loop can drain it (a chatty dev server, a watch-mode rebuild loop,
|
||||
// a crash-restart spew) would otherwise never let drainString return
|
||||
// empty, so the deadline check below — only reached on an empty
|
||||
// drain — would never fire. That turns `wait` into an unbounded
|
||||
// block regardless of what the caller asked for. Check it here too,
|
||||
// so continuous output can never starve the timeout.
|
||||
if time.Now().After(deadline) {
|
||||
return finish()
|
||||
}
|
||||
continue
|
||||
}
|
||||
if session.doneClosed() {
|
||||
|
||||
@@ -450,6 +450,65 @@ func TestExecToolResultSurfacesBufferTruncationOutsideByteBudget(t *testing.T) {
|
||||
}
|
||||
}
|
||||
|
||||
// TestCollectRespectsDeadlineUnderContinuousOutput asserts collect() returns
|
||||
// close to its requested deadline even while output keeps arriving. Before
|
||||
// the corresponding fix, the deadline was only checked in the branch reached
|
||||
// when drainString returns empty — a background process producing output
|
||||
// fast/continuously enough to keep the buffer perpetually non-empty could
|
||||
// theoretically starve that check indefinitely. This synthetic writer
|
||||
// (8 goroutines, tight loop) did not reliably reproduce that starvation under
|
||||
// Go's scheduler in practice — the reader still won the race often enough —
|
||||
// so this test doesn't prove the old code could hang; it just pins down the
|
||||
// intended behavior (bounded by wait) going forward.
|
||||
func TestCollectRespectsDeadlineUnderContinuousOutput(t *testing.T) {
|
||||
session := &execSession{
|
||||
id: 1000,
|
||||
output: newExecOutputBuffer(),
|
||||
done: make(chan struct{}),
|
||||
}
|
||||
|
||||
stop := make(chan struct{})
|
||||
var wg sync.WaitGroup
|
||||
// Several concurrent writers, each pushing a decent-sized chunk in a tight
|
||||
// loop: a single slow writer lets the reader win the race often enough
|
||||
// (the runtime schedules a gap between writes) to mask the bug. Enough
|
||||
// parallel writers keep the buffer non-empty essentially continuously,
|
||||
// closer to a real chatty process whose PTY reads land in bursts.
|
||||
const writers = 8
|
||||
chunk := []byte(strings.Repeat("x", 256))
|
||||
wg.Add(writers)
|
||||
for i := 0; i < writers; i++ {
|
||||
go func() {
|
||||
defer wg.Done()
|
||||
for {
|
||||
select {
|
||||
case <-stop:
|
||||
return
|
||||
default:
|
||||
session.output.Write(chunk)
|
||||
}
|
||||
}
|
||||
}()
|
||||
}
|
||||
t.Cleanup(func() {
|
||||
close(stop)
|
||||
wg.Wait()
|
||||
})
|
||||
|
||||
const wait = 200 * time.Millisecond
|
||||
start := time.Now()
|
||||
_, _ = session.collect(context.Background(), wait)
|
||||
elapsed := time.Since(start)
|
||||
|
||||
// Generous slack over `wait` for scheduling jitter under a continuously
|
||||
// writing goroutine — this must stay a small multiple of wait, not
|
||||
// "however long the writer keeps going" (which is what the bug produced:
|
||||
// this test would hang past the 30s test timeout without the fix).
|
||||
if elapsed > 3*wait {
|
||||
t.Fatalf("collect took %v under continuous output, want close to the %v deadline", elapsed, wait)
|
||||
}
|
||||
}
|
||||
|
||||
// resilientTempDir is like t.TempDir() but tolerates the Windows handle-release
|
||||
// lag: a SIGKILL'd child process that had the dir as its cwd may not have
|
||||
// released it the instant it is reaped, so the immediate RemoveAll t.TempDir()
|
||||
|
||||
@@ -56,6 +56,13 @@ func pasteFromClipboardCmd() tea.Cmd {
|
||||
// spec prompt, the MCP manager, an open picker, the detailed transcript) swallow
|
||||
// the paste; empty content is a no-op.
|
||||
func (m model) routePaste(content string) (tea.Model, tea.Cmd) {
|
||||
// A paste is a deliberate action, same as a keypress or click — it means
|
||||
// the user moved on to something else, so it disarms a stale Esc
|
||||
// cancel-confirmation. tea.PasteMsg/clipboardReadMsg aren't
|
||||
// tea.KeyPressMsg, so they don't go through that generic keypress hook;
|
||||
// do it once here, before any early return, so both the bracketed-paste
|
||||
// and right-click-paste paths are covered uniformly.
|
||||
m = m.disarmCancelConfirmation()
|
||||
if content == "" {
|
||||
// Empty text clipboard — the user may have pasted a screenshot.
|
||||
// Probe the OS clipboard for image content asynchronously.
|
||||
|
||||
@@ -490,16 +490,16 @@ func (m model) handleModelCommand(args string) (model, string) {
|
||||
// picker calls this when a model from a non-active provider is chosen, so the
|
||||
// picker can list every saved provider and switch across them (like a unified
|
||||
// provider+model selector). The key is loaded from the encrypted store / env.
|
||||
func (m model) switchProviderModel(providerName, modelID string) (model, string) {
|
||||
func (m model) switchProviderModel(providerName, modelID string) (model, string, tea.Cmd) {
|
||||
if m.pending {
|
||||
return m, "Model\nCannot switch providers while a run is active."
|
||||
return m, "Model\nCannot switch providers while a run is active.", nil
|
||||
}
|
||||
if m.newProvider == nil {
|
||||
return m, "Model\nProvider rebuild is not available for this TUI session."
|
||||
return m, "Model\nProvider rebuild is not available for this TUI session.", nil
|
||||
}
|
||||
target, ok := m.savedProviderByName(providerName)
|
||||
if !ok {
|
||||
return m, "Model\nunknown provider " + strconv.Quote(providerName)
|
||||
return m, "Model\nunknown provider " + strconv.Quote(providerName), nil
|
||||
}
|
||||
target = m.profileWithCredential(target)
|
||||
target.Model = strings.TrimSpace(modelID)
|
||||
@@ -508,11 +508,11 @@ func (m model) switchProviderModel(providerName, modelID string) (model, string)
|
||||
// was deleted/unreadable the marker can still be set, and building a keyless
|
||||
// provider would only fail later with a 401. Local/no-auth providers need no key.
|
||||
if strings.TrimSpace(target.APIKey) == "" && strings.TrimSpace(target.AuthHeaderValue) == "" && !(hasDescriptor && descriptor.Local) {
|
||||
return m, "Model\nprovider " + strconv.Quote(providerName) + " has no usable credential — run setup or `zero auth login " + providerName + "`."
|
||||
return m, "Model\nprovider " + strconv.Quote(providerName) + " has no usable credential — run setup or `zero auth login " + providerName + "`.", nil
|
||||
}
|
||||
next, err := m.newProvider(target)
|
||||
if err != nil {
|
||||
return m, "Model\n" + redaction.RedactString(err.Error(), redaction.Options{ExtraSecretValues: []string{target.APIKey}})
|
||||
return m, "Model\n" + redaction.RedactString(err.Error(), redaction.Options{ExtraSecretValues: []string{target.APIKey}}), nil
|
||||
}
|
||||
m.provider = next
|
||||
m.providerProfile = target
|
||||
@@ -524,7 +524,19 @@ func (m model) switchProviderModel(providerName, modelID string) (model, string)
|
||||
_, _ = config.SetActiveProvider(m.userConfigPath, target.Name)
|
||||
_, _ = config.SetProviderModel(m.userConfigPath, target.Name, target.Model)
|
||||
}
|
||||
return m, fmt.Sprintf("Model\nSwitched to %s · %s", target.Name, target.Model)
|
||||
// Warm discovery for the provider we just switched to, same as Init() does
|
||||
// for the provider active at launch — otherwise the context-usage gauge has
|
||||
// no window for this provider until /model happens to be opened separately.
|
||||
var cmds []tea.Cmd
|
||||
if hasDescriptor {
|
||||
if cmd := m.modelPickerProviderDiscoveryCmd(descriptor, target); cmd != nil {
|
||||
cmds = append(cmds, cmd)
|
||||
}
|
||||
if cmd := m.ollamaContextWindowDiscoveryCmd(descriptor, target.BaseURL, target.Model); cmd != nil {
|
||||
cmds = append(cmds, cmd)
|
||||
}
|
||||
}
|
||||
return m, fmt.Sprintf("Model\nSwitched to %s · %s", target.Name, target.Model), tea.Batch(cmds...)
|
||||
}
|
||||
|
||||
// profileWithCredential fills a profile's APIKey for provider construction the same
|
||||
|
||||
@@ -467,7 +467,7 @@ func providerNextActionLines(profile config.ProviderProfile, snapshot zerocomman
|
||||
}
|
||||
|
||||
func providerProfileHasCredential(profile config.ProviderProfile) bool {
|
||||
return strings.TrimSpace(profile.APIKey) != "" || profile.APIKeyStored || strings.TrimSpace(profile.AuthHeaderValue) != ""
|
||||
return profile.HasConfiguredCredential()
|
||||
}
|
||||
|
||||
func providerCredentialRequired(profile config.ProviderProfile, providerKind string) bool {
|
||||
|
||||
@@ -27,3 +27,29 @@ func TestContextWindowSegment(t *testing.T) {
|
||||
t.Fatalf("gauge = %q, want 161K/200K · 81%%", got)
|
||||
}
|
||||
}
|
||||
|
||||
// TestStatusLineDoesNotDuplicateTokenFigureNextToGauge: the gauge's "used"
|
||||
// figure and the plain usage segment's token count both read the exact same
|
||||
// latestUsageTokens value — once the gauge is showing it, the usage segment
|
||||
// must fall back to cost-only, or the same number renders twice side by
|
||||
// side in the footer (e.g. "◔ 161K/200K · 81% │ 161K tok").
|
||||
func TestStatusLineDoesNotDuplicateTokenFigureNextToGauge(t *testing.T) {
|
||||
m := newModel(t.Context(), Options{ModelName: "claude-sonnet-4.5"})
|
||||
if _, err := m.usageTracker.Record(usage.RecordInput{
|
||||
ModelID: "claude-sonnet-4.5",
|
||||
Usage: zeroruntime.Usage{InputTokens: 160_000, OutputTokens: 1000},
|
||||
}); err != nil {
|
||||
t.Fatalf("Record: %v", err)
|
||||
}
|
||||
|
||||
status := plainRender(t, m.statusLine(110))
|
||||
if !strings.Contains(status, "161K/200K") {
|
||||
t.Fatalf("status line = %q, expected the context gauge to render", status)
|
||||
}
|
||||
if strings.Count(status, "161K") != 1 {
|
||||
t.Fatalf("status line = %q, the 161K token figure must appear exactly once, not duplicated next to the gauge", status)
|
||||
}
|
||||
if strings.Contains(status, "tok") {
|
||||
t.Fatalf("status line = %q, the plain token segment should be suppressed once the gauge shows the same figure", status)
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,251 @@
|
||||
// file_view.go is the drill-in view for a touched file, opened from the FILES
|
||||
// sidebar section (files_panel.go). It reuses the subchat pattern: while
|
||||
// active, the chat column's body swaps to this file's content — the sidebar,
|
||||
// composer, and scroll engine keep working unchanged (transcriptBodyItems is
|
||||
// the single source the viewport, renderer, and hit-testers all read, so
|
||||
// swapping there keeps every consumer consistent). Two modes:
|
||||
//
|
||||
// diff (default) — the file's edit cards from this session, full-depth
|
||||
// full — the file as it stands on disk, syntax highlighted, with
|
||||
// gutter markers on the lines this session's diffs added
|
||||
//
|
||||
// d/f switch modes (with an empty composer), Esc returns to the chat at the
|
||||
// scroll position it was left at.
|
||||
package tui
|
||||
|
||||
import (
|
||||
"bufio"
|
||||
"fmt"
|
||||
"os"
|
||||
"path/filepath"
|
||||
"strings"
|
||||
)
|
||||
|
||||
// fileViewMaxLines caps the full-file mode so a giant generated file can't
|
||||
// freeze a render; the tail collapses into a "… N more lines" trailer.
|
||||
const fileViewMaxLines = 4000
|
||||
|
||||
const (
|
||||
fileViewDiff = iota
|
||||
fileViewFull
|
||||
)
|
||||
|
||||
// fileViewState manages the drill-in view for a touched file. When active, the
|
||||
// transcript body swaps to the file's diff/content instead of the chat rows.
|
||||
type fileViewState struct {
|
||||
active bool
|
||||
path string // workspace-relative, as carried by changedFiles
|
||||
mode int // fileViewDiff | fileViewFull
|
||||
// parentScrollOffset preserves the chat scroll position so closing the view
|
||||
// returns to the same spot (mirrors subchatState).
|
||||
parentScrollOffset int
|
||||
}
|
||||
|
||||
// openFileView activates the drill-in for path in diff mode. Opening from an
|
||||
// already-open view (clicking another FILES row) keeps the original saved chat
|
||||
// scroll position rather than saving the file view's own offset as "parent".
|
||||
// Re-opening the file that is ALREADY being viewed is a no-op: a stray
|
||||
// re-click must not bounce the user from full mode back to diff or reset
|
||||
// their scroll position.
|
||||
func (m model) openFileView(path string) model {
|
||||
if m.fileView.active && m.fileView.path == path {
|
||||
return m
|
||||
}
|
||||
if !m.fileView.active {
|
||||
m.fileView.parentScrollOffset = m.chatScrollOffset
|
||||
}
|
||||
m.fileView.active = true
|
||||
m.fileView.path = path
|
||||
m.fileView.mode = fileViewDiff
|
||||
// A file only the git sweep knows about (bash/subagent mutation) has no edit
|
||||
// cards to stack — open straight on the full file instead of a placeholder.
|
||||
if len(m.fileViewResultRows()) == 0 {
|
||||
m.fileView.mode = fileViewFull
|
||||
}
|
||||
m.chatScrollOffset = 0
|
||||
m = m.clearHover() // bodyY numbering differs between the file body and the chat
|
||||
return m
|
||||
}
|
||||
|
||||
// exitFileView deactivates the view and restores the chat scroll position.
|
||||
func (m model) exitFileView() model {
|
||||
if !m.fileView.active {
|
||||
return m
|
||||
}
|
||||
m.chatScrollOffset = m.fileView.parentScrollOffset
|
||||
m.fileView = fileViewState{}
|
||||
m = m.clearHover()
|
||||
return m
|
||||
}
|
||||
|
||||
// setFileViewMode switches diff/full, resetting the scroll to the bottom-anchored
|
||||
// start since the two bodies have unrelated heights.
|
||||
func (m model) setFileViewMode(mode int) model {
|
||||
if !m.fileView.active || m.fileView.mode == mode {
|
||||
return m
|
||||
}
|
||||
m.fileView.mode = mode
|
||||
m.chatScrollOffset = 0
|
||||
return m
|
||||
}
|
||||
|
||||
// fileViewNavBar renders the single-line header shown in place of the pinned
|
||||
// title bar while the view is active: the path plus the key hints. One line
|
||||
// exactly, so every scrollableTranscriptFrame computed against it agrees with
|
||||
// the title bar's geometry.
|
||||
func (m model) fileViewNavBar(width int) string {
|
||||
mode := "diff"
|
||||
other := "f full"
|
||||
if m.fileView.mode == fileViewFull {
|
||||
mode = "full"
|
||||
other = "d diff"
|
||||
}
|
||||
left := zeroTheme.accent.Render("← "+truncatePathLeft(m.fileView.path, maxInt(8, width/2))) +
|
||||
zeroTheme.faint.Render(" · "+mode)
|
||||
right := zeroTheme.faint.Render(other + " · esc back")
|
||||
return fitStyledLine(joinHeaderLine(left, right, width), width)
|
||||
}
|
||||
|
||||
// fileViewBodyItems builds the body items the transcript machinery renders
|
||||
// while the view is active — one pre-rendered block, so scrolling and height
|
||||
// accounting flow through the exact same path as chat rows.
|
||||
func (m model) fileViewBodyItems(width int) []transcriptBodyItem {
|
||||
var block string
|
||||
if m.fileView.mode == fileViewFull {
|
||||
block = m.renderFileViewFull(width)
|
||||
} else {
|
||||
block = m.renderFileViewDiff(width)
|
||||
}
|
||||
return []transcriptBodyItem{transcriptBlockBodyItem(transcriptBodyItemRow, -1, block)}
|
||||
}
|
||||
|
||||
// fileViewResultRows returns the transcript's tool-result rows that touched the
|
||||
// viewed file, in chronological order.
|
||||
func (m model) fileViewResultRows() []transcriptRow {
|
||||
var rows []transcriptRow
|
||||
for _, row := range m.transcript {
|
||||
if row.kind != rowToolResult {
|
||||
continue
|
||||
}
|
||||
for _, p := range row.changedFiles {
|
||||
if p == m.fileView.path {
|
||||
rows = append(rows, row)
|
||||
break
|
||||
}
|
||||
}
|
||||
}
|
||||
return rows
|
||||
}
|
||||
|
||||
// renderFileViewDiff renders the session's edits to the file as its full-depth
|
||||
// tool cards (bodyCap 0, the detailed-view depth), stacked chronologically —
|
||||
// the same cards the chat shows, so the diffs read identically in both places.
|
||||
func (m model) renderFileViewDiff(width int) string {
|
||||
rows := m.fileViewResultRows()
|
||||
if len(rows) == 0 {
|
||||
return zeroTheme.faint.Render("No recorded edits for this file in this session.")
|
||||
}
|
||||
rc := buildRowContext(m.transcript)
|
||||
opts := cardRenderOptions{bodyCap: 0, cwd: m.cwd}
|
||||
var b strings.Builder
|
||||
for i, row := range rows {
|
||||
if i > 0 {
|
||||
b.WriteString("\n\n")
|
||||
}
|
||||
if len(rows) > 1 {
|
||||
b.WriteString(zeroTheme.faint.Render(fmt.Sprintf("edit %d of %d", i+1, len(rows))))
|
||||
b.WriteString("\n")
|
||||
}
|
||||
b.WriteString(m.renderRowModeUncached(row, width, rc, opts))
|
||||
}
|
||||
return b.String()
|
||||
}
|
||||
|
||||
// renderFileViewFull renders the file as it currently stands on disk, syntax
|
||||
// highlighted, with a line-number gutter and an accent ▎ marker on the lines
|
||||
// this session's diffs added (matched by exact text — an approximation that
|
||||
// tolerates later drift; a stale marker just doesn't highlight).
|
||||
func (m model) renderFileViewFull(width int) string {
|
||||
target := m.fileView.path
|
||||
if !filepath.IsAbs(target) {
|
||||
target = filepath.Join(m.cwd, target)
|
||||
}
|
||||
// Stream the read and stop at the cap: os.ReadFile would load a multi-GB
|
||||
// file wholesale before any truncation, which is the exact render freeze
|
||||
// fileViewMaxLines exists to prevent.
|
||||
file, err := os.Open(target)
|
||||
if err != nil {
|
||||
return zeroTheme.faint.Render("Could not read file: " + err.Error())
|
||||
}
|
||||
defer file.Close()
|
||||
var lines []string
|
||||
truncated := false
|
||||
scanner := bufio.NewScanner(file)
|
||||
scanner.Buffer(make([]byte, 0, 64*1024), 16*1024*1024)
|
||||
for scanner.Scan() {
|
||||
if len(lines) == fileViewMaxLines {
|
||||
truncated = true
|
||||
break
|
||||
}
|
||||
lines = append(lines, scanner.Text())
|
||||
}
|
||||
if err := scanner.Err(); err != nil {
|
||||
if len(lines) == 0 {
|
||||
return zeroTheme.faint.Render("Could not read file: " + err.Error())
|
||||
}
|
||||
truncated = true // e.g. a single over-long line mid-file: show what we have
|
||||
}
|
||||
|
||||
changed := m.fileViewChangedLines()
|
||||
gutterW := len(fmt.Sprintf("%d", len(lines)))
|
||||
textBudget := maxInt(8, width-gutterW-3) // gutter + space + marker column
|
||||
// Highlight with an effectively-infinite measure so the highlighter never
|
||||
// wraps — output lines stay 1:1 with file lines and the gutter numbering
|
||||
// can't desync. Each line is then truncated to the column budget below.
|
||||
display, ok := highlightCodeForPath(lines, m.fileView.path, 1<<20, nil)
|
||||
if !ok || len(display) != len(lines) {
|
||||
display = lines // no lexer for this path: render plain
|
||||
}
|
||||
|
||||
var b strings.Builder
|
||||
for i, line := range display {
|
||||
line = fitStyledLine(line, textBudget)
|
||||
if i > 0 {
|
||||
b.WriteString("\n")
|
||||
}
|
||||
marker := " "
|
||||
if changed[strings.TrimSpace(lines[i])] {
|
||||
marker = zeroTheme.accent.Render("▎")
|
||||
}
|
||||
b.WriteString(zeroTheme.faintest.Render(fmt.Sprintf("%*d ", gutterW, i+1)))
|
||||
b.WriteString(marker)
|
||||
b.WriteString(line)
|
||||
}
|
||||
if truncated {
|
||||
// No exact remaining-line count: computing one would require reading the
|
||||
// rest of the file, defeating the bounded read above.
|
||||
b.WriteString("\n")
|
||||
b.WriteString(zeroTheme.faint.Render(fmt.Sprintf("… more lines (file truncated at %d for display)", len(lines))))
|
||||
}
|
||||
return b.String()
|
||||
}
|
||||
|
||||
// fileViewChangedLines collects the trimmed text of every line the session's
|
||||
// diffs ADDED to the viewed file, for the full-mode gutter markers. Very short
|
||||
// lines ("}", "return", ")") are skipped: text-matching them would mark every
|
||||
// unrelated occurrence across the file, which misleads far more than a missing
|
||||
// marker on a brace line ever could.
|
||||
func (m model) fileViewChangedLines() map[string]bool {
|
||||
changed := map[string]bool{}
|
||||
for _, row := range m.fileViewResultRows() {
|
||||
for _, line := range strings.Split(row.detail, "\n") {
|
||||
if !strings.HasPrefix(line, "+") || strings.HasPrefix(line, "+++") {
|
||||
continue
|
||||
}
|
||||
if text := strings.TrimSpace(strings.TrimPrefix(line, "+")); len(text) >= 4 {
|
||||
changed[text] = true
|
||||
}
|
||||
}
|
||||
}
|
||||
return changed
|
||||
}
|
||||
@@ -0,0 +1,288 @@
|
||||
package tui
|
||||
|
||||
import (
|
||||
"encoding/json"
|
||||
"fmt"
|
||||
"os"
|
||||
"path/filepath"
|
||||
"strings"
|
||||
"testing"
|
||||
|
||||
tea "charm.land/bubbletea/v2"
|
||||
|
||||
"github.com/Gitlawb/zero/internal/agent"
|
||||
"github.com/Gitlawb/zero/internal/sessions"
|
||||
"github.com/Gitlawb/zero/internal/tools"
|
||||
)
|
||||
|
||||
// TestFileViewOpenExitRestoresScroll: opening saves the chat scroll position,
|
||||
// resets it for the file body, and Esc restores it; switching files while open
|
||||
// keeps the ORIGINAL saved position (not the file view's own).
|
||||
func TestFileViewOpenExitRestoresScroll(t *testing.T) {
|
||||
m := filesPanelTestModel()
|
||||
m.chatScrollOffset = 12
|
||||
|
||||
m = m.openFileView("web/app.js")
|
||||
if !m.fileView.active || m.fileView.mode != fileViewDiff {
|
||||
t.Fatalf("open should activate in diff mode: %+v", m.fileView)
|
||||
}
|
||||
if m.chatScrollOffset != 0 || m.fileView.parentScrollOffset != 12 {
|
||||
t.Fatalf("open should reset scroll and save the parent offset: offset=%d saved=%d", m.chatScrollOffset, m.fileView.parentScrollOffset)
|
||||
}
|
||||
|
||||
m.chatScrollOffset = 5 // scrolled within the file body
|
||||
m = m.openFileView("internal/tui/sidebar.go")
|
||||
if m.fileView.parentScrollOffset != 12 {
|
||||
t.Fatalf("switching files must keep the original parent offset, got %d", m.fileView.parentScrollOffset)
|
||||
}
|
||||
|
||||
m = m.exitFileView()
|
||||
if m.fileView.active || m.chatScrollOffset != 12 {
|
||||
t.Fatalf("exit should restore the chat scroll: active=%v offset=%d", m.fileView.active, m.chatScrollOffset)
|
||||
}
|
||||
}
|
||||
|
||||
// TestFileViewEscAndModeKeys: Esc exits the view via the model's key handler;
|
||||
// d/f switch modes while the composer is empty and never while typing.
|
||||
func TestFileViewEscAndModeKeys(t *testing.T) {
|
||||
m := filesPanelTestModel()
|
||||
m = m.openFileView("web/app.js")
|
||||
|
||||
updated, _ := m.Update(tea.KeyPressMsg{Code: 'f', Text: "f"})
|
||||
m = updated.(model)
|
||||
if m.fileView.mode != fileViewFull {
|
||||
t.Fatal("f should switch to full mode")
|
||||
}
|
||||
updated, _ = m.Update(tea.KeyPressMsg{Code: 'd', Text: "d"})
|
||||
m = updated.(model)
|
||||
if m.fileView.mode != fileViewDiff {
|
||||
t.Fatal("d should switch back to diff mode")
|
||||
}
|
||||
|
||||
// With text in the composer, d/f type as normal characters.
|
||||
m.input.SetValue("say")
|
||||
updated, _ = m.Update(tea.KeyPressMsg{Code: 'f', Text: "f"})
|
||||
m = updated.(model)
|
||||
if m.fileView.mode != fileViewDiff {
|
||||
t.Fatal("f while typing must not hijack the composer")
|
||||
}
|
||||
m.input.SetValue("")
|
||||
|
||||
updated, _ = m.Update(tea.KeyPressMsg{Code: tea.KeyEsc})
|
||||
m = updated.(model)
|
||||
if m.fileView.active {
|
||||
t.Fatal("Esc should exit the file view")
|
||||
}
|
||||
}
|
||||
|
||||
// TestFileViewDiffBody: diff mode stacks the file's edit cards chronologically
|
||||
// with "edit N of M" labels; a file with no recorded edits shows the quiet
|
||||
// placeholder.
|
||||
func TestFileViewDiffBody(t *testing.T) {
|
||||
m := filesPanelTestModel()
|
||||
m = m.openFileView("internal/tui/sidebar.go")
|
||||
body := plainRender(t, m.renderFileViewDiff(78))
|
||||
if !strings.Contains(body, "edit 1 of 2") || !strings.Contains(body, "edit 2 of 2") {
|
||||
t.Fatalf("expected chronological edit labels:\n%s", body)
|
||||
}
|
||||
if !strings.Contains(body, "added one") || !strings.Contains(body, "three") {
|
||||
t.Errorf("expected both diffs' content:\n%s", body)
|
||||
}
|
||||
|
||||
m.fileView.path = "never/touched.go"
|
||||
if got := plainRender(t, m.renderFileViewDiff(78)); !strings.Contains(got, "No recorded edits") {
|
||||
t.Errorf("untouched file should show the placeholder, got:\n%s", got)
|
||||
}
|
||||
}
|
||||
|
||||
// TestFileViewFullBody: full mode shows the on-disk content with line numbers
|
||||
// and marks session-added lines with the gutter marker; a missing file degrades
|
||||
// to a readable error line.
|
||||
func TestFileViewFullBody(t *testing.T) {
|
||||
dir := t.TempDir()
|
||||
if err := os.WriteFile(filepath.Join(dir, "app.js"), []byte("let a = 1\nlet untouched = 0\n"), 0o644); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
m := filesPanelTestModel()
|
||||
m.cwd = dir
|
||||
m.transcript = append(m.transcript, transcriptRow{
|
||||
kind: rowToolResult, tool: "write_file", id: "w9", status: tools.StatusOK,
|
||||
detail: "+let a = 1",
|
||||
changedFiles: []string{"app.js"},
|
||||
})
|
||||
m = m.openFileView("app.js")
|
||||
m = m.setFileViewMode(fileViewFull)
|
||||
|
||||
body := m.renderFileViewFull(78)
|
||||
plain := plainRender(t, body)
|
||||
if !strings.Contains(plain, "1 ") || !strings.Contains(plain, "let untouched = 0") {
|
||||
t.Fatalf("full view should show numbered file content:\n%s", plain)
|
||||
}
|
||||
lines := strings.Split(plain, "\n")
|
||||
if len(lines) != 2 {
|
||||
t.Fatalf("one rendered line per file line, got %d:\n%s", len(lines), plain)
|
||||
}
|
||||
if !strings.Contains(lines[0], "▎") {
|
||||
t.Errorf("session-added line should carry the gutter marker: %q", lines[0])
|
||||
}
|
||||
if strings.Contains(lines[1], "▎") {
|
||||
t.Errorf("untouched line must not carry the marker: %q", lines[1])
|
||||
}
|
||||
|
||||
m.fileView.path = "gone.js"
|
||||
if got := plainRender(t, m.renderFileViewFull(78)); !strings.Contains(got, "Could not read file") {
|
||||
t.Errorf("missing file should degrade to an error line, got:\n%s", got)
|
||||
}
|
||||
}
|
||||
|
||||
// TestFileViewSwapsTranscriptBody: while active, transcriptBodyItems returns
|
||||
// the file body (a single block) instead of the chat rows, and the pinned
|
||||
// title bar swaps to the one-line nav bar — the geometry every frame consumer
|
||||
// relies on.
|
||||
func TestFileViewSwapsTranscriptBody(t *testing.T) {
|
||||
m := filesPanelTestModel()
|
||||
m = m.openFileView("internal/tui/sidebar.go")
|
||||
|
||||
items := m.transcriptBodyItems(m.chatColumnWidth(), "")
|
||||
if len(items) != 1 {
|
||||
t.Fatalf("file view should swap the body to a single block item, got %d items", len(items))
|
||||
}
|
||||
nav := plainRender(t, m.pinnedTitleBar(m.chatColumnWidth()))
|
||||
if !strings.Contains(nav, "sidebar.go") || !strings.Contains(nav, "esc back") {
|
||||
t.Fatalf("nav bar should show the path and key hints: %q", nav)
|
||||
}
|
||||
if lines := len(viewLines(m.fileViewNavBar(m.chatColumnWidth()))); lines != 1 {
|
||||
t.Fatalf("nav bar must be exactly one line (title-bar geometry), got %d", lines)
|
||||
}
|
||||
|
||||
// The whole view renders without panicking in both modes and shows the nav.
|
||||
if view := plainRender(t, m.transcriptView()); !strings.Contains(view, "esc back") {
|
||||
t.Fatal("transcript view should carry the file nav bar")
|
||||
}
|
||||
}
|
||||
|
||||
// TestSubchatEntryClosesFileView: drilling into an AGENTS row while a file view
|
||||
// is open closes the file view first (the subchat owns the single-column view).
|
||||
func TestSubchatEntryClosesFileView(t *testing.T) {
|
||||
store := sessions.NewStore(sessions.StoreOptions{RootDir: t.TempDir()})
|
||||
if _, err := store.Create(sessions.CreateInput{SessionID: "sess-1"}); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
m := filesPanelTestModel()
|
||||
m.sessionStore = store
|
||||
m.swarmSessionMap = map[string]string{"subagent-1": "sess-1"}
|
||||
m.transcript = append(m.transcript,
|
||||
transcriptRow{kind: rowToolCall, tool: "swarm_spawn", detail: "build it", runID: 1},
|
||||
transcriptRow{kind: rowToolResult, tool: "swarm_spawn", detail: "Spawned subagent as task subagent-1 on team default.", runID: 1},
|
||||
)
|
||||
m.activeRunID = 1
|
||||
m = m.openFileView("web/app.js")
|
||||
|
||||
width := sidebarWidth(m.width)
|
||||
agents := m.sidebarAgentSelectables(width)
|
||||
if len(agents) == 0 {
|
||||
t.Fatal("expected a clickable agent row")
|
||||
}
|
||||
click := testMouseClick(tea.MouseLeft, m.chatColumnWidth()+3, agents[0].lineOffset)
|
||||
updated, _, handled := m.handleTranscriptSelectionMouse(click)
|
||||
if !handled {
|
||||
t.Fatal("agent row click should be handled")
|
||||
}
|
||||
if updated.fileView.active {
|
||||
t.Fatal("entering the subchat should close the file view")
|
||||
}
|
||||
if !updated.subchat.active {
|
||||
t.Fatal("subchat should be active")
|
||||
}
|
||||
}
|
||||
|
||||
// TestChangedFilesRehydration: a persisted tool-result payload's changedFiles
|
||||
// restores onto the rehydrated transcript row, so the FILES panel survives
|
||||
// /resume.
|
||||
func TestChangedFilesRehydration(t *testing.T) {
|
||||
events := []sessions.Event{{
|
||||
Type: sessions.EventToolResult,
|
||||
Payload: json.RawMessage(`{"toolCallId":"t1","name":"edit_file","status":"ok","output":"+x","changedFiles":["pkg/a.go","pkg/b.go"]}`),
|
||||
}}
|
||||
rows := transcriptRowsFromSessionEvents(events)
|
||||
if len(rows) != 1 {
|
||||
t.Fatalf("expected 1 row, got %d", len(rows))
|
||||
}
|
||||
got := rows[0].changedFiles
|
||||
if len(got) != 2 || got[0] != "pkg/a.go" || got[1] != "pkg/b.go" {
|
||||
t.Fatalf("changedFiles not rehydrated: %v", got)
|
||||
}
|
||||
}
|
||||
|
||||
// TestOpenFileViewSamePathIsNoOp: re-clicking the FILES row of the file already
|
||||
// being viewed must not clobber the user's mode or scroll — the old
|
||||
// unconditional openFileView bounced full mode back to diff and reset scroll.
|
||||
func TestOpenFileViewSamePathIsNoOp(t *testing.T) {
|
||||
m := filesPanelTestModel()
|
||||
m = m.openFileView("web/app.js")
|
||||
m = m.setFileViewMode(fileViewFull)
|
||||
m.chatScrollOffset = 7 // scrolled within the file body
|
||||
|
||||
m = m.openFileView("web/app.js")
|
||||
if m.fileView.mode != fileViewFull {
|
||||
t.Fatal("re-opening the same file must keep full mode")
|
||||
}
|
||||
if m.chatScrollOffset != 7 {
|
||||
t.Fatalf("re-opening the same file must keep the scroll, got %d", m.chatScrollOffset)
|
||||
}
|
||||
// A DIFFERENT file still switches (and resets to diff mode as documented).
|
||||
m = m.openFileView("internal/tui/sidebar.go")
|
||||
if m.fileView.path != "internal/tui/sidebar.go" || m.fileView.mode != fileViewDiff {
|
||||
t.Fatalf("opening another file should switch views: %+v", m.fileView)
|
||||
}
|
||||
}
|
||||
|
||||
// TestFileViewFullBodyTruncatesLongFile: the full view stops reading at
|
||||
// fileViewMaxLines (bounded read — a giant file must not be loaded wholesale)
|
||||
// and appends the truncation trailer.
|
||||
func TestFileViewFullBodyTruncatesLongFile(t *testing.T) {
|
||||
dir := t.TempDir()
|
||||
var b strings.Builder
|
||||
for i := 0; i < fileViewMaxLines+50; i++ {
|
||||
fmt.Fprintf(&b, "line %d\n", i)
|
||||
}
|
||||
if err := os.WriteFile(filepath.Join(dir, "big.txt"), []byte(b.String()), 0o644); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
m := filesPanelTestModel()
|
||||
m.cwd = dir
|
||||
m.gitTouched = []gitSweepFile{{path: "big.txt"}}
|
||||
m = m.openFileView("big.txt")
|
||||
|
||||
plain := plainRender(t, m.renderFileViewFull(80))
|
||||
lines := strings.Split(plain, "\n")
|
||||
if len(lines) != fileViewMaxLines+1 { // capped content + the trailer line
|
||||
t.Fatalf("rendered %d lines, want %d content lines + 1 trailer", len(lines), fileViewMaxLines)
|
||||
}
|
||||
if !strings.Contains(lines[len(lines)-1], "truncated") {
|
||||
t.Fatalf("expected the truncation trailer, got %q", lines[len(lines)-1])
|
||||
}
|
||||
}
|
||||
|
||||
// TestFileViewKeysDeferToBlockingModal: with a permission prompt up, Esc and
|
||||
// the d/f shortcuts belong to the prompt — the drill-in must not swallow them
|
||||
// (Esc exiting the view instead of reaching the prompt's deny handling).
|
||||
func TestFileViewKeysDeferToBlockingModal(t *testing.T) {
|
||||
m := filesPanelTestModel()
|
||||
m = m.openFileView("web/app.js")
|
||||
m.pendingPermission = &pendingPermissionPrompt{
|
||||
request: agent.PermissionRequest{ToolName: "write_file"},
|
||||
decide: func(agent.PermissionDecision) {},
|
||||
}
|
||||
|
||||
updated, _ := m.Update(tea.KeyPressMsg{Code: 'f', Text: "f"})
|
||||
m = updated.(model)
|
||||
if m.fileView.mode != fileViewDiff {
|
||||
t.Fatal("f with a permission prompt up must not switch file-view modes")
|
||||
}
|
||||
updated, _ = m.Update(tea.KeyPressMsg{Code: tea.KeyEsc})
|
||||
m = updated.(model)
|
||||
if !m.fileView.active {
|
||||
t.Fatal("Esc with a permission prompt up must not exit the file view")
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,237 @@
|
||||
// files_git_sweep.go fills the FILES sidebar's blind spot: mutations that
|
||||
// bypass the file tools entirely — bash/exec_command scaffolding (npm create,
|
||||
// go generate, heredoc writes) and subagents editing the shared workspace. None
|
||||
// of those produce a changedFiles-carrying tool result, so the transcript-derived
|
||||
// roster (files_panel.go) never sees them. The sweep asks git instead: a
|
||||
// baseline `git status --porcelain` snapshot is taken at startup (Init), and a
|
||||
// re-run after each command tool result / turn end reports any NEWLY dirty
|
||||
// paths, which merge into the roster with a diffstat from `git diff --numstat`.
|
||||
// Pre-existing dirty state stays in the baseline and never shows; a non-git
|
||||
// workspace fails the first command and the sweep silently stays off.
|
||||
package tui
|
||||
|
||||
import (
|
||||
"context"
|
||||
"strconv"
|
||||
"strings"
|
||||
"time"
|
||||
|
||||
tea "charm.land/bubbletea/v2"
|
||||
)
|
||||
|
||||
// gitSweepTimeout bounds each background git invocation so a hung index lock
|
||||
// can never stall message delivery (the command runs off the update goroutine).
|
||||
const gitSweepTimeout = 3 * time.Second
|
||||
|
||||
// gitSweepFile is one workspace file git reports as dirty: workspace-relative
|
||||
// path (git's own output convention, matching changedFiles), whether it is new
|
||||
// (untracked/added), and the tracked diffstat when known (0/0 for untracked).
|
||||
type gitSweepFile struct {
|
||||
path string
|
||||
created bool
|
||||
adds int
|
||||
dels int
|
||||
}
|
||||
|
||||
// gitSweepMsg carries one sweep's result. baseline marks the startup snapshot
|
||||
// (recorded as "pre-existing, never show") vs a live re-check (merged into the
|
||||
// roster). ok is false when git failed (not a repo, no git binary) — the
|
||||
// handler then marks the sweep unavailable rather than retrying every turn.
|
||||
type gitSweepMsg struct {
|
||||
baseline bool
|
||||
ok bool
|
||||
files []gitSweepFile
|
||||
}
|
||||
|
||||
// gitSweepCmd runs the status+numstat pair off the update goroutine. cwd is the
|
||||
// workspace root the TUI resolves paths against.
|
||||
func gitSweepCmd(parent context.Context, cwd string, baseline bool) tea.Cmd {
|
||||
return func() tea.Msg {
|
||||
if parent == nil {
|
||||
parent = context.Background()
|
||||
}
|
||||
ctx, cancel := context.WithTimeout(parent, gitSweepTimeout)
|
||||
defer cancel()
|
||||
// --untracked-files=all enumerates files inside new directories; plain
|
||||
// porcelain collapses them to "dir/", which is useless as a FILES row.
|
||||
status, err := defaultPRCommandRunner(ctx, cwd, "git", "status", "--porcelain", "--untracked-files=all")
|
||||
if err != nil {
|
||||
return gitSweepMsg{baseline: baseline, ok: false}
|
||||
}
|
||||
files := parseGitPorcelain(status)
|
||||
// Diffstat for tracked modifications; untracked files have no diff to
|
||||
// stat. -z makes the output machine-parseable: NUL-terminated records, no
|
||||
// path quoting, and renames as explicit preimage/postimage fields instead
|
||||
// of the brace-mangled "src/{old => new}" a plain --numstat emits (which
|
||||
// would never match a porcelain path). Best-effort: a failure (e.g. unborn
|
||||
// HEAD in a fresh repo) keeps the file list with zero counts rather than
|
||||
// dropping the sweep.
|
||||
if numstat, err := defaultPRCommandRunner(ctx, cwd, "git", "diff", "HEAD", "--numstat", "-z"); err == nil {
|
||||
stats := parseGitNumstat(numstat)
|
||||
for i := range files {
|
||||
if counts, ok := stats[files[i].path]; ok {
|
||||
files[i].adds, files[i].dels = counts[0], counts[1]
|
||||
}
|
||||
}
|
||||
}
|
||||
return gitSweepMsg{baseline: baseline, ok: true, files: files}
|
||||
}
|
||||
}
|
||||
|
||||
// parseGitPorcelain parses `git status --porcelain` v1 output into sweep files.
|
||||
// Format: two status columns, a space, then the path ("XY path"); renames show
|
||||
// "old -> new" (keep the new side); untracked entries are "?? path".
|
||||
func parseGitPorcelain(out string) []gitSweepFile {
|
||||
var files []gitSweepFile
|
||||
for _, line := range strings.Split(out, "\n") {
|
||||
if len(line) < 4 {
|
||||
continue
|
||||
}
|
||||
code, path := line[:2], strings.TrimSpace(line[3:])
|
||||
if to, _, found := cutRename(path); found {
|
||||
path = to
|
||||
}
|
||||
path = unquoteGitPath(path)
|
||||
if path == "" {
|
||||
continue
|
||||
}
|
||||
files = append(files, gitSweepFile{
|
||||
path: path,
|
||||
created: code == "??" || strings.Contains(code, "A"),
|
||||
})
|
||||
}
|
||||
return files
|
||||
}
|
||||
|
||||
// cutRename splits a porcelain rename value "old -> new", returning the new
|
||||
// path. found is false for ordinary (non-rename) paths.
|
||||
func cutRename(path string) (string, string, bool) {
|
||||
if idx := strings.Index(path, " -> "); idx >= 0 {
|
||||
return path[idx+4:], path[:idx], true
|
||||
}
|
||||
return "", "", false
|
||||
}
|
||||
|
||||
// unquoteGitPath strips the quotes git wraps around paths with special
|
||||
// characters ("web/my file.js"). Escapes inside are left as-is — such a path
|
||||
// still identifies the file well enough for a sidebar row.
|
||||
func unquoteGitPath(path string) string {
|
||||
if len(path) >= 2 && strings.HasPrefix(path, `"`) && strings.HasSuffix(path, `"`) {
|
||||
return path[1 : len(path)-1]
|
||||
}
|
||||
return path
|
||||
}
|
||||
|
||||
// parseGitNumstat parses `git diff --numstat -z` output into path → [added,
|
||||
// deleted]. -z records are NUL-terminated "added\tdeleted\tpath"; a rename/copy
|
||||
// instead ends the counts record with an EMPTY path ("added\tdeleted\t") and
|
||||
// appends two more NUL-terminated fields, preimage then postimage — the stats
|
||||
// key is the postimage (the path porcelain/changedFiles report). Paths are
|
||||
// never quoted or brace-mangled in -z mode. Binary files report "-" counts and
|
||||
// are skipped.
|
||||
func parseGitNumstat(out string) map[string][2]int {
|
||||
stats := map[string][2]int{}
|
||||
fields := strings.Split(out, "\x00")
|
||||
for i := 0; i < len(fields); i++ {
|
||||
parts := strings.SplitN(fields[i], "\t", 3)
|
||||
if len(parts) != 3 {
|
||||
continue
|
||||
}
|
||||
adds, errA := strconv.Atoi(parts[0])
|
||||
dels, errD := strconv.Atoi(parts[1])
|
||||
if errA != nil || errD != nil {
|
||||
continue
|
||||
}
|
||||
path := parts[2]
|
||||
if path == "" {
|
||||
// Rename/copy record: the next two fields are preimage, postimage.
|
||||
if i+2 >= len(fields) {
|
||||
break // truncated output — drop the partial record
|
||||
}
|
||||
path = fields[i+2]
|
||||
i += 2
|
||||
}
|
||||
if path != "" {
|
||||
stats[path] = [2]int{adds, dels}
|
||||
}
|
||||
}
|
||||
return stats
|
||||
}
|
||||
|
||||
// handleGitSweepMsg folds a sweep result into the model: the baseline snapshot
|
||||
// records what was already dirty before this TUI session (those paths never
|
||||
// show), a live sweep upserts newly dirty paths into gitTouched in first-seen
|
||||
// order. A failed sweep marks git unavailable so no further sweeps are issued.
|
||||
func (m model) handleGitSweepMsg(msg gitSweepMsg) model {
|
||||
m.gitSweepInFlight = false
|
||||
if !msg.ok {
|
||||
m.gitSweepUnavailable = true
|
||||
if m.gitFileBaseline == nil {
|
||||
m.gitFileBaseline = map[string]bool{}
|
||||
}
|
||||
return m
|
||||
}
|
||||
if msg.baseline {
|
||||
baseline := make(map[string]bool, len(msg.files))
|
||||
for _, f := range msg.files {
|
||||
baseline[f.path] = true
|
||||
}
|
||||
m.gitFileBaseline = baseline
|
||||
return m
|
||||
}
|
||||
for _, f := range msg.files {
|
||||
if m.gitFileBaseline[f.path] {
|
||||
continue
|
||||
}
|
||||
found := false
|
||||
for i := range m.gitTouched {
|
||||
if m.gitTouched[i].path == f.path {
|
||||
m.gitTouched[i] = f
|
||||
found = true
|
||||
break
|
||||
}
|
||||
}
|
||||
if !found {
|
||||
// Copy-on-append: model copies share the backing array, so an in-place
|
||||
// append from two update branches could alias. Rebuilding is cheap at
|
||||
// sidebar scale.
|
||||
m.gitTouched = append(append([]gitSweepFile(nil), m.gitTouched...), f)
|
||||
}
|
||||
}
|
||||
return m
|
||||
}
|
||||
|
||||
// maybeGitSweep issues a live sweep when one is useful and none is running:
|
||||
// the baseline exists (Init's snapshot answered), git works here, and the
|
||||
// workspace is known. Returns the (possibly nil) command to batch.
|
||||
func (m model) maybeGitSweep() (model, tea.Cmd) {
|
||||
if m.gitSweepInFlight || m.gitSweepUnavailable || m.gitFileBaseline == nil || strings.TrimSpace(m.cwd) == "" {
|
||||
return m, nil
|
||||
}
|
||||
m.gitSweepInFlight = true
|
||||
return m, gitSweepCmd(m.ctx, m.cwd, false)
|
||||
}
|
||||
|
||||
// gitTouchedFiles adapts the sweep results to the roster's touchedFile shape,
|
||||
// for merging under the transcript-derived entries (files_panel.go), newest
|
||||
// detection first — gitTouched upserts in first-seen order, so iterating it in
|
||||
// reverse keeps the merged FILES tail consistent with the roster's
|
||||
// newest-first ordering. No transcript row backs them (lastRowIndex -1), so
|
||||
// selecting one skips the scroll/tint and the drill-in opens on the full file.
|
||||
func (m model) gitTouchedFiles() []touchedFile {
|
||||
if len(m.gitTouched) == 0 {
|
||||
return nil
|
||||
}
|
||||
files := make([]touchedFile, 0, len(m.gitTouched))
|
||||
for i := len(m.gitTouched) - 1; i >= 0; i-- {
|
||||
f := m.gitTouched[i]
|
||||
files = append(files, touchedFile{
|
||||
path: f.path,
|
||||
created: f.created,
|
||||
adds: f.adds,
|
||||
dels: f.dels,
|
||||
lastRowIndex: -1,
|
||||
})
|
||||
}
|
||||
return files
|
||||
}
|
||||
@@ -0,0 +1,243 @@
|
||||
package tui
|
||||
|
||||
import (
|
||||
"os"
|
||||
"os/exec"
|
||||
"path/filepath"
|
||||
"testing"
|
||||
)
|
||||
|
||||
func TestParseGitPorcelain(t *testing.T) {
|
||||
out := " M web/app.js\n?? web/new.css\nA docs/added.md\nR old.go -> pkg/new.go\n?? \"web/my file.js\"\n\n"
|
||||
files := parseGitPorcelain(out)
|
||||
if len(files) != 5 {
|
||||
t.Fatalf("expected 5 entries, got %d: %+v", len(files), files)
|
||||
}
|
||||
byPath := map[string]gitSweepFile{}
|
||||
for _, f := range files {
|
||||
byPath[f.path] = f
|
||||
}
|
||||
if f := byPath["web/app.js"]; f.created {
|
||||
t.Error("modified file must not read as created")
|
||||
}
|
||||
if f := byPath["web/new.css"]; !f.created {
|
||||
t.Error("untracked file should read as created")
|
||||
}
|
||||
if f := byPath["docs/added.md"]; !f.created {
|
||||
t.Error("index-added file should read as created")
|
||||
}
|
||||
if _, ok := byPath["pkg/new.go"]; !ok {
|
||||
t.Errorf("rename should keep the new path: %+v", files)
|
||||
}
|
||||
if _, ok := byPath["web/my file.js"]; !ok {
|
||||
t.Errorf("quoted path should unquote: %+v", files)
|
||||
}
|
||||
}
|
||||
|
||||
// TestParseGitNumstat feeds the exact `git diff --numstat -z` record shapes:
|
||||
// plain "added\tdeleted\tpath\0", binary "-\t-\tpath\0", and the rename form
|
||||
// "added\tdeleted\t\0preimage\0postimage\0" — the stats must key the postimage
|
||||
// (the path porcelain/changedFiles report), which the old newline parser lost
|
||||
// (plain --numstat brace-mangles renames, so they never matched a roster path).
|
||||
func TestParseGitNumstat(t *testing.T) {
|
||||
out := "12\t3\tweb/app.js\x00" +
|
||||
"-\t-\tassets/logo.png\x00" +
|
||||
"4\t0\t\x00old.go\x00pkg/new.go\x00" +
|
||||
"1\t1\tweb/my file.js\x00" // -z paths are never quoted
|
||||
stats := parseGitNumstat(out)
|
||||
if got := stats["web/app.js"]; got != [2]int{12, 3} {
|
||||
t.Errorf("web/app.js = %v, want [12 3]", got)
|
||||
}
|
||||
if _, ok := stats["assets/logo.png"]; ok {
|
||||
t.Error("binary '-' entries must be skipped")
|
||||
}
|
||||
if got := stats["pkg/new.go"]; got != [2]int{4, 0} {
|
||||
t.Errorf("renamed file must key the postimage path = %v, want [4 0]", got)
|
||||
}
|
||||
if _, ok := stats["old.go"]; ok {
|
||||
t.Error("the rename preimage must not appear as its own entry")
|
||||
}
|
||||
if got := stats["web/my file.js"]; got != [2]int{1, 1} {
|
||||
t.Errorf("path with spaces = %v, want [1 1] (no quoting in -z mode)", got)
|
||||
}
|
||||
// Truncated rename record (missing postimage) must not panic or mis-key.
|
||||
if got := parseGitNumstat("4\t0\t\x00old.go"); len(got) != 0 {
|
||||
t.Errorf("truncated rename record should be dropped, got %v", got)
|
||||
}
|
||||
}
|
||||
|
||||
// TestGitSweepMergeAndBaseline: the baseline snapshot hides pre-existing dirty
|
||||
// paths; live sweeps upsert only new ones; a failed sweep latches unavailable.
|
||||
func TestGitSweepMergeAndBaseline(t *testing.T) {
|
||||
m := model{}
|
||||
m = m.handleGitSweepMsg(gitSweepMsg{baseline: true, ok: true, files: []gitSweepFile{{path: "dirty-before.go"}}})
|
||||
if !m.gitFileBaseline["dirty-before.go"] {
|
||||
t.Fatal("baseline should record pre-existing dirty paths")
|
||||
}
|
||||
|
||||
m = m.handleGitSweepMsg(gitSweepMsg{ok: true, files: []gitSweepFile{
|
||||
{path: "dirty-before.go", adds: 9},
|
||||
{path: "kanban/board.tsx", created: true, adds: 120},
|
||||
}})
|
||||
if len(m.gitTouched) != 1 || m.gitTouched[0].path != "kanban/board.tsx" {
|
||||
t.Fatalf("only newly dirty paths should merge: %+v", m.gitTouched)
|
||||
}
|
||||
|
||||
// Re-sweep updates stats in place, no duplicate.
|
||||
m = m.handleGitSweepMsg(gitSweepMsg{ok: true, files: []gitSweepFile{{path: "kanban/board.tsx", created: true, adds: 150, dels: 2}}})
|
||||
if len(m.gitTouched) != 1 || m.gitTouched[0].adds != 150 {
|
||||
t.Fatalf("re-sweep should upsert stats: %+v", m.gitTouched)
|
||||
}
|
||||
|
||||
failed := model{}
|
||||
failed = failed.handleGitSweepMsg(gitSweepMsg{baseline: true, ok: false})
|
||||
if !failed.gitSweepUnavailable {
|
||||
t.Fatal("a failed sweep should latch unavailable")
|
||||
}
|
||||
if _, cmd := failed.maybeGitSweep(); cmd != nil {
|
||||
t.Fatal("no further sweeps once unavailable")
|
||||
}
|
||||
}
|
||||
|
||||
// TestMaybeGitSweepGating: no sweep before the baseline answers, none while one
|
||||
// is in flight, and the in-flight flag sets when one is issued.
|
||||
func TestMaybeGitSweepGating(t *testing.T) {
|
||||
m := model{cwd: "/tmp"}
|
||||
if _, cmd := m.maybeGitSweep(); cmd != nil {
|
||||
t.Fatal("no baseline yet: sweep must not run")
|
||||
}
|
||||
m.gitFileBaseline = map[string]bool{}
|
||||
next, cmd := m.maybeGitSweep()
|
||||
if cmd == nil || !next.gitSweepInFlight {
|
||||
t.Fatal("with a baseline, a sweep should be issued and marked in flight")
|
||||
}
|
||||
if _, again := next.maybeGitSweep(); again != nil {
|
||||
t.Fatal("single-flight: no second sweep while one runs")
|
||||
}
|
||||
}
|
||||
|
||||
// TestTouchedFilesMergesGitSweep: git-discovered files append below the
|
||||
// transcript-derived entries, deduped by path (a tool-result entry wins).
|
||||
func TestTouchedFilesMergesGitSweep(t *testing.T) {
|
||||
m := filesPanelTestModel()
|
||||
m.gitTouched = []gitSweepFile{
|
||||
{path: "kanban/board.tsx", created: true, adds: 120},
|
||||
{path: "web/app.js", adds: 999}, // duplicate of a transcript entry
|
||||
}
|
||||
files := m.touchedFiles()
|
||||
var kanban *touchedFile
|
||||
appCount := 0
|
||||
for i := range files {
|
||||
if files[i].path == "kanban/board.tsx" {
|
||||
kanban = &files[i]
|
||||
}
|
||||
if files[i].path == "web/app.js" {
|
||||
appCount++
|
||||
if files[i].adds == 999 {
|
||||
t.Error("transcript-derived entry should win over the git duplicate")
|
||||
}
|
||||
}
|
||||
}
|
||||
if kanban == nil || !kanban.created || kanban.lastRowIndex != -1 {
|
||||
t.Fatalf("git-only file should merge with created badge and no row anchor: %+v", files)
|
||||
}
|
||||
if appCount != 1 {
|
||||
t.Fatalf("web/app.js should appear exactly once, got %d", appCount)
|
||||
}
|
||||
}
|
||||
|
||||
// TestOpenFileViewGitOnlyFallsBackToFull: a file with no edit cards (git sweep
|
||||
// discovery) opens straight on the full-file view instead of an empty diff.
|
||||
func TestOpenFileViewGitOnlyFallsBackToFull(t *testing.T) {
|
||||
m := filesPanelTestModel()
|
||||
m.gitTouched = []gitSweepFile{{path: "kanban/board.tsx", created: true}}
|
||||
m = m.openFileView("kanban/board.tsx")
|
||||
if m.fileView.mode != fileViewFull {
|
||||
t.Fatal("git-only file should open in full mode")
|
||||
}
|
||||
m = m.exitFileView()
|
||||
m = m.openFileView("web/app.js")
|
||||
if m.fileView.mode != fileViewDiff {
|
||||
t.Fatal("a file with edit cards still opens in diff mode")
|
||||
}
|
||||
}
|
||||
|
||||
// TestGitSweepCmdAgainstRealRepo: end-to-end against a real git repo — the
|
||||
// baseline sees pre-existing dirt, a post-mutation sweep reports the new file
|
||||
// as created and the modified file with its numstat.
|
||||
func TestGitSweepCmdAgainstRealRepo(t *testing.T) {
|
||||
if _, err := exec.LookPath("git"); err != nil {
|
||||
t.Skip("git not installed")
|
||||
}
|
||||
dir := t.TempDir()
|
||||
run := func(args ...string) {
|
||||
t.Helper()
|
||||
cmd := exec.Command("git", args...)
|
||||
cmd.Dir = dir
|
||||
cmd.Env = append(os.Environ(),
|
||||
"GIT_AUTHOR_NAME=t", "GIT_AUTHOR_EMAIL=t@t", "GIT_COMMITTER_NAME=t", "GIT_COMMITTER_EMAIL=t@t")
|
||||
if out, err := cmd.CombinedOutput(); err != nil {
|
||||
t.Fatalf("git %v: %v\n%s", args, err, out)
|
||||
}
|
||||
}
|
||||
write := func(name, content string) {
|
||||
t.Helper()
|
||||
if err := os.WriteFile(filepath.Join(dir, name), []byte(content), 0o644); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
}
|
||||
run("init", "-q")
|
||||
write("tracked.txt", "one\ntwo\n")
|
||||
run("add", ".")
|
||||
run("commit", "-q", "-m", "seed")
|
||||
write("pre-existing.txt", "dirt\n") // dirty BEFORE the TUI "opens"
|
||||
|
||||
baseline := gitSweepCmd(nil, dir, true)().(gitSweepMsg)
|
||||
if !baseline.ok || len(baseline.files) != 1 || baseline.files[0].path != "pre-existing.txt" {
|
||||
t.Fatalf("baseline should see only the pre-existing dirt: %+v", baseline)
|
||||
}
|
||||
|
||||
// The "agent" now scaffolds via the shell.
|
||||
write("scaffolded.txt", "hello\n")
|
||||
write("tracked.txt", "one\ntwo\nthree\nfour\n")
|
||||
|
||||
sweep := gitSweepCmd(nil, dir, false)().(gitSweepMsg)
|
||||
if !sweep.ok {
|
||||
t.Fatal("sweep failed")
|
||||
}
|
||||
byPath := map[string]gitSweepFile{}
|
||||
for _, f := range sweep.files {
|
||||
byPath[f.path] = f
|
||||
}
|
||||
if f, ok := byPath["scaffolded.txt"]; !ok || !f.created {
|
||||
t.Fatalf("scaffolded file should report created: %+v", sweep.files)
|
||||
}
|
||||
if f := byPath["tracked.txt"]; f.adds != 2 || f.dels != 0 {
|
||||
t.Fatalf("tracked.txt numstat = +%d −%d, want +2 −0", f.adds, f.dels)
|
||||
}
|
||||
|
||||
// A rename WITH edits: porcelain reports the new path, and the -z numstat
|
||||
// rename record must resolve to the same (postimage) path so the diffstat
|
||||
// actually attaches — the plain --numstat form brace-mangles the path and
|
||||
// the counts were silently lost.
|
||||
run("add", ".")
|
||||
run("commit", "-q", "-m", "second")
|
||||
run("mv", "tracked.txt", "renamed.txt")
|
||||
write("renamed.txt", "one\ntwo\nthree\nfour\nfive\n")
|
||||
renameSweep := gitSweepCmd(nil, dir, false)().(gitSweepMsg)
|
||||
if !renameSweep.ok {
|
||||
t.Fatal("rename sweep failed")
|
||||
}
|
||||
renamed := map[string]gitSweepFile{}
|
||||
for _, f := range renameSweep.files {
|
||||
renamed[f.path] = f
|
||||
}
|
||||
if f, ok := renamed["renamed.txt"]; !ok || f.adds != 1 {
|
||||
t.Fatalf("renamed file should carry its numstat under the new path, got %+v", renameSweep.files)
|
||||
}
|
||||
|
||||
// Not-a-repo → ok=false (the sweep latches off).
|
||||
if msg := gitSweepCmd(nil, t.TempDir(), false)().(gitSweepMsg); msg.ok {
|
||||
t.Fatal("a non-repo should report ok=false")
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,416 @@
|
||||
// files_panel.go renders the FILES section of the right context sidebar: the
|
||||
// workspace files this session has touched, newest first, with an A/M badge and
|
||||
// a +added/−removed diffstat per file, plus a pulsing row for the file whose
|
||||
// write is streaming right now. Like the swarm roster (sidebar.go), the touched
|
||||
// set is not separate model state — it is recovered on demand from the
|
||||
// transcript's tool-result rows (their changedFiles), so it survives resume for
|
||||
// free and can never drift from what the chat shows.
|
||||
//
|
||||
// Interaction (see handleTranscriptSelectionMouse): the first click on a row
|
||||
// SELECTS the file — its edit cards tint in the chat and the transcript scrolls
|
||||
// to the most recent one; a second click (or a click while the drill-in is
|
||||
// already open) opens the file view (file_view.go). Esc clears the selection.
|
||||
package tui
|
||||
|
||||
import (
|
||||
"fmt"
|
||||
"sort"
|
||||
"strings"
|
||||
|
||||
tea "charm.land/bubbletea/v2"
|
||||
|
||||
"github.com/Gitlawb/zero/internal/tools"
|
||||
)
|
||||
|
||||
// maxSidebarFiles caps the FILES rows so the section stays a glanceable set,
|
||||
// not a scrolling log; older files collapse into a "+N more" trailer.
|
||||
const maxSidebarFiles = 6
|
||||
|
||||
// touchedFile is one workspace file the session has mutated, aggregated across
|
||||
// every tool-result row that touched it.
|
||||
type touchedFile struct {
|
||||
path string
|
||||
adds int // total added lines across its diffs
|
||||
dels int // total removed lines across its diffs
|
||||
edits int // number of mutations
|
||||
created bool // first touch created the file (write_file "Created …")
|
||||
failed bool // the latest touch errored
|
||||
lastRowIndex int // transcript index of the most recent result touching it
|
||||
}
|
||||
|
||||
// touchedFiles recovers the session's touched-file roster from the transcript,
|
||||
// most recently touched first. Recomputed on demand (the value-receiver model
|
||||
// can't persist a registry from View), mirroring swarmSpawnedAgents; the scan is
|
||||
// a single pass over the transcript per render, same order as the sidebar's
|
||||
// other sections.
|
||||
func (m model) touchedFiles() []touchedFile {
|
||||
var files []touchedFile
|
||||
index := map[string]int{}
|
||||
for i, row := range m.transcript {
|
||||
if row.kind != rowToolResult || len(row.changedFiles) == 0 {
|
||||
continue
|
||||
}
|
||||
adds, dels := planDiffStat(row.detail)
|
||||
// A multi-file result (apply_patch spanning several files) must not charge
|
||||
// the WHOLE patch's totals to every file it touched — split the diff by its
|
||||
// per-file headers and attribute each file its own counts.
|
||||
var perFile map[string][2]int
|
||||
if len(row.changedFiles) > 1 {
|
||||
perFile = perFileDiffStats(row.detail)
|
||||
}
|
||||
for _, path := range row.changedFiles {
|
||||
if path == "" {
|
||||
continue
|
||||
}
|
||||
at, seen := index[path]
|
||||
if !seen {
|
||||
index[path] = len(files)
|
||||
files = append(files, touchedFile{
|
||||
path: path,
|
||||
created: resultRowCreatedFile(row),
|
||||
lastRowIndex: i,
|
||||
})
|
||||
at = len(files) - 1
|
||||
}
|
||||
fileAdds, fileDels := adds, dels
|
||||
if perFile != nil {
|
||||
// Headers were found: use this file's own counts. A path the split
|
||||
// couldn't attribute shows 0/0 rather than the inflated patch totals.
|
||||
counts := perFile[path]
|
||||
fileAdds, fileDels = counts[0], counts[1]
|
||||
}
|
||||
files[at].adds += fileAdds
|
||||
files[at].dels += fileDels
|
||||
files[at].edits++
|
||||
files[at].failed = row.status == tools.StatusError
|
||||
files[at].lastRowIndex = i
|
||||
}
|
||||
}
|
||||
// Most recently touched first: the file being worked on now belongs at the
|
||||
// top, like the sidebar's ACTIVITY feed. Sorted by last touch (not reversed
|
||||
// first-seen order): a file touched early and touched again last must list
|
||||
// first. Stable, so same-row files keep their changedFiles order.
|
||||
sort.SliceStable(files, func(i, j int) bool {
|
||||
return files[i].lastRowIndex > files[j].lastRowIndex
|
||||
})
|
||||
// Merge the git sweep's discoveries (bash/subagent mutations that carry no
|
||||
// changedFiles — files_git_sweep.go) below the transcript-derived entries,
|
||||
// skipping paths a tool result already reported.
|
||||
for _, f := range m.gitTouchedFiles() {
|
||||
if _, seen := index[f.path]; seen {
|
||||
continue
|
||||
}
|
||||
files = append(files, f)
|
||||
}
|
||||
return files
|
||||
}
|
||||
|
||||
// perFileDiffStats splits a (possibly multi-file) unified diff into per-path
|
||||
// +added/−removed counts, keyed by the workspace-relative path from each
|
||||
// section's "+++ b/…" header (the "--- a/…" old side when the new side is
|
||||
// /dev/null, i.e. a deletion). Returns nil when the detail carries no file
|
||||
// headers at all (write_file/edit_file previews may be bare hunks) — the caller
|
||||
// then falls back to whole-detail totals, which are correct for a single file.
|
||||
func perFileDiffStats(detail string) map[string][2]int {
|
||||
stats := map[string][2]int{}
|
||||
current, oldPath := "", ""
|
||||
normalize := func(line string, prefix string) string {
|
||||
path := strings.TrimSpace(line[4:])
|
||||
if tab := strings.IndexByte(path, '\t'); tab >= 0 {
|
||||
path = path[:tab] // unified-diff convention: optional timestamp after a tab
|
||||
}
|
||||
path = unquoteGitPath(path)
|
||||
if path == "/dev/null" {
|
||||
return ""
|
||||
}
|
||||
return strings.TrimPrefix(path, prefix)
|
||||
}
|
||||
for _, line := range strings.Split(detail, "\n") {
|
||||
switch {
|
||||
case strings.HasPrefix(line, "--- "):
|
||||
oldPath = normalize(line, "a/")
|
||||
case strings.HasPrefix(line, "+++ "):
|
||||
current = normalize(line, "b/")
|
||||
if current == "" {
|
||||
current = oldPath // deletion: charge the removed lines to the old path
|
||||
}
|
||||
case current == "":
|
||||
// Lines before the first header (or in an unattributable section).
|
||||
case strings.HasPrefix(line, "+"):
|
||||
counts := stats[current]
|
||||
counts[0]++
|
||||
stats[current] = counts
|
||||
case strings.HasPrefix(line, "-"):
|
||||
counts := stats[current]
|
||||
counts[1]++
|
||||
stats[current] = counts
|
||||
}
|
||||
}
|
||||
if len(stats) == 0 {
|
||||
return nil
|
||||
}
|
||||
return stats
|
||||
}
|
||||
|
||||
// resultRowCreatedFile reports whether a tool-result row reads as a file
|
||||
// creation ("tool result: write_file ok Created x (…)"), so the FILES row can
|
||||
// badge it A rather than M. Heuristic on the confirmation text write_file
|
||||
// already emits; a miss just shows M, never breaks anything.
|
||||
func resultRowCreatedFile(row transcriptRow) bool {
|
||||
return strings.Contains(row.text, " Created ")
|
||||
}
|
||||
|
||||
// liveEditingPath is the path of the file whose mutating tool call is streaming
|
||||
// its arguments RIGHT NOW (the same live write streamingToolCallView previews),
|
||||
// or "" when no mutation is in flight. It renders as a pulsing row pinned atop
|
||||
// the FILES section.
|
||||
func (m model) liveEditingPath() string {
|
||||
if m.streamCallDecoder == nil {
|
||||
return ""
|
||||
}
|
||||
switch m.streamCallName {
|
||||
case "write_file", "edit_file", "apply_patch":
|
||||
return m.streamCallDecoder.path
|
||||
}
|
||||
return ""
|
||||
}
|
||||
|
||||
// fileHit marks a rendered FILES row (by its ABSOLUTE index inside the rendered
|
||||
// sidebar) that is clickable, carrying the file it refers to.
|
||||
type fileHit struct {
|
||||
lineOffset int
|
||||
path string
|
||||
}
|
||||
|
||||
// sidebarFilesHeader renders the FILES section header with the touched count.
|
||||
func (m model) sidebarFilesHeader(width int) string {
|
||||
n := len(m.touchedFiles())
|
||||
if n == 0 {
|
||||
return sidebarHeader("FILES", width)
|
||||
}
|
||||
return sidebarHeaderWithCount("FILES", fmt.Sprintf("%d", n), zeroTheme.muted, width)
|
||||
}
|
||||
|
||||
// sidebarFileLines renders the FILES section body: the live "writing" pulse row
|
||||
// first, then the touched files newest-first, capped at maxSidebarFiles with a
|
||||
// "+N more" trailer. Returns nil when the session has touched nothing (the
|
||||
// caller shows a placeholder). The paired hits slice records each clickable
|
||||
// row's index WITHIN the returned lines.
|
||||
func (m model) sidebarFileLines(width int) ([]string, []fileHit) {
|
||||
files := m.touchedFiles()
|
||||
live := m.liveEditingPath()
|
||||
if len(files) == 0 && live == "" {
|
||||
return nil, nil
|
||||
}
|
||||
room := maxInt(4, width-3)
|
||||
var lines []string
|
||||
var hits []fileHit
|
||||
|
||||
// The file being written this instant: an accent pulse, not yet clickable
|
||||
// (its result row — the diff — doesn't exist until the call completes).
|
||||
if live != "" {
|
||||
lines = append(lines, " "+zeroTheme.accent.Render("●")+" "+
|
||||
zeroTheme.ink.Render(truncatePathLeft(live, room)))
|
||||
}
|
||||
|
||||
// Filter the live row out FIRST so the "+N more" trailer counts only rows
|
||||
// that could actually render — counting the skipped live entry would inflate
|
||||
// the overflow by one.
|
||||
visible := files[:0:0]
|
||||
for _, f := range files {
|
||||
if f.path != live {
|
||||
visible = append(visible, f)
|
||||
}
|
||||
}
|
||||
shown := 0
|
||||
for _, f := range visible {
|
||||
if shown >= maxSidebarFiles {
|
||||
lines = append(lines, " "+zeroTheme.faint.Render(fmt.Sprintf("+%d more", len(visible)-shown)))
|
||||
break
|
||||
}
|
||||
shown++
|
||||
hits = append(hits, fileHit{lineOffset: len(lines), path: f.path})
|
||||
lines = append(lines, m.renderFileRow(f, room))
|
||||
}
|
||||
return lines, hits
|
||||
}
|
||||
|
||||
// renderFileRow renders one touched file: status badge, left-truncated path,
|
||||
// and the +/− diffstat, with the selected file carrying an accent marker so the
|
||||
// selection reads in the sidebar as well as in the chat tint.
|
||||
func (m model) renderFileRow(f touchedFile, room int) string {
|
||||
badge := zeroTheme.muted.Render("M")
|
||||
switch {
|
||||
case f.failed:
|
||||
badge = zeroTheme.red.Render("✗")
|
||||
case f.created:
|
||||
badge = zeroTheme.green.Render("A")
|
||||
}
|
||||
// Reserve the diffstat's width so the path truncates around it.
|
||||
stat := ""
|
||||
if f.adds > 0 || f.dels > 0 {
|
||||
stat = fmt.Sprintf(" +%d −%d", f.adds, f.dels)
|
||||
}
|
||||
pathRoom := maxInt(4, room-len(stat))
|
||||
pathStyle := zeroTheme.muted
|
||||
lead := " "
|
||||
if m.selectedFile == f.path {
|
||||
lead = zeroTheme.accent.Render("▸")
|
||||
pathStyle = zeroTheme.ink
|
||||
}
|
||||
line := lead + badge + " " + pathStyle.Render(truncatePathLeft(f.path, pathRoom))
|
||||
if stat != "" {
|
||||
line += zeroTheme.faintest.Render(stat)
|
||||
}
|
||||
return line
|
||||
}
|
||||
|
||||
// sidebarFileSelectables returns the clickable FILES rows with their ABSOLUTE
|
||||
// index inside the rendered sidebar. The FILES section renders after PLAN in
|
||||
// renderContextSidebar: AGENTS header + body, blank + PLAN header + body, then
|
||||
// blank + FILES header, then the file rows. The offset accounting mirrors
|
||||
// sidebarPlanSelectables exactly, extended one section down.
|
||||
func (m model) sidebarFileSelectables(width int) []fileHit {
|
||||
lines, hits := m.sidebarFileLines(width)
|
||||
if len(lines) == 0 {
|
||||
return nil
|
||||
}
|
||||
agentBody := len(m.sidebarAgentLines(width))
|
||||
if agentBody == 0 {
|
||||
agentBody = 1 // the "no agents spawned" placeholder occupies one line
|
||||
}
|
||||
planBody := len(m.sidebarPlanLines(width))
|
||||
if planBody == 0 {
|
||||
planBody = 1 // the "no active plan" placeholder occupies one line
|
||||
}
|
||||
base := 1 + agentBody + 2 + planBody + 2 // sections above + (blank + FILES header)
|
||||
for i := range hits {
|
||||
hits[i].lineOffset += base
|
||||
}
|
||||
return hits
|
||||
}
|
||||
|
||||
// fileRowAtMouse maps a left-click in the context sidebar to a touched file,
|
||||
// mirroring planStepAtMouse's column/x gate. Rows truncated away by the
|
||||
// sidebar's height budget (or colliding with the token floor line) never match.
|
||||
func (m model) fileRowAtMouse(msg tea.MouseMsg) (string, bool) {
|
||||
if !m.sidebarActive() {
|
||||
return "", false
|
||||
}
|
||||
if m.setup.visible || m.providerWizard != nil || m.mcpAddWizard != nil || m.mcpManager != nil || m.picker != nil || m.suggestionsActive() {
|
||||
return "", false
|
||||
}
|
||||
sidebarW := sidebarWidth(m.width)
|
||||
if sidebarW <= 0 {
|
||||
return "", false
|
||||
}
|
||||
x0 := m.chatColumnWidth() + 3 // " │ " divider between the columns
|
||||
x, y := mouseX(msg), mouseY(msg)
|
||||
if x < x0 || x >= x0+sidebarW {
|
||||
return "", false
|
||||
}
|
||||
for _, hit := range m.sidebarFileSelectables(sidebarW) {
|
||||
if hit.lineOffset == y && hit.lineOffset < m.height-1 && hit.path != "" {
|
||||
return hit.path, true
|
||||
}
|
||||
}
|
||||
return "", false
|
||||
}
|
||||
|
||||
// rowTouchesSelectedFile reports whether a transcript row's mutation touched
|
||||
// the currently selected file, so its card renders with the selection tint.
|
||||
func (m model) rowTouchesSelectedFile(row transcriptRow) bool {
|
||||
if m.selectedFile == "" || row.kind != rowToolResult {
|
||||
return false
|
||||
}
|
||||
for _, path := range row.changedFiles {
|
||||
if path == m.selectedFile {
|
||||
return true
|
||||
}
|
||||
}
|
||||
return false
|
||||
}
|
||||
|
||||
// lastRowIndexForFile returns the transcript index of the most recent
|
||||
// tool-result row that touched path, or -1.
|
||||
func (m model) lastRowIndexForFile(path string) int {
|
||||
for i := len(m.transcript) - 1; i >= 0; i-- {
|
||||
row := m.transcript[i]
|
||||
if row.kind != rowToolResult {
|
||||
continue
|
||||
}
|
||||
for _, p := range row.changedFiles {
|
||||
if p == path {
|
||||
return i
|
||||
}
|
||||
}
|
||||
}
|
||||
return -1
|
||||
}
|
||||
|
||||
// selectFile marks path as the selected file and scrolls the transcript so its
|
||||
// most recent edit card is in view; the card tint comes from the renderers
|
||||
// reading selectedFile (rowTouchesSelectedFile).
|
||||
func (m model) selectFile(path string) model {
|
||||
m.selectedFile = path
|
||||
if offset, ok := m.scrollOffsetForTranscriptRow(m.lastRowIndexForFile(path)); ok {
|
||||
m.chatScrollOffset = offset
|
||||
if offset == 0 {
|
||||
m.chatBodyLines = 0
|
||||
}
|
||||
}
|
||||
return m
|
||||
}
|
||||
|
||||
// scrollOffsetForTranscriptRow computes the chatScrollOffset that places the
|
||||
// given transcript row's first rendered line at the top of the viewport (with
|
||||
// one line of breathing room), using the same layout metrics the scroll engine
|
||||
// itself uses. ok is false outside alt-screen or when the row isn't rendered
|
||||
// (e.g. skipped/collapsed).
|
||||
func (m model) scrollOffsetForTranscriptRow(rowIndex int) (int, bool) {
|
||||
if rowIndex < 0 || !m.altScreen || m.height <= 0 {
|
||||
return 0, false
|
||||
}
|
||||
width := m.chatColumnWidth()
|
||||
items := m.transcriptBodyItems(width, "")
|
||||
metrics := measureTranscriptBodyItems(items, m.transcriptBodyHeights)
|
||||
startY := -1
|
||||
for _, span := range metrics.spans {
|
||||
if span.kind == transcriptBodyItemRow && span.rowIndex == rowIndex {
|
||||
startY = span.startY
|
||||
break
|
||||
}
|
||||
}
|
||||
if startY < 0 {
|
||||
return 0, false
|
||||
}
|
||||
frame := m.scrollableTranscriptFrame(m.pinnedTitleBar(width), m.footerView(width))
|
||||
viewport := transcriptViewportForLayout(metrics, frame, m.chatScrollOffset)
|
||||
// The offset counts lines below the fold: window.start == total-height-offset,
|
||||
// so placing startY at the window top (minus one context line) means
|
||||
// offset = total - height - (startY - 1), clamped to the scroll range.
|
||||
offset := metrics.totalLines() - frame.bodyRect.height - (startY - 1)
|
||||
return clampInt(offset, 0, viewport.maxOffset()), true
|
||||
}
|
||||
|
||||
// truncatePathLeft fits a path into room cells by dropping leading components
|
||||
// ("internal/tui/sidebar.go" → "…/tui/sidebar.go"), keeping the filename — the
|
||||
// part that identifies the file — intact for as long as possible.
|
||||
func truncatePathLeft(path string, room int) string {
|
||||
if room <= 0 {
|
||||
return ""
|
||||
}
|
||||
if len(path) <= room {
|
||||
return path
|
||||
}
|
||||
const ellipsis = "…/"
|
||||
parts := strings.Split(path, "/")
|
||||
for start := 1; start < len(parts); start++ {
|
||||
candidate := ellipsis + strings.Join(parts[start:], "/")
|
||||
if len(candidate) <= room {
|
||||
return candidate
|
||||
}
|
||||
}
|
||||
// Even "…/name" overflows: fall back to a right-truncated basename.
|
||||
return truncateRunes(ellipsis+parts[len(parts)-1], room)
|
||||
}
|
||||
@@ -0,0 +1,317 @@
|
||||
package tui
|
||||
|
||||
import (
|
||||
"strings"
|
||||
"testing"
|
||||
|
||||
tea "charm.land/bubbletea/v2"
|
||||
|
||||
"github.com/Gitlawb/zero/internal/tools"
|
||||
)
|
||||
|
||||
// filesPanelTestModel is sidebarTestModel plus a couple of touched files: one
|
||||
// created, one edited twice (the second touch most recent).
|
||||
func filesPanelTestModel() model {
|
||||
m := sidebarTestModel()
|
||||
m.transcript = append(m.transcript,
|
||||
transcriptRow{kind: rowToolResult, tool: "write_file", id: "f1", status: tools.StatusOK,
|
||||
text: "tool result: write_file ok Created web/app.js (10 lines).",
|
||||
detail: "+let a = 1\n+let b = 2",
|
||||
changedFiles: []string{"web/app.js"}},
|
||||
transcriptRow{kind: rowToolResult, tool: "edit_file", id: "f2", status: tools.StatusOK,
|
||||
text: "tool result: edit_file ok Edited internal/tui/sidebar.go.",
|
||||
detail: "+added one\n-removed one",
|
||||
changedFiles: []string{"internal/tui/sidebar.go"}},
|
||||
transcriptRow{kind: rowToolResult, tool: "edit_file", id: "f3", status: tools.StatusOK,
|
||||
text: "tool result: edit_file ok Edited internal/tui/sidebar.go.",
|
||||
detail: "+two\n+three\n-gone",
|
||||
changedFiles: []string{"internal/tui/sidebar.go"}},
|
||||
)
|
||||
return m
|
||||
}
|
||||
|
||||
// TestTouchedFilesAggregates: the roster is recovered from tool-result rows,
|
||||
// newest-touch first, with per-file diffstat totals, edit counts, and the
|
||||
// created badge from write_file's confirmation text.
|
||||
func TestTouchedFilesAggregates(t *testing.T) {
|
||||
m := filesPanelTestModel()
|
||||
files := m.touchedFiles()
|
||||
if len(files) != 2 {
|
||||
t.Fatalf("expected 2 touched files, got %d: %+v", len(files), files)
|
||||
}
|
||||
// sidebar.go was touched last, so it lists first.
|
||||
if files[0].path != "internal/tui/sidebar.go" {
|
||||
t.Fatalf("most recently touched file should list first, got %q", files[0].path)
|
||||
}
|
||||
if files[0].adds != 3 || files[0].dels != 2 || files[0].edits != 2 {
|
||||
t.Errorf("sidebar.go diffstat = +%d −%d over %d edits, want +3 −2 over 2", files[0].adds, files[0].dels, files[0].edits)
|
||||
}
|
||||
if files[0].created {
|
||||
t.Error("edited file must not read as created")
|
||||
}
|
||||
if !files[1].created {
|
||||
t.Error("write_file 'Created …' result should mark the file created")
|
||||
}
|
||||
if files[0].lastRowIndex != len(m.transcript)-1 {
|
||||
t.Errorf("lastRowIndex = %d, want the final transcript row", files[0].lastRowIndex)
|
||||
}
|
||||
}
|
||||
|
||||
// TestSidebarFileLinesRenderAndOverflow: rows carry the badge + left-truncated
|
||||
// path + diffstat; beyond maxSidebarFiles the tail collapses into "+N more";
|
||||
// hits index only real file rows.
|
||||
func TestSidebarFileLinesRenderAndOverflow(t *testing.T) {
|
||||
m := filesPanelTestModel()
|
||||
lines, hits := m.sidebarFileLines(34)
|
||||
joined := plainRender(t, strings.Join(lines, "\n"))
|
||||
if !strings.Contains(joined, "sidebar.go") || !strings.Contains(joined, "app.js") {
|
||||
t.Fatalf("file rows missing paths:\n%s", joined)
|
||||
}
|
||||
if !strings.Contains(joined, "+3 −2") {
|
||||
t.Errorf("expected aggregated diffstat +3 −2:\n%s", joined)
|
||||
}
|
||||
if !strings.Contains(joined, "A") || !strings.Contains(joined, "M") {
|
||||
t.Errorf("expected A and M badges:\n%s", joined)
|
||||
}
|
||||
if len(hits) != 2 {
|
||||
t.Fatalf("expected 2 clickable hits, got %d", len(hits))
|
||||
}
|
||||
if hits[0].path != "internal/tui/sidebar.go" {
|
||||
t.Errorf("first hit should be the newest file, got %q", hits[0].path)
|
||||
}
|
||||
|
||||
// Overflow: 8 distinct files -> maxSidebarFiles rows + a "+2 more" trailer.
|
||||
over := sidebarTestModel()
|
||||
for _, name := range []string{"a", "b", "c", "d", "e", "f", "g", "h"} {
|
||||
over.transcript = append(over.transcript, transcriptRow{
|
||||
kind: rowToolResult, tool: "edit_file", id: name, status: tools.StatusOK,
|
||||
changedFiles: []string{name + ".go"},
|
||||
})
|
||||
}
|
||||
overLines, overHits := over.sidebarFileLines(34)
|
||||
if len(overHits) != maxSidebarFiles {
|
||||
t.Fatalf("expected %d clickable rows, got %d", maxSidebarFiles, len(overHits))
|
||||
}
|
||||
if got := plainRender(t, overLines[len(overLines)-1]); !strings.Contains(got, "+2 more") {
|
||||
t.Errorf("expected '+2 more' trailer, got %q", got)
|
||||
}
|
||||
}
|
||||
|
||||
// TestSidebarFilesLivePulseRow: while a mutating tool call streams its args,
|
||||
// the file it is writing shows as a pinned (unclickable) pulse row.
|
||||
func TestSidebarFilesLivePulseRow(t *testing.T) {
|
||||
m := filesPanelTestModel()
|
||||
m.streamCallName = "write_file"
|
||||
m.streamCallDecoder = newStreamingDecoder()
|
||||
m.streamCallDecoder.feed(`{"path":"web/new.css","content":"body{}`)
|
||||
|
||||
lines, hits := m.sidebarFileLines(34)
|
||||
if got := plainRender(t, lines[0]); !strings.Contains(got, "web/new.css") {
|
||||
t.Fatalf("live write should pin its path atop FILES, got %q", got)
|
||||
}
|
||||
for _, hit := range hits {
|
||||
if hit.path == "web/new.css" {
|
||||
t.Error("the live row must not be clickable (no result exists yet)")
|
||||
}
|
||||
}
|
||||
// A non-mutating streaming call shows no pulse row.
|
||||
m.streamCallName = "read_file"
|
||||
if m.liveEditingPath() != "" {
|
||||
t.Error("read_file must not read as a live edit")
|
||||
}
|
||||
}
|
||||
|
||||
// TestSidebarFileSelectablesMatchRenderedRows: the hit offsets computed by
|
||||
// sidebarFileSelectables must land exactly on the rendered FILES rows in
|
||||
// renderContextSidebar's output — the same invariant the mouse hit-test relies
|
||||
// on. Asserted against the real render, not a re-derivation of the math.
|
||||
func TestSidebarFileSelectablesMatchRenderedRows(t *testing.T) {
|
||||
m := filesPanelTestModel()
|
||||
width := sidebarWidth(m.width)
|
||||
rendered := m.renderContextSidebar(width, m.height)
|
||||
hits := m.sidebarFileSelectables(width)
|
||||
if len(hits) == 0 {
|
||||
t.Fatal("expected clickable FILES rows")
|
||||
}
|
||||
for _, hit := range hits {
|
||||
if hit.lineOffset >= len(rendered) {
|
||||
t.Fatalf("hit offset %d beyond rendered sidebar (%d lines)", hit.lineOffset, len(rendered))
|
||||
}
|
||||
line := plainRender(t, rendered[hit.lineOffset])
|
||||
base := hit.path[strings.LastIndex(hit.path, "/")+1:]
|
||||
if !strings.Contains(line, base) {
|
||||
t.Errorf("hit for %q points at line %d which reads %q", hit.path, hit.lineOffset, line)
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
// TestFileRowClickSelectsThenOpens: the first sidebar click on a file selects
|
||||
// it (tint + scroll state, no view swap); the second click on the same file
|
||||
// opens the drill-in; clicking another file while the view is open switches it.
|
||||
func TestFileRowClickSelectsThenOpens(t *testing.T) {
|
||||
m := filesPanelTestModel()
|
||||
width := sidebarWidth(m.width)
|
||||
hits := m.sidebarFileSelectables(width)
|
||||
if len(hits) < 2 {
|
||||
t.Fatal("expected two clickable FILES rows")
|
||||
}
|
||||
x := m.chatColumnWidth() + 3
|
||||
click := func(hit fileHit) tea.MouseMsg { return testMouseClick(tea.MouseLeft, x, hit.lineOffset) }
|
||||
|
||||
m1, _, handled := m.handleTranscriptSelectionMouse(click(hits[0]))
|
||||
if !handled {
|
||||
t.Fatal("FILES row click should be handled")
|
||||
}
|
||||
if m1.selectedFile != hits[0].path || m1.fileView.active {
|
||||
t.Fatalf("first click should select (not open): selected=%q active=%v", m1.selectedFile, m1.fileView.active)
|
||||
}
|
||||
|
||||
m2, _, _ := m1.handleTranscriptSelectionMouse(click(hits[0]))
|
||||
if !m2.fileView.active || m2.fileView.path != hits[0].path {
|
||||
t.Fatalf("second click should open the file view: %+v", m2.fileView)
|
||||
}
|
||||
|
||||
m3, _, _ := m2.handleTranscriptSelectionMouse(click(hits[1]))
|
||||
if !m3.fileView.active || m3.fileView.path != hits[1].path {
|
||||
t.Fatalf("clicking another file with the view open should switch it: %+v", m3.fileView)
|
||||
}
|
||||
if m3.selectedFile != hits[1].path {
|
||||
t.Errorf("switching the view should move the selection too, got %q", m3.selectedFile)
|
||||
}
|
||||
}
|
||||
|
||||
// TestRowTouchesSelectedFileTint: only tool-result rows whose changedFiles
|
||||
// carry the selected path tint, and the render cache key differs across
|
||||
// selection states so the tint can't be served stale.
|
||||
func TestRowTouchesSelectedFileTint(t *testing.T) {
|
||||
m := filesPanelTestModel()
|
||||
row := m.transcript[len(m.transcript)-1]
|
||||
if m.rowTouchesSelectedFile(row) {
|
||||
t.Fatal("nothing selected: no row should tint")
|
||||
}
|
||||
m.selectedFile = "internal/tui/sidebar.go"
|
||||
if !m.rowTouchesSelectedFile(row) {
|
||||
t.Fatal("selected file's edit row should tint")
|
||||
}
|
||||
other := m.transcript[len(m.transcript)-3] // web/app.js
|
||||
if m.rowTouchesSelectedFile(other) {
|
||||
t.Fatal("an unrelated file's row must not tint")
|
||||
}
|
||||
|
||||
rc := buildRowContext(m.transcript)
|
||||
opts := cardRenderOptions{bodyCap: cardBodyMaxLines, cwd: m.cwd}
|
||||
selectedKey, _ := m.renderRowCacheKey(row, 80, rc, opts, false)
|
||||
m.selectedFile = ""
|
||||
plainKey, _ := m.renderRowCacheKey(row, 80, rc, opts, false)
|
||||
if selectedKey == plainKey {
|
||||
t.Error("render cache key must change with the selection state")
|
||||
}
|
||||
}
|
||||
|
||||
// TestEscClearsFileSelectionThenNothing: Esc drops an active file selection
|
||||
// (before any run-level action) and is consumed doing so.
|
||||
func TestEscClearsFileSelectionThenNothing(t *testing.T) {
|
||||
m := filesPanelTestModel()
|
||||
m.selectedFile = "web/app.js"
|
||||
updated, _ := m.Update(tea.KeyPressMsg{Code: tea.KeyEsc})
|
||||
if got := updated.(model).selectedFile; got != "" {
|
||||
t.Fatalf("Esc should clear the file selection, still %q", got)
|
||||
}
|
||||
}
|
||||
|
||||
func TestTruncatePathLeft(t *testing.T) {
|
||||
if got := truncatePathLeft("internal/tui/sidebar.go", 40); got != "internal/tui/sidebar.go" {
|
||||
t.Errorf("short path should pass through, got %q", got)
|
||||
}
|
||||
if got := truncatePathLeft("internal/tui/sidebar.go", 18); got != "…/tui/sidebar.go" {
|
||||
t.Errorf("want …/tui/sidebar.go, got %q", got)
|
||||
}
|
||||
if got := truncatePathLeft("internal/tui/sidebar.go", 14); got != "…/sidebar.go" {
|
||||
t.Errorf("want …/sidebar.go, got %q", got)
|
||||
}
|
||||
}
|
||||
|
||||
// TestTouchedFilesPerFileDiffStat: a multi-file result (apply_patch spanning
|
||||
// several files) must charge each file its OWN +/- counts from the per-file
|
||||
// diff sections — not the whole patch's totals to every file it touched.
|
||||
func TestTouchedFilesPerFileDiffStat(t *testing.T) {
|
||||
m := sidebarTestModel()
|
||||
patch := "diff --git a/web/one.js b/web/one.js\n" +
|
||||
"--- a/web/one.js\n+++ b/web/one.js\n@@ -1,1 +1,2 @@\n+added one\n+added two\n" +
|
||||
"diff --git a/web/two.js b/web/two.js\n" +
|
||||
"--- a/web/two.js\n+++ b/web/two.js\n@@ -1,2 +1,1 @@\n-gone one\n-gone two\n-gone three\n"
|
||||
m.transcript = append(m.transcript, transcriptRow{
|
||||
kind: rowToolResult, tool: "apply_patch", id: "p1", status: tools.StatusOK,
|
||||
detail: patch,
|
||||
changedFiles: []string{"web/one.js", "web/two.js"},
|
||||
})
|
||||
byPath := map[string]touchedFile{}
|
||||
for _, f := range m.touchedFiles() {
|
||||
byPath[f.path] = f
|
||||
}
|
||||
if f := byPath["web/one.js"]; f.adds != 2 || f.dels != 0 {
|
||||
t.Errorf("web/one.js = +%d −%d, want its own +2 −0 (not the patch totals)", f.adds, f.dels)
|
||||
}
|
||||
if f := byPath["web/two.js"]; f.adds != 0 || f.dels != 3 {
|
||||
t.Errorf("web/two.js = +%d −%d, want its own +0 −3 (not the patch totals)", f.adds, f.dels)
|
||||
}
|
||||
}
|
||||
|
||||
// TestTouchedFilesRetouchOrdersByLastTouch: touch a, then b, then a again — a
|
||||
// must list first. The old "reverse first-seen order" put b first because a's
|
||||
// slot kept its original position.
|
||||
func TestTouchedFilesRetouchOrdersByLastTouch(t *testing.T) {
|
||||
m := sidebarTestModel()
|
||||
for _, step := range []struct{ id, path string }{
|
||||
{"r1", "a.go"}, {"r2", "b.go"}, {"r3", "a.go"},
|
||||
} {
|
||||
m.transcript = append(m.transcript, transcriptRow{
|
||||
kind: rowToolResult, tool: "edit_file", id: step.id, status: tools.StatusOK,
|
||||
changedFiles: []string{step.path},
|
||||
})
|
||||
}
|
||||
files := m.touchedFiles()
|
||||
if len(files) != 2 || files[0].path != "a.go" {
|
||||
t.Fatalf("the re-touched file must list first, got %+v", files)
|
||||
}
|
||||
}
|
||||
|
||||
// TestSidebarFileLinesOverflowExcludesLiveRow: when the live-writing file is
|
||||
// also a touched file, it renders as the pulse row and is skipped from the
|
||||
// list — the "+N more" trailer must not count that skipped entry.
|
||||
func TestSidebarFileLinesOverflowExcludesLiveRow(t *testing.T) {
|
||||
m := sidebarTestModel()
|
||||
for _, name := range []string{"a", "b", "c", "d", "e", "f", "g", "h"} {
|
||||
m.transcript = append(m.transcript, transcriptRow{
|
||||
kind: rowToolResult, tool: "edit_file", id: name, status: tools.StatusOK,
|
||||
changedFiles: []string{name + ".go"},
|
||||
})
|
||||
}
|
||||
// h.go (a touched file) is ALSO the live write: 7 listable files remain,
|
||||
// 6 render, so the trailer is +1 — not +2 (which counted the skipped live row).
|
||||
m.streamCallName = "edit_file"
|
||||
m.streamCallDecoder = newStreamingDecoder()
|
||||
m.streamCallDecoder.feed(`{"path":"h.go","content":"x`)
|
||||
|
||||
lines, _ := m.sidebarFileLines(34)
|
||||
trailer := plainRender(t, lines[len(lines)-1])
|
||||
if !strings.Contains(trailer, "+1 more") {
|
||||
t.Fatalf("overflow must exclude the live row from the count, got %q", trailer)
|
||||
}
|
||||
}
|
||||
|
||||
// TestSidebarHasContentForLiveWrite: the sidebar counts an in-flight first
|
||||
// write as content, so the FILES pulse is visible before any result row lands.
|
||||
func TestSidebarHasContentForLiveWrite(t *testing.T) {
|
||||
m := sidebarTestModel()
|
||||
m.plan.steps = nil // drop the helper's seeded plan: no agents/plan/files now
|
||||
if m.sidebarHasContent() {
|
||||
t.Fatal("session without agents/plan/files should have no sidebar content")
|
||||
}
|
||||
m.streamCallName = "write_file"
|
||||
m.streamCallDecoder = newStreamingDecoder()
|
||||
m.streamCallDecoder.feed(`{"path":"web/new.css","content":"body{}`)
|
||||
if !m.sidebarHasContent() {
|
||||
t.Fatal("a live in-flight write must count as sidebar content")
|
||||
}
|
||||
}
|
||||
@@ -122,6 +122,8 @@ func TestEscCancellationLeavesVisibleMarker(t *testing.T) {
|
||||
|
||||
updated, _ := m.Update(testKey(tea.KeyEsc))
|
||||
next := updated.(model)
|
||||
updated, _ = next.Update(testKey(tea.KeyEsc))
|
||||
next = updated.(model)
|
||||
if !transcriptContains(next.transcript, "Run cancelled.") {
|
||||
t.Fatalf("expected visible cancellation marker, got %#v", next.transcript)
|
||||
}
|
||||
|
||||
@@ -15,6 +15,9 @@ const (
|
||||
// hoverPlanStep: a plan step row in the sidebar's PLAN section, identified by
|
||||
// step index.
|
||||
hoverPlanStep
|
||||
// hoverFileRow: a touched-file row in the sidebar's FILES section, identified
|
||||
// by path.
|
||||
hoverFileRow
|
||||
)
|
||||
|
||||
// hoverTarget identifies the single clickable row (if any) currently under the
|
||||
@@ -34,6 +37,7 @@ type hoverTarget struct {
|
||||
bodyY int // hoverTranscript
|
||||
sessionID string // hoverSidebarAgent
|
||||
stepIndex int // hoverPlanStep
|
||||
filePath string // hoverFileRow
|
||||
}
|
||||
|
||||
// mouseHover reports whether msg is a plain cursor-movement event with NO button
|
||||
@@ -59,6 +63,9 @@ func (m model) updateHoverTarget(msg tea.MouseMsg) model {
|
||||
if stepIndex, ok := m.planStepAtMouse(msg); ok {
|
||||
return m.withHover(hoverTarget{kind: hoverPlanStep, stepIndex: stepIndex})
|
||||
}
|
||||
if path, ok := m.fileRowAtMouse(msg); ok {
|
||||
return m.withHover(hoverTarget{kind: hoverFileRow, filePath: path})
|
||||
}
|
||||
if line, ok := m.transcriptLineAtMouse(msg); ok {
|
||||
// A permission option reuses its OWN existing keyboard-cursor highlight
|
||||
// (see hoverPermissionOption) rather than the m.hover mechanism, so there's
|
||||
|
||||
@@ -0,0 +1,59 @@
|
||||
package tui
|
||||
|
||||
import (
|
||||
"context"
|
||||
"reflect"
|
||||
"testing"
|
||||
|
||||
tea "charm.land/bubbletea/v2"
|
||||
)
|
||||
|
||||
// TestInitRequestsWindowSize: Bubble Tea documents an initial WindowSizeMsg as
|
||||
// delivered automatically on program start, but that's the terminal
|
||||
// proactively pushing a size — if it's ever missed (a slow/unusual terminal,
|
||||
// a multiplexer, a startup race), nothing else asks again, m.height stays 0
|
||||
// forever, and transcriptView's `if m.altScreen && m.height > 0` gate falls
|
||||
// back to the unpadded, non-fullscreen render path for the whole session (the
|
||||
// alt-screen viewport never gets filled below the actual content). Init must
|
||||
// explicitly request it too, the same way it already explicitly requests the
|
||||
// background color rather than relying solely on an unprompted push.
|
||||
func TestInitRequestsWindowSize(t *testing.T) {
|
||||
m := newModel(context.Background(), Options{ModelName: "gpt-4"})
|
||||
cmd := m.Init()
|
||||
if cmd == nil {
|
||||
t.Fatal("Init() must return a non-nil command")
|
||||
}
|
||||
|
||||
want := reflect.ValueOf(tea.RequestWindowSize).Pointer()
|
||||
if !batchContainsCmd(t, cmd, want) {
|
||||
t.Error("Init() must request the window size (tea.RequestWindowSize), not rely solely on the terminal's unprompted initial WindowSizeMsg")
|
||||
}
|
||||
}
|
||||
|
||||
// batchContainsCmd reports whether cmd (Init()'s single top-level
|
||||
// tea.Batch(...)) contains a sub-command matching want, compared by pointer
|
||||
// (the same technique TestThemeAutoReProbesBackground uses for
|
||||
// tea.RequestBackgroundColor — reliable for named top-level functions like
|
||||
// tea.RequestWindowSize, not closures). Invokes cmd itself once to unpack the
|
||||
// tea.BatchMsg, but only pointer-compares the sub-commands — never calls
|
||||
// them, since Init()'s batch also carries real closures (e.g. provider model
|
||||
// discovery) that make live network calls and must not fire in a unit test.
|
||||
func batchContainsCmd(t *testing.T, cmd tea.Cmd, want uintptr) bool {
|
||||
t.Helper()
|
||||
if cmd == nil {
|
||||
return false
|
||||
}
|
||||
if reflect.ValueOf(cmd).Pointer() == want {
|
||||
return true
|
||||
}
|
||||
batch, ok := cmd().(tea.BatchMsg)
|
||||
if !ok {
|
||||
return false
|
||||
}
|
||||
for _, sub := range batch {
|
||||
if sub != nil && reflect.ValueOf(sub).Pointer() == want {
|
||||
return true
|
||||
}
|
||||
}
|
||||
return false
|
||||
}
|
||||
@@ -31,7 +31,7 @@ var keybindingGroups = []keybindingGroup{
|
||||
bindings: []keybinding{
|
||||
{"Enter", "send the message"},
|
||||
{"Alt+Enter", "insert a newline (multi-line compose)"},
|
||||
{"Esc", "cancel the run / dismiss a popup / clear the input"},
|
||||
{"Esc (×2)", "cancel the run / dismiss a popup / clear the input"},
|
||||
{"Ctrl+C", "cancel the run, then quit"},
|
||||
{"?", "show this help (on an empty input)"},
|
||||
},
|
||||
|
||||
+288
-101
@@ -25,6 +25,7 @@ import (
|
||||
"github.com/Gitlawb/zero/internal/notify"
|
||||
"github.com/Gitlawb/zero/internal/providerhealth"
|
||||
"github.com/Gitlawb/zero/internal/providermodeldiscovery"
|
||||
"github.com/Gitlawb/zero/internal/providers/providerio"
|
||||
"github.com/Gitlawb/zero/internal/sandbox"
|
||||
"github.com/Gitlawb/zero/internal/sessions"
|
||||
"github.com/Gitlawb/zero/internal/streamjson"
|
||||
@@ -40,6 +41,15 @@ const chatWheelScrollLines = 5
|
||||
const ctrlCExitConfirmDuration = 3 * time.Second
|
||||
const ctrlCExitConfirmText = "Press Ctrl+C again to exit"
|
||||
|
||||
// escCancelConfirmDuration/escCancelConfirmText guard Esc cancelling a running
|
||||
// turn, mirroring ctrlCExitConfirmDuration/ctrlCExitConfirmText's pattern (same
|
||||
// window, same amber footer treatment) so the two "stop it" keybinds feel
|
||||
// consistent. Without this, a single stray Esc — e.g. meant to dismiss a
|
||||
// suggestion overlay that had already closed — silently threw away an
|
||||
// in-progress run with no chance to reconsider.
|
||||
const escCancelConfirmDuration = 3 * time.Second
|
||||
const escCancelConfirmText = "Press Esc again to cancel"
|
||||
|
||||
// dragEdgeScrollInterval/dragEdgeScrollStep drive the smooth-glide auto-scroll
|
||||
// while a drag holds past the transcript edge (see edgeScrollDelta). A small step
|
||||
// on a short, steady cadence reads as a smooth continuous scroll; the wheel-scroll
|
||||
@@ -48,40 +58,41 @@ const dragEdgeScrollInterval = 70 * time.Millisecond
|
||||
const dragEdgeScrollStep = 1
|
||||
|
||||
type model struct {
|
||||
ctx context.Context
|
||||
cwd string
|
||||
userCommands []usercommands.Command // file-sourced /commands (.zero/commands)
|
||||
userConfigPath string
|
||||
doctorUserConfigPath string
|
||||
projectConfigPath string
|
||||
gitBranch string
|
||||
providerName string
|
||||
modelName string
|
||||
providerProfile config.ProviderProfile
|
||||
savedProviders []config.ProviderProfile
|
||||
provider zeroruntime.Provider
|
||||
newProvider func(config.ProviderProfile) (zeroruntime.Provider, error)
|
||||
probeProviderHealth func(context.Context, providerhealth.Options) providerhealth.Result
|
||||
discoverProviderModels func(context.Context, config.ProviderProfile) ([]providermodeldiscovery.Model, error)
|
||||
registry *tools.Registry
|
||||
sessionStore *sessions.Store
|
||||
sandboxStore *sandbox.GrantStore
|
||||
mcpConfig config.MCPConfig
|
||||
mcpPermissionStore *internalmcp.PermissionStore
|
||||
mcpTokenStore *internalmcp.TokenStore
|
||||
mcpCommand func(context.Context, []string) MCPCommandResult
|
||||
sandboxSetupCommand func(context.Context) SandboxSetupCommandResult
|
||||
mcpViewStateCache MCPViewState
|
||||
mcpViewStateReady bool
|
||||
mcpCommandSeq int
|
||||
mcpCommandCancel context.CancelFunc
|
||||
sandboxSetupSeq int
|
||||
sandboxSetupInFlight bool
|
||||
doctorCommandSeq int
|
||||
doctorInFlight bool
|
||||
doctorFrame int
|
||||
activeSession sessions.Metadata
|
||||
sessionEvents []sessions.Event
|
||||
ctx context.Context
|
||||
cwd string
|
||||
userCommands []usercommands.Command // file-sourced /commands (.zero/commands)
|
||||
userConfigPath string
|
||||
doctorUserConfigPath string
|
||||
projectConfigPath string
|
||||
gitBranch string
|
||||
providerName string
|
||||
modelName string
|
||||
providerProfile config.ProviderProfile
|
||||
savedProviders []config.ProviderProfile
|
||||
provider zeroruntime.Provider
|
||||
newProvider func(config.ProviderProfile) (zeroruntime.Provider, error)
|
||||
probeProviderHealth func(context.Context, providerhealth.Options) providerhealth.Result
|
||||
discoverProviderModels func(context.Context, config.ProviderProfile) ([]providermodeldiscovery.Model, error)
|
||||
discoverOllamaContextWindow func(ctx context.Context, baseURL string, model string) (int, error)
|
||||
registry *tools.Registry
|
||||
sessionStore *sessions.Store
|
||||
sandboxStore *sandbox.GrantStore
|
||||
mcpConfig config.MCPConfig
|
||||
mcpPermissionStore *internalmcp.PermissionStore
|
||||
mcpTokenStore *internalmcp.TokenStore
|
||||
mcpCommand func(context.Context, []string) MCPCommandResult
|
||||
sandboxSetupCommand func(context.Context) SandboxSetupCommandResult
|
||||
mcpViewStateCache MCPViewState
|
||||
mcpViewStateReady bool
|
||||
mcpCommandSeq int
|
||||
mcpCommandCancel context.CancelFunc
|
||||
sandboxSetupSeq int
|
||||
sandboxSetupInFlight bool
|
||||
doctorCommandSeq int
|
||||
doctorInFlight bool
|
||||
doctorFrame int
|
||||
activeSession sessions.Metadata
|
||||
sessionEvents []sessions.Event
|
||||
// titledSessions records session ids for which a model-generated title has
|
||||
// already been attempted this process, so a finished turn re-fires the title
|
||||
// generator at most once per session (even before its async result lands).
|
||||
@@ -200,6 +211,22 @@ type model struct {
|
||||
// sidebar; when set, the chat reflows to full width. Distinct from the
|
||||
// availability conditions in sidebarAvailable (geometry / mode / overlays).
|
||||
sidebarHidden bool
|
||||
// selectedFile is the touched file selected by clicking its FILES sidebar
|
||||
// row: its edit cards tint in the chat (rowTouchesSelectedFile) and a second
|
||||
// click opens the drill-in file view. "" when nothing is selected; Esc clears.
|
||||
selectedFile string
|
||||
// fileView is the drill-in view for a touched file (file_view.go): while
|
||||
// active the chat column's body shows the file's diff/content instead of the
|
||||
// transcript, mirroring the subchat drill-in.
|
||||
fileView fileViewState
|
||||
// Git-sweep state (files_git_sweep.go): the startup snapshot of already-dirty
|
||||
// paths (nil until Init's sweep answers), the newly dirty files discovered by
|
||||
// live sweeps (bash/subagent mutations that carry no changedFiles), the
|
||||
// single-flight guard, and the "not a git repo / no git" latch.
|
||||
gitFileBaseline map[string]bool
|
||||
gitTouched []gitSweepFile
|
||||
gitSweepInFlight bool
|
||||
gitSweepUnavailable bool
|
||||
// swarmDoneAt records when each swarm member was first seen finished (done/
|
||||
// failed) in a swarm_status report, so the sidebar can linger it briefly with a
|
||||
// fading ✓ before dropping it (a smooth exit, not an abrupt pop). Stamped in the
|
||||
@@ -296,6 +323,14 @@ type model struct {
|
||||
copyStatusSeq int
|
||||
exitConfirmActive bool
|
||||
exitConfirmSeq int
|
||||
// cancelConfirmActive/cancelConfirmSeq mirror exitConfirmActive/exitConfirmSeq
|
||||
// (same seq-gated tea.Tick pattern) but guard a DIFFERENT action: Esc
|
||||
// cancelling a running turn. The two are deliberately separate state (not a
|
||||
// shared flag) since they're different actions with different consequences
|
||||
// (quit the app vs. cancel the current run) that are armed by different
|
||||
// keys — Ctrl+C and Esc respectively.
|
||||
cancelConfirmActive bool
|
||||
cancelConfirmSeq int
|
||||
// edgeScrollDelta drives the smooth-glide auto-scroll while a drag holds past
|
||||
// the transcript's top/bottom edge: 0 when idle, else the signed per-tick step
|
||||
// (matches transcriptEdgeScrollDelta's sign convention). A self-scheduling
|
||||
@@ -330,6 +365,12 @@ type model struct {
|
||||
// catalog descriptor ID), so /model shows each provider's real current models —
|
||||
// the same list the provider-setup wizard discovers — not the static catalog.
|
||||
modelPickerLiveByProvider map[string][]providermodeldiscovery.Model
|
||||
// ollamaContextWindowByModel holds context-window sizes fetched from a local
|
||||
// Ollama daemon's native /api/show endpoint (keyed by model name), for
|
||||
// custom/local models that have no curated-catalog entry and whose
|
||||
// OpenAI-compatible /v1/models listing doesn't carry that metadata at all —
|
||||
// see modelContextWindow.
|
||||
ollamaContextWindowByModel map[string]int
|
||||
|
||||
// pendingImages holds image attachments staged by /image for the next user
|
||||
// turn; pendingImageLabels are their display names (base(path)) for the chip
|
||||
@@ -358,6 +399,12 @@ type exitConfirmExpiredMsg struct {
|
||||
seq int
|
||||
}
|
||||
|
||||
// cancelConfirmExpiredMsg mirrors exitConfirmExpiredMsg for the Esc
|
||||
// cancel-a-run confirmation (see cancelConfirmActive).
|
||||
type cancelConfirmExpiredMsg struct {
|
||||
seq int
|
||||
}
|
||||
|
||||
// dragEdgeScrollTickMsg advances the smooth-glide auto-scroll one step (see
|
||||
// edgeScrollDelta). seq must match m.edgeScrollSeq or the tick is stale (the
|
||||
// drag moved back into the body, released, or was otherwise stopped since this
|
||||
@@ -645,56 +692,57 @@ func newModel(ctx context.Context, options Options) model {
|
||||
notifier.SetFocused(true)
|
||||
|
||||
m := model{
|
||||
ctx: ctx,
|
||||
cwd: cwd,
|
||||
swarmDoneAt: map[string]time.Time{},
|
||||
userCommands: loadedUserCommands,
|
||||
composerCursorVisible: true,
|
||||
userConfigPath: options.UserConfigPath,
|
||||
doctorUserConfigPath: doctorUserConfigPath,
|
||||
projectConfigPath: options.ProjectConfigPath,
|
||||
savedProviders: options.SavedProviders,
|
||||
gitBranch: gitBranch(cwd),
|
||||
providerName: options.ProviderName,
|
||||
modelName: options.ModelName,
|
||||
providerProfile: options.ProviderProfile,
|
||||
favoriteModels: favoriteModelSet(options.FavoriteModels),
|
||||
recapsEnabled: options.RecapsEnabled,
|
||||
provider: options.Provider,
|
||||
newProvider: options.NewProvider,
|
||||
probeProviderHealth: options.ProbeProviderHealth,
|
||||
discoverProviderModels: options.DiscoverProviderModels,
|
||||
registry: registry,
|
||||
sessionStore: sessionStore,
|
||||
sandboxStore: sandboxStore,
|
||||
mcpConfig: options.MCPConfig,
|
||||
mcpPermissionStore: options.MCPPermissionStore,
|
||||
mcpTokenStore: options.MCPTokenStore,
|
||||
mcpCommand: options.MCPCommand,
|
||||
sandboxSetupCommand: options.SandboxSetupCommand,
|
||||
agentOptions: options.AgentOptions,
|
||||
sessionCompactor: options.SessionCompactor,
|
||||
runtimeMessageSink: options.RuntimeMessageSink,
|
||||
permissionMode: permissionMode,
|
||||
reasoningEffort: options.ReasoningEffort,
|
||||
responseStyle: defaultedResponseStyle(options.ResponseStyle),
|
||||
themeMode: resolveThemeMode(options.Theme, os.Getenv("ZERO_THEME"), options.SavedTheme),
|
||||
hasDarkBg: true,
|
||||
userAgent: options.UserAgent,
|
||||
usageTracker: usageTracker,
|
||||
transcript: initialTranscript(),
|
||||
transcriptBodyHeights: newTranscriptBodyHeightCache(defaultTranscriptBodyHeightCacheMaxEntries),
|
||||
prService: prService,
|
||||
prState: prService.GetState(),
|
||||
input: input,
|
||||
spinner: runSpinner,
|
||||
now: time.Now,
|
||||
notifier: notifier,
|
||||
altScreen: options.AltScreen,
|
||||
liveUsageCounts: map[int]int{},
|
||||
swarmSessionMap: map[string]string{},
|
||||
setup: newSetupState(options.Setup),
|
||||
setupSave: options.Setup.Save,
|
||||
ctx: ctx,
|
||||
cwd: cwd,
|
||||
swarmDoneAt: map[string]time.Time{},
|
||||
userCommands: loadedUserCommands,
|
||||
composerCursorVisible: true,
|
||||
userConfigPath: options.UserConfigPath,
|
||||
doctorUserConfigPath: doctorUserConfigPath,
|
||||
projectConfigPath: options.ProjectConfigPath,
|
||||
savedProviders: options.SavedProviders,
|
||||
gitBranch: gitBranch(cwd),
|
||||
providerName: options.ProviderName,
|
||||
modelName: options.ModelName,
|
||||
providerProfile: options.ProviderProfile,
|
||||
favoriteModels: favoriteModelSet(options.FavoriteModels),
|
||||
recapsEnabled: options.RecapsEnabled,
|
||||
provider: options.Provider,
|
||||
newProvider: options.NewProvider,
|
||||
probeProviderHealth: options.ProbeProviderHealth,
|
||||
discoverProviderModels: options.DiscoverProviderModels,
|
||||
discoverOllamaContextWindow: options.DiscoverOllamaContextWindow,
|
||||
registry: registry,
|
||||
sessionStore: sessionStore,
|
||||
sandboxStore: sandboxStore,
|
||||
mcpConfig: options.MCPConfig,
|
||||
mcpPermissionStore: options.MCPPermissionStore,
|
||||
mcpTokenStore: options.MCPTokenStore,
|
||||
mcpCommand: options.MCPCommand,
|
||||
sandboxSetupCommand: options.SandboxSetupCommand,
|
||||
agentOptions: options.AgentOptions,
|
||||
sessionCompactor: options.SessionCompactor,
|
||||
runtimeMessageSink: options.RuntimeMessageSink,
|
||||
permissionMode: permissionMode,
|
||||
reasoningEffort: options.ReasoningEffort,
|
||||
responseStyle: defaultedResponseStyle(options.ResponseStyle),
|
||||
themeMode: resolveThemeMode(options.Theme, os.Getenv("ZERO_THEME"), options.SavedTheme),
|
||||
hasDarkBg: true,
|
||||
userAgent: options.UserAgent,
|
||||
usageTracker: usageTracker,
|
||||
transcript: initialTranscript(),
|
||||
transcriptBodyHeights: newTranscriptBodyHeightCache(defaultTranscriptBodyHeightCacheMaxEntries),
|
||||
prService: prService,
|
||||
prState: prService.GetState(),
|
||||
input: input,
|
||||
spinner: runSpinner,
|
||||
now: time.Now,
|
||||
notifier: notifier,
|
||||
altScreen: options.AltScreen,
|
||||
liveUsageCounts: map[int]int{},
|
||||
swarmSessionMap: map[string]string{},
|
||||
setup: newSetupState(options.Setup),
|
||||
setupSave: options.Setup.Save,
|
||||
}
|
||||
// Apply an explicit theme immediately; auto stays on the dark default until
|
||||
// Init's terminal background probe resolves it (see Init / BackgroundColorMsg).
|
||||
@@ -759,6 +807,24 @@ func composerBlinkCmd() tea.Cmd {
|
||||
|
||||
func (m model) Init() tea.Cmd {
|
||||
cmds := []tea.Cmd{textinput.Blink, composerBlinkCmd()}
|
||||
// Bubble Tea documents an initial WindowSizeMsg as delivered automatically
|
||||
// on program start, so m.height/m.width are normally set before the first
|
||||
// render. But that's the terminal proactively pushing a size — if it's
|
||||
// ever missed (a slow/unusual terminal, a multiplexer, a startup race),
|
||||
// nothing else ever asks again: m.height stays its zero value forever,
|
||||
// `if m.altScreen && m.height > 0` (transcriptView) falls back to the
|
||||
// unpadded, non-fullscreen render path for the rest of the session, and
|
||||
// the alt-screen viewport never gets filled below the actual content.
|
||||
// Explicitly requesting it here means Zero doesn't depend solely on the
|
||||
// terminal's unprompted push — mirrors the RequestBackgroundColor request
|
||||
// below for the same reason.
|
||||
cmds = append(cmds, tea.RequestWindowSize)
|
||||
// Baseline git snapshot for the FILES sidebar sweep: whatever is already
|
||||
// dirty when the TUI opens is pre-existing state, not this session's work
|
||||
// (files_git_sweep.go). Async; a non-git workspace just disables the sweep.
|
||||
if strings.TrimSpace(m.cwd) != "" {
|
||||
cmds = append(cmds, gitSweepCmd(m.ctx, m.cwd, true))
|
||||
}
|
||||
// In auto mode, ask the terminal for its background color; the reply arrives
|
||||
// as tea.BackgroundColorMsg and selects light vs dark (see updateModel).
|
||||
if m.themeMode == themeAuto {
|
||||
@@ -773,6 +839,13 @@ func (m model) Init() tea.Cmd {
|
||||
if cmd := m.modelPickerProviderDiscoveryCmd(descriptor, m.providerProfile); cmd != nil {
|
||||
cmds = append(cmds, cmd)
|
||||
}
|
||||
// The generic discovery above has no source for a local Ollama model's
|
||||
// context window (see ollamaContextWindowDiscoveryCmd); probe its
|
||||
// native /api/show separately so the gauge works for custom/local
|
||||
// Ollama models too, not just ones in the curated catalog.
|
||||
if cmd := m.ollamaContextWindowDiscoveryCmd(descriptor, m.providerProfile.BaseURL, m.modelName); cmd != nil {
|
||||
cmds = append(cmds, cmd)
|
||||
}
|
||||
}
|
||||
if m.prService != nil && m.runtimeMessageSink != nil {
|
||||
service := m.prService
|
||||
@@ -849,6 +922,14 @@ func (m model) disarmExitConfirmation() model {
|
||||
return m
|
||||
}
|
||||
|
||||
func (m model) disarmCancelConfirmation() model {
|
||||
if m.cancelConfirmActive {
|
||||
m.cancelConfirmActive = false
|
||||
m.cancelConfirmSeq++
|
||||
}
|
||||
return m
|
||||
}
|
||||
|
||||
// Update routes every message through updateModel, then advances the flush
|
||||
// frontier for inline rendering. Alt-screen runs keep rows in the managed view
|
||||
// instead of printing into terminal scrollback (see flush.go).
|
||||
@@ -927,6 +1008,11 @@ func (m model) updateModel(msg tea.Msg) (tea.Model, tea.Cmd) {
|
||||
m.exitConfirmActive = false
|
||||
}
|
||||
return m, nil
|
||||
case cancelConfirmExpiredMsg:
|
||||
if msg.seq == m.cancelConfirmSeq {
|
||||
m.cancelConfirmActive = false
|
||||
}
|
||||
return m, nil
|
||||
case dragEdgeScrollTickMsg:
|
||||
if msg.seq != m.edgeScrollSeq || m.edgeScrollDelta == 0 || !m.transcriptSelection.active {
|
||||
return m, nil // stale, or the chain was stopped since this tick was scheduled
|
||||
@@ -974,6 +1060,13 @@ func (m model) updateModel(msg tea.Msg) (tea.Model, tea.Cmd) {
|
||||
if !keyCtrl(msg, 'c') {
|
||||
m = m.disarmExitConfirmation()
|
||||
}
|
||||
// Mirrors the exit-confirmation reset above: any key that isn't itself
|
||||
// the confirming Esc means the user moved on to something else, so a
|
||||
// later, unrelated Esc must arm a fresh confirmation rather than
|
||||
// silently cancel off a stale press from seconds ago.
|
||||
if !keyIs(msg, tea.KeyEsc) {
|
||||
m = m.disarmCancelConfirmation()
|
||||
}
|
||||
// The `?` help overlay is modal: `?`, Esc, q, or Enter close it; every
|
||||
// other key is swallowed so nothing types into the hidden composer.
|
||||
if m.helpOverlay {
|
||||
@@ -987,6 +1080,14 @@ func (m model) updateModel(msg tea.Msg) (tea.Model, tea.Cmd) {
|
||||
return m.handleCtrlC()
|
||||
case keyCtrl(msg, 'o'):
|
||||
return m.toggleDetailedTranscript(), nil
|
||||
case m.fileView.active && m.noBlockingModal() && m.composerValue() == "" && (keyText(msg) == "d" || keyText(msg) == "f"):
|
||||
// Mode toggle for the file drill-in, only while the composer is empty
|
||||
// (so mid-sentence typing is never hijacked) and no modal is up (so a
|
||||
// permission prompt / ask-user / wizard keeps its own key handling).
|
||||
if keyText(msg) == "f" {
|
||||
return m.setFileViewMode(fileViewFull), nil
|
||||
}
|
||||
return m.setFileViewMode(fileViewDiff), nil
|
||||
case keyCtrl(msg, 'e'):
|
||||
// Release/recapture the mouse so the user can drag-select and copy text
|
||||
// natively (mouse capture otherwise intercepts terminal selection).
|
||||
@@ -996,12 +1097,29 @@ func (m model) updateModel(msg tea.Msg) (tea.Model, tea.Cmd) {
|
||||
}
|
||||
return m.appendSystemNotice("Mouse interaction re-enabled."), nil
|
||||
case keyIs(msg, tea.KeyEsc):
|
||||
// Esc is heavily overloaded below (subchat exit, MCP cancel, ask-user,
|
||||
// permission deny, wizard/picker/suggestions dismiss, ...) before ever
|
||||
// reaching the run-cancel fallback. Capture whether this press really
|
||||
// is the confirming second Esc BEFORE any of those branches can fire,
|
||||
// then disarm unconditionally: an Esc that gets consumed by one of
|
||||
// them wasn't a confirm, so it must not leave cancelConfirmActive
|
||||
// armed for some later, unrelated Esc to silently act on.
|
||||
wasConfirmingCancel := m.pending && m.cancelConfirmActive
|
||||
m = m.disarmCancelConfirmation()
|
||||
// Subchat view exits on Esc (returns to main chat).
|
||||
if m.subchat.active {
|
||||
m.chatScrollOffset = m.subchat.exit()
|
||||
m = m.clearHover() // bodyY numbering differs between subchat and the parent transcript
|
||||
return m, nil
|
||||
}
|
||||
// File drill-in exits on Esc (returns to the chat at its saved scroll
|
||||
// position); the file stays selected so a second Esc clears that. Only
|
||||
// with no blocking modal up: Esc on a permission prompt / ask-user /
|
||||
// wizard must reach THAT surface's deny/cancel handling below, not
|
||||
// silently close the drill-in behind it.
|
||||
if m.fileView.active && m.noBlockingModal() {
|
||||
return m.exitFileView(), nil
|
||||
}
|
||||
if m.mcpCommandCancel != nil {
|
||||
m.cancelMCPCommand()
|
||||
if m.mcpAddWizard != nil {
|
||||
@@ -1058,14 +1176,34 @@ func (m model) updateModel(msg tea.Msg) (tea.Model, tea.Cmd) {
|
||||
if m.suggestionsActive() {
|
||||
return m.dismissSuggestions(), nil
|
||||
}
|
||||
// A selected FILES row clears before anything run-related: the
|
||||
// selection is a passive highlight, so Esc dropping it is cheap and
|
||||
// expected (mirrors how editors clear selection on Esc).
|
||||
if m.selectedFile != "" {
|
||||
m.selectedFile = ""
|
||||
return m, nil
|
||||
}
|
||||
if m.hasQueuedMessage() {
|
||||
return m.clearQueuedMessage(), nil
|
||||
}
|
||||
m.clearComposer()
|
||||
m.clearSuggestions()
|
||||
if m.pending {
|
||||
m.cancelRun()
|
||||
if wasConfirmingCancel {
|
||||
m.clearComposer()
|
||||
m.cancelRun()
|
||||
return m, nil
|
||||
}
|
||||
// First Esc only arms the confirmation — preserve whatever
|
||||
// draft the user has typed, since nothing has actually been
|
||||
// cancelled yet and they may not press Esc again.
|
||||
m.cancelConfirmActive = true
|
||||
m.cancelConfirmSeq++
|
||||
seq := m.cancelConfirmSeq
|
||||
return m, tea.Tick(escCancelConfirmDuration, func(time.Time) tea.Msg {
|
||||
return cancelConfirmExpiredMsg{seq: seq}
|
||||
})
|
||||
}
|
||||
m.clearComposer()
|
||||
return m, nil
|
||||
case keyIs(msg, tea.KeyEnter):
|
||||
if m.transcriptDetailed {
|
||||
@@ -1621,6 +1759,7 @@ func (m model) updateModel(msg tea.Msg) (tea.Model, tea.Cmd) {
|
||||
}
|
||||
m.clearStreamingToolCall() // active run finished — drop any lingering "writing" block
|
||||
m.pending = false
|
||||
m = m.disarmCancelConfirmation() // the run finished on its own — nothing left to confirm cancelling
|
||||
// Fully reset the fade state at stream end. The next render
|
||||
// emits the final row in solid ink (no settling animation), and
|
||||
// the pending streamingFadeTickMsg that lands after this point
|
||||
@@ -1718,8 +1857,13 @@ func (m model) updateModel(msg tea.Msg) (tea.Model, tea.Cmd) {
|
||||
}
|
||||
m, recapCmd = m.maybeRecapTurn(msg.runID, finalAnswer)
|
||||
}
|
||||
// End-of-turn git sweep: catch file mutations the tool stream couldn't
|
||||
// report (bash scaffolding, subagent edits) so the FILES sidebar is
|
||||
// complete once the turn settles.
|
||||
var sweepCmd tea.Cmd
|
||||
m, sweepCmd = m.maybeGitSweep()
|
||||
next, queuedCmd := m.launchQueuedMessageIfReady()
|
||||
return next, tea.Batch(titleCmd, recapCmd, queuedCmd)
|
||||
return next, tea.Batch(titleCmd, recapCmd, sweepCmd, queuedCmd)
|
||||
case sessionTitleGeneratedMsg:
|
||||
return m.handleSessionTitleGenerated(msg)
|
||||
case recapGeneratedMsg:
|
||||
@@ -1870,6 +2014,14 @@ func (m model) updateModel(msg tea.Msg) (tea.Model, tea.Cmd) {
|
||||
m.transcript = collapseRepeatedStatusCard(m.transcript, msg.row)
|
||||
m.transcript = appendTranscriptRow(m.transcript, msg.row)
|
||||
m = m.captureStepWork(msg.row)
|
||||
// A finished command tool may have mutated files git can see but no
|
||||
// changedFiles reports (npm create, heredoc writes, subagent edits) —
|
||||
// re-sweep so the FILES sidebar picks them up mid-turn.
|
||||
if msg.row.kind == rowToolResult && isPlanCommandTool(msg.row.tool) {
|
||||
var sweep tea.Cmd
|
||||
m, sweep = m.maybeGitSweep()
|
||||
return m, sweep
|
||||
}
|
||||
return m, nil
|
||||
case swarmSessionsMsg:
|
||||
// Merge completed swarm members' session ids so their AGENTS sidebar rows
|
||||
@@ -1900,6 +2052,8 @@ func (m model) updateModel(msg tea.Msg) (tea.Model, tea.Cmd) {
|
||||
case prStateMsg:
|
||||
m.prState = msg.state
|
||||
return m, nil
|
||||
case gitSweepMsg:
|
||||
return m.handleGitSweepMsg(msg), nil
|
||||
case prWatcherStartedMsg:
|
||||
if msg.stop == nil {
|
||||
return m, nil
|
||||
@@ -1922,6 +2076,14 @@ func (m model) updateModel(msg tea.Msg) (tea.Model, tea.Cmd) {
|
||||
return m.applySetupOAuthDeviceCode(msg)
|
||||
case modelPickerModelsDiscoveredMsg:
|
||||
return m.applyModelPickerModelsDiscovered(msg), nil
|
||||
case ollamaContextWindowDiscoveredMsg:
|
||||
if msg.err == nil && msg.contextWindow > 0 {
|
||||
if m.ollamaContextWindowByModel == nil {
|
||||
m.ollamaContextWindowByModel = map[string]int{}
|
||||
}
|
||||
m.ollamaContextWindowByModel[msg.modelName] = msg.contextWindow
|
||||
}
|
||||
return m, nil
|
||||
case mcpCommandResultMsg:
|
||||
return m.applyMCPCommandResultMessage(msg), nil
|
||||
}
|
||||
@@ -2096,6 +2258,12 @@ func (m model) pinnedTitleBar(width int) string {
|
||||
if !m.altScreen || m.height <= 0 {
|
||||
return ""
|
||||
}
|
||||
// The file drill-in replaces the title bar with its nav line (path + key
|
||||
// hints). Both are exactly one line, and every frame computation routes
|
||||
// through here, so the swap never desyncs the viewport geometry.
|
||||
if m.fileView.active {
|
||||
return m.fileViewNavBar(width)
|
||||
}
|
||||
return m.titleBar(width)
|
||||
}
|
||||
|
||||
@@ -2133,15 +2301,18 @@ func (m model) footerView(width int) string {
|
||||
footer.WriteString(fitStyledLine(joinHeaderLine(" "+left, right, width), width))
|
||||
}
|
||||
footer.WriteString("\n")
|
||||
// A message typed while a run is active is queued for the next turn; show its
|
||||
// preview directly ABOVE the input box (not below), so it reads as "waiting to
|
||||
// send" sitting on top of what you're currently typing.
|
||||
if queued := renderQueuedMessagePreview(m.queuedMessage, width); queued != "" {
|
||||
footer.WriteString(queued)
|
||||
footer.WriteString("\n")
|
||||
}
|
||||
footer.WriteString(m.composerBox(width))
|
||||
if hint := m.composerDescriptionHint(width); hint != "" {
|
||||
footer.WriteString("\n")
|
||||
footer.WriteString(hint)
|
||||
}
|
||||
if queued := renderQueuedMessagePreview(m.queuedMessage, width); queued != "" {
|
||||
footer.WriteString("\n")
|
||||
footer.WriteString(queued)
|
||||
}
|
||||
footer.WriteString("\n")
|
||||
footer.WriteString(m.statusLine(width))
|
||||
return footer.String()
|
||||
@@ -2717,6 +2888,15 @@ const quietWorkingHint = 8 * time.Second
|
||||
// quietGenerationHint returns a "still generating…" cue with an advancing
|
||||
// quiet-timer when the active turn has produced no streamed output for a while,
|
||||
// else "". The advancing number is itself the liveness signal.
|
||||
//
|
||||
// Past half the provider's idle timeout, the cue escalates to name what's
|
||||
// actually happening and when Zero will act on its own: a heartbeating-but-
|
||||
// silent stream (observed on chatgpt/gpt-5.x and ollama reasoning models,
|
||||
// see providerio.ErrStreamStalled) is bounded by the content-stall watchdog at
|
||||
// providerio.ContentStallTimeout(idle), but until it fires this exact same
|
||||
// plain "still generating… Xs" text is indistinguishable from a genuine hang —
|
||||
// the ticking number was the only signal, and it looks identical whether real
|
||||
// (if slow) content is coming or nothing ever will.
|
||||
func (m model) quietGenerationHint() string {
|
||||
if m.activeRunID == 0 {
|
||||
return ""
|
||||
@@ -2732,6 +2912,10 @@ func (m model) quietGenerationHint() string {
|
||||
if quiet < quietWorkingHint {
|
||||
return ""
|
||||
}
|
||||
if idleTimeout := providerio.ResolveStreamIdleTimeout(0); idleTimeout > 0 && quiet >= idleTimeout/2 {
|
||||
ceiling := providerio.ContentStallTimeout(idleTimeout)
|
||||
return fmt.Sprintf("still generating… %s — unusually quiet, Zero will auto-recover by ~%s if it doesn't resume", formatWorkingElapsed(quiet), formatWorkingElapsed(ceiling))
|
||||
}
|
||||
return "still generating… " + formatWorkingElapsed(quiet)
|
||||
}
|
||||
|
||||
@@ -3294,12 +3478,13 @@ func (m model) choosePicker() (tea.Model, tea.Cmd) {
|
||||
}
|
||||
return m, nil
|
||||
}
|
||||
var cmd tea.Cmd
|
||||
switch picker.kind {
|
||||
case pickerModel:
|
||||
text := ""
|
||||
if owner := strings.TrimSpace(item.OwnerProvider); owner != "" && !strings.EqualFold(owner, strings.TrimSpace(m.providerName)) {
|
||||
// A model from another saved provider: switch provider + model together.
|
||||
m, text = m.switchProviderModel(owner, item.Value)
|
||||
m, text, cmd = m.switchProviderModel(owner, item.Value)
|
||||
} else {
|
||||
m, text = m.handleModelCommand(item.Value)
|
||||
}
|
||||
@@ -3329,7 +3514,7 @@ func (m model) choosePicker() (tea.Model, tea.Cmd) {
|
||||
return m, tea.RequestBackgroundColor
|
||||
}
|
||||
}
|
||||
return m, nil
|
||||
return m, cmd
|
||||
}
|
||||
|
||||
func (m model) chooseSuggestion() (tea.Model, tea.Cmd) {
|
||||
@@ -3853,7 +4038,8 @@ func (m *model) cancelRun() {
|
||||
m.pending = false
|
||||
m.runCancel = nil
|
||||
m.activeRunID = 0
|
||||
m.plan.frozenAt = m.now() // freeze the plan clock while idle (no run in flight)
|
||||
m.cancelConfirmActive = false // whatever path got here, there's nothing left to confirm cancelling
|
||||
m.plan.frozenAt = m.now() // freeze the plan clock while idle (no run in flight)
|
||||
m.pendingPermission = nil
|
||||
m.pendingAskUser = nil
|
||||
// The interim block renders streamingText live; a cancelled run's partial
|
||||
@@ -4178,13 +4364,14 @@ func (m model) runAgentWithOptions(runID int, runCtx context.Context, prompt str
|
||||
}
|
||||
}
|
||||
row := transcriptRow{
|
||||
kind: rowToolResult,
|
||||
id: effectiveToolRowID(result.ToolCallID, callSeq[result.ToolCallID]),
|
||||
text: toolResultRowText(result),
|
||||
tool: result.Name,
|
||||
status: result.Status,
|
||||
detail: toolResultDetail(result),
|
||||
runID: runID,
|
||||
kind: rowToolResult,
|
||||
id: effectiveToolRowID(result.ToolCallID, callSeq[result.ToolCallID]),
|
||||
text: toolResultRowText(result),
|
||||
tool: result.Name,
|
||||
status: result.Status,
|
||||
detail: toolResultDetail(result),
|
||||
runID: runID,
|
||||
changedFiles: result.ChangedFiles,
|
||||
}
|
||||
// A Task result is shown by the specialist card, and update_plan by the
|
||||
// plan panel/sidebar, so skip both redundant transcript rows.
|
||||
|
||||
@@ -84,6 +84,13 @@ func (m model) modelContextWindow(modelName string) int {
|
||||
return window
|
||||
}
|
||||
}
|
||||
// A custom/local Ollama model tag has no curated-catalog entry, and its
|
||||
// OpenAI-compatible /v1/models listing (the discoveredContextWindow source
|
||||
// above) doesn't carry context-window metadata at all — see
|
||||
// ollamaContextWindowDiscoveryCmd, the only other source for this.
|
||||
if window := m.ollamaContextWindowByModel[trimmed]; window > 0 {
|
||||
return window
|
||||
}
|
||||
// Unknown: report 0 so display gauges show no denominator. Compaction enablement
|
||||
// applies its own positive fallback via modelregistry.AgentContextWindow.
|
||||
return 0
|
||||
|
||||
+203
-7
@@ -1108,7 +1108,87 @@ func TestPromptSubmitDoesNotStartAnotherRunWhilePending(t *testing.T) {
|
||||
}
|
||||
}
|
||||
|
||||
func TestEscCancelsPendingRun(t *testing.T) {
|
||||
func TestEscRequiresSecondPressToCancelPendingRun(t *testing.T) {
|
||||
m := newModel(context.Background(), Options{})
|
||||
cancelled := false
|
||||
m.pending = true
|
||||
m.activeRunID = 1
|
||||
m.runCancel = func() { cancelled = true }
|
||||
|
||||
updated, cmd := m.Update(testKey(tea.KeyEsc))
|
||||
next := updated.(model)
|
||||
|
||||
if cancelled {
|
||||
t.Fatal("first Esc should not cancel the pending run")
|
||||
}
|
||||
if !next.pending {
|
||||
t.Fatal("first Esc should leave the run pending")
|
||||
}
|
||||
if !next.cancelConfirmActive {
|
||||
t.Fatal("first Esc should arm cancel confirmation")
|
||||
}
|
||||
if cmd == nil {
|
||||
t.Fatal("first Esc should schedule confirmation expiry")
|
||||
}
|
||||
status := plainRender(t, next.statusLine(80))
|
||||
if !strings.Contains(status, escCancelConfirmText) {
|
||||
t.Fatalf("status line = %q, want cancel confirmation", status)
|
||||
}
|
||||
|
||||
updated, _ = next.Update(testKey(tea.KeyEsc))
|
||||
next = updated.(model)
|
||||
|
||||
if !cancelled {
|
||||
t.Fatal("second Esc should cancel pending run")
|
||||
}
|
||||
if next.pending {
|
||||
t.Fatal("expected second Esc to clear pending state")
|
||||
}
|
||||
if next.activeRunID != 0 || next.runCancel != nil {
|
||||
t.Fatalf("expected active run state to clear, got id=%d cancel=%v", next.activeRunID, next.runCancel)
|
||||
}
|
||||
if next.cancelConfirmActive {
|
||||
t.Fatal("cancelling should clear cancel confirmation")
|
||||
}
|
||||
}
|
||||
|
||||
// TestEscArmingCancelConfirmationPreservesComposerDraft: the first Esc only
|
||||
// arms the confirmation — nothing has actually been cancelled yet, so it
|
||||
// must not destroy a draft the user is still typing. Only the confirming
|
||||
// second Esc (the one that actually cancels the run) clears the composer.
|
||||
func TestEscArmingCancelConfirmationPreservesComposerDraft(t *testing.T) {
|
||||
m := newModel(context.Background(), Options{})
|
||||
m.pending = true
|
||||
m.activeRunID = 1
|
||||
m.runCancel = func() {}
|
||||
m.input.SetValue("draft prompt")
|
||||
|
||||
updated, _ := m.Update(testKey(tea.KeyEsc))
|
||||
next := updated.(model)
|
||||
|
||||
if !next.cancelConfirmActive {
|
||||
t.Fatal("first Esc should arm cancel confirmation")
|
||||
}
|
||||
if next.composerValue() != "draft prompt" {
|
||||
t.Fatalf("first Esc should preserve the draft, got %q", next.composerValue())
|
||||
}
|
||||
|
||||
updated, _ = next.Update(testKey(tea.KeyEsc))
|
||||
next = updated.(model)
|
||||
|
||||
if next.pending {
|
||||
t.Fatal("second Esc should cancel the pending run")
|
||||
}
|
||||
if next.composerValue() != "" {
|
||||
t.Fatalf("the confirming second Esc should clear the draft, got %q", next.composerValue())
|
||||
}
|
||||
}
|
||||
|
||||
// TestPasteDisarmsCancelConfirmation: a paste isn't a keypress, so it never
|
||||
// went through the generic "any non-Esc key disarms it" hook. Pasting is a
|
||||
// deliberate action just like typing or clicking — it must disarm a stale
|
||||
// confirmation too, or a later, unrelated Esc could silently cancel the run.
|
||||
func TestPasteDisarmsCancelConfirmation(t *testing.T) {
|
||||
m := newModel(context.Background(), Options{})
|
||||
cancelled := false
|
||||
m.pending = true
|
||||
@@ -1117,15 +1197,131 @@ func TestEscCancelsPendingRun(t *testing.T) {
|
||||
|
||||
updated, _ := m.Update(testKey(tea.KeyEsc))
|
||||
next := updated.(model)
|
||||
if !next.cancelConfirmActive {
|
||||
t.Fatal("first Esc should arm cancel confirmation")
|
||||
}
|
||||
|
||||
if !cancelled {
|
||||
t.Fatal("expected Esc to cancel pending run")
|
||||
updated, _ = next.Update(testPaste("pasted text"))
|
||||
next = updated.(model)
|
||||
if next.cancelConfirmActive {
|
||||
t.Fatal("a paste should disarm the stale cancel confirmation")
|
||||
}
|
||||
if next.pending {
|
||||
t.Fatal("expected Esc to clear pending state")
|
||||
|
||||
updated, _ = next.Update(testKey(tea.KeyEsc))
|
||||
next = updated.(model)
|
||||
if cancelled {
|
||||
t.Fatal("Esc after a paste should re-arm, not immediately cancel")
|
||||
}
|
||||
if next.activeRunID != 0 || next.runCancel != nil {
|
||||
t.Fatalf("expected active run state to clear, got id=%d cancel=%v", next.activeRunID, next.runCancel)
|
||||
if !next.cancelConfirmActive {
|
||||
t.Fatal("Esc after a paste should arm a fresh confirmation")
|
||||
}
|
||||
}
|
||||
|
||||
func TestEscCancelConfirmationExpires(t *testing.T) {
|
||||
m := newModel(context.Background(), Options{})
|
||||
m.pending = true
|
||||
m.activeRunID = 1
|
||||
m.runCancel = func() {}
|
||||
|
||||
updated, _ := m.Update(testKey(tea.KeyEsc))
|
||||
next := updated.(model)
|
||||
seq := next.cancelConfirmSeq
|
||||
|
||||
updated, _ = next.Update(cancelConfirmExpiredMsg{seq: seq - 1})
|
||||
next = updated.(model)
|
||||
if !next.cancelConfirmActive {
|
||||
t.Fatal("stale expiry should not clear active cancel confirmation")
|
||||
}
|
||||
|
||||
updated, _ = next.Update(cancelConfirmExpiredMsg{seq: seq})
|
||||
next = updated.(model)
|
||||
if next.cancelConfirmActive {
|
||||
t.Fatal("matching expiry should clear cancel confirmation")
|
||||
}
|
||||
if !next.pending {
|
||||
t.Fatal("expiring the confirmation should not cancel the run")
|
||||
}
|
||||
}
|
||||
|
||||
// TestEscCancelConfirmationDisarmsOnInterveningKey mirrors
|
||||
// TestCtrlCExitConfirmationDisarmsOnInterveningKey: an intervening key other
|
||||
// than Esc (typing, Ctrl+O, etc.) means the user moved on to something else,
|
||||
// so a later, unrelated Esc must arm a fresh confirmation instead of
|
||||
// silently cancelling off a stale press from seconds ago.
|
||||
func TestEscCancelConfirmationDisarmsOnInterveningKey(t *testing.T) {
|
||||
m := newModel(context.Background(), Options{})
|
||||
cancelled := false
|
||||
m.pending = true
|
||||
m.activeRunID = 1
|
||||
m.runCancel = func() { cancelled = true }
|
||||
|
||||
updated, _ := m.Update(testKey(tea.KeyEsc))
|
||||
next := updated.(model)
|
||||
if !next.cancelConfirmActive {
|
||||
t.Fatal("first Esc should arm cancel confirmation")
|
||||
}
|
||||
seq := next.cancelConfirmSeq
|
||||
|
||||
updated, _ = next.Update(testKey('h'))
|
||||
next = updated.(model)
|
||||
if next.cancelConfirmActive {
|
||||
t.Fatal("an intervening non-Esc key should disarm cancel confirmation")
|
||||
}
|
||||
if next.cancelConfirmSeq == seq {
|
||||
t.Fatal("disarming should advance the sequence so a stale expiry tick is ignored")
|
||||
}
|
||||
|
||||
updated, _ = next.Update(testKey(tea.KeyEsc))
|
||||
next = updated.(model)
|
||||
if cancelled {
|
||||
t.Fatal("Esc after an intervening key should re-arm, not cancel")
|
||||
}
|
||||
if !next.cancelConfirmActive {
|
||||
t.Fatal("Esc after an intervening key should arm a fresh confirmation")
|
||||
}
|
||||
}
|
||||
|
||||
// TestEscCancelConfirmationDisarmsWhenStolenByAskUser: a mid-turn ask_user
|
||||
// prompt lands between the two Esc presses. The user's second Esc denies the
|
||||
// questionnaire (an earlier branch in the Esc handler), not a confirm, so it
|
||||
// must not leave cancelConfirmActive armed for a later, unrelated Esc to
|
||||
// silently cancel the run.
|
||||
func TestEscCancelConfirmationDisarmsWhenStolenByAskUser(t *testing.T) {
|
||||
m := newModel(context.Background(), Options{})
|
||||
cancelled := false
|
||||
m.pending = true
|
||||
m.activeRunID = 1
|
||||
m.runCancel = func() { cancelled = true }
|
||||
|
||||
updated, _ := m.Update(testKey(tea.KeyEsc))
|
||||
next := updated.(model)
|
||||
if !next.cancelConfirmActive {
|
||||
t.Fatal("first Esc should arm cancel confirmation")
|
||||
}
|
||||
|
||||
request := agent.AskUserRequest{Questions: []agent.AskUserQuestion{{Question: "name?"}}}
|
||||
next.pendingAskUser = &pendingAskUserPrompt{
|
||||
request: request,
|
||||
answer: func([]string) {},
|
||||
states: newAskUserStates(request.Questions),
|
||||
}
|
||||
|
||||
updated, _ = next.Update(testKey(tea.KeyEsc))
|
||||
next = updated.(model)
|
||||
if cancelled {
|
||||
t.Fatal("an Esc consumed by the ask-user prompt must not cancel the run")
|
||||
}
|
||||
if next.cancelConfirmActive {
|
||||
t.Fatal("an Esc consumed by the ask-user prompt must disarm the stale cancel confirmation")
|
||||
}
|
||||
|
||||
updated, _ = next.Update(testKey(tea.KeyEsc))
|
||||
next = updated.(model)
|
||||
if cancelled {
|
||||
t.Fatal("the next Esc should arm a fresh confirmation, not immediately cancel")
|
||||
}
|
||||
if !next.cancelConfirmActive {
|
||||
t.Fatal("the next Esc should arm a fresh confirmation")
|
||||
}
|
||||
}
|
||||
|
||||
|
||||
@@ -40,6 +40,15 @@ func (m model) handleMouse(msg tea.MouseMsg) (tea.Model, tea.Cmd) {
|
||||
if m.providerWizard != nil && m.providerWizard.oauthPending {
|
||||
return m, nil
|
||||
}
|
||||
// A click is a deliberate action, same as a keypress — it means the user
|
||||
// moved on to something else, so it disarms a stale Esc cancel-confirmation
|
||||
// rather than leaving it armed for some later, unrelated Esc to act on.
|
||||
// Scoped to actual clicks (not hover/motion/wheel), since motion events fire
|
||||
// continuously while the mouse merely sits over the terminal and would
|
||||
// otherwise defeat the confirmation window on every render tick.
|
||||
if mouseLeftPress(msg) || mouseRightPress(msg) {
|
||||
m = m.disarmCancelConfirmation()
|
||||
}
|
||||
// A right-click pastes the clipboard straight into the focused field — no
|
||||
// menu. pasteFromClipboardCmd reads the clipboard off the Update goroutine; the
|
||||
// clipboardReadMsg result is routed by routePaste to wherever input is focused
|
||||
|
||||
@@ -44,6 +44,9 @@ func oauthDevicePrepare(name string) (oauth.DeviceAuth, oauth.Config, error) {
|
||||
Store: store,
|
||||
HTTPClient: &http.Client{Timeout: 60 * time.Second},
|
||||
OpenBrowser: browser.OpenURL,
|
||||
// Device-flow providers (e.g. Hugging Face) rely on the baked-in preset for
|
||||
// their endpoints; opt in so the device code can be requested.
|
||||
AllowPresets: true,
|
||||
})
|
||||
if err != nil {
|
||||
return oauth.DeviceAuth{}, oauth.Config{}, err
|
||||
@@ -62,8 +65,9 @@ func oauthDeviceComplete(name string, cfg oauth.Config, auth oauth.DeviceAuth) e
|
||||
return err
|
||||
}
|
||||
manager, err := oauth.NewManager(oauth.ManagerOptions{
|
||||
Store: store,
|
||||
HTTPClient: &http.Client{Timeout: 60 * time.Second},
|
||||
Store: store,
|
||||
HTTPClient: &http.Client{Timeout: 60 * time.Second},
|
||||
AllowPresets: true, // preset config is needed to poll/exchange the device token
|
||||
})
|
||||
if err != nil {
|
||||
return err
|
||||
@@ -84,8 +88,9 @@ func oauthStoredToken(ctx context.Context, providerID string) string {
|
||||
return ""
|
||||
}
|
||||
manager, err := oauth.NewManager(oauth.ManagerOptions{
|
||||
Store: store,
|
||||
HTTPClient: &http.Client{Timeout: 30 * time.Second},
|
||||
Store: store,
|
||||
HTTPClient: &http.Client{Timeout: 30 * time.Second},
|
||||
AllowPresets: true, // refreshing a preset-provider token re-resolves its config
|
||||
})
|
||||
if err != nil {
|
||||
return ""
|
||||
|
||||
@@ -755,6 +755,15 @@ func (m model) completeSetup() (tea.Model, tea.Cmd) {
|
||||
m.providerProfile = result.Provider
|
||||
m.providerName = result.Provider.Name
|
||||
m.modelName = result.Provider.Model
|
||||
// Export ZERO_PROVIDER alongside the committed profile fields (and the
|
||||
// config setupSave already persisted as active). Unlike command_center's
|
||||
// switch — which commits everything only after a successful build — setup
|
||||
// commits config + profile unconditionally here, so the env must match
|
||||
// them unconditionally too: applyEnv makes ZERO_PROVIDER WIN over config,
|
||||
// so a stale value from an earlier /model switch left in place would send
|
||||
// spawned children to the OLD provider even though config now names the
|
||||
// new one. That is the exact D3 gap this closes.
|
||||
config.SetActiveProviderEnv(result.Provider.Name)
|
||||
if m.newProvider != nil {
|
||||
if provider, providerErr := m.newProvider(result.Provider); providerErr == nil {
|
||||
m.provider = provider
|
||||
|
||||
@@ -3,6 +3,7 @@ package tui
|
||||
import (
|
||||
"context"
|
||||
"errors"
|
||||
"os"
|
||||
"strings"
|
||||
"testing"
|
||||
|
||||
@@ -1535,3 +1536,42 @@ func absInt(value int) int {
|
||||
}
|
||||
return value
|
||||
}
|
||||
|
||||
// Completing setup switches the live provider, so it must export ZERO_PROVIDER
|
||||
// exactly like the /model, /provider, and wizard switch paths — a stale value
|
||||
// from an earlier switch would otherwise win over config in every spawned
|
||||
// child (applyEnv) and pin specialists/swarm members to the OLD provider's
|
||||
// credentials.
|
||||
func TestCompleteSetupExportsActiveProviderEnv(t *testing.T) {
|
||||
t.Setenv(config.ActiveProviderEnv, "stale-previous-provider")
|
||||
m := newModel(context.Background(), Options{
|
||||
Setup: SetupOptions{
|
||||
Visible: true,
|
||||
Providers: []SetupProviderOption{
|
||||
{ID: "openai", Name: "OpenAI", DefaultModel: "gpt-4.1", EnvVar: "OPENAI_API_KEY", RequiresAuth: true},
|
||||
},
|
||||
Save: func(selection SetupSelection) (SetupResult, error) {
|
||||
return SetupResult{
|
||||
Provider: config.ProviderProfile{
|
||||
Name: selection.CatalogID,
|
||||
CatalogID: selection.CatalogID,
|
||||
Model: selection.Model,
|
||||
},
|
||||
}, nil
|
||||
},
|
||||
},
|
||||
})
|
||||
m.width = 100
|
||||
m.height = 30
|
||||
m.setup.stage = setupStageReady
|
||||
|
||||
updated, _ := m.completeSetup()
|
||||
next := updated.(model)
|
||||
|
||||
if next.providerName == "" {
|
||||
t.Fatal("setup completion should have set a provider name")
|
||||
}
|
||||
if got := os.Getenv(config.ActiveProviderEnv); got != next.providerName {
|
||||
t.Fatalf("%s = %q after setup save, want %q (children would spawn on the stale provider)", config.ActiveProviderEnv, got, next.providerName)
|
||||
}
|
||||
}
|
||||
+27
-26
@@ -20,32 +20,33 @@ import (
|
||||
|
||||
// Options configures the reusable Zero terminal UI shell.
|
||||
type Options struct {
|
||||
Cwd string
|
||||
UserConfigPath string
|
||||
DoctorUserConfigPath string
|
||||
ProjectConfigPath string
|
||||
ProviderName string
|
||||
ModelName string
|
||||
ProviderProfile config.ProviderProfile
|
||||
SavedProviders []config.ProviderProfile // all configured providers, for the /model multi-provider list
|
||||
FavoriteModels []string
|
||||
RecapsEnabled bool
|
||||
Provider zeroruntime.Provider
|
||||
NewProvider func(config.ProviderProfile) (zeroruntime.Provider, error)
|
||||
ProbeProviderHealth func(context.Context, providerhealth.Options) providerhealth.Result
|
||||
DiscoverProviderModels func(context.Context, config.ProviderProfile) ([]providermodeldiscovery.Model, error)
|
||||
RuntimeMessageSink func(tea.Msg)
|
||||
Registry *tools.Registry
|
||||
SessionStore *sessions.Store
|
||||
SandboxStore *sandbox.GrantStore
|
||||
MCPConfig config.MCPConfig
|
||||
MCPPermissionStore *mcp.PermissionStore
|
||||
MCPTokenStore *mcp.TokenStore
|
||||
MCPCommand func(context.Context, []string) MCPCommandResult
|
||||
SandboxSetupCommand func(context.Context) SandboxSetupCommandResult
|
||||
UsageTracker *usage.Tracker
|
||||
SessionCompactor SessionCompactor
|
||||
PrService *PrService
|
||||
Cwd string
|
||||
UserConfigPath string
|
||||
DoctorUserConfigPath string
|
||||
ProjectConfigPath string
|
||||
ProviderName string
|
||||
ModelName string
|
||||
ProviderProfile config.ProviderProfile
|
||||
SavedProviders []config.ProviderProfile // all configured providers, for the /model multi-provider list
|
||||
FavoriteModels []string
|
||||
RecapsEnabled bool
|
||||
Provider zeroruntime.Provider
|
||||
NewProvider func(config.ProviderProfile) (zeroruntime.Provider, error)
|
||||
ProbeProviderHealth func(context.Context, providerhealth.Options) providerhealth.Result
|
||||
DiscoverProviderModels func(context.Context, config.ProviderProfile) ([]providermodeldiscovery.Model, error)
|
||||
DiscoverOllamaContextWindow func(ctx context.Context, baseURL string, model string) (int, error)
|
||||
RuntimeMessageSink func(tea.Msg)
|
||||
Registry *tools.Registry
|
||||
SessionStore *sessions.Store
|
||||
SandboxStore *sandbox.GrantStore
|
||||
MCPConfig config.MCPConfig
|
||||
MCPPermissionStore *mcp.PermissionStore
|
||||
MCPTokenStore *mcp.TokenStore
|
||||
MCPCommand func(context.Context, []string) MCPCommandResult
|
||||
SandboxSetupCommand func(context.Context) SandboxSetupCommandResult
|
||||
UsageTracker *usage.Tracker
|
||||
SessionCompactor SessionCompactor
|
||||
PrService *PrService
|
||||
|
||||
AgentOptions agent.Options
|
||||
PermissionMode agent.PermissionMode
|
||||
|
||||
@@ -565,6 +565,46 @@ type modelPickerModelsDiscoveredMsg struct {
|
||||
err error
|
||||
}
|
||||
|
||||
// ollamaContextWindowDiscoveredMsg carries the result of an async /api/show
|
||||
// probe against a local Ollama daemon (see ollamaContextWindowDiscoveryCmd).
|
||||
// A zero contextWindow (or a non-nil err) means the probe found nothing
|
||||
// usable and the map is left untouched, not zeroed out.
|
||||
type ollamaContextWindowDiscoveredMsg struct {
|
||||
modelName string
|
||||
contextWindow int
|
||||
err error
|
||||
}
|
||||
|
||||
// ollamaContextWindowDiscoveryCmd probes a local Ollama daemon's native
|
||||
// /api/show endpoint for modelName's context length. Scoped to the local
|
||||
// Ollama provider only (catalog ID "ollama", not "ollama-cloud" — a
|
||||
// different hosted service this endpoint isn't assumed to exist on): the
|
||||
// generic /v1/models discovery has no source for this metadata for
|
||||
// custom/local model tags, so without this the context gauge just never
|
||||
// shows for them (see modelContextWindow).
|
||||
func (m model) ollamaContextWindowDiscoveryCmd(descriptor providercatalog.Descriptor, baseURL string, modelName string) tea.Cmd {
|
||||
if descriptor.ID != "ollama" {
|
||||
return nil
|
||||
}
|
||||
modelName = strings.TrimSpace(modelName)
|
||||
baseURL = strings.TrimSpace(baseURL)
|
||||
if modelName == "" || baseURL == "" {
|
||||
return nil
|
||||
}
|
||||
discover := m.discoverOllamaContextWindow
|
||||
if discover == nil {
|
||||
discover = func(ctx context.Context, baseURL string, model string) (int, error) {
|
||||
return providermodeldiscovery.DiscoverOllamaContextWindow(ctx, baseURL, model, providermodeldiscovery.Options{})
|
||||
}
|
||||
}
|
||||
return func() tea.Msg {
|
||||
ctx, cancel := context.WithTimeout(m.ctx, 8*time.Second)
|
||||
defer cancel()
|
||||
window, err := discover(ctx, baseURL, modelName)
|
||||
return ollamaContextWindowDiscoveredMsg{modelName: modelName, contextWindow: window, err: err}
|
||||
}
|
||||
}
|
||||
|
||||
func (m model) normalizeProfileForProvider(provider providercatalog.Descriptor) config.ProviderProfile {
|
||||
profile := m.providerProfile
|
||||
normalizeIdentity := profileMatchesProviderBaseURL(profile, provider) ||
|
||||
|
||||
@@ -14,6 +14,7 @@ import (
|
||||
|
||||
"github.com/Gitlawb/zero/internal/config"
|
||||
"github.com/Gitlawb/zero/internal/modelregistry"
|
||||
"github.com/Gitlawb/zero/internal/providercatalog"
|
||||
"github.com/Gitlawb/zero/internal/providermodeldiscovery"
|
||||
"github.com/Gitlawb/zero/internal/zeroruntime"
|
||||
)
|
||||
@@ -878,4 +879,100 @@ func TestModelContextWindowResolution(t *testing.T) {
|
||||
if got := m.modelContextWindow(""); got != 0 {
|
||||
t.Fatalf("empty model name should yield 0, got %d", got)
|
||||
}
|
||||
// A custom/local Ollama model tag has no curated-catalog entry and its
|
||||
// generic /v1/models listing carries no window either — the only source is
|
||||
// the Ollama-specific /api/show probe, landed via ollamaContextWindowByModel.
|
||||
m.ollamaContextWindowByModel = map[string]int{"kimi-k2.7-code:cloud": 131072}
|
||||
if got := m.modelContextWindow("kimi-k2.7-code:cloud"); got != 131072 {
|
||||
t.Fatalf("ollama-discovered window should be used for an unregistered model, got %d", got)
|
||||
}
|
||||
}
|
||||
|
||||
// TestOllamaContextWindowDiscoveryCmdScopedToLocalOllama: the /api/show probe
|
||||
// only makes sense against a local Ollama daemon (catalog ID "ollama") — a
|
||||
// different provider like "ollama-cloud" is a distinct hosted service this
|
||||
// endpoint isn't assumed to exist on, and every other provider already has
|
||||
// its context window covered by the curated catalog or /v1/models discovery.
|
||||
func TestOllamaContextWindowDiscoveryCmdScopedToLocalOllama(t *testing.T) {
|
||||
m := model{ctx: context.Background()}
|
||||
|
||||
ollama, ok := providercatalog.Get("ollama")
|
||||
if !ok {
|
||||
t.Fatal("expected \"ollama\" to be a registered catalog descriptor")
|
||||
}
|
||||
if cmd := m.ollamaContextWindowDiscoveryCmd(ollama, "http://localhost:11434/v1", "kimi-k2.7-code:cloud"); cmd == nil {
|
||||
t.Fatal("expected a discovery command for the local ollama provider")
|
||||
}
|
||||
|
||||
ollamaCloud, ok := providercatalog.Get("ollama-cloud")
|
||||
if !ok {
|
||||
t.Fatal("expected \"ollama-cloud\" to be a registered catalog descriptor")
|
||||
}
|
||||
if cmd := m.ollamaContextWindowDiscoveryCmd(ollamaCloud, "https://ollama.com/v1", "qwen3-coder:480b"); cmd != nil {
|
||||
t.Fatal("ollama-cloud is a different hosted service; must not probe /api/show against it")
|
||||
}
|
||||
|
||||
if cmd := m.ollamaContextWindowDiscoveryCmd(ollama, "", "kimi-k2.7-code:cloud"); cmd != nil {
|
||||
t.Fatal("an empty base URL should yield no command")
|
||||
}
|
||||
if cmd := m.ollamaContextWindowDiscoveryCmd(ollama, "http://localhost:11434/v1", ""); cmd != nil {
|
||||
t.Fatal("an empty model name should yield no command")
|
||||
}
|
||||
}
|
||||
|
||||
// TestOllamaContextWindowDiscoveredMsgPopulatesMap verifies the Update()
|
||||
// handler for the async probe's result actually reaches modelContextWindow's
|
||||
// fallback source, and that a failed/zero probe leaves the map untouched
|
||||
// rather than caching a bogus zero.
|
||||
func TestOllamaContextWindowDiscoveredMsgPopulatesMap(t *testing.T) {
|
||||
m := newModel(context.Background(), Options{})
|
||||
|
||||
updated, cmd := m.Update(ollamaContextWindowDiscoveredMsg{modelName: "kimi-k2.7-code:cloud", contextWindow: 131072})
|
||||
next := updated.(model)
|
||||
if cmd != nil {
|
||||
t.Fatal("applying a discovered window should not schedule further work")
|
||||
}
|
||||
if got := next.modelContextWindow("kimi-k2.7-code:cloud"); got != 131072 {
|
||||
t.Fatalf("modelContextWindow after discovery = %d, want 131072", got)
|
||||
}
|
||||
|
||||
updated, _ = next.Update(ollamaContextWindowDiscoveredMsg{modelName: "other-model", contextWindow: 0, err: errors.New("boom")})
|
||||
next = updated.(model)
|
||||
if got := next.modelContextWindow("other-model"); got != 0 {
|
||||
t.Fatalf("a failed probe must not populate a window, got %d", got)
|
||||
}
|
||||
}
|
||||
|
||||
// TestSwitchProviderModelWarmsDiscoveryForTheNewProvider: switching providers
|
||||
// mid-session (e.g. via the /model picker) previously fired no discovery at
|
||||
// all for the newly active provider — Init() only warms the provider active
|
||||
// at launch — so the context gauge stayed blank for the rest of the session
|
||||
// unless /model happened to be reopened separately. Switching to Ollama
|
||||
// specifically must also warm the /api/show probe, the only source of a
|
||||
// context window for custom/local Ollama models.
|
||||
func TestSwitchProviderModelWarmsDiscoveryForTheNewProvider(t *testing.T) {
|
||||
m := newModel(context.Background(), Options{
|
||||
ProviderName: "openai",
|
||||
ModelName: "gpt-5.1",
|
||||
Provider: &fakeProvider{},
|
||||
ProviderProfile: config.ProviderProfile{Name: "openai", CatalogID: "openai", Model: "gpt-5.1"},
|
||||
SavedProviders: []config.ProviderProfile{
|
||||
{Name: "openai", CatalogID: "openai", Model: "gpt-5.1"},
|
||||
{Name: "ollama", CatalogID: "ollama", ProviderKind: config.ProviderKindOpenAICompatible, BaseURL: "http://localhost:11434/v1", Model: "kimi-k2.7-code:cloud"},
|
||||
},
|
||||
NewProvider: func(config.ProviderProfile) (zeroruntime.Provider, error) {
|
||||
return &fakeProvider{}, nil
|
||||
},
|
||||
})
|
||||
|
||||
next, text, cmd := m.switchProviderModel("ollama", "kimi-k2.7-code:cloud")
|
||||
if !strings.Contains(text, "Switched to ollama") {
|
||||
t.Fatalf("switch notice = %q, want it to confirm the switch", text)
|
||||
}
|
||||
if next.modelName != "kimi-k2.7-code:cloud" || next.providerName != "ollama" {
|
||||
t.Fatalf("model/provider not switched: modelName=%q providerName=%q", next.modelName, next.providerName)
|
||||
}
|
||||
if cmd == nil {
|
||||
t.Fatal("switching to ollama should warm both the generic and ollama-specific discovery commands")
|
||||
}
|
||||
}
|
||||
@@ -20,6 +20,7 @@ import (
|
||||
"github.com/Gitlawb/zero/internal/providercatalog"
|
||||
"github.com/Gitlawb/zero/internal/provideroauth"
|
||||
"github.com/Gitlawb/zero/internal/redaction"
|
||||
"github.com/Gitlawb/zero/internal/zeroruntime"
|
||||
)
|
||||
|
||||
// providerWizardOAuthMsg carries the result of an in-wizard browser OAuth login.
|
||||
@@ -166,6 +167,10 @@ func runProviderTokenLogin(name string) error {
|
||||
Store: store,
|
||||
HTTPClient: &http.Client{Timeout: 60 * time.Second},
|
||||
OpenBrowser: browser.OpenURL,
|
||||
// The user explicitly chose to sign in with this provider's OAuth, so opt
|
||||
// into its baked-in preset (e.g. xAI's public client_id); without this the
|
||||
// config never resolves and the browser never opens.
|
||||
AllowPresets: true,
|
||||
})
|
||||
if err != nil {
|
||||
return err
|
||||
@@ -883,13 +888,20 @@ func (m model) applyProviderWizard() (model, tea.Cmd) {
|
||||
modelChoice := wizard.currentModel()
|
||||
profile := providerWizardProfile(provider, modelChoice.ID, wizard.apiKey, wizard.baseURL, wizard.profileName)
|
||||
runtimeProfile := providerWizardRuntimeProfile(profile)
|
||||
|
||||
// Build and persist into LOCALS first, committing live state only once BOTH
|
||||
// succeed. A persist failure (read-only config, disk full) must not leave the
|
||||
// chat running on the new provider while the status line, m.providerProfile,
|
||||
// and the ZERO_PROVIDER export (which pins spawned children) still point at
|
||||
// the old one — parent and children would silently run on different providers.
|
||||
var nextProvider zeroruntime.Provider
|
||||
if m.newProvider != nil {
|
||||
nextProvider, err := m.newProvider(runtimeProfile)
|
||||
built, err := m.newProvider(runtimeProfile)
|
||||
if err != nil {
|
||||
wizard.err = redaction.RedactString(err.Error(), redaction.Options{ExtraSecretValues: []string{profile.APIKey, runtimeProfile.APIKey}})
|
||||
return m, nil
|
||||
}
|
||||
m.provider = nextProvider
|
||||
nextProvider = built
|
||||
}
|
||||
if strings.TrimSpace(m.userConfigPath) != "" {
|
||||
// Capture flip: move the freshly entered key into the encrypted credential
|
||||
@@ -899,12 +911,24 @@ func (m model) applyProviderWizard() (model, tea.Cmd) {
|
||||
profile = config.SecureProviderProfile(profile, m.userConfigPath)
|
||||
if _, err := config.UpsertProvider(m.userConfigPath, profile, true); err != nil {
|
||||
wizard.err = redaction.RedactString(err.Error(), redaction.Options{ExtraSecretValues: []string{secret, profile.APIKey}})
|
||||
return m, nil
|
||||
return m, nil // nothing committed to live state yet
|
||||
}
|
||||
}
|
||||
|
||||
// Both succeeded — commit the live provider, profile, model, and the child
|
||||
// env export together, so they can never disagree.
|
||||
if nextProvider != nil {
|
||||
m.provider = nextProvider
|
||||
}
|
||||
m.providerProfile = profile
|
||||
m.providerName = profile.Name
|
||||
m.modelName = profile.Model
|
||||
// Keep sub-agent child processes on the same provider we just switched to —
|
||||
// same as the /model and /provider switch paths (command_center.go). Without
|
||||
// this, a ZERO_PROVIDER exported by an earlier switch stays pointing at the
|
||||
// OLD provider and wins over config in every spawned child (applyEnv), so
|
||||
// specialists/swarm members run on the wrong provider's credentials.
|
||||
config.SetActiveProviderEnv(profile.Name)
|
||||
m.providerWizard = nil
|
||||
return m, nil
|
||||
}
|
||||
@@ -1229,9 +1253,29 @@ func (wizard *providerWizardState) renderProviderStep(width int) []string {
|
||||
for offset, provider := range wizard.providers[start : start+maxVisible] {
|
||||
lines = append(lines, wizard.renderSelectableProvider(width, start+offset, provider))
|
||||
}
|
||||
// A failed OAuth attempt leaves the wizard on this list (it does not advance),
|
||||
// so the error must render here or the click looks like a silent no-op. The
|
||||
// credential step renders its own copy for the ctrl+o path.
|
||||
if wizard.oauthMode && wizard.oauthErr != "" {
|
||||
lines = append(lines, "", zeroTheme.red.Render("OAuth login failed: "+wizard.oauthErr))
|
||||
if hint := providerWizardOAuthErrHint(wizard.currentProvider()); hint != "" {
|
||||
lines = append(lines, zeroTheme.faint.Render(hint))
|
||||
}
|
||||
}
|
||||
return lines
|
||||
}
|
||||
|
||||
// providerWizardOAuthErrHint returns a provider-specific next step for a failed
|
||||
// OAuth login. Hugging Face ships no public client_id (unlike xAI), so a login
|
||||
// can only work once the operator registers an app and supplies its client_id.
|
||||
func providerWizardOAuthErrHint(provider providercatalog.Descriptor) string {
|
||||
if strings.EqualFold(provider.ID, "huggingface") {
|
||||
return "Hugging Face needs your own app: create one at " +
|
||||
"https://huggingface.co/settings/applications/new, then set ZERO_OAUTH_HUGGINGFACE_CLIENT_ID."
|
||||
}
|
||||
return ""
|
||||
}
|
||||
|
||||
func (wizard *providerWizardState) renderSelectableProvider(width int, index int, provider providercatalog.Descriptor) string {
|
||||
selected := index == wizard.selectedProvider
|
||||
surface := transparentSurface
|
||||
|
||||
@@ -125,6 +125,36 @@ func TestProviderWizardDeviceCodeMsgShowsCodeAndPolls(t *testing.T) {
|
||||
}
|
||||
}
|
||||
|
||||
// A failed OAuth attempt leaves the wizard on the provider list; the error must be
|
||||
// rendered there (not just on the credential step) so a click isn't a silent
|
||||
// no-op, and Hugging Face gets an actionable client_id hint.
|
||||
func TestProviderStepSurfacesOAuthError(t *testing.T) {
|
||||
m := mouseTestModel()
|
||||
m.providerWizard = m.newProviderWizard()
|
||||
wizard := m.providerWizard
|
||||
wizard.oauthMode = true
|
||||
wizard.providers = providerWizardOAuthDescriptors()
|
||||
found := false
|
||||
for i, p := range wizard.providers {
|
||||
if strings.EqualFold(p.ID, "huggingface") {
|
||||
wizard.selectedProvider = i
|
||||
found = true
|
||||
}
|
||||
}
|
||||
if !found {
|
||||
t.Fatal("huggingface should be an OAuth-capable provider")
|
||||
}
|
||||
wizard.oauthErr = `oauth: provider "huggingface" is not configured; set ZERO_OAUTH_HUGGINGFACE_CLIENT_ID`
|
||||
|
||||
view := strings.Join(wizard.renderProviderStep(72), "\n")
|
||||
if !strings.Contains(view, "OAuth login failed") {
|
||||
t.Fatalf("provider step should surface the OAuth error:\n%s", view)
|
||||
}
|
||||
if !strings.Contains(view, "huggingface.co/settings/applications/new") {
|
||||
t.Fatalf("Hugging Face hint should point at app registration:\n%s", view)
|
||||
}
|
||||
}
|
||||
|
||||
func TestProviderWizardDeviceErrorSurfaced(t *testing.T) {
|
||||
m := mouseTestModel()
|
||||
m.providerWizard = m.newProviderWizard()
|
||||
|
||||
@@ -1189,3 +1189,104 @@ func containsString(values []string, want string) bool {
|
||||
}
|
||||
return false
|
||||
}
|
||||
|
||||
// Applying the wizard switches the live provider, so it must export
|
||||
// ZERO_PROVIDER exactly like the /model and /provider switch paths — a stale
|
||||
// value from an earlier switch would otherwise win over config in every
|
||||
// spawned child (applyEnv) and pin specialists/swarm members to the OLD
|
||||
// provider's credentials.
|
||||
func TestApplyProviderWizardExportsActiveProviderEnv(t *testing.T) {
|
||||
t.Setenv(config.ActiveProviderEnv, "stale-previous-provider")
|
||||
m := newModel(context.Background(), Options{})
|
||||
// Isolate the SUCCESS path's persist to a temp config (the default empty
|
||||
// path would skip persist; a future default must never reach the real user
|
||||
// config), and stub the build so the full commit sequence runs.
|
||||
m.userConfigPath = filepath.Join(t.TempDir(), "config.json")
|
||||
m.newProvider = func(config.ProviderProfile) (zeroruntime.Provider, error) {
|
||||
return &fakeProvider{}, nil
|
||||
}
|
||||
m.providerWizard = &providerWizardState{
|
||||
step: providerWizardStepModel,
|
||||
profileName: "acme-wizard",
|
||||
providers: []providercatalog.Descriptor{{
|
||||
ID: "openrouter",
|
||||
Name: "OpenRouter",
|
||||
Transport: providercatalog.TransportOpenAICompatible,
|
||||
DefaultBaseURL: "https://openrouter.ai/api/v1",
|
||||
DefaultModel: "openai/gpt-4.1",
|
||||
AuthEnvVars: []string{"OPENROUTER_API_KEY"},
|
||||
RequiresAuth: true,
|
||||
SupportedAPIFormats: []providercatalog.APIFormat{providercatalog.APIFormatOpenAIChatCompletions},
|
||||
}},
|
||||
models: []providerWizardModel{{ID: "openai/gpt-4.1", Description: "GPT-4.1"}},
|
||||
}
|
||||
|
||||
updated, _ := m.applyProviderWizard()
|
||||
next := updated
|
||||
|
||||
if next.providerName == "" {
|
||||
t.Fatal("wizard apply should have set a provider name")
|
||||
}
|
||||
if got := os.Getenv(config.ActiveProviderEnv); got != next.providerName {
|
||||
t.Fatalf("%s = %q after wizard apply, want %q (children would spawn on the stale provider)", config.ActiveProviderEnv, got, next.providerName)
|
||||
}
|
||||
}
|
||||
|
||||
// On a config PERSIST failure, applyProviderWizard must leave live state fully
|
||||
// unchanged — the chat must NOT already be running on the new provider while the
|
||||
// status line and the ZERO_PROVIDER export (which pins spawned children) still
|
||||
// point at the old one. Build and persist are staged into locals; nothing is
|
||||
// committed unless both succeed.
|
||||
func TestApplyProviderWizardPersistFailureLeavesLiveStateUnchanged(t *testing.T) {
|
||||
t.Setenv("ZERO_CRED_STORAGE", "encrypted-file") // never touch the real OS keychain: apiKey is secured before the persist fails
|
||||
t.Setenv(config.ActiveProviderEnv, "old-provider")
|
||||
|
||||
// A config path whose parent is a regular FILE, so writeConfigFile's MkdirAll
|
||||
// fails and UpsertProvider returns an error.
|
||||
blocker := filepath.Join(t.TempDir(), "not-a-dir")
|
||||
if err := os.WriteFile(blocker, []byte("x"), 0o600); err != nil {
|
||||
t.Fatalf("seed blocker file: %v", err)
|
||||
}
|
||||
brokenConfigPath := filepath.Join(blocker, "config.json")
|
||||
|
||||
oldProvider := &fakeProvider{}
|
||||
newProvider := &fakeProvider{}
|
||||
m := newModel(context.Background(), Options{})
|
||||
m.provider = oldProvider
|
||||
m.providerProfile = config.ProviderProfile{Name: "old-provider"}
|
||||
m.providerName = "old-provider"
|
||||
m.userConfigPath = brokenConfigPath
|
||||
m.newProvider = func(config.ProviderProfile) (zeroruntime.Provider, error) { return newProvider, nil }
|
||||
m.providerWizard = &providerWizardState{
|
||||
step: providerWizardStepModel,
|
||||
profileName: "acme-new",
|
||||
providers: []providercatalog.Descriptor{{
|
||||
ID: "openrouter",
|
||||
Name: "OpenRouter",
|
||||
Transport: providercatalog.TransportOpenAICompatible,
|
||||
DefaultBaseURL: "https://openrouter.ai/api/v1",
|
||||
DefaultModel: "openai/gpt-4.1",
|
||||
AuthEnvVars: []string{"OPENROUTER_API_KEY"},
|
||||
RequiresAuth: true,
|
||||
SupportedAPIFormats: []providercatalog.APIFormat{providercatalog.APIFormatOpenAIChatCompletions},
|
||||
}},
|
||||
models: []providerWizardModel{{ID: "openai/gpt-4.1", Description: "GPT-4.1"}},
|
||||
apiKey: "sk-new",
|
||||
}
|
||||
|
||||
updated, _ := m.applyProviderWizard()
|
||||
next := updated
|
||||
|
||||
if next.providerWizard == nil || next.providerWizard.err == "" {
|
||||
t.Fatal("a persist failure must surface a wizard error and keep the wizard open")
|
||||
}
|
||||
if next.provider != oldProvider {
|
||||
t.Fatal("live provider must NOT be swapped when the persist fails")
|
||||
}
|
||||
if next.providerName != "old-provider" {
|
||||
t.Fatalf("providerName = %q, want it unchanged on persist failure", next.providerName)
|
||||
}
|
||||
if got := os.Getenv(config.ActiveProviderEnv); got != "old-provider" {
|
||||
t.Fatalf("%s = %q, want it unchanged on persist failure (children would diverge from parent)", config.ActiveProviderEnv, got)
|
||||
}
|
||||
}
|
||||
@@ -55,6 +55,38 @@ func TestQueuedPromptPreviewAppearsInView(t *testing.T) {
|
||||
}
|
||||
}
|
||||
|
||||
// TestQueuedPromptPreviewSitsAboveComposer: the queued-message preview must
|
||||
// render ABOVE the input box, not below it — a message waiting to send should
|
||||
// sit on top of what you're currently typing.
|
||||
func TestQueuedPromptPreviewSitsAboveComposer(t *testing.T) {
|
||||
m := newQueuedMessageTestModel(t)
|
||||
m.pending = true
|
||||
m.activeRunID = 1
|
||||
m.runID = 1
|
||||
m.width = 96
|
||||
m.input.SetValue("summarize the failing test output")
|
||||
updated, _ := m.Update(testKey(tea.KeyEnter))
|
||||
next := updated.(model)
|
||||
|
||||
footer := plainRender(t, next.footerView(96))
|
||||
lines := strings.Split(footer, "\n")
|
||||
queuedLine, composerTopLine := -1, -1
|
||||
for i, ln := range lines {
|
||||
if queuedLine < 0 && strings.Contains(ln, "queued") {
|
||||
queuedLine = i
|
||||
}
|
||||
if composerTopLine < 0 && strings.Contains(ln, "╭") { // composer box top border
|
||||
composerTopLine = i
|
||||
}
|
||||
}
|
||||
if queuedLine < 0 || composerTopLine < 0 {
|
||||
t.Fatalf("expected both a queued line and a composer box; queued=%d composer=%d\n%s", queuedLine, composerTopLine, footer)
|
||||
}
|
||||
if queuedLine >= composerTopLine {
|
||||
t.Fatalf("queued preview (line %d) must sit ABOVE the composer box top border (line %d):\n%s", queuedLine, composerTopLine, footer)
|
||||
}
|
||||
}
|
||||
|
||||
func TestAgentResponseLaunchesQueuedPrompt(t *testing.T) {
|
||||
provider := &scriptedProvider{scripts: [][]zeroruntime.StreamEvent{{
|
||||
{Type: zeroruntime.StreamEventText, Content: "queued answer"},
|
||||
|
||||
@@ -164,6 +164,9 @@ func (m model) renderRowCacheKey(row transcriptRow, width int, rc rowContext, op
|
||||
appendRenderCacheField(&b, strconv.FormatBool(row.final))
|
||||
appendRenderCacheField(&b, strconv.Itoa(row.turnTools))
|
||||
appendRenderCacheField(&b, strconv.FormatInt(int64(row.turnElapsed), 10))
|
||||
// The FILES selection tints this row's card border, so selecting/deselecting
|
||||
// a file must miss the cache entry rendered under the other state.
|
||||
appendRenderCacheField(&b, strconv.FormatBool(m.rowTouchesSelectedFile(row)))
|
||||
|
||||
key := rcKey(row.runID, row.id)
|
||||
appendRenderCacheField(&b, rc.hints[key])
|
||||
|
||||
@@ -36,7 +36,7 @@ func pickerBusyText(name string) string {
|
||||
Title: "Busy",
|
||||
Lines: []string{"Can't change " + label + " while a run is in progress."},
|
||||
}},
|
||||
Hints: []string{"press Esc to cancel the run, then try again"},
|
||||
Hints: []string{"press Esc twice to cancel the run, then try again"},
|
||||
})
|
||||
}
|
||||
|
||||
@@ -167,6 +167,10 @@ type cardRenderOptions struct {
|
||||
bodyCap int
|
||||
cwd string
|
||||
expanded bool
|
||||
// fileSelected marks a tool-result card whose mutation touched the file
|
||||
// selected in the FILES sidebar; the card border tints accent so the
|
||||
// selection reads in the transcript.
|
||||
fileSelected bool
|
||||
}
|
||||
|
||||
// flushCardBodyMaxLines is the body cap for cards flushed to scrollback. The
|
||||
@@ -210,6 +214,10 @@ func (m model) renderRowMode(row transcriptRow, width int, rc rowContext, flush
|
||||
}
|
||||
|
||||
func (m model) renderRowModeUncached(row transcriptRow, width int, rc rowContext, opts cardRenderOptions) string {
|
||||
// Resolved per-row (not at the opts construction sites) so every render
|
||||
// path — live, flush, detailed — carries the FILES selection tint; the
|
||||
// cache key includes the same predicate (renderRowCacheKey).
|
||||
opts.fileSelected = m.rowTouchesSelectedFile(row)
|
||||
switch row.kind {
|
||||
case rowUser:
|
||||
return renderUserRow(row, width)
|
||||
@@ -1390,6 +1398,11 @@ func renderToolResultCard(row transcriptRow, width int, rc rowContext, opts card
|
||||
glyph := zeroTheme.green.Render("•")
|
||||
nameStyle := zeroTheme.green
|
||||
borderStyle := zeroTheme.line
|
||||
if opts.fileSelected {
|
||||
// The selected FILES row's edit card: accent border, same as the
|
||||
// sidebar's ▸ marker, so click → highlight reads as one gesture.
|
||||
borderStyle = zeroTheme.accent
|
||||
}
|
||||
if failed {
|
||||
glyph = zeroTheme.red.Render("•")
|
||||
nameStyle = zeroTheme.red
|
||||
|
||||
+29
-6
@@ -444,12 +444,13 @@ func transcriptRowsFromSessionEvents(events []sessions.Event) []transcriptRow {
|
||||
}
|
||||
output := payloadString(payload, "output")
|
||||
rows = append(rows, transcriptRow{
|
||||
kind: rowToolResult,
|
||||
id: effectiveToolRowID(id, callSeq[id]),
|
||||
text: fmt.Sprintf("tool result: %s %s %s", name, status, truncateTUIOutput(output, tuiToolOutputLimit)),
|
||||
tool: name,
|
||||
status: status,
|
||||
detail: output,
|
||||
kind: rowToolResult,
|
||||
id: effectiveToolRowID(id, callSeq[id]),
|
||||
text: fmt.Sprintf("tool result: %s %s %s", name, status, truncateTUIOutput(output, tuiToolOutputLimit)),
|
||||
tool: name,
|
||||
status: status,
|
||||
detail: output,
|
||||
changedFiles: payloadStringSlice(payload, "changedFiles"),
|
||||
})
|
||||
case sessions.EventError:
|
||||
if message := payloadString(payload, "message"); message != "" {
|
||||
@@ -619,6 +620,28 @@ func payloadString(payload map[string]any, key string) string {
|
||||
}
|
||||
}
|
||||
|
||||
// payloadStringSlice reads a []string persisted into a session payload (JSON
|
||||
// round-trips it as []any), skipping non-string entries. Nil when absent.
|
||||
func payloadStringSlice(payload map[string]any, key string) []string {
|
||||
switch typed := payload[key].(type) {
|
||||
case []string:
|
||||
return typed
|
||||
case []any:
|
||||
out := make([]string, 0, len(typed))
|
||||
for _, v := range typed {
|
||||
if s, ok := v.(string); ok && s != "" {
|
||||
out = append(out, s)
|
||||
}
|
||||
}
|
||||
if len(out) == 0 {
|
||||
return nil
|
||||
}
|
||||
return out
|
||||
default:
|
||||
return nil
|
||||
}
|
||||
}
|
||||
|
||||
func payloadBool(payload map[string]any, key string) bool {
|
||||
value := payload[key]
|
||||
switch typed := value.(type) {
|
||||
|
||||
@@ -775,6 +775,8 @@ func TestEscCancelRecordsSessionError(t *testing.T) {
|
||||
t.Fatal("expected prompt submit to start an agent run")
|
||||
}
|
||||
|
||||
updated, _ = next.Update(testKey(tea.KeyEsc))
|
||||
next = updated.(model)
|
||||
updated, _ = next.Update(testKey(tea.KeyEsc))
|
||||
next = updated.(model)
|
||||
|
||||
@@ -836,7 +838,10 @@ func TestCancelledRunFlushesCheckpointSessionEvents(t *testing.T) {
|
||||
next = updated.(model)
|
||||
if _, ok := runtimeMsg.(permissionRequestMsg); ok {
|
||||
// Cancel mid-run via Esc while the permission prompt is pending: this
|
||||
// unblocks the goroutine through ctx cancellation.
|
||||
// unblocks the goroutine through ctx cancellation. Esc now requires a
|
||||
// second press within the confirmation window to actually cancel.
|
||||
updated, _ = next.Update(testKey(tea.KeyEsc))
|
||||
next = updated.(model)
|
||||
updated, _ = next.Update(testKey(tea.KeyEsc))
|
||||
next = updated.(model)
|
||||
cancelled = true
|
||||
|
||||
@@ -97,6 +97,11 @@ func (m model) sidebarHasContent() bool {
|
||||
if len(m.sidebarSpecialists()) > 0 || len(m.swarmSpawnedAgents()) > 0 {
|
||||
return true
|
||||
}
|
||||
if len(m.touchedFiles()) > 0 || m.liveEditingPath() != "" {
|
||||
// A live in-flight write counts before its result row exists, so the
|
||||
// FILES pulse for the session's first mutation isn't hidden.
|
||||
return true
|
||||
}
|
||||
return !m.plan.isEmpty()
|
||||
}
|
||||
|
||||
@@ -587,6 +592,19 @@ func (m model) renderContextSidebar(width, height int) []string {
|
||||
lines = append(lines, planLines...)
|
||||
}
|
||||
|
||||
// FILES section: the files this session has touched (files_panel.go).
|
||||
// Rendered BELOW the plan steps so it never shifts sidebarPlanSelectables'
|
||||
// click offsets; its own hits (sidebarFileSelectables) account for the
|
||||
// sections above it.
|
||||
add("")
|
||||
add(m.sidebarFilesHeader(width))
|
||||
fileLines, _ := m.sidebarFileLines(width)
|
||||
if len(fileLines) == 0 {
|
||||
add(sidebarPlaceholder("no files touched", width))
|
||||
} else {
|
||||
lines = append(lines, fileLines...)
|
||||
}
|
||||
|
||||
// ACTIVITY section: recent completed work + a live "generating…" pulse. Shown
|
||||
// BELOW the plan steps so it never shifts sidebarPlanSelectables' click offsets,
|
||||
// and budgeted (height-1 minus what's used) so it clips ITSELF from the bottom
|
||||
@@ -651,6 +669,12 @@ func (m model) hoveredSidebarLineOffset(width int) (int, bool) {
|
||||
return hit.lineOffset, true
|
||||
}
|
||||
}
|
||||
case hoverFileRow:
|
||||
for _, hit := range m.sidebarFileSelectables(width) {
|
||||
if hit.path == m.hover.filePath {
|
||||
return hit.lineOffset, true
|
||||
}
|
||||
}
|
||||
}
|
||||
return 0, false
|
||||
}
|
||||
|
||||
@@ -41,6 +41,11 @@ type transcriptRow struct {
|
||||
askUser *agent.AskUserRequest
|
||||
expanded bool // collapsible transcript rows, e.g. provider thoughts
|
||||
|
||||
// changedFiles lists the workspace-relative paths a mutating tool result
|
||||
// wrote (from tools.Result.ChangedFiles; restored from the session payload on
|
||||
// resume). The sidebar FILES section derives its roster from these.
|
||||
changedFiles []string
|
||||
|
||||
// specialistInfo holds the specialist card data for rowSpecialist rows.
|
||||
// Nil for all other row kinds.
|
||||
specialistInfo *specialistInfo
|
||||
|
||||
@@ -211,6 +211,12 @@ func (m model) renderHoverHighlight(rendered string, selectable []transcriptSele
|
||||
}
|
||||
|
||||
func (m model) transcriptBodyItems(width int, emptyOverlay string) []transcriptBodyItem {
|
||||
// File drill-in: the chat column's body swaps to the viewed file's
|
||||
// diff/content. Swapping HERE (the single source every consumer reads) keeps
|
||||
// the viewport, scroll engine, renderer, and mouse hit-tests consistent.
|
||||
if m.fileView.active {
|
||||
return m.fileViewBodyItems(width)
|
||||
}
|
||||
items := []transcriptBodyItem{}
|
||||
// Transcript ROWS render at the full chat width; row/status glyphs provide
|
||||
// structure without adding another body margin. Block items (title bar, empty
|
||||
@@ -1242,6 +1248,9 @@ func (m model) handleTranscriptSelectionMouse(msg tea.MouseMsg) (model, tea.Cmd,
|
||||
// session, reusing the specialist-card subchat path. Checked before the
|
||||
// transcript hit-test since the sidebar is outside the chat column.
|
||||
if hit, ok := m.sidebarLineAtMouse(msg); ok {
|
||||
// The subchat drill-in owns the whole (single-column) view; a file
|
||||
// drill-in can't meaningfully stay open behind it.
|
||||
m = m.exitFileView()
|
||||
if errMsg := m.subchat.enter(m.sessionStore, hit.sessionID, hit.title, m.chatScrollOffset); errMsg != "" {
|
||||
m = m.appendSystemNotice(errMsg)
|
||||
}
|
||||
@@ -1252,10 +1261,24 @@ func (m model) handleTranscriptSelectionMouse(msg tea.MouseMsg) (model, tea.Cmd,
|
||||
// A click on a PLAN step row drops a transcript card listing the file
|
||||
// changes captured while that step was in progress.
|
||||
if stepIndex, ok := m.planStepAtMouse(msg); ok {
|
||||
// The card lands in the chat transcript; close the file drill-in so
|
||||
// it isn't appended invisibly behind the swapped body.
|
||||
m = m.exitFileView()
|
||||
var cmd tea.Cmd
|
||||
m, cmd = m.openPlanStepDetail(stepIndex)
|
||||
return m, cmd, true
|
||||
}
|
||||
// A click on a FILES row: first click selects the file (its edit cards
|
||||
// tint and the chat scrolls to the most recent one); a click on the
|
||||
// already-selected file — or any FILES click while the drill-in is open —
|
||||
// opens/switches the file view.
|
||||
if path, ok := m.fileRowAtMouse(msg); ok {
|
||||
if m.fileView.active || m.selectedFile == path {
|
||||
m.selectedFile = path
|
||||
return m.openFileView(path), nil, true
|
||||
}
|
||||
return m.selectFile(path), nil, true
|
||||
}
|
||||
line, ok := m.transcriptLineAtMouse(msg)
|
||||
if !ok {
|
||||
if m.transcriptSelection.active {
|
||||
|
||||
+12
-3
@@ -201,6 +201,9 @@ func (m model) statusLine(width int) string {
|
||||
if m.exitConfirmActive {
|
||||
return fitStyledLine(prefix+zeroTheme.amber.Render("●")+" "+zeroTheme.amber.Render(ctrlCExitConfirmText), width)
|
||||
}
|
||||
if m.cancelConfirmActive {
|
||||
return fitStyledLine(prefix+zeroTheme.amber.Render("●")+" "+zeroTheme.amber.Render(escCancelConfirmText), width)
|
||||
}
|
||||
return fitStyledLine(left, width)
|
||||
}
|
||||
|
||||
@@ -210,6 +213,8 @@ func (m model) statusLine(width int) string {
|
||||
}
|
||||
if m.exitConfirmActive {
|
||||
left = prefix + zeroTheme.amber.Render("●") + " " + zeroTheme.amber.Render(ctrlCExitConfirmText)
|
||||
} else if m.cancelConfirmActive {
|
||||
left = prefix + zeroTheme.amber.Render("●") + " " + zeroTheme.amber.Render(escCancelConfirmText)
|
||||
} else if summary := m.backgroundTerminalSummary(); summary != "" {
|
||||
left += separator + zeroTheme.muted.Render(summary)
|
||||
}
|
||||
@@ -218,15 +223,19 @@ func (m model) statusLine(width int) string {
|
||||
// Context-fill gauge: surface it down to the narrow tier (where it matters
|
||||
// most), but skip it when the context sidebar is already showing the % so the
|
||||
// figure isn't duplicated.
|
||||
gaugeShown := false
|
||||
if tier >= tierNarrow && !m.sidebarActive() {
|
||||
if gauge := m.contextWindowSegment(); gauge != "" {
|
||||
rightGroups = append(rightGroups, gauge)
|
||||
gaugeShown = true
|
||||
}
|
||||
}
|
||||
// The sidebar pins the token readout at its floor, so when it's open keep
|
||||
// only the cost here — otherwise the token figure shows on both sides.
|
||||
// The sidebar pins the token readout at its floor, and the gauge's "used"
|
||||
// figure is the exact same number (both read latestUsageTokens) — either
|
||||
// one showing means the plain usage segment must drop its own token count
|
||||
// to just the cost, or the count renders twice side by side.
|
||||
usage := m.usageStatusSegment()
|
||||
if m.sidebarActive() {
|
||||
if m.sidebarActive() || gaugeShown {
|
||||
usage = m.usageCostSegment()
|
||||
}
|
||||
if usage != "" {
|
||||
|
||||
@@ -106,6 +106,46 @@ func TestQuietGenerationHint(t *testing.T) {
|
||||
}
|
||||
}
|
||||
|
||||
// TestQuietGenerationHintEscalatesPastHalfIdleTimeout: a heartbeating-but-
|
||||
// silent stream (chatgpt/gpt-5.x, ollama reasoning models — see
|
||||
// providerio.ErrStreamStalled) and a genuinely healthy-but-slow one look
|
||||
// identical under the plain "still generating… Xs" cue — the ticking number
|
||||
// is the only signal, whether real content is still coming or nothing ever
|
||||
// will. Past half the provider's idle timeout the cue must say so explicitly
|
||||
// and name when Zero's own content-stall watchdog will act, rather than
|
||||
// leaving the user to guess whether this is a hang.
|
||||
func TestQuietGenerationHintEscalatesPastHalfIdleTimeout(t *testing.T) {
|
||||
// 30s idle timeout: half (15s) sits comfortably above quietWorkingHint (8s),
|
||||
// leaving a clean window to observe the plain cue before it escalates.
|
||||
t.Setenv("ZERO_STREAM_IDLE_TIMEOUT", "30s")
|
||||
base := time.Date(2026, 6, 25, 12, 0, 0, 0, time.UTC)
|
||||
m := model{now: func() time.Time { return base }}
|
||||
m.activeRunID = 7
|
||||
m.turnStartedAt = base
|
||||
|
||||
// Quiet past quietWorkingHint but under half the (30s) idle timeout -> the
|
||||
// plain cue, same as TestQuietGenerationHint's normal case.
|
||||
m.lastStreamActivity = base.Add(-10 * time.Second)
|
||||
got := m.quietGenerationHint()
|
||||
if !strings.Contains(got, "still generating") {
|
||||
t.Fatalf("under half the idle timeout: want the plain cue, got %q", got)
|
||||
}
|
||||
if strings.Contains(got, "auto-recover") {
|
||||
t.Fatalf("under half the idle timeout: should not have escalated yet, got %q", got)
|
||||
}
|
||||
|
||||
// Quiet for >= half the idle timeout -> escalates to name the watchdog and
|
||||
// its ceiling (providerio.ContentStallTimeout(30s) = 30s*1.2 = 36s here).
|
||||
m.lastStreamActivity = base.Add(-15 * time.Second)
|
||||
got = m.quietGenerationHint()
|
||||
if !strings.Contains(got, "unusually quiet") || !strings.Contains(got, "auto-recover") {
|
||||
t.Fatalf("past half the idle timeout: want an escalated cue naming the watchdog, got %q", got)
|
||||
}
|
||||
if !strings.Contains(got, "36s") {
|
||||
t.Fatalf("escalated cue should name the content-stall ceiling (ContentStallTimeout(30s) = 36s), got %q", got)
|
||||
}
|
||||
}
|
||||
|
||||
// TestQuietHintHiddenWhenSidebarShowsIt: when the context sidebar is up (it
|
||||
// carries the "generating…" pulse in ACTIVITY), the working line must NOT also
|
||||
// show the hint — it appears in exactly one place.
|
||||
|
||||
@@ -0,0 +1,12 @@
|
||||
{
|
||||
"$schema": "https://raw.githubusercontent.com/googleapis/release-please/main/schemas/config.json",
|
||||
"release-type": "node",
|
||||
"include-component-in-tag": false,
|
||||
"bootstrap-sha": "02f0c0929bec65f5fc41bdcab3eb518d2b0b329a",
|
||||
"packages": {
|
||||
".": {
|
||||
"package-name": "@gitlawb/zero",
|
||||
"release-as": "0.1.0"
|
||||
}
|
||||
}
|
||||
}
|
||||
Reference in new issue
Block a user