Merge remote-tracking branch 'origin/main' into feat/skill-bundled-files

fix(skills): match the tree hash when recovering an interrupted install
2026-11-12 15:02:21 -10:00 · 2026-10-25 19:14:16 +05:30 · 2026-10-21 15:54:26 +05:30 · 2026-10-21 12:14:08 +05:30 · 2026-10-20 20:10:21 +05:30 · 2026-10-20 19:38:56 +05:30
1 changed files with 2 additions and 9 deletions
@@ -936,15 +936,8 @@ func TestExecCommandInteractiveBlockSuggestsTTY(t *testing.T) {
 }

 func TestExecCommandTTYSkipsInteractiveBlock(t *testing.T) {
-	// The ssh can still be resolving the bogus host when the 250ms yield
-	// returns, which leaves its session running in the test root. Stop it
-	// before the root goes, and use execTestRoot for the moment Windows still
-	// holds the directory after the stop.
-	root := execTestRoot(t)
-	manager := newExecSessionManager()
-	t.Cleanup(func() { manager.StopAll() })
-	tool := NewScopedExecCommandTool(root, nil, manager)
-	// ssh to a bogus host fails on its own; the point is that the
+	tool := NewScopedExecCommandTool(t.TempDir(), nil, newExecSessionManager())
+	// ssh to a bogus host fails fast on its own; the point is that the
 	// interactive guard must not fire ahead of the tty path.
 	result := tool.Run(context.Background(), map[string]any{
 		"cmd": "ssh host.example.com", "tty": true, "yield_time_ms": 250,
Author	SHA1	Message	Date
Vasanthdev2004	1c13236c75	Merge remote-tracking branch 'origin/main' into feat/skill-bundled-files	2026-10-25 19:14:16 +05:30
Vasanthdev2004	cf19bd387d	Merge remote-tracking branch 'origin/main' into feat/skill-bundled-files	2026-10-21 15:54:26 +05:30
Vasanthdev2004	e6ebe1da33	fix(skills): match the tree hash when recovering an interrupted install lockReconciler matched both trees of an interrupted workspace on the SKILL.md hash alone. A reinstall that changes only a bundled file keeps SKILL.md, so a kill between the tree swap and the lockfile publish left two trees carrying the recorded hash, and recovery kept the new one and retired the backup the lockfile still described. A tree now matches an entry with a tree hash only when both hashes match. An entry from before tree hashes is still matched on SKILL.md alone. A tree hash that cannot be computed is returned as an error, the way an unreadable SKILL.md already is, so recovery decides nothing about a tree it could not read. Also bring the package comment up to date: install copies the skill directory, not SKILL.md alone.	2026-10-21 12:14:08 +05:30
Vasanthdev2004	9a2c8fb90e	fix(skills): compare a reinstall over an old lock entry with SKILL.md alone A lock entry written before tree hashes has no treeHash, so the reinstall compared the new tree hash with an empty string and always counted as an update. Re-adding an unchanged skill that is only a SKILL.md printed "Updated" and "the files bundled with it changed" when there were none. That entry comes from an install that copied SKILL.md alone, so compare with that: it is an update when SKILL.md changed or the reinstall now brings bundled files. InstallResult gains previousTreeHash, and the CLI uses it to say the bundled files are now installed rather than changed on the first reinstall over such an entry.	2026-10-20 20:10:21 +05:30
Vasanthdev2004	2aeb796fae	feat(skills): install a skill's bundled files and point the skill tool at them A skill was only its SKILL.md: install copied that one file, and the skill tool returned only the markdown body, so a skill whose instructions run its own scripts was broken by installing it, and a hand-placed skill directory gave the model no way to find the files beside it. Install now copies the whole skill directory, leaving out hidden entries (.git, .env) and symlinks, which it neither follows nor copies but reports. A script stays executable; everything else is installed 0644. A tree over 1,000 files or 32 MiB is refused. skills.lock records a treeHash beside the SKILL.md hash; skill info reports drift in bundled files, and an entry from before this is still checked on SKILL.md alone. A reinstall that changed only a bundled file is reported as an update. Both skill tools end their output with the skill's directory and a list of up to 50 bundled files when there are any; a SKILL.md-only skill is returned unchanged. Closes #584	2026-10-20 19:38:56 +05:30