VirusTotal/yara
1
0
Fork 0
mirror of https://github.com/VirusTotal/yara.git synced 2026-10-12 02:10:00 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: check mmap result (#2003)

Browse Source 
* fix: check mmap result

Check if mmap failed (return value MAP_FAILED) and, if yes, exit.

* feat: fallback to pread() if file mmap failed

* fix: initialize zero buffer for uninitialized mapping
This commit is contained in:
secDre4mer
2023-11-15 23:50:23 +01:00
committed by GitHub
parent c1e911fbe0
commit 12566310ea
1 changed files with 15 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files
libyara/proc/linux.c
+15 -10
View File
@@ -218,8 +218,16 @@ YR_API const uint8_t* yr_process_fetch_memory_block_data(YR_MEMORY_BLOCK* block)
fd,
proc_info->map_offset);
close(fd);
if (context->buffer == MAP_FAILED)
{
// Notify the code below that we couldn't read from the file
// fallback to pread() from the process
fd = -1;
}
context->buffer_size = block->size;
}
else
if (fd < 0)
{
context->buffer = mmap(
NULL,
@@ -228,17 +236,14 @@ YR_API const uint8_t* yr_process_fetch_memory_block_data(YR_MEMORY_BLOCK* block)
MAP_PRIVATE | MAP_ANONYMOUS,
-1,
0);
}
if (context->buffer != NULL)
{
if (context->buffer == MAP_FAILED)
{
context->buffer = NULL;
context->buffer_size = 0;
goto _exit;
}
context->buffer_size = block->size;
}
else
{
context->buffer_size = 0;
goto _exit;
}
// If mapping can't be accessed through the filesystem, read everything from
// target process VM.