fix(app): preserve timeline top outlines

packages/ai/src/schema/options.ts

@@ -178,7 +178,6 @@ export class LanguageModelCompatibility extends Schema.Class<LanguageModelCompat
   toolSchema: Schema.optional(LanguageModelToolSchemaCompatibility),
   reasoningField: Schema.optional(Schema.String),
   maxTokensField: Schema.optional(LanguageModelMaxTokensFieldCompatibility),
-  requireFinishReason: Schema.optional(Schema.Boolean),
 }) {}
 
 export namespace LanguageModelCompatibility {

packages/ai/test/llm.test.ts

@@ -102,7 +102,7 @@ describe("llm constructors", () => {
     const updated = LanguageModel.update(base, {
       route: responsesRoute,
       defaults: { generation: { maxTokens: 20 } },
-      compatibility: { toolSchema: "gemini", requireFinishReason: false },
+      compatibility: { toolSchema: "gemini" },
     })
     const updatedInput = LanguageModel.input(updated)
 
@@ -110,7 +110,7 @@ describe("llm constructors", () => {
     expect(String(updated.id)).toBe("fake-model")
     expect(updated.route).toBe(responsesRoute)
     expect(updated.defaults?.generation).toEqual({ maxTokens: 20 })
-    expect(updated.compatibility).toEqual({ toolSchema: "gemini", requireFinishReason: false })
+    expect(updated.compatibility).toEqual({ toolSchema: "gemini" })
     expect(updatedInput.defaults).toBe(updated.defaults)
     expect(updatedInput.compatibility).toBe(updated.compatibility)
     expect(String(updatedInput.provider)).toBe("fake")

packages/app/e2e/regression/session-timeline-shell-outline.spec.ts

@@ -57,7 +57,7 @@ for (const deviceScaleFactor of [1.25, 1.5]) {
     expect(edges.box.height).toBeCloseTo(geometry.outputHeight, 2)
     expect(geometry.borderColor).toBe("rgb(255, 0, 255)")
     expect(geometry.boxShadow).toBe("none")
-    expect(geometry.clipMargin).toBe("0.5px")
+    expect(geometry.clipMargin).toBe("1px")
     expect(edges.magenta.top).toBeGreaterThan(0.75)
     expect(edges.magenta.bottom).toBeGreaterThan(0.75)
     expect(edges.magenta.vertical).toBeGreaterThanOrEqual(2)
@@ -117,7 +117,40 @@ test("keeps the patch card inside a fractionally short virtual row", async ({ pa
   expect(edges.luminance.top).toBeLessThan(245)
   expect(edges.luminance.bottom).toBeLessThan(245)
   expect(Math.abs(edges.luminance.bottom - edges.luminance.top)).toBeLessThan(10)
-  expect(geometry.clipMargin).toBe("0.5px")
+  expect(geometry.clipMargin).toBe("1px")
+})
+
+test("keeps the shell outline inside a fractionally high virtual row", async ({ page }) => {
+  const shellID = "prt_shell_top_outline"
+  const timeline = await setupTimeline(page, {
+    messages: [userMessage(), assistantMessage([shell(shellID, "completed", "shell output")])],
+    settings: { newLayoutDesigns: true, shellToolPartsExpanded: true },
+    reducedMotion: true,
+    deviceScaleFactor: 1.25,
+  })
+  const part = page.locator(`[data-timeline-part-id="${shellID}"]`)
+  const output = part.locator('[data-component="bash-output"]')
+  const row = page.locator("[data-timeline-key]", { has: part })
+  await expect(output).toBeVisible()
+  await timeline.settle()
+
+  const overflow = await row.evaluate((element) => {
+    const output = element.querySelector<HTMLElement>('[data-component="bash-output"]')
+    if (!output) throw new Error("Shell output is unavailable")
+    const offset = output.getBoundingClientRect().top - element.getBoundingClientRect().top + 0.99
+    output.style.transform = `translateY(-${offset}px)`
+    output.style.setProperty("--v2-border-border-base", "rgb(255, 0, 255)")
+    output.style.setProperty("background", "rgb(0, 0, 0)", "important")
+    return {
+      top: element.getBoundingClientRect().top - output.getBoundingClientRect().top,
+      clipMargin: getComputedStyle(element).overflowClipMargin,
+    }
+  })
+  await timeline.settle()
+
+  expect(overflow.top).toBeCloseTo(0.99, 1)
+  expect(overflow.clipMargin).toBe("1px")
+  expect((await captureCardEdges(page, output)).magenta.top).toBeGreaterThan(0.75)
 })
 
 test("allows paint rounding for every framed row but not fixed turn gaps", async ({ page }) => {
@@ -153,7 +186,7 @@ test("allows paint rounding for every framed row but not fixed turn gaps", async
       clipMargin: getComputedStyle(element).overflowClipMargin,
     })),
   )
-  expect(rows.filter((row) => row.tag !== "TurnGap").every((row) => row.clipMargin === "0.5px")).toBe(true)
+  expect(rows.filter((row) => row.tag !== "TurnGap").every((row) => row.clipMargin === "1px")).toBe(true)
   expect(rows.filter((row) => row.tag === "TurnGap")).toEqual([{ tag: "TurnGap", clipMargin: "0px" }])
 })
 

packages/app/src/pages/session/timeline/message-timeline.tsx

@@ -1299,8 +1299,8 @@ export function MessageTimeline(props: {
           width: "100%",
           height: `${item().size}px`,
           overflow: "clip",
-          // Rounded virtual measurements can otherwise clip a framed row's outer paint.
-          "overflow-clip-margin": row()._tag === "TurnGap" ? undefined : "0.5px",
+          // Fractional virtual starts and measurements can otherwise clip a framed row's outer paint.
+          "overflow-clip-margin": row()._tag === "TurnGap" ? undefined : "1px",
         }}
       >
         <div

packages/client/src/promise/generated/types.ts

@@ -169,8 +169,6 @@ export type EventLogSynced = { type: "log.synced"; aggregateID: string; seq?: nu
 
 export type ModelReasoningField = "reasoning" | "reasoning_content" | "reasoning_text" | (string & {})
 
-export type ModelMaxTokensField = "max_completion_tokens" | "max_tokens"
-
 export type ModelCapabilities = { tools: boolean; input: Array<string>; output: Array<string> }
 
 export type ModelVariant = {
@@ -1232,11 +1230,7 @@ export type SessionToolCalled = {
 
 export type ToolContent1 = ToolTextContent | ToolFileContent1
 
-export type ModelCompatibility = {
-  reasoningField?: ModelReasoningField
-  maxTokensField?: ModelMaxTokensField
-  requireFinishReason?: boolean
-}
+export type ModelCompatibility = { reasoningField?: ModelReasoningField }
 
 export type ModelCost = {
   tier?: { type: "context"; size: number }

packages/core/test/config/provider.test.ts

@@ -237,11 +237,7 @@ describe("ConfigProviderPlugin.Plugin", () => {
                   models: {
                     chat: {
                       name: "First",
-                      compatibility: {
-                        reasoningField: "vendor_reasoning",
-                        maxTokensField: "max_completion_tokens",
-                        requireFinishReason: false,
-                      },
+                      compatibility: { reasoningField: "vendor_reasoning" },
                       capabilities: { tools: true, input: ["text"], output: ["text"] },
                       disabled: true,
                       limit: { context: 100, output: 50 },
@@ -322,11 +318,7 @@ describe("ConfigProviderPlugin.Plugin", () => {
         expect(model.id).toBe(modelID)
         expect(model.modelID).toBe(Model.ID.make("api-chat"))
         expect(model.name).toBe("Last")
-        expect(model.compatibility).toEqual({
-          reasoningField: "vendor_reasoning",
-          maxTokensField: "max_completion_tokens",
-          requireFinishReason: false,
-        })
+        expect(model.compatibility).toEqual({ reasoningField: "vendor_reasoning" })
         expect(model.capabilities).toEqual({ tools: true, input: ["text"], output: ["text"] })
         expect(model.enabled).toBe(false)
         expect(model.limit).toEqual({ context: 100, output: 75 })

packages/core/test/model-resolver.test.ts

@@ -194,11 +194,7 @@ describe("ModelResolver", () => {
     Effect.gen(function* () {
       const resolved = yield* ModelResolver.fromCatalogModel(
         model(Provider.aisdk("@ai-sdk/openai-compatible"), {
-          compatibility: {
-            reasoningField: "vendor_reasoning",
-            maxTokensField: "max_completion_tokens",
-            requireFinishReason: false,
-          },
+          compatibility: { reasoningField: "vendor_reasoning" },
           settings: {
             apiKey: "settings-secret",
             baseURL: "https://compatible.example/v1",
@@ -208,8 +204,7 @@ describe("ModelResolver", () => {
           body: {},
         }),
       )
-      const request = LLM.request({ model: resolved, prompt: "Hello", generation: { maxTokens: 10 } })
-      const prepared = yield* compileRequest(request)
+      const request = LLM.request({ model: resolved, prompt: "Hello" })
       const headers = yield* resolved.route.auth.apply({
         request,
         method: "POST",
@@ -221,10 +216,6 @@ describe("ModelResolver", () => {
       expect(headers.authorization).toBe("Bearer settings-secret")
       expect(resolved.route.id).toBe("openai-compatible-chat")
       expect(resolved.compatibility?.reasoningField).toBe("vendor_reasoning")
-      expect(resolved.compatibility?.maxTokensField).toBe("max_completion_tokens")
-      expect(resolved.compatibility?.requireFinishReason).toBe(false)
-      expect(prepared.body).toMatchObject({ max_completion_tokens: 10 })
-      expect(prepared.body).not.toHaveProperty("max_tokens")
       expect(resolved.route.endpoint.baseURL).toBe("https://compatible.example/v1")
       expect(resolved.route.defaults.http?.body).toEqual({})
     }),

packages/schema/src/model.ts

@@ -47,16 +47,9 @@ export const ReasoningField: Schema.Codec<ReasoningField> = Schema.Union([
   Schema.String,
 ]).annotate({ identifier: "Model.ReasoningField" })
 
-export const MaxTokensField = Schema.Literals(["max_completion_tokens", "max_tokens"]).annotate({
-  identifier: "Model.MaxTokensField",
-})
-export type MaxTokensField = typeof MaxTokensField.Type
-
 export interface Compatibility extends Schema.Schema.Type<typeof Compatibility> {}
 export const Compatibility = Schema.Struct({
   reasoningField: ReasoningField.pipe(optional),
-  maxTokensField: MaxTokensField.pipe(optional),
-  requireFinishReason: Schema.Boolean.pipe(optional),
 }).annotate({ identifier: "Model.Compatibility" })
 
 export interface Capabilities extends Schema.Schema.Type<typeof Capabilities> {}

packages/schema/test/model.test.ts

@@ -30,22 +30,3 @@ describe("Model.ReasoningField", () => {
       expect(decode(field)).toBe(field)
   })
 })
-
-describe("Model.Compatibility", () => {
-  test("decodes model compatibility overrides", () => {
-    const decode = Schema.decodeUnknownSync(Model.Compatibility)
-
-    expect(decode({})).toEqual({})
-    expect(
-      decode({
-        reasoningField: "vendor_reasoning",
-        maxTokensField: "max_completion_tokens",
-        requireFinishReason: false,
-      }),
-    ).toEqual({
-      reasoningField: "vendor_reasoning",
-      maxTokensField: "max_completion_tokens",
-      requireFinishReason: false,
-    })
-  })
-})

packages/tui/src/component/dialog-mcp.tsx

@@ -128,7 +128,6 @@ export function DialogMcp() {
               {
                 title: toggleTitle(),
                 command: "dialog.mcp.toggle",
-                variant: toggleTitle() === "disconnect" ? "destructive" : "primary",
                 onTrigger: (option) => {
                   setFocused(option.value as string)
                   toggle(option.value as string)

packages/tui/src/component/dialog-move-session.tsx

@@ -372,7 +372,6 @@ export function DialogMoveSession(props: DialogMoveSessionProps) {
                 {
                   command: "dialog.move_session.delete",
                   title: "delete",
-                  variant: "destructive",
                   disabled: (option) => {
                     const value = option?.value
                     if (!value || value.type !== "directory" || value.subdirectory) return true

packages/tui/src/component/dialog-session-list.tsx

@@ -236,7 +236,6 @@ export function DialogSessionList() {
         {
           command: "session.delete",
           title: "delete",
-          variant: "destructive",
           onTrigger: (option: { value: string }) => {
             if (toDelete() !== option.value) {
               setToDelete(option.value)

packages/tui/src/component/dialog-stash.tsx

@@ -75,7 +75,6 @@ export function DialogStash(props: { onSelect: (entry: StashEntry) => void }) {
         {
           command: "stash.delete",
           title: "delete",
-          variant: "destructive",
           onTrigger: (option) => {
             if (toDelete() === option.value) {
               stash.remove(option.value)

packages/tui/src/ui/dialog-select.tsx

@@ -45,7 +45,6 @@ export interface DialogSelectProps<T> {
 type DialogSelectActionBase<T> = {
   command: string
   title: string
-  variant?: "primary" | "destructive"
   side?: "left" | "right"
   hidden?: boolean
   disabled?: boolean | ((option: DialogSelectOption<T> | undefined) => boolean)
@@ -552,19 +551,18 @@ export function DialogSelect<T>(props: DialogSelectProps<T>) {
     const item = action.item
     const active = createMemo(() => isActionFocused(item))
     const disabled = createMemo(() => isActionDisabled(item))
-    const variant = () => item.variant ?? "primary"
     return (
       <box
         flexDirection="row"
-        backgroundColor={active() ? theme.background.action[variant()].focused : RGBA.fromInts(0, 0, 0, 0)}
+        backgroundColor={active() ? theme.background.action.primary.focused : RGBA.fromInts(0, 0, 0, 0)}
         onMouseUp={() => trigger(item)}
       >
         <text
           fg={
             disabled()
-              ? theme.text.action[variant()].disabled
+              ? theme.text.action.primary.disabled
               : active()
-                ? theme.text.action[variant()].focused
+                ? theme.text.action.primary.focused
                 : theme.text.default
           }
           attributes={active() ? TextAttributes.BOLD : undefined}
@@ -574,9 +572,9 @@ export function DialogSelect<T>(props: DialogSelectProps<T>) {
         <text
           fg={
             disabled()
-              ? theme.text.action[variant()].disabled
+              ? theme.text.action.primary.disabled
               : active()
-                ? theme.text.action[variant()].focused
+                ? theme.text.action.primary.focused
                 : theme.text.subdued
           }
         >