anomalyco/opencode
1
0
Fork 0
mirror of https://github.com/anomalyco/opencode.git synced 2026-07-22 02:05:26 -04:00
Code Issues 5.9k Packages Projects Releases 19 Wiki Activity

[PR #3429] Fix cross-platform path resolution in build script #10639

New Issue
Closed
opened 2026-02-16 18:15:21 -05:00 by yindo · 0 comments
yindo commented 2026-02-16 18:15:21 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/anomalyco/opencode/pull/3429

State: closed
Merged: No

Fix cross-platform path resolution in build script

Problem

The build script at packages/opencode/script/build.ts was failing on Windows due to improper path resolution. The script used new URL("..", import.meta.url).pathname which doesn't work correctly on Windows, causing the build to fail with "ENOENT: no such file or directory" errors.

Root Cause

The original path resolution approach:

const dir = new URL("..", import.meta.url).pathname
process.chdir(dir)

This approach works on Linux/macOS but fails on Windows because:

  1. import.meta.url.pathname on Windows returns a path without a drive letter
  2. The chdir operation fails because the resolved path is invalid

Solution

Updated to path resolution to use cross-platform compatible methods:

import { fileURLToPath } from "url"

// Fix cross-platform path resolution
const __filename = fileURLToPath(import.meta.url)
const __dirname = path.dirname(__filename)
const dir = path.resolve(__dirname, "..")

process.chdir(dir)

This approach:

  • Uses fileURLToPath() to properly convert the file URL to a system path
  • Works correctly on both Windows and Linux/macOS
  • Maintains backward compatibility
  • Follows Node.js best practices for ES module path resolution

Testing

  • ✅ Script now runs successfully on Windows
  • ✅ Build process starts correctly and builds for Windows x64 platform
  • ✅ Cross-platform builds still work (Linux/macOS builds may fail on Windows due to missing cross-platform binaries, but this is expected behavior)
  • ✅ No regression in functionality

Impact

This change enables Windows developers to build the opencode project without having to manually fix path resolution issues. The fix is minimal and focused, maintaining all existing functionality while adding proper Windows support.

Files changed:

  • packages/opencode/script/build.ts - Updated path resolution logic
**Original Pull Request:** https://github.com/anomalyco/opencode/pull/3429 **State:** closed **Merged:** No --- # Fix cross-platform path resolution in build script ## Problem The build script at `packages/opencode/script/build.ts` was failing on Windows due to improper path resolution. The script used `new URL("..", import.meta.url).pathname` which doesn't work correctly on Windows, causing the build to fail with "ENOENT: no such file or directory" errors. ## Root Cause The original path resolution approach: ```typescript const dir = new URL("..", import.meta.url).pathname process.chdir(dir) ``` This approach works on Linux/macOS but fails on Windows because: 1. `import.meta.url.pathname` on Windows returns a path without a drive letter 2. The `chdir` operation fails because the resolved path is invalid ## Solution Updated to path resolution to use cross-platform compatible methods: ```typescript import { fileURLToPath } from "url" // Fix cross-platform path resolution const __filename = fileURLToPath(import.meta.url) const __dirname = path.dirname(__filename) const dir = path.resolve(__dirname, "..") process.chdir(dir) ``` This approach: - Uses `fileURLToPath()` to properly convert the file URL to a system path - Works correctly on both Windows and Linux/macOS - Maintains backward compatibility - Follows Node.js best practices for ES module path resolution ## Testing - ✅ Script now runs successfully on Windows - ✅ Build process starts correctly and builds for Windows x64 platform - ✅ Cross-platform builds still work (Linux/macOS builds may fail on Windows due to missing cross-platform binaries, but this is expected behavior) - ✅ No regression in functionality ## Impact This change enables Windows developers to build the opencode project without having to manually fix path resolution issues. The fix is minimal and focused, maintaining all existing functionality while adding proper Windows support. Files changed: - `packages/opencode/script/build.ts` - Updated path resolution logic
yindo added the pull-request label 2026-02-16 18:15:21 -05:00
yindo closed this issue 2026-02-16 18:15:21 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
acp
bad
bug
discussion
docs
documentation
enhancement
extension
good first issue
growth
help-wanted
mcp
model-problem
needs:compliance
nix
opentui
perf
pull-request
Mirrored from GitHub Pull Request
 tui
web
windows
zen
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: anomalyco/opencode#10639
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?