anomalyco/opencode
1
0
Fork 0
mirror of https://github.com/anomalyco/opencode.git synced 2026-07-22 18:25:32 -04:00
Code Issues 5.9k Packages Projects Releases 19 Wiki Activity

[PR #7165] refactor: simplify task tool subagent filtering #12282

New Issue
Closed
opened 2026-02-16 18:17:12 -05:00 by yindo · 0 comments
yindo commented 2026-02-16 18:17:12 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/anomalyco/opencode/pull/7165

State: closed
Merged: Yes

Summary

Small cleanup to align the task tool's filtering approach with how skill.ts handles it, plus simplification of the userInvokedAgents mechanism.

Self-contained filtering:

  • Move subagent filtering into task.ts itself (using ctx?.agent from #7042)
  • Remove the post-hoc regeneration in prompt.ts

Simplify bypass logic:

  • Replace userInvokedAgents array with bypassAgentCheck boolean
  • Only check the current turn's user message (not all messages in session)
  • Prevents bypass from persisting across the entire session

Test cleanup:

  • Remove redundant filterSubagents tests (already covered by PermissionNext.evaluate tests)

Changes

  • task.ts: Filter during description generation + simplify permission check
  • prompt.ts: Remove regeneration block + use bypassAgentCheck boolean
  • test: Remove redundant tests (~130 lines)

No functional changes to permission behavior - just cleaner code!

**Original Pull Request:** https://github.com/anomalyco/opencode/pull/7165 **State:** closed **Merged:** Yes --- ## Summary Small cleanup to align the task tool's filtering approach with how skill.ts handles it, plus simplification of the `userInvokedAgents` mechanism. **Self-contained filtering:** - Move subagent filtering into `task.ts` itself (using `ctx?.agent` from #7042) - Remove the post-hoc regeneration in `prompt.ts` **Simplify bypass logic:** - Replace `userInvokedAgents` array with `bypassAgentCheck` boolean - Only check the current turn's user message (not all messages in session) - Prevents bypass from persisting across the entire session **Test cleanup:** - Remove redundant `filterSubagents` tests (already covered by `PermissionNext.evaluate` tests) ## Changes - `task.ts`: Filter during description generation + simplify permission check - `prompt.ts`: Remove regeneration block + use `bypassAgentCheck` boolean - `test`: Remove redundant tests (~130 lines) No functional changes to permission behavior - just cleaner code!
yindo added the pull-request label 2026-02-16 18:17:12 -05:00
yindo closed this issue 2026-02-16 18:17:12 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
acp
bad
bug
discussion
docs
documentation
enhancement
extension
good first issue
growth
help-wanted
mcp
model-problem
needs:compliance
nix
opentui
perf
pull-request
Mirrored from GitHub Pull Request
 tui
web
windows
zen
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: anomalyco/opencode#12282
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?