anomalyco/opencode
1
0
Fork 0
mirror of https://github.com/anomalyco/opencode.git synced 2026-07-22 02:05:26 -04:00
Code Issues 5.9k Packages Projects Releases 19 Wiki Activity

[PR #7473] fix: prevent subagent permission bypass via tools field inheritance #12412

New Issue
Open
opened 2026-02-16 18:17:19 -05:00 by yindo · 0 comments
yindo commented 2026-02-16 18:17:19 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/anomalyco/opencode/pull/7473

State: open
Merged: No

Summary
Fixes a security vulnerability where subagents bypassed permission restrictions due to direct tools array inheritance from parent agents.
Problem
Agents with restricted tool access could access parent agent tools they shouldn't have permission to use. The tools field was being spread directly from agent config, bypassing permission evaluation.
Solution

  • Exclude tools field from agent config spread to prevent inheritance
  • Filter tools by agent-specific permission rules in ToolRegistry
  • Apply permission filtering in session initialization and prompt construction

Fixes: #7474
Related: #5894, #3808, #7296, #6527

Test Coverage
4 test files with comprehensive coverage validating agents cannot access tools outside their permission scope.

Verified manually to finally fix this issue. I had been stuck on 1.0.200 for few days due to this and having a rather complex multi-sub-agent configuration that relies on permissions guard rails working correctly.

**Original Pull Request:** https://github.com/anomalyco/opencode/pull/7473 **State:** open **Merged:** No --- **Summary** Fixes a security vulnerability where subagents bypassed permission restrictions due to direct tools array inheritance from parent agents. **Problem** Agents with restricted tool access could access parent agent tools they shouldn't have permission to use. The `tools` field was being spread directly from agent config, bypassing permission evaluation. **Solution** - Exclude `tools` field from agent config spread to prevent inheritance - Filter tools by agent-specific permission rules in ToolRegistry - Apply permission filtering in session initialization and prompt construction Fixes: #7474 Related: #5894, #3808, #7296, #6527 **Test Coverage** 4 test files with comprehensive coverage validating agents cannot access tools outside their permission scope. Verified manually to finally fix this issue. I had been stuck on 1.0.200 for few days due to this and having a rather complex multi-sub-agent configuration that relies on permissions guard rails working correctly.
yindo added the pull-request label 2026-02-16 18:17:19 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
acp
bad
bug
discussion
docs
documentation
enhancement
extension
good first issue
growth
help-wanted
mcp
model-problem
needs:compliance
nix
opentui
perf
pull-request
Mirrored from GitHub Pull Request
 tui
web
windows
zen
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: anomalyco/opencode#12412
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?