anomalyco/opencode
1
0
Fork 0
mirror of https://github.com/anomalyco/opencode.git synced 2026-07-21 17:56:33 -04:00
Code Issues 5.9k Packages Projects Releases 19 Wiki Activity

[PR #8271] fix: Replace empty catch blocks with proper error logging #12680

New Issue
Open
opened 2026-02-16 18:17:34 -05:00 by yindo · 0 comments
yindo commented 2026-02-16 18:17:34 -05:00
Owner
Copy Link
Copy Source

Original Pull Request: https://github.com/anomalyco/opencode/pull/8271

State: open
Merged: No

Summary

This PR fixes 7 instances of empty catch blocks across 5 files that were silently swallowing errors, making debugging difficult and potentially masking critical failures.

Changes Made

1. packages/opencode/src/session/message-v2.ts

  • Added Log import for error logging
  • Replaced empty catch block in error response parsing with debug logging
  • Impact: Improves debugging of API error responses

2. packages/opencode/src/cli/cmd/tui/component/prompt/index.tsx

  • Added Log import for error logging
  • Replaced empty catch block in image paste handling with debug logging
  • Impact: Improves debugging of clipboard/paste operations

3. packages/opencode/src/session/retry.ts

  • Added Log import for error logging
  • Replaced empty catch block in error response parsing with debug logging
  • Impact: Improves debugging of retry mechanism

4. packages/opencode/src/pty/index.ts

  • Replaced two empty catch blocks with debug logging for process termination
  • Uses existing logger instance (Log.create({ service: "pty" }))
  • Impact: Improves debugging of PTY session management

5. packages/opencode/src/server/mdns.ts

  • Replaced empty catch block with debug logging for bonjour instance cleanup
  • Uses existing logger instance (Log.create({ service: "mdns" }))
  • Impact: Improves debugging of mDNS service discovery

Technical Details

  • ✅ Uses existing Log utility throughout codebase
  • ✅ Uses Log.Default.debug() and existing logger instances appropriately
  • ✅ Adds descriptive error messages with error context
  • ✅ Maintains existing control flow and error handling behavior
  • ✅ Only adds observability, no functional changes
  • ✅ Follows project's error handling preferences (prefer logging over silent failures)

Testing

  • All changes maintain existing behavior
  • No functionality changes, only observability improvements
  • Compatible with existing test suite

Impact

  • Improved Debugging: All error scenarios now logged at debug level
  • Zero Breaking Changes: Maintains existing behavior while adding observability
  • Production Ready: Uses existing logging infrastructure
  • Maintainable: Clear, descriptive log messages for future debugging

Files Changed

  • 5 files modified
  • 7 empty catch blocks replaced with proper error logging
  • 3 new Log imports added (2 files already had Log imported)

Verification

  • ✅ All changes follow existing code patterns
  • ✅ Uses established logging infrastructure
  • ✅ No changes to business logic or error handling behavior
  • ✅ Improves codebase maintainability and debuggability

Related Issues

Addresses technical debt identified in codebase review where empty catch blocks were silently swallowing errors, making production debugging nearly impossible.

**Original Pull Request:** https://github.com/anomalyco/opencode/pull/8271 **State:** open **Merged:** No --- ## Summary This PR fixes 7 instances of empty catch blocks across 5 files that were silently swallowing errors, making debugging difficult and potentially masking critical failures. ## Changes Made ### 1. `packages/opencode/src/session/message-v2.ts` - Added `Log` import for error logging - Replaced empty catch block in error response parsing with debug logging - **Impact**: Improves debugging of API error responses ### 2. `packages/opencode/src/cli/cmd/tui/component/prompt/index.tsx` - Added `Log` import for error logging - Replaced empty catch block in image paste handling with debug logging - **Impact**: Improves debugging of clipboard/paste operations ### 3. `packages/opencode/src/session/retry.ts` - Added `Log` import for error logging - Replaced empty catch block in error response parsing with debug logging - **Impact**: Improves debugging of retry mechanism ### 4. `packages/opencode/src/pty/index.ts` - Replaced two empty catch blocks with debug logging for process termination - Uses existing logger instance (`Log.create({ service: "pty" })`) - **Impact**: Improves debugging of PTY session management ### 5. `packages/opencode/src/server/mdns.ts` - Replaced empty catch block with debug logging for bonjour instance cleanup - Uses existing logger instance (`Log.create({ service: "mdns" })`) - **Impact**: Improves debugging of mDNS service discovery ## Technical Details - ✅ Uses existing `Log` utility throughout codebase - ✅ Uses `Log.Default.debug()` and existing logger instances appropriately - ✅ Adds descriptive error messages with error context - ✅ Maintains existing control flow and error handling behavior - ✅ Only adds observability, no functional changes - ✅ Follows project's error handling preferences (prefer logging over silent failures) ## Testing - All changes maintain existing behavior - No functionality changes, only observability improvements - Compatible with existing test suite ## Impact - **Improved Debugging**: All error scenarios now logged at debug level - **Zero Breaking Changes**: Maintains existing behavior while adding observability - **Production Ready**: Uses existing logging infrastructure - **Maintainable**: Clear, descriptive log messages for future debugging ## Files Changed - 5 files modified - 7 empty catch blocks replaced with proper error logging - 3 new Log imports added (2 files already had Log imported) ## Verification - ✅ All changes follow existing code patterns - ✅ Uses established logging infrastructure - ✅ No changes to business logic or error handling behavior - ✅ Improves codebase maintainability and debuggability ## Related Issues Addresses technical debt identified in codebase review where empty catch blocks were silently swallowing errors, making production debugging nearly impossible.
yindo added the pull-request label 2026-02-16 18:17:34 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
acp
bad
bug
discussion
docs
documentation
enhancement
extension
good first issue
growth
help-wanted
mcp
model-problem
needs:compliance
nix
opentui
perf
pull-request
Mirrored from GitHub Pull Request
 tui
web
windows
zen
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: anomalyco/opencode#12680
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?