anomalyco/opencode
1
0
Fork 0
mirror of https://github.com/anomalyco/opencode.git synced 2026-07-22 10:15:31 -04:00
Code Issues 5.9k Packages Projects Releases 19 Wiki Activity

Non-null assertions on find() results can cause runtime crashes #8271

New Issue
Open
opened 2026-02-16 18:09:34 -05:00 by yindo · 1 comment
yindo commented 2026-02-16 18:09:34 -05:00
Owner
Copy Link
Copy Source

Originally created by @riftzen-bit on GitHub (Feb 1, 2026).

Originally assigned to: @rekram1-node on GitHub.

Summary

Several locations in the codebase use non-null assertions (!) on find() results, which will crash at runtime if the element is not found.

Locations

  1. packages/opencode/src/acp/agent.ts:1264 - `.find((c) => c.name === cmd.name)!`
  2. packages/opencode/src/cli/cmd/tui/context/local.tsx:57 - `.find((x) => x.name === agentStore.current)!`
  3. packages/opencode/src/provider/provider.ts:1051 - `Object.keys(mod).find((key) => key.startsWith("create"))!`
  4. packages/opencode/src/session/compaction.ts:99 - `.findLast((m) => m.info.id === input.parentID)!.info as MessageV2.User`
  5. packages/opencode/src/session/summary.ts:124 - `.find((m) => m.info.id === input.messageID)!`

Issue

// Example from provider.ts:1051
const fn = mod[Object.keys(mod).find((key) => key.startsWith("create"))!]
// If no key starts with "create", find() returns undefined
// The ! assertion bypasses the type check but crashes at runtime

The ! (non-null assertion) operator tells TypeScript to trust that the value is not null/undefined, but if find() doesn't match any element, it returns undefined, causing "Cannot read property 'X' of undefined" errors.

Impact

  • Severity: Medium
  • Type: Runtime Error
  • Effect: Crashes when search predicate doesn't match

Suggested Fix

Replace non-null assertions with proper null checks:

// Option 1: Guard clause
const key = Object.keys(mod).find((key) => key.startsWith("create"))
if (!key) {
  throw new Error(\`Provider module \${model.api.npm} has no create function\`)
}
const fn = mod[key]

// Option 2: Optional chaining with fallback
const fn = mod[Object.keys(mod).find((key) => key.startsWith("create")) ?? ""]
if (!fn) {
  throw new Error(...)
}
Originally created by @riftzen-bit on GitHub (Feb 1, 2026). Originally assigned to: @rekram1-node on GitHub. ## Summary Several locations in the codebase use non-null assertions (!) on find() results, which will crash at runtime if the element is not found. ## Locations 1. `packages/opencode/src/acp/agent.ts:1264` - \`.find((c) => c.name === cmd.name)!\` 2. `packages/opencode/src/cli/cmd/tui/context/local.tsx:57` - \`.find((x) => x.name === agentStore.current)!\` 3. `packages/opencode/src/provider/provider.ts:1051` - \`Object.keys(mod).find((key) => key.startsWith("create"))!\` 4. `packages/opencode/src/session/compaction.ts:99` - \`.findLast((m) => m.info.id === input.parentID)!.info as MessageV2.User\` 5. `packages/opencode/src/session/summary.ts:124` - \`.find((m) => m.info.id === input.messageID)!\` ## Issue ```typescript // Example from provider.ts:1051 const fn = mod[Object.keys(mod).find((key) => key.startsWith("create"))!] // If no key starts with "create", find() returns undefined // The ! assertion bypasses the type check but crashes at runtime ``` The `!` (non-null assertion) operator tells TypeScript to trust that the value is not null/undefined, but if find() doesn't match any element, it returns undefined, causing "Cannot read property 'X' of undefined" errors. ## Impact - **Severity**: Medium - **Type**: Runtime Error - **Effect**: Crashes when search predicate doesn't match ## Suggested Fix Replace non-null assertions with proper null checks: ```typescript // Option 1: Guard clause const key = Object.keys(mod).find((key) => key.startsWith("create")) if (!key) { throw new Error(\`Provider module \${model.api.npm} has no create function\`) } const fn = mod[key] // Option 2: Optional chaining with fallback const fn = mod[Object.keys(mod).find((key) => key.startsWith("create")) ?? ""] if (!fn) { throw new Error(...) } ```
yindo commented 2026-02-16 18:09:34 -05:00
Author
Owner
Copy Link
Copy Source

@github-actions[bot] commented on GitHub (Feb 1, 2026):

This issue might be a duplicate of existing issues. Please check:

  • #11262: [BUG] TUI Fatal Error: Cannot read property 'name' of undefined (local.agent.current()) - Related to the non-null assertion in src/cli/cmd/tui/context/local.tsx:57
  • #8398: opentui: fatal: undefined is not an object (evaluating 'local.agent.current().name') - Exact same symptom in a similar context
  • #11700: Missing array bounds checking in LLM provider response handling - Related pattern of missing null checks on array access

Feel free to ignore if these don't address your specific case.

@github-actions[bot] commented on GitHub (Feb 1, 2026): This issue might be a duplicate of existing issues. Please check: - #11262: [BUG] TUI Fatal Error: Cannot read property 'name' of undefined (local.agent.current()) - Related to the non-null assertion in src/cli/cmd/tui/context/local.tsx:57 - #8398: opentui: fatal: undefined is not an object (evaluating 'local.agent.current().name') - Exact same symptom in a similar context - #11700: Missing array bounds checking in LLM provider response handling - Related pattern of missing null checks on array access Feel free to ignore if these don't address your specific case.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
acp
bad
bug
discussion
docs
documentation
enhancement
extension
good first issue
growth
help-wanted
mcp
model-problem
needs:compliance
nix
opentui
perf
pull-request
Mirrored from GitHub Pull Request
 tui
web
windows
zen
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: anomalyco/opencode#8271
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?